[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

smeenai added a comment. Similar to the case @mstorsjo mentioned, this also causes the following code to fail now: struct S { unsigned size; }; template struct U { S s; unsigned size() { return s.size(); } }; This is obviously invalid, and I personally prefer get

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

smeenai added a comment. In D67414#1873445 , @efriedma wrote: > > https://gcc.godbolt.org/z/cY9-HQ > > gcc's behavior for your testcase makes no sense. We have to emit the > definition of a static function: it can't be defined in any other translation >

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

smeenai added a comment. It looks like our behavior still differs from gcc in the case of a `static inline __attribute__((gnu_inline))` function: https://gcc.godbolt.org/z/cY9-HQ. We emit it and gcc doesn't. I don't think that combination makes a lot of sense, but I ran into it in some internal

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

smeenai added a comment. I'm not sure why Phabricator is still showing Needs Review, but @rnk's approval should make this count as accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72242/new/ https://reviews.llvm.org/D72242 ___ cfe-c

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

smeenai added a subscriber: hans. smeenai added a comment. CC @hans for the 10.0 branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72242/new/ https://reviews.llvm.org/D72242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

smeenai added a comment. This also fixes https://bugs.llvm.org/show_bug.cgi?id=44886 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72242/new/ https://reviews.llvm.org/D72242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

smeenai added a comment. In D73742#1871012 , @aganea wrote: > In D73742#1870961 , @smeenai wrote: > > > I'm assuming this needs to be picked to 10.0? > > > Yes! Is it up to the authors to integrate their patches to

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

smeenai added a comment. I'm assuming this needs to be picked to 10.0? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73742/new/ https://reviews.llvm.org/D73742 ___ cfe-commits mailing list cfe-commits@

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG14f870366a93: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs (authored by ianlevesque, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

smeenai accepted this revision. smeenai added a comment. LGTM. I'll commit this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 ___ cfe-commits mailing

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

smeenai added a comment. Is it worth adding a test that a function with an explicit xray-instrument attribute also has these other attributes applied? Comment at: clang/test/CodeGen/xray-attributes-skip-entry-exit.cpp:8 +// RUN: -std=c++11 -triple x86_64-unknown-unknown -e

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

smeenai added a comment. I can commit this for you, but is it possible to write a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 ___ cfe-commits mai

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

smeenai added a comment. This LGTM, but I'll give the clang-tidy developers some time to weigh in. Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:106 +) + add_custom_target(clang-tidy-headers DEPENDS clang-headers) + set_target_properties(clang-tidy-headers PROPE

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

smeenai added a comment. Can you upload the patch with context (`git diff -U` if you're using the web interface or via arcanist)? You'll want to add install targets for this, by adding a `COMPONENT` to the `install` command and referencing that in the target. See https://reviews.llvm.org/s

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

smeenai added a subscriber: plotfi. smeenai added a comment. CC @plotfi for the InterfaceStubs failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 ___ cfe-

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

This revision was automatically updated to reflect the committed changes. Closed by commit rG97ba483026cd: [xray] Allow instrumenting only function entry and/or only function exit (authored by ianlevesque, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d62be244108: [clang][xray] Add -fxray-ignore-loops option (authored by ianlevesque, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D728

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

smeenai added inline comments. Herald added a subscriber: herhut. Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3133 return TokError("invalid floating point literal"); - } else if (Value.convertFromString(IDVal, APFloat::rmNearestTiesToEven) == - APFloat::opI

[PATCH] D70764: build: reduce CMake handling for zlib

smeenai added a comment. In D70764#1803559 , @raj.khem wrote: > this is now in master, and I am seeing build failures in cross-building > clang, e.g. when building clang for arm on a x86_64 host. its resorting to > finding, libz from buildhost instead of

[PATCH] D71507: [perf-training] Make training data location configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c59c4ffb9c1: [perf-training] Make training data location configurable (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71507/new/ https

[PATCH] D71507: [perf-training] Make training data location configurable

smeenai added a comment. I'm not sure where best to document this. We have https://llvm.org/docs/HowToBuildWithPGO.html, but that doesn't mention the build system's built-in PGO support as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D71507: [perf-training] Make training data location configurable

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek, xiaobai. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. We may wish to keep the PGO training data outside the repository. Add a CMake variable to allow referencing an external lit testsu

[PATCH] D71428: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES

This revision was automatically updated to reflect the committed changes. Closed by commit rG61c8ee6a2fa4: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES (authored by xinxinw1, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D71428: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES

smeenai added reviewers: beanz, phosek, compnerd, smeenai. smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71428/new/ https://reviews.llvm.

[PATCH] D69194: build: add clang-cl and clang++ symlinks in the build tree

smeenai added a comment. > Furthermore, the current build only installs the symbolic links in the > install tree, not the build tree This isn't right ... if I look at my LLVM build tree, I have clang, clang++ and clang-cl symlinks, all pointing to the actual clang-10 binary. Where are you seei

[PATCH] D68412: [clang] [cmake] Support LLVM_DISTRIBUTION_COMPONENTS in stand-alone build

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68412/new/ https://reviews.llvm.org/D68412 ___ cfe-commits mailing list cfe-commits

[PATCH] D65841: [Driver] Switch -stdlib++-isystem test to -###-verbatim

smeenai created this revision. smeenai added reviewers: compnerd, phosek, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows the test to pass on Windows and avoid backslash quoting issues. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65841

[PATCH] D65839: [Driver] Add verbatim dry run option

smeenai updated this revision to Diff 213773. smeenai edited the summary of this revision. smeenai added a comment. Output to stdout Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65839/new/ https://reviews.llvm.org/D65839 Files: clang/include/cl

[PATCH] D65839: [Driver] Add verbatim dry run option

smeenai added a comment. I'm not tied to the name `-###-verbatim` and am open to suggestions if anyone can think of something better. My troll suggestion was `-`, but @compnerd didn't like that for some reason... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai abandoned this revision. smeenai added a comment. Abandoning in favor of D65839 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64538/new/ https://reviews.llvm.org/D64538 __

[PATCH] D65839: [Driver] Add verbatim dry run option

smeenai created this revision. smeenai added reviewers: compnerd, phosek, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. smeenai added a parent revision: D65838: [Driver] Use enumeration for quoting mode. NFC. When writing driver tests, it's useful to have a way to ou

[PATCH] D65838: [Driver] Use enumeration for quoting mode. NFC

smeenai created this revision. smeenai added reviewers: compnerd, phosek, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Boolean parameters are generally hard to understand, especially when we don't consistently have a comment for them. Change to an enumeration. While

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

This revision was automatically updated to reflect the committed changes. Closed by commit rL367982: [Driver] Introduce -stdlib++-isystem (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a reviewer: rnk. smeenai added a subscriber: rnk. smeenai added a comment. Adding @rnk as someone familiar with the driver/frontend :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai marked an inline comment as done. smeenai added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1307 + HasStdlibxxIsystem ? TC.AddClangCXXStdlibIsystemArgs(Args, CmdArgs) + : TC.AddClangCXXStdlibIncludeArgs(Args, Cmd

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

smeenai added a comment. In D61479#1586987 , @sberg wrote: > eh, the summary here doesn't get updated from the actual git commit message :( > > thanks for the reviews! You can use `arc diff --verbatim` to update the summary based on your local commit me

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. In D64579#1581557 , @beanz wrote: > Yea, this makes sense even if it is a bit sad. We do use the > `--whole-archive` approach for `libLLVM`, and it works. I was hoping to avoid > it here in part to free up the ability to link `li

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rL365825: [clang-shlib] Fix clang-shlib for PRIVATE dependencies (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64582/new/ https://reviews.llvm.org/D64582 _

[PATCH] D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros

smeenai added a comment. Nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64580/new/ https://reviews.llvm.org/D64580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. In D64579#1581194 , @smeenai wrote: > In D64579#1581172 , @phosek wrote: > > > While upgrading to newer CMake would be nice, I think it's unlikely that we > > could move all the way to 3.12

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. In D64579#1581172 , @phosek wrote: > While upgrading to newer CMake would be nice, I think it's unlikely that we > could move all the way to 3.12 since that version was only released a year > ago and still isn't available in most

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai added a comment. @beanz, what do you think of this? I think it's kinda awful, but I can't think of a better alternative short of upgrading to CMake 3.12 (as detailed in my comment). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64579/new/

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Any static library with a PRIVATE dependency ends up with a $ generator expression in its INTERFACE_LINK_LIBRARIES, which won't be evaluate

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. In D64538#1579610 , @rnk wrote: > In D64538#1579573 , @smeenai wrote: > > > In D64538#1579561 , @rnk wrote: > > > > > An extremely convenient feature

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. In D64538#1579561 , @rnk wrote: > An extremely convenient feature of the current escaping pattern is that it > magically works for both the cmd shell and various bash implementations. You > can simply copy paste the commands and

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a subscriber: phosek. smeenai added a comment. CC @phosek, since I believe you had issues writing tests referencing the installation directory in the past. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64538/new/ https://reviews.llvm

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. In D64538#1579510 , @smeenai wrote: > Hmm, this only fixes `-###`. Looking into `-v` now. Ignore this – I was testing with a version without my change :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. Hmm, this only fixes `-###`. Looking into `-v` now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64538/new/ https://reviews.llvm.org/D64538 ___ cfe-commits mailing list cfe-co

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai created this revision. smeenai added reviewers: compnerd, hans, mstorsjo, rnk, thakis, zturner. Herald added a project: clang. Herald added a subscriber: cfe-commits. Escaping backslashes results in unnatural looking output, and the actual escapes are mostly unnecessary. We were also not c

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

smeenai added subscribers: beanz, smeenai. smeenai added a comment. In D58418#1577349 , @jkorous wrote: > Thanks for the revert. > > There's actually one more problem - seems like ninja doesn't like the > generated build.ninja file on Linux. > > ninja:

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. In D64089#1576902 , @ldionne wrote: > Background question: I'm familiar with the behavior on Darwin, where we > prefer C++ headers in the toolchain (alongside the driver), however do other > platforms behave the same? I thought t

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D64383: build: use multiple `install` rather than building up a list

smeenai added inline comments. Comment at: src/CMakeLists.txt:440 + endif() + if (LIBCXX_INSTALL_STATIC_LIBRARY) +install(TARGETS cxx_static Super nit: you don't have a newline here but do have a newline before the LIBCXX_INSTALL_EXPERIMENTAL_LIBRARY condi

[PATCH] D64383: build: use multiple `install` rather than building up a list

smeenai accepted this revision. smeenai added a comment. Nice! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64383/new/ https://reviews.llvm.org/D64383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. In D64089#1567028 , @danalbert wrote: > > For example, when we're building against the Android NDK, we might want to > > use the NDK's C++ headers (which have a custom inline namespace) even if we > > have C++ headers installed n

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai created this revision. smeenai added reviewers: compnerd, phosek, rsmith, zer0. Herald added a subscriber: srhines. Herald added a project: clang. There are times when we wish to explicitly control the C++ standard library search paths used by the driver. For example, when we're building a

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

smeenai added a comment. In D61974#1508097 , @ahatanak wrote: > Delete the entire code path that tries to work around a bug in gcc. Should something be added to the release notes for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

smeenai accepted this revision. smeenai added a comment. LGTM, neat! Comment at: llvm/test/CodeGen/X86/extern_weak.ll:20-21 +; DARWIN-LABEL: _bar: +; DARWIN: cmpl $0, L_foo$non_lazy_ptr +; DARWIN: jmp _foo ## TAILCALL + I'm not parsing this too well (it's not q

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

smeenai added inline comments. Comment at: libunwind/src/CMakeLists.txt:160 if (LIBUNWIND_INSTALL_LIBRARY) - install(TARGETS ${LIBUNWIND_INSTALL_TARGETS} + if(libcxxabi IN_LIST LLVM_RUNTIME_DISTRIBUTION_COMPONENTS) +set(export_to_llvmruntimes EXPORT LLVMRuntimes) -

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

smeenai accepted this revision. smeenai added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ https://reviews.llvm.org/D61220 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

smeenai added a comment. I feel something like `llvm::sys::path::PathListSeparator` would be nicer, since AFAIK any path list should be separated with semicolons on Windows and colons everywhere else. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61121/new/ htt

[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

smeenai added a comment. LGTM, though I'd wait for Hans and/or Reid too. I like the GCC/MinGW behavior here much more than the MSVC behavior. Having to mark the definitions only in the explicit instantiations case (for MSVC) whereas everything else requires you to mark the declarations is a wei

[PATCH] D61054: lib/Header: Fix Visual Studio builds

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM This would break if someone does a debug and release build simultaneously, the copies occur simultaneously and the filesystem gets unhappy, That seems fairly contrived though, and this

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai added a comment. @tstellar ping. Someone appears to be running into this on the CMake mailing list too: https://cmake.org/pipermail/cmake/2019-April/069359.html Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https://reviews.llvm.org/D58537 __

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

This revision was automatically updated to reflect the committed changes. Closed by commit rL357184: [CodeGen] Add additional mangling for struct members of non trivial structs (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

smeenai added a comment. Looks good. I'll commit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

smeenai added a comment. Also, it might be worth adding a third level of struct to the test, to show that it handles arbitrary nesting correctly (which it does). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59873/new/ https://reviews.llvm.org/D59

[PATCH] D59873: Add additional mangling for struct members of non trivial structs

smeenai added a comment. Do you need someone to commit this for you? Comment at: clang/test/CodeGenObjC/nontrivial-c-struct-within-struct-name.m:1 +// RUN: %clang_cc1 -triple arm64-apple-ios11 -fobjc-arc -fblocks -fobjc-runtime=ios-11.0 -emit-llvm -o - -DUSESTRUCT -I %S/Input

[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

smeenai added inline comments. Comment at: lld/COFF/Chunks.cpp:47 +namespace { +// This class exists just for the purpose of calculating the expected size of pcc wrote: > rnk wrote: > > ruiu wrote: > > > rnk wrote: > > > > ruiu wrote: > > > > > rnk wrote: > > >

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM, though you may wanna wait for @jdenny too. In D59168#1423587 , @phosek wrote: > The layout currently looks as follows: > > compiler-rt: >

[PATCH] D58317: [clang] Add install targets for API headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL355853: [clang] Add install targets for API headers (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

smeenai added inline comments. Comment at: clang/test/Driver/linux-per-target-runtime-dir.c:15 // CHECK-PER-TARGET-RUNTIME: "--sysroot=[[SYSROOT]]" +// CHECK-PER-TARGET-RUNTIME: "-L{{.*}}{{/|}}..{{/|}}lib{{/|}}x86_64-linux-gnu" // CHECK-PER-TARGET-RUNTIME: "-L[[RE

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

smeenai added inline comments. Comment at: clang/test/Driver/linux-per-target-runtime-dir.c:15 // CHECK-PER-TARGET-RUNTIME: "--sysroot=[[SYSROOT]]" +// CHECK-PER-TARGET-RUNTIME: "-L{{.*}}{{/|}}..{{/|}}lib{{/|}}x86_64-linux-gnu" // CHECK-PER-TARGET-RUNTIME: "-L[[RE

[PATCH] D58317: [clang] Add install targets for API headers

smeenai added a comment. Ping (although I'm not planning to land this until Monday). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58317/new/ https://reviews.llvm.org/D58317 ___ cfe-commits mailing lis

[PATCH] D58921: [CMake] Tell libc++ that we're using compiler-rt on Apple platforms

smeenai added a comment. Is this to work around https://github.com/llvm/llvm-project/blob/f84083b4dbb1ddb6d2783400f11121f490cdb5a8/libcxx/lib/CMakeLists.txt#L312? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58921/new/ https://reviews.llvm.org/D58921 ___

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: libcxx/CMakeLists.txt:420-421 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

smeenai added inline comments. Comment at: clang/test/Driver/linux-per-target-runtime-dir.c:13 // CHECK-PER-TARGET-RUNTIME: "-isysroot" "[[SYSROOT:[^"]+]]" // CHECK-PER-TARGET-RUNTIME: "-internal-isystem" "[[RESDIR]]/include/c++/v1" // CHECK-PER-TARGET-RUNTIME: "-internal-isys

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

smeenai added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:89 + P.assign(D.Dir); + llvm::sys::path::append(P, "..", "lib", D.getTargetTriple(), "lib"); + if (getVFS().exists(P)) Is this supposed to append lib twice? Comment at

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL355340: [build] Rename clang-headers to clang-resource-headers (authored by smeenai, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D58791?vs=189

[PATCH] D58862: [cmake] Create exports for umbrella library targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL355354: [cmake] Create exports for umbrella library targets (authored by smeenai, committed by ). Changed prior to commit: https://reviews.llvm.org/D58862?vs=189019&id=189229#toc Repository: rL LLVM

[PATCH] D58317: [clang] Add install targets for API headers

smeenai added a comment. @phosek This is using the clang-headers name now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58317/new/ https://reviews.llvm.org/D58317 ___ cfe-commits mailing list cfe-comm

[PATCH] D58317: [clang] Add install targets for API headers

smeenai updated this revision to Diff 189199. smeenai retitled this revision from "[clang] Add install targets for library headers" to "[clang] Add install targets for API headers". smeenai edited the summary of this revision. smeenai added a comment. Update target name Repository: rG LLVM Gi

[PATCH] D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation

smeenai added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5312 + CmdArgs.push_back("-forder-file-instrumentation"); + // Enable order file instrumentation when ThinLTO is not on. When ThinLTO is + // on, we need to pass these flags as linker flags an

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai added a comment. In D58791#1415496 , @tstellar wrote: > This looks good, but could you also add an entry in the ReleaseNotes for this. Will do – thanks for the reminder :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai updated this revision to Diff 189014. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-extra/te

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai updated this revision to Diff 188988. smeenai added a comment. Release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-e

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai added a comment. I added an entry to the release notes. The release notes change only covers the changes in this diff. My plan is to land this, wait for a few days (so that users of the target get broken in an obvious way), and then add the new install-clang-headers target (for installi

[PATCH] D58862: [cmake] Create exports for umbrella library targets

smeenai created this revision. smeenai added reviewers: beanz, phosek. Herald added a subscriber: mgorny. Herald added projects: clang, LLVM. When using the umbrella llvm-libraries and clang-libraries targets, we should export all library targets, otherwise they'll be part of our distribution but

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai added a comment. @tstellar are you planning to land this soon? It'll conflict with D58791 , but I'm not planning to land that for another few days, so I can rebase on top of this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar, rnk, dim. Herald added subscribers: openmp-commits, Sanitizers, jdoerfert, javed.absar, mgorny. Herald added a reviewer: serge-sans-paille. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. The current in

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai accepted this revision. smeenai added a comment. LGTM, thanks! Comment at: clang/lib/Headers/CMakeLists.txt:136 list(APPEND out_files ${dst}) + # The list function only updates out_files in the current scope. We need + # call set in order to also update the variab

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

smeenai added a comment. I tried committing this for you, but it doesn't apply to master. Could you rebase? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52956/new/ https://reviews.llvm.org/D52956 ___ cfe-commits ma

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai accepted this revision. smeenai added reviewers: beanz, phosek. smeenai added a comment. This revision is now accepted and ready to land. LGTM, though I generally prefer functions to macros. Comment at: clang/lib/Headers/CMakeLists.txt:127 -# Generate arm_neon.h -clan

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

smeenai added a comment. You should ask the reviewers to commit it in your behalf. You can request commit access after you've had a few patches accepted and committed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52956/new/ https://reviews.llvm.org/D52956 __

[PATCH] D58317: [clang] Add install targets for library headers

smeenai updated this revision to Diff 187698. smeenai retitled this revision from "[clang] Add install targets for development headers" to "[clang] Add install targets for library headers". smeenai edited the summary of this revision. smeenai added a comment. Update description Repository: rG

[PATCH] D58317: [clang] Add install targets for library headers

smeenai updated this revision to Diff 187697. smeenai added a comment. Switch to clang-library-headers pending cfe-dev discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58317/new/ https://reviews.llvm.org/D58317 Files: clang/CMakeLists.tx

[PATCH] D58480: [clang] Add CMake target for installing clang's CMake exports

This revision was automatically updated to reflect the committed changes. Closed by commit rL354527: [clang] Add CMake target for installing clang's CMake exports (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58317: [clang] Add install targets for development headers

smeenai added a comment. In D58317#1404961 , @phosek wrote: > In D58317#1400223 , @smeenai wrote: > > > I'm not entirely happy with the name clang-dev-headers, and am open to > > suggestions. It's unfortunate clang

<    1   2   3   4   5   6   7   8   >