[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

rastogishubham added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2271-2274 + const TargetInfo = getASTContext().getTargetInfo(); + if (NumBits > TI.getMaxBitIntWidth()) { Diag(Loc, diag::err_bit_int_max_size) +<< IsUnsigned << TI.getMaxBitIntWidth();

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

rastogishubham added a comment. Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command: xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

rastogishubham added a comment. Hi Qiongsi Thanks for the response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___ cfe-commits mailing list

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

rastogishubham added a comment. Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command: xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=Debug -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE

[PATCH] D126892: [NFC] Fix issue on CMake Xcode build configuration.

rastogishubham added a comment. Hi! This seems to work just fine. LGTM! Shubham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126892/new/ https://reviews.llvm.org/D126892 ___ cfe-commits mailing list

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

rastogishubham added a comment. Hi Qiongsi, Thank you for your work on the patch, it seems to work now! Shubham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498

[PATCH] D147747: Add test to verify behavior of .cfi_sections .debug_frame intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe8eab468eee: Add tests to verify behavior of .cfi_sections .debug_frame intrinsic. (authored by rastogishubham). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG