STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix an assumption about the state of moved-from std::functions.
The Standard doesn't provide any guarantees beyond "valid but unspecified" for
moved-from std::f
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix non-Standard assumptions when testing sample().
sample() isn't specified with a reproducible algorithm, so expecting
exact output is non-Standard. Mark thos
STL_MSFT marked an inline comment as done.
STL_MSFT added a comment.
Added the requested comment, will commit.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.sample/sample.pass.cpp:74
assert(end.base() - oa == std::min(os, is));
- assert(std::equal(oa,
Author: stl_msft
Date: Fri Nov 18 15:54:43 2016
New Revision: 287383
URL: http://llvm.org/viewvc/llvm-project?rev=287383&view=rev
Log:
[libcxx] [test] D26816: Fix non-Standard assumptions when testing sample().
sample() isn't specified with a reproducible algorithm, so expecting
exact output is n
Author: stl_msft
Date: Fri Nov 18 15:54:31 2016
New Revision: 287381
URL: http://llvm.org/viewvc/llvm-project?rev=287381&view=rev
Log:
[libcxx] [test] D26813: allocator is non-Standard.
N4582 17.6.3.5 [allocator.requirements] says that allocators are given
cv-unqualified object types, and N4582 2
Author: stl_msft
Date: Fri Nov 18 15:54:38 2016
New Revision: 287382
URL: http://llvm.org/viewvc/llvm-project?rev=287382&view=rev
Log:
[libcxx] [test] D26815: Fix an assumption about the state of moved-from
std::functions.
The Standard doesn't provide any guarantees beyond "valid but unspecified
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287381.
https://reviews.llvm.org/D26813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287382.
https://reviews.llvm.org/D26815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT marked an inline comment as done.
STL_MSFT added a comment.
Thanks, r287383 (including the requested comment).
https://reviews.llvm.org/D26816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
STL_MSFT added a comment.
My changes to the ofstream.cons tests preserve the test coverage (as they
already contain the machinery to create writable files).
Would you like it if I removed the "if (fs) { stuff }" blocks from the
ifstream.cons tests entirely, and changed the comments to say thing
Author: stl_msft
Date: Fri Nov 18 16:45:32 2016
New Revision: 287391
URL: http://llvm.org/viewvc/llvm-project?rev=287391&view=rev
Log:
[libcxx] [test] D26812: In random tests, use real static_asserts and silence a
warning.
In C++11 mode and newer, use real static_asserts.
In C++03 mode, min() an
STL_MSFT accepted this revision.
STL_MSFT added a reviewer: STL_MSFT.
STL_MSFT added a comment.
This revision is now accepted and ready to land.
Made the requested changes, committed as r287391 with Eric's approval.
Comment at: test/std/numerics/rand/rand.eng/rand.eng.lcong/val
STL_MSFT updated the summary for this revision.
STL_MSFT updated this revision to Diff 78589.
STL_MSFT added a comment.
Instead of skipping failures to open, just have comments pointing to the
ofstream.cons tests where this coverage has moved.
https://reviews.llvm.org/D26814
Files:
test/std/
STL_MSFT added a comment.
Found some minor issues.
Comment at: test/std/utilities/variant/variant.get/get_if_index.pass.cpp:92
+V v(42l);
+ASSERT_SAME_TYPE(decltype(std::get_if<1>(std::addressof(v))), long*);
+assert(*std::get_if<1>(std::addressof(v)) ==
STL_MSFT added inline comments.
Comment at:
test/std/utilities/variant/variant.helpers/variant_alternative.pass.cpp:33
+void test() {
+static_assert(std::is_same_v<
+typename std::variant_alternative::type, E>, "");
EricWF wrote:
> STL_MSFT wrote:
>
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 2/12.
Add static_cast when comparing int to std::size_t.
Also, include when it wasn't already being in
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 3/12.
Change unsigned to int in parameters.
https://reviews.llvm.org/D27015
Files:
test/std/algori
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 4/12.
Change "int j;" indices to "std::size_t j;".
Also, include when it wasn't already being included
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 5/12.
Various changes:
test/std/algorithms/alg.sorting/alg.binary.search/binary.search/binary_search.pa
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y',
signed/unsigned mismatch", part 6/12.
Add static_cast when initializing unsigned integers with negative num
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y',
signed/unsigned mismatch", part 7/12.
When initializing unsigned integers to their maximum values, change "
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 9/12.
Add static_cast to more comparisons. (Performed manually, unlike
part 8/12.)
Also, include when
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.
Add static_cast. In these cases, the values are guaranteed to be small-ish,
and they're being com
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12.
Change "unsigned n = 0;" to "int n = 0;". It's being compared to int elements
and ptrdiff_t dist
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
[libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 12/12.
Various changes:
test/std/algorithms/alg.sorting/alg.mer
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix copy-paste silliness; ULL can't ever be 32-bit.
https://reviews.llvm.org/D27026
Files:
test/std/localization/locale.categories/category.numeric/locale.
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Strip trailing whitespace.
https://reviews.llvm.org/D27027
Files:
test/std/algorithms/alg.sorting/alg.clamp/clamp.comp.pass.cpp
test/std/algorithms/alg.so
Author: stl_msft
Date: Wed Nov 23 16:01:58 2016
New Revision: 287822
URL: http://llvm.org/viewvc/llvm-project?rev=287822&view=rev
Log:
[libcxx] [test] D27014: Fix MSVC warning C4018 "signed/unsigned mismatch", part
2/12.
Add static_cast when comparing int to std::size_t.
Also, include when it
Author: stl_msft
Date: Wed Nov 23 16:02:27 2016
New Revision: 287824
URL: http://llvm.org/viewvc/llvm-project?rev=287824&view=rev
Log:
[libcxx] [test] D27016: Fix MSVC warning C4018 "signed/unsigned mismatch", part
4/12.
Change "int j;" indices to "std::size_t j;".
Also, include when it wasn't
Author: stl_msft
Date: Wed Nov 23 16:02:35 2016
New Revision: 287825
URL: http://llvm.org/viewvc/llvm-project?rev=287825&view=rev
Log:
[libcxx] [test] D27018: Fix MSVC warning C4018 "signed/unsigned mismatch", part
5/12.
Various changes:
test/std/algorithms/alg.sorting/alg.binary.search/binary.
Author: stl_msft
Date: Wed Nov 23 16:02:16 2016
New Revision: 287823
URL: http://llvm.org/viewvc/llvm-project?rev=287823&view=rev
Log:
[libcxx] [test] D27015: Fix MSVC warning C4018 "signed/unsigned mismatch", part
3/12.
Change unsigned to int in parameters.
Modified:
libcxx/trunk/test/std
Author: stl_msft
Date: Wed Nov 23 16:02:44 2016
New Revision: 287826
URL: http://llvm.org/viewvc/llvm-project?rev=287826&view=rev
Log:
[libcxx] [test] D27019: Fix MSVC warning C4245 "conversion from 'X' to 'Y',
signed/unsigned mismatch", part 6/12.
Add static_cast when initializing unsigned inte
Author: stl_msft
Date: Wed Nov 23 16:02:53 2016
New Revision: 287827
URL: http://llvm.org/viewvc/llvm-project?rev=287827&view=rev
Log:
[libcxx] [test] D27020: Fix MSVC warning C4245 "conversion from 'X' to 'Y',
signed/unsigned mismatch", part 7/12.
When initializing unsigned integers to their ma
Author: stl_msft
Date: Wed Nov 23 16:03:28 2016
New Revision: 287829
URL: http://llvm.org/viewvc/llvm-project?rev=287829&view=rev
Log:
[libcxx] [test] D27027: Strip trailing whitespace.
Modified:
libcxx/trunk/test/std/algorithms/alg.sorting/alg.clamp/clamp.comp.pass.cpp
libcxx/trunk/test/
Author: stl_msft
Date: Wed Nov 23 16:02:59 2016
New Revision: 287828
URL: http://llvm.org/viewvc/llvm-project?rev=287828&view=rev
Log:
[libcxx] [test] D27026: Fix copy-paste silliness; ULL can't ever be 32-bit.
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.numeric/l
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287820.
https://reviews.llvm.org/D27013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287822.
https://reviews.llvm.org/D27014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287823.
https://reviews.llvm.org/D27015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287824.
https://reviews.llvm.org/D27016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287826.
https://reviews.llvm.org/D27019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287825.
https://reviews.llvm.org/D27018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287828.
https://reviews.llvm.org/D27026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287827.
https://reviews.llvm.org/D27020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287829.
https://reviews.llvm.org/D27027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT added a comment.
As yet another alternative, I could keep the ios_base::openmode tests in
ifstream.cons, but use ios_base::binary instead of ios_base::out.
https://reviews.llvm.org/D26814
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: stl_msft
Date: Mon Dec 5 19:13:29 2016
New Revision: 288747
URL: http://llvm.org/viewvc/llvm-project?rev=288747&view=rev
Log:
[libcxx] [test] D27023: Fix MSVC warning C4389 "signed/unsigned mismatch", part
10/12.
Add static_cast. In these cases, the values are guaranteed to be small-ish
Author: stl_msft
Date: Mon Dec 5 19:13:14 2016
New Revision: 288746
URL: http://llvm.org/viewvc/llvm-project?rev=288746&view=rev
Log:
[libcxx] [test] D27022: Fix MSVC warning C4389 "signed/unsigned mismatch", part
9/12.
Add static_cast to more comparisons. (Performed manually, unlike
part 8/12
Author: stl_msft
Date: Mon Dec 5 19:13:40 2016
New Revision: 288748
URL: http://llvm.org/viewvc/llvm-project?rev=288748&view=rev
Log:
[libcxx] [test] D27024: Fix MSVC warning C4389 "signed/unsigned mismatch", part
11/12.
Change "unsigned n = 0;" to "int n = 0;". It's being compared to int eleme
Author: stl_msft
Date: Mon Dec 5 19:13:51 2016
New Revision: 288749
URL: http://llvm.org/viewvc/llvm-project?rev=288749&view=rev
Log:
[libcxx] [test] D27025: Fix MSVC warning C4389 "signed/unsigned mismatch", part
12/12.
Various changes:
test/std/algorithms/alg.sorting/alg.merge/inplace_merge.
Author: stl_msft
Date: Mon Dec 5 19:14:06 2016
New Revision: 288750
URL: http://llvm.org/viewvc/llvm-project?rev=288750&view=rev
Log:
[libcxx] [test] D27266: Remove spurious semicolons.
Modified:
libcxx/trunk/test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash_equa
Author: stl_msft
Date: Mon Dec 5 19:14:29 2016
New Revision: 288751
URL: http://llvm.org/viewvc/llvm-project?rev=288751&view=rev
Log:
[libcxx] [test] D27267: Fix MSVC x64 warning C4267 "conversion from 'size_t' to
'int' [or 'unsigned int'], possible loss of data", part 1/4.
Replace "int n = str
Author: stl_msft
Date: Mon Dec 5 19:14:43 2016
New Revision: 288752
URL: http://llvm.org/viewvc/llvm-project?rev=288752&view=rev
Log:
[libcxx] [test] D27268: Fix MSVC x64 warning C4267 "conversion from 'size_t' to
'int' [or 'unsigned int'], possible loss of data", part 2/4.
Use static_cast when
Author: stl_msft
Date: Mon Dec 5 19:14:51 2016
New Revision: 288753
URL: http://llvm.org/viewvc/llvm-project?rev=288753&view=rev
Log:
[libcxx] [test] D27269: Fix MSVC x64 warning C4267 "conversion from 'size_t' to
'int' [or 'unsigned int'], possible loss of data", part 3/4.
test/std/containers/
Author: stl_msft
Date: Thu Dec 8 15:37:47 2016
New Revision: 289105
URL: http://llvm.org/viewvc/llvm-project?rev=289105&view=rev
Log:
[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible
loss of data", part 1/7.
Given `std::basic_streambuf::int_type __c`, `std::basic_str
Author: stl_msft
Date: Thu Dec 8 15:38:01 2016
New Revision: 289106
URL: http://llvm.org/viewvc/llvm-project?rev=289106&view=rev
Log:
[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible
loss of data", part 2/7.
These tests for some guy's transparent operator functors we
Author: stl_msft
Date: Thu Dec 8 15:38:44 2016
New Revision: 289110
URL: http://llvm.org/viewvc/llvm-project?rev=289110&view=rev
Log:
[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible
loss of data", part 6/7.
test/std/algorithms/alg.modifying.operations/alg.random.shu
Author: stl_msft
Date: Thu Dec 8 15:38:14 2016
New Revision: 289107
URL: http://llvm.org/viewvc/llvm-project?rev=289107&view=rev
Log:
[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible
loss of data", part 3/7.
Add static_cast when constructing pair from (Something,
in
Author: stl_msft
Date: Thu Dec 8 15:38:23 2016
New Revision: 289108
URL: http://llvm.org/viewvc/llvm-project?rev=289108&view=rev
Log:
[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible
loss of data", part 4/7.
Change char to long and remove some char casts. This preser
Author: stl_msft
Date: Thu Dec 8 15:38:57 2016
New Revision: 289111
URL: http://llvm.org/viewvc/llvm-project?rev=289111&view=rev
Log:
[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible
loss of data", part 7/7.
test/std/input.output/iostream.format/input.streams/istream
Author: stl_msft
Date: Thu Dec 8 15:38:32 2016
New Revision: 289109
URL: http://llvm.org/viewvc/llvm-project?rev=289109&view=rev
Log:
[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible
loss of data", part 5/7.
Instead of storing double in double and then truncating to
Author: stl_msft
Date: Fri Dec 9 13:53:08 2016
New Revision: 289264
URL: http://llvm.org/viewvc/llvm-project?rev=289264&view=rev
Log:
[libcxx] [test] Add LIBCPP_ASSERT_NOEXCEPT/LIBCPP_ASSERT_NOT_NOEXCEPT, remove
an unused variable.
test/support/test_macros.h
For convenience/greppability, add ma
Author: stl_msft
Date: Fri Dec 9 16:35:53 2016
New Revision: 289283
URL: http://llvm.org/viewvc/llvm-project?rev=289283&view=rev
Log:
[libcxx] [test] Fix string_view tests.
test/std/strings/string.view/string.view.ops/compare.pointer_size.pass.cpp
Passing -1 to size_t triggers signed/unsigned mi
Author: stl_msft
Date: Mon Dec 12 13:50:22 2016
New Revision: 289463
URL: http://llvm.org/viewvc/llvm-project?rev=289463&view=rev
Log:
[libcxx] [test] Change ifstream constructor tests to handle read-only files.
Certain source control systems like to set the read-only bit on their files,
which in
Author: stl_msft
Date: Mon Dec 12 13:50:14 2016
New Revision: 289462
URL: http://llvm.org/viewvc/llvm-project?rev=289462&view=rev
Log:
[libcxx] [test] Fix an improper assumption about Null Forward Iterators.
Value-initialized iterators still can't be compared to those with parents.
Fixes D26626.
Author: stl_msft
Date: Mon Dec 12 19:54:58 2016
New Revision: 289512
URL: http://llvm.org/viewvc/llvm-project?rev=289512&view=rev
Log:
[libcxx] [test] Fix size_t-to-int truncation warnings in syserr.hash.
After r289363, these tests were triggering MSVC x64 warning C4267
"conversion from 'size_t'
Author: stl_msft
Date: Wed May 3 20:35:11 2017
New Revision: 302104
URL: http://llvm.org/viewvc/llvm-project?rev=302104&view=rev
Log:
[libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set
TEST_STD_VER.
_HAS_CXX17 indicates whether MSVC's STL is in C++17 mode.
In MSVC there's
Author: stl_msft
Date: Wed May 3 20:43:58 2017
New Revision: 302105
URL: http://llvm.org/viewvc/llvm-project?rev=302105&view=rev
Log:
[libcxx] [test] Strip trailing whitespace. NFC.
Modified:
libcxx/trunk/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.cxx1
Author: stl_msft
Date: Fri May 5 18:01:38 2017
New Revision: 302318
URL: http://llvm.org/viewvc/llvm-project?rev=302318&view=rev
Log:
[libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance
shouldn't be mandated".
In C++17, these iterators are allowed but not required
to inherit
Author: stl_msft
Date: Fri May 5 18:38:24 2017
New Revision: 302322
URL: http://llvm.org/viewvc/llvm-project?rev=302322&view=rev
Log:
[libcxx] [test] Fix MSVC "warning C6326: Potential comparison of a constant
with another constant".
The expressions `1 == 1` and `true` have the same type, value
Author: stl_msft
Date: Fri May 5 18:51:39 2017
New Revision: 302325
URL: http://llvm.org/viewvc/llvm-project?rev=302325&view=rev
Log:
[libcxx] [test] Suppress MSVC's /analyze warning C6294 in a more fine-grained
manner.
Fixes D32926.
Modified:
libcxx/trunk/test/std/utilities/template.bits
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix unreferenced formal parameter warnings. Found by MSVC as usual.
https://reviews.llvm.org/D25851
Files:
test/std/utilities/optional/optional.object/optional.object.ctor
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix shadow warnings. This variable was scoped incorrectly, found by MSVC.
https://reviews.llvm.org/D25852
Files:
test/std/utilities/optional/optional.object/optional.objec
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
The Standard doesn't depict make_from_tuple() as conditionally noexcept. Mark
these tests as libcxx-specific.
https://reviews.llvm.org/D25853
Files:
test/std/utilities/tup
Author: stl_msft
Date: Thu Oct 27 16:25:12 2016
New Revision: 285346
URL: http://llvm.org/viewvc/llvm-project?rev=285346&view=rev
Log:
[PATCH] D25483: [libcxx] [test] Fix non-Standard assumptions about how many
elements are allocated
Modified:
libcxx/trunk/test/std/containers/sequences/deque
STL_MSFT closed this revision.
STL_MSFT added a comment.
Committed r285346. Thanks!!
https://reviews.llvm.org/D25483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Committed as r286007.
https://reviews.llvm.org/D26294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
test/std/depr/depr.c.headers/inttypes_h.pass.cpp
test/std/input.output/file.streams/c.files/cinttypes.pass.cpp
test/std/input.output/iostream.forward/iosfwd.pass.cpp
Add test()
Author: stl_msft
Date: Mon Nov 14 11:35:14 2016
New Revision: 286847
URL: http://llvm.org/viewvc/llvm-project?rev=286847&view=rev
Log:
[libcxx] [test] D26314: Fix MSVC warning C4189 "local variable is initialized
but not referenced".
test/std/depr/depr.c.headers/inttypes_h.pass.cpp
test/std/inpu
STL_MSFT closed this revision.
STL_MSFT added a comment.
Checked in as r286847.
https://reviews.llvm.org/D26314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Silence another occurrence of MSVC's spurious unused warning.
Again, I'm sorry about this one (VSO#188582 tracks the need to fix the
compiler), but this targeted suppression h
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
This is optional, but I think it would be convenient if we could upstream the
ignoring of env.lst and keep.lst files that our test harness automatically
generates.
https://re
I've added a note to myself (in the list of "bugs I need fixes for") that these
two suppressions should be removed when the compiler bug is finally fixed.
JonCaves actually marked this as Fix Available on July 20, so a fix may be
forthcoming in the near future.
STL
-Original Message-
F
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix an MSVC x64 compiler warning, "warning C4312: 'type cast': conversion from
'unsigned int' to 'int *' of greater size".
The warning (which is valuable) is simple to avoid:
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix an MSVC x64 compiler error due to mismatched iterator types.
This was attempting to store a list>::iterator in a
list::iterator. That isn't guaranteed by the Standard, and
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Add TEST_STACK_ALLOCATOR_WORKAROUND. As I reported to Eric and Marshall:
"stack_allocator is seriously nonconformant to N4582 17.6.3.5
[allocator.requirements].
First, it lac
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Fix an accidental assignment within assert() that should have been
equality.
Fixes MSVC "warning C4706: assignment within conditional expression".
http://reviews.llv
[Dmitry Polukhin]
> As for 'A*' to 'B*" case, indeed it is not very common and it looks like
> someone just forgot to specify 'public'.
If we're doing something gratuitously nonconformant in MS product code or even
sample code, you should report it to us, so we can fix it upstream, instead of
h
[Richard Smith]
> You can find a description of the problem in http://llvm.org/PR27337
> Brief summary:
> The WTL bug is the missing 'public' on the second base class on this line:
> https://sourceforge.net/p/wtl/code/HEAD/tree/trunk/wtl/Samples/MDIDocVw/mainfrm.h#l636
> The C1xx bug is that it ac
STL_MSFT created this revision.
STL_MSFT added reviewers: mclow.lists, EricWF.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Consistently guard "#pragma clang" with "#if defined(__clang__)".
Similarly, consistently guard "#pragma GCC" with "#if defined(__GNUC__)".
Fixes MSVC "warning C4068:
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Remove the names of unreferenced parameters.
Fixes MSVC "warning C4100: unreferenced formal parameter".
http://reviews.llvm.org/D19619
Files:
test/std/algorithms/a
STL_MSFT created this revision.
STL_MSFT added reviewers: mclow.lists, EricWF.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Add braces, move braces, and rename variables to avoid shadowing.
Fixes MSVC "warning C4456: declaration of 'meow' hides previous local
declaration".
http://reviews.
STL_MSFT created this revision.
STL_MSFT added reviewers: mclow.lists, EricWF.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Rename function parameters to avoid shadowing.
Fixes MSVC "warning C4459: declaration of 'meow' hides global declaration".
http://reviews.llvm.org/D19621
Files:
te
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Implement the member functions of a local struct.
Fixes MSVC "warning C4822: local class member function does not have a body".
http://reviews.llvm.org/D19622
Files:
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Initialize local doubles to 0.0.
(Zero is a strict subset of garbage.)
Fixes MSVC "warning C4701: potentially uninitialized local variable 'meow'
used".
http://revi
STL_MSFT created this revision.
STL_MSFT added reviewers: mclow.lists, EricWF.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Void-cast runtime-unused variables.
Also, remove unused names in exception handlers and remove an unused array.
Fixes MSVC "warning C4101: unreferenced local variable
STL_MSFT added a comment.
I'd be happy to deal with this in another way. Would you accept
_MSC_VER-guarded pragmas to silence such warnings? I didn't see an easy way to
rework the logic here so that the variables are obviously initialized on every
codepath, which would be the ideal pragma-less
STL_MSFT retitled this revision from "[libc++] Initialize local doubles to
0.0." to "[libcxx] [test] Initialize local doubles to NaN.".
STL_MSFT updated the summary for this revision.
STL_MSFT updated this revision to Diff 55506.
STL_MSFT added a comment.
Now I'm using NaN instead of 0.0 for the
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Need to include for std::unique_ptr.
Fixes MSVC "error C2039: 'unique_ptr': is not a member of 'std'".
http://reviews.llvm.org/D19698
Files:
test/std/utili
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Need to include for its streaming operators.
Fixes MSVC errors:
"error C2678: binary '>>': no operator found which takes a left-hand operand of
type 'std::ist
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] nasty_mutex::operator& should return nullptr, like nasty_list
above it.
Fixes MSVC "error C4716: 'nasty_mutex::operator&': must return a value".
http://review
101 - 200 of 281 matches
Mail list logo
