r338301 - Avoid returning an invalid end source loc

2018-07-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jul 30 13:39:14 2018 New Revision: 338301 URL: http://llvm.org/viewvc/llvm-project?rev=338301=rev Log: Avoid returning an invalid end source loc Modified: cfe/trunk/include/clang/AST/DeclarationName.h cfe/trunk/lib/AST/DeclarationName.cpp Modified:

Re: r338301 - Avoid returning an invalid end source loc

2018-08-07 Thread Stephen Kelly via cfe-commits
Blaikie wrote: test case? On Mon, Jul 30, 2018 at 1:39 PM Stephen Kelly via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: steveire Date: Mon Jul 30 13:39:14 2018 New Revision: 338301 URL: http://llvm.org/viewvc/llvm-project?rev=338301=rev Log:

Re: r338301 - Avoid returning an invalid end source loc

2018-08-07 Thread Stephen Kelly via cfe-commits
Blaikie wrote: test case? On Mon, Jul 30, 2018 at 1:39 PM Stephen Kelly via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: steveire Date: Mon Jul 30 13:39:14 2018 New Revision: 338301 URL: http://llvm.org/viewvc/llvm-pro

r339810 - Add a newline to SourceLocation dump output

2018-08-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Aug 15 13:32:06 2018 New Revision: 339810 URL: http://llvm.org/viewvc/llvm-project?rev=339810=rev Log: Add a newline to SourceLocation dump output Summary: Migrate callers to print(). dump() should be useful to downstreams and third parties as a debugging aid.

r339731 - Remove obsolete comment

2018-08-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Aug 14 14:34:29 2018 New Revision: 339731 URL: http://llvm.org/viewvc/llvm-project?rev=339731=rev Log: Remove obsolete comment This related to the code as first checked in in r266292 ([ASTImporter] Implement some expression-related AST node import., 2016-04-14).

r339730 - Fix Stmt::ignoreImplicit

2018-08-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Aug 14 14:33:28 2018 New Revision: 339730 URL: http://llvm.org/viewvc/llvm-project?rev=339730=rev Log: Fix Stmt::ignoreImplicit Summary: A CXXBindTemporaryExpr can appear inside an ImplicitCastExpr, and was not ignored previously. Fixes the case reported in PR37327.

[clang-tools-extra] r339401 - Port getLocEnd -> getEndLoc

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 15:43:02 2018 New Revision: 339401 URL: http://llvm.org/viewvc/llvm-project?rev=339401=rev Log: Port getLocEnd -> getEndLoc Subscribers: nemanjai, ioeric, kbarton, cfe-commits Differential Revision: https://reviews.llvm.org/D50355 Modified:

r339402 - Remove obsolete set call

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 15:44:03 2018 New Revision: 339402 URL: http://llvm.org/viewvc/llvm-project?rev=339402=rev Log: Remove obsolete set call Summary: Case case of the switch statement here makes the same call, but it is already done at the start of the function. Reviewers: rsmith,

r339372 - Add getBeginLoc API to replace getLocStart

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 13:05:03 2018 New Revision: 339372 URL: http://llvm.org/viewvc/llvm-project?rev=339372=rev Log: Add getBeginLoc API to replace getLocStart Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50346 Modified:

r339373 - Add getBeginLoc API to replace getStartLoc

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 13:05:18 2018 New Revision: 339373 URL: http://llvm.org/viewvc/llvm-project?rev=339373=rev Log: Add getBeginLoc API to replace getStartLoc Reviewers: teemperor! Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50347 Modified:

r339374 - Add getEndLoc API to replace getLocEnd

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 13:05:47 2018 New Revision: 339374 URL: http://llvm.org/viewvc/llvm-project?rev=339374=rev Log: Add getEndLoc API to replace getLocEnd Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50348 Modified:

r339379 - Fix build

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 13:21:09 2018 New Revision: 339379 URL: http://llvm.org/viewvc/llvm-project?rev=339379=rev Log: Fix build Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp URL:

r339384 - Port getStartLoc -> getBeginLoc

2018-08-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 9 14:05:56 2018 New Revision: 339384 URL: http://llvm.org/viewvc/llvm-project?rev=339384=rev Log: Port getStartLoc -> getBeginLoc Reviewers: teemperor! Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50349 Modified:

r340376 - Update the docs for using LLVM toolset in Visual Studio

2018-08-21 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Aug 21 18:11:18 2018 New Revision: 340376 URL: http://llvm.org/viewvc/llvm-project?rev=340376=rev Log: Update the docs for using LLVM toolset in Visual Studio Reviewers: hans Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51079 Modified:

r340586 - Fix typo

2018-08-23 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 23 15:41:52 2018 New Revision: 340586 URL: http://llvm.org/viewvc/llvm-project?rev=340586=rev Log: Fix typo Modified: cfe/trunk/utils/TableGen/ClangCommentHTMLNamedCharacterReferenceEmitter.cpp Modified:

[clang-tools-extra] r341583 - Fix reported range of partial token replacement

2018-09-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Sep 6 13:16:34 2018 New Revision: 341583 URL: http://llvm.org/viewvc/llvm-project?rev=341583=rev Log: Fix reported range of partial token replacement Summary: Fixes bug: 38678 Reviewers: klimek, rsmith Subscribers: cfe-commits Differential Revision:

Re: r341141 - Extract parseBindID method

2018-09-06 Thread Stephen Kelly via cfe-commits
should squash things for review? I don't know. Thanks for any post-commit review! Stephen. On 31/08/18 07:06, Roman Lebedev via cfe-commits wrote: I don't think this was reviewed. The differential is not in 'accepted' state. Roman. On Fri, Aug 31, 2018 at 2:11 AM, Stephen Kelly via cfe

Re: r341141 - Extract parseBindID method

2018-09-06 Thread Stephen Kelly via cfe-commits
On 06/09/18 20:42, Roman Lebedev wrote: You can specify the dependencies between the differentials in phabricator. I didn't know that, thanks! ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r341140 - Add dump() method for SourceRange

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:10:52 2018 New Revision: 341140 URL: http://llvm.org/viewvc/llvm-project?rev=341140=rev Log: Add dump() method for SourceRange Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50662 Modified:

r341141 - Extract parseBindID method

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:11:01 2018 New Revision: 341141 URL: http://llvm.org/viewvc/llvm-project?rev=341141=rev Log: Extract parseBindID method Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51258 Modified:

r341142 - Allow binding to NamedValue resulting from let expression

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:11:09 2018 New Revision: 341142 URL: http://llvm.org/viewvc/llvm-project?rev=341142=rev Log: Allow binding to NamedValue resulting from let expression Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51259 Modified:

[clang-tools-extra] r341144 - Extract runCommandsInFile method

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:25:38 2018 New Revision: 341144 URL: http://llvm.org/viewvc/llvm-project?rev=341144=rev Log: Extract runCommandsInFile method Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51260 Modified:

[clang-tools-extra] r341145 - Add preload option to clang-query

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:25:44 2018 New Revision: 341145 URL: http://llvm.org/viewvc/llvm-project?rev=341145=rev Log: Add preload option to clang-query Summary: This allows loading a file with pre-defined let commands for example. Subscribers: cfe-commits Differential Revision:

r341146 - Remove vestiges of configure buildsystem

2018-08-30 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Aug 30 16:41:03 2018 New Revision: 341146 URL: http://llvm.org/viewvc/llvm-project?rev=341146=rev Log: Remove vestiges of configure buildsystem Summary: Subscribers: mgorny, cfe-commits Differential Revision: https://reviews.llvm.org/D50738 Modified:

r336640 - Test commit

2018-07-10 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jul 9 23:55:12 2018 New Revision: 336640 URL: http://llvm.org/viewvc/llvm-project?rev=336640=rev Log: Test commit Add redundant doc. Modified: cfe/trunk/include/clang/AST/ExprCXX.h Modified: cfe/trunk/include/clang/AST/ExprCXX.h URL:

[clang-tools-extra] r345193 - [clang-query] Add 'detailed-ast' output as an alias for 'dump'

2018-10-24 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 24 13:33:45 2018 New Revision: 345193 URL: http://llvm.org/viewvc/llvm-project?rev=345193=rev Log: [clang-query] Add 'detailed-ast' output as an alias for 'dump' Summary: Future development can then dump other content than AST. Reviewers: aaron.ballman

[clang-tools-extra] r345194 - [clang-query] Refactor Output settings to booleans

2018-10-24 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 24 13:33:55 2018 New Revision: 345194 URL: http://llvm.org/viewvc/llvm-project?rev=345194=rev Log: [clang-query] Refactor Output settings to booleans Summary: This will make it possible to add non-exclusive mode output. Reviewers: aaron.ballman Subscribers:

[clang-tools-extra] r345192 - [clang-query] Re-word command help

2018-10-24 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 24 13:33:14 2018 New Revision: 345192 URL: http://llvm.org/viewvc/llvm-project?rev=345192=rev Log: [clang-query] Re-word command help Summary: This will make it possible to easily * Add new commands which accept parameters * Extend the list of features

[clang-tools-extra] r345522 - [clang-query] Add non-exclusive output API

2018-10-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Oct 29 11:59:56 2018 New Revision: 345522 URL: http://llvm.org/viewvc/llvm-project?rev=345522=rev Log: [clang-query] Add non-exclusive output API Summary: Add granular options for AST dumping, text printing and diagnostics. This makes it possible to * Have both diag

[clang-tools-extra] r344840 - [clang-query] Add option to print matcher expression

2018-10-20 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Oct 20 02:13:59 2018 New Revision: 344840 URL: http://llvm.org/viewvc/llvm-project?rev=344840=rev Log: [clang-query] Add option to print matcher expression Summary: This is useful if using clang-query -f with a file containing multiple matchers. Reviewers:

r343807 - [NestedNameSpecifier] Add missing stream-specific dump methods

2018-10-04 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Oct 4 12:22:00 2018 New Revision: 343807 URL: http://llvm.org/viewvc/llvm-project?rev=343807=rev Log: [NestedNameSpecifier] Add missing stream-specific dump methods Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

r343719 - Update documentation for correctness

2018-10-03 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 3 13:52:57 2018 New Revision: 343719 URL: http://llvm.org/viewvc/llvm-project?rev=343719=rev Log: Update documentation for correctness Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h URL:

r344022 - Regenerate AST Matcher docs

2018-10-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Oct 9 01:24:11 2018 New Revision: 344022 URL: http://llvm.org/viewvc/llvm-project?rev=344022=rev Log: Regenerate AST Matcher docs Modified: cfe/trunk/docs/LibASTMatchersReference.html Modified: cfe/trunk/docs/LibASTMatchersReference.html URL:

r344023 - Remove non-existant typeloc matchers from documentation

2018-10-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Oct 9 01:24:18 2018 New Revision: 344023 URL: http://llvm.org/viewvc/llvm-project?rev=344023=rev Log: Remove non-existant typeloc matchers from documentation Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/docs/tools/dump_ast_matchers.py

r344021 - Fix indentation

2018-10-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Oct 9 01:24:06 2018 New Revision: 344021 URL: http://llvm.org/viewvc/llvm-project?rev=344021=rev Log: Fix indentation Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h URL:

r344026 - [ASTMatcher] Add missing imaginaryLiteral

2018-10-09 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Oct 9 01:44:28 2018 New Revision: 344026 URL: http://llvm.org/viewvc/llvm-project?rev=344026=rev Log: [ASTMatcher] Add missing imaginaryLiteral Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp URL:

r343716 - Sort list of matchers

2018-10-03 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 3 13:52:45 2018 New Revision: 343716 URL: http://llvm.org/viewvc/llvm-project?rev=343716=rev Log: Sort list of matchers Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp URL:

r343717 - Add matchers missing from dynamic AST registry

2018-10-03 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 3 13:52:51 2018 New Revision: 343717 URL: http://llvm.org/viewvc/llvm-project?rev=343717=rev Log: Add matchers missing from dynamic AST registry Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp

r343720 - Remove stray character from docs

2018-10-03 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 3 13:53:02 2018 New Revision: 343720 URL: http://llvm.org/viewvc/llvm-project?rev=343720=rev Log: Remove stray character from docs Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h URL:

[clang-tools-extra] r343664 - [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-03 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 3 00:52:44 2018 New Revision: 343664 URL: http://llvm.org/viewvc/llvm-project?rev=343664=rev Log: [clang-query] Add single-letter 'q' alias for 'quit' Reviewers: aaron.ballman, pcc Reviewed By: aaron.ballman Subscribers: Szelethus, cfe-commits Differential

r343665 - Allow comments with '#' in dynamic AST Matchers

2018-10-03 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 3 00:56:43 2018 New Revision: 343665 URL: http://llvm.org/viewvc/llvm-project?rev=343665=rev Log: Allow comments with '#' in dynamic AST Matchers Summary: This is necessary for clang-query to be able to handle comments. Reviewers: aaron.ballman Reviewed By:

[clang-tools-extra] r343666 - [clang-query] Add comment token handling

2018-10-03 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Oct 3 01:21:54 2018 New Revision: 343666 URL: http://llvm.org/viewvc/llvm-project?rev=343666=rev Log: [clang-query] Add comment token handling Summary: It is possible to pass a file of commands to clang-query using the command line option -f or --preload. Make it

[clang-tools-extra] r343533 - [clang-query] Add missing 'l' command handling

2018-10-01 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Oct 1 13:34:21 2018 New Revision: 343533 URL: http://llvm.org/viewvc/llvm-project?rev=343533=rev Log: [clang-query] Add missing 'l' command handling The `let` command was added in commit 045c15ba (Add new 'let' command to bind arbitrary values into constants.,

[clang-tools-extra] r343532 - [clang-query] Sort command options

2018-10-01 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Oct 1 13:34:15 2018 New Revision: 343532 URL: http://llvm.org/viewvc/llvm-project?rev=343532=rev Log: [clang-query] Sort command options Modified: clang-tools-extra/trunk/clang-query/QueryParser.cpp Modified: clang-tools-extra/trunk/clang-query/QueryParser.cpp

[clang-tools-extra] r343528 - [clang-tidy] Build it even without static analyzer

2018-10-01 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Oct 1 13:24:22 2018 New Revision: 343528 URL: http://llvm.org/viewvc/llvm-project?rev=343528=rev Log: [clang-tidy] Build it even without static analyzer Conditionally compile the parts of clang-tidy which depend on the static analyzer. Funnily enough, I made the

r343530 - Update CMakeLists.txt snippet so that example compiles

2018-10-01 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Oct 1 13:28:07 2018 New Revision: 343530 URL: http://llvm.org/viewvc/llvm-project?rev=343530=rev Log: Update CMakeLists.txt snippet so that example compiles Summary: Previous to this the example didn't work out of the box, it seems some cmake config changed between

[clang-tools-extra] r343536 - [clang-query] Test non-code-completion on single letter shortcuts

2018-10-01 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Oct 1 13:45:44 2018 New Revision: 343536 URL: http://llvm.org/viewvc/llvm-project?rev=343536=rev Log: [clang-query] Test non-code-completion on single letter shortcuts Modified: clang-tools-extra/trunk/unittests/clang-query/QueryParserTest.cpp Modified:

[clang-tools-extra] r343535 - [clang-query] Add missing quit test

2018-10-01 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Oct 1 13:45:39 2018 New Revision: 343535 URL: http://llvm.org/viewvc/llvm-project?rev=343535=rev Log: [clang-query] Add missing quit test Modified: clang-tools-extra/trunk/unittests/clang-query/QueryParserTest.cpp Modified:

[clang-tools-extra] r343538 - Sort expected test output after previous commit

2018-10-01 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Oct 1 14:10:30 2018 New Revision: 343538 URL: http://llvm.org/viewvc/llvm-project?rev=343538=rev Log: Sort expected test output after previous commit Modified: clang-tools-extra/trunk/unittests/clang-query/QueryParserTest.cpp Modified:

r351637 - Move decl context dumping to TextNodeDumper

2019-01-19 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 19 01:05:55 2019 New Revision: 351637 URL: http://llvm.org/viewvc/llvm-project?rev=351637=rev Log: Move decl context dumping to TextNodeDumper Summary: Only an obscure case is moved. Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

r351646 - [ASTDump] NFC: Use `const auto` in cxx_range_for loops

2019-01-19 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 19 01:57:51 2019 New Revision: 351646 URL: http://llvm.org/viewvc/llvm-project?rev=351646=rev Log: [ASTDump] NFC: Use `const auto` in cxx_range_for loops This is coming up a lot in reviews. Better just to do them all at once. Modified:

r351647 - [ASTDump] NFC: Convert iterative loops to cxx_range_for

2019-01-19 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sat Jan 19 01:57:59 2019 New Revision: 351647 URL: http://llvm.org/viewvc/llvm-project?rev=351647=rev Log: [ASTDump] NFC: Convert iterative loops to cxx_range_for This is coming up a lot in reviews. Better just to change them all at once. Modified:

r351600 - [ASTDump] Mark BlockDecls which capture this with a tag

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 13:55:24 2019 New Revision: 351600 URL: http://llvm.org/viewvc/llvm-project?rev=351600=rev Log: [ASTDump] Mark BlockDecls which capture this with a tag Summary: Removal of the child node makes it easier to separate traversal from output generation. Reviewers:

r351597 - [ASTDump] Mark variadic declarations with a tag instead of child node

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 13:38:30 2019 New Revision: 351597 URL: http://llvm.org/viewvc/llvm-project?rev=351597=rev Log: [ASTDump] Mark variadic declarations with a tag instead of child node Summary: This makes it easier to separate traversal of the AST from output generation.

r351601 - [ASTDump] Mark null params with a tag rather than a child node

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:00:16 2019 New Revision: 351601 URL: http://llvm.org/viewvc/llvm-project?rev=351601=rev Log: [ASTDump] Mark null params with a tag rather than a child node Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

r351605 - [ASTDump] NFC: Move variable into if() statement

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:15:09 2019 New Revision: 351605 URL: http://llvm.org/viewvc/llvm-project?rev=351605=rev Log: [ASTDump] NFC: Move variable into if() statement Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r351606 - [ASTDump] Add test for current AST dump behavior

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:15:13 2019 New Revision: 351606 URL: http://llvm.org/viewvc/llvm-project?rev=351606=rev Log: [ASTDump] Add test for current AST dump behavior Added: cfe/trunk/test/AST/ast-dump-undeserialized.cpp Added: cfe/trunk/test/AST/ast-dump-undeserialized.cpp URL:

r351604 - [ASTDump] NFC: Remove redundant condition

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:15:05 2019 New Revision: 351604 URL: http://llvm.org/viewvc/llvm-project?rev=351604=rev Log: [ASTDump] NFC: Remove redundant condition These conditions are duplicated from the dumpDeclContext function called within the if(). This is presumably an attempt to

r351603 - [ASTDump] NFC: Remove non-needed braces

2019-01-18 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Fri Jan 18 14:14:59 2019 New Revision: 351603 URL: http://llvm.org/viewvc/llvm-project?rev=351603=rev Log: [ASTDump] NFC: Remove non-needed braces Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

Re: [PATCH] D56829: Move decl context dumping to TextNodeDumper

2019-01-20 Thread Stephen Kelly via cfe-commits
On 20/01/2019 16:57, Stella Stamenova via Phabricator via cfe-commits wrote: stella.stamenova added a comment. It looks like this change broke a number of the LLDB tests: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/781 Could you look into this or revert the change, so that the

r351235 - Implement CXXCtorInitializer dump in terms of Visitor

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 12:17:33 2019 New Revision: 351235 URL: http://llvm.org/viewvc/llvm-project?rev=351235=rev Log: Implement CXXCtorInitializer dump in terms of Visitor Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56707

r351236 - NFC: Implement OMPClause dump in terms of visitors

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 12:31:31 2019 New Revision: 351236 URL: http://llvm.org/viewvc/llvm-project?rev=351236=rev Log: NFC: Implement OMPClause dump in terms of visitors Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56708

r351116 - [ASTDump] NFC: Move dumping of QualType node to TextNodeDumper

2019-01-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jan 14 12:15:29 2019 New Revision: 351116 URL: http://llvm.org/viewvc/llvm-project?rev=351116=rev Log: [ASTDump] NFC: Move dumping of QualType node to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

r351112 - NFC: Fix nits I missed before

2019-01-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jan 14 11:50:34 2019 New Revision: 351112 URL: http://llvm.org/viewvc/llvm-project?rev=351112=rev Log: NFC: Fix nits I missed before Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/lib/AST/TextNodeDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r351115 - [ASTDump] NFC: Canonicalize handling of TypeLocInfo

2019-01-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jan 14 12:13:09 2019 New Revision: 351115 URL: http://llvm.org/viewvc/llvm-project?rev=351115=rev Log: [ASTDump] NFC: Canonicalize handling of TypeLocInfo Summary: No need to avoid the Visit method. Reviewers: aaron.ballman Subscribers: cfe-commits Differential

r351114 - [ASTDump] NFC: Move Type Visit implementation to TextNodeDumper

2019-01-14 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Jan 14 12:11:02 2019 New Revision: 351114 URL: http://llvm.org/viewvc/llvm-project?rev=351114=rev Log: [ASTDump] NFC: Move Type Visit implementation to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

Re: r351269 - Re-order overrides in FunctionDecl dump

2019-01-15 Thread Stephen Kelly via cfe-commits
On 15/01/2019 23:00, Aaron Ballman wrote: On Tue, Jan 15, 2019 at 5:54 PM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Tue Jan 15 14:50:37 2019 New Revision: 351269 URL: http://llvm.org/viewvc/llvm-project?rev=351269=rev Log: Re-order overrides in FunctionDecl dump Output all

r351272 - Re-order type param children of ObjC nodes

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 15:07:30 2019 New Revision: 351272 URL: http://llvm.org/viewvc/llvm-project?rev=351272=rev Log: Re-order type param children of ObjC nodes Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55394 Modified:

r351239 - Implement BlockDecl::Capture dump in terms of visitors

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 12:41:37 2019 New Revision: 351239 URL: http://llvm.org/viewvc/llvm-project?rev=351239=rev Log: Implement BlockDecl::Capture dump in terms of visitors Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56709

r351271 - NFC: Some cleanups that I missed in the previous commit

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 15:05:11 2019 New Revision: 351271 URL: http://llvm.org/viewvc/llvm-project?rev=351271=rev Log: NFC: Some cleanups that I missed in the previous commit Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r351268 - NFC: Replace iterator loop with cxx_range_for

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 14:45:46 2019 New Revision: 351268 URL: http://llvm.org/viewvc/llvm-project?rev=351268=rev Log: NFC: Replace iterator loop with cxx_range_for Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r351269 - Re-order overrides in FunctionDecl dump

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 14:50:37 2019 New Revision: 351269 URL: http://llvm.org/viewvc/llvm-project?rev=351269=rev Log: Re-order overrides in FunctionDecl dump Output all content which is local to the FunctionDecl before traversing to child AST nodes. This is necessary so that all of

r351172 - [ASTDump] NFC: Move dump of type nodes to NodeDumper

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 01:30:00 2019 New Revision: 351172 URL: http://llvm.org/viewvc/llvm-project?rev=351172=rev Log: [ASTDump] NFC: Move dump of type nodes to NodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56642

r351175 - NFC: Move Decl node handling to TextNodeDumper

2019-01-15 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Jan 15 01:35:52 2019 New Revision: 351175 URL: http://llvm.org/viewvc/llvm-project?rev=351175=rev Log: NFC: Move Decl node handling to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56643 Modified:

r348794 - Change InitListExpr dump to label and pointer

2018-12-10 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Dec 10 12:53:32 2018 New Revision: 348794 URL: http://llvm.org/viewvc/llvm-project?rev=348794=rev Log: Change InitListExpr dump to label and pointer Summary: Don't add a child just for the label. Reviewers: aaron.ballman Subscribers: cfe-commits Differential

r348795 - Re-order content in OMPDeclareReductionDecl dump

2018-12-10 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Dec 10 12:53:39 2018 New Revision: 348795 URL: http://llvm.org/viewvc/llvm-project?rev=348795=rev Log: Re-order content in OMPDeclareReductionDecl dump Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55395 Modified:

Re: r348794 - Change InitListExpr dump to label and pointer

2018-12-10 Thread Stephen Kelly via cfe-commits
I'll revert it to allow for further discussion. On 10/12/2018 21:12, Richard Smith wrote: On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: steveire Date: Mon Dec 10 12:53:32 2018 New Revision: 348794 URL

r348797 - Re-order content of template parameter dumps

2018-12-10 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Dec 10 13:03:00 2018 New Revision: 348797 URL: http://llvm.org/viewvc/llvm-project?rev=348797=rev Log: Re-order content of template parameter dumps Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55393 Modified:

Re: r348794 - Change InitListExpr dump to label and pointer

2018-12-10 Thread Stephen Kelly via cfe-commits
I suggest continuing this discussion here: https://reviews.llvm.org/D55488 On 10/12/2018 21:42, Aaron Ballman wrote: On Mon, Dec 10, 2018 at 4:13 PM Richard Smith via cfe-commits wrote: On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits wrote: Author: steveire Date: Mon Dec 10 12

r348799 - Revert "Change InitListExpr dump to label and pointer"

2018-12-10 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Dec 10 13:20:05 2018 New Revision: 348799 URL: http://llvm.org/viewvc/llvm-project?rev=348799=rev Log: Revert "Change InitListExpr dump to label and pointer" This reverts commit r348794. Modified: cfe/trunk/lib/AST/ASTDumper.cpp

r348798 - Fix nits

2018-12-10 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Dec 10 13:04:04 2018 New Revision: 348798 URL: http://llvm.org/viewvc/llvm-project?rev=348798=rev Log: Fix nits Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

Re: Dumping AST information to other formats

2018-11-28 Thread Stephen Kelly via cfe-commits
On 27/11/2018 09:49, Stephen Kelly via cfe-commits wrote: On 26/11/2018 19:20, Aaron Ballman via cfe-commits wrote: Once upon a time, there was -ast-print-xml. This -cc1 option was dropped because it was frequently out of sync with the AST data. It is right to ask: why would JSON, etc be any

r347901 - NFC: Fix case of CommentVisitor::Visit methods

2018-11-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Nov 29 11:31:32 2018 New Revision: 347901 URL: http://llvm.org/viewvc/llvm-project?rev=347901=rev Log: NFC: Fix case of CommentVisitor::Visit methods This difference is very visible because it is used with other Visitor classes together. Modified:

r347900 - NFC: Move ColorScope to global scope

2018-11-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Nov 29 11:30:37 2018 New Revision: 347900 URL: http://llvm.org/viewvc/llvm-project?rev=347900=rev Log: NFC: Move ColorScope to global scope Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r347899 - NFC: Constify ShowColors

2018-11-29 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Nov 29 11:30:08 2018 New Revision: 347899 URL: http://llvm.org/viewvc/llvm-project?rev=347899=rev Log: NFC: Constify ShowColors Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r348241 - Extend test for DependentSizedArrayType

2018-12-04 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Tue Dec 4 01:53:36 2018 New Revision: 348241 URL: http://llvm.org/viewvc/llvm-project?rev=348241=rev Log: Extend test for DependentSizedArrayType Use a using declaration to force the type to appear in the -ast-dump output. Modified:

r348408 - Add dump tests for inherited default template parameters

2018-12-05 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Dec 5 12:21:13 2018 New Revision: 348408 URL: http://llvm.org/viewvc/llvm-project?rev=348408=rev Log: Add dump tests for inherited default template parameters Modified: cfe/trunk/test/AST/ast-dump-decl.cpp Modified: cfe/trunk/test/AST/ast-dump-decl.cpp URL:

r348410 - NFC: Extract TextTreeStructure class

2018-12-05 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Dec 5 12:53:14 2018 New Revision: 348410 URL: http://llvm.org/viewvc/llvm-project?rev=348410=rev Log: NFC: Extract TextTreeStructure class Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55188 Added:

Re: r348408 - Add dump tests for inherited default template parameters

2018-12-05 Thread Stephen Kelly via cfe-commits
Surely all of the tests specifically about template decls should be moved? On 05/12/2018 20:31, Aaron Ballman wrote: On Wed, Dec 5, 2018 at 3:24 PM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Wed Dec 5 12:21:13 2018 New Revision: 348408 URL: http://llvm.org/viewvc/llvm

r348412 - NFC: Extract TextNodeDumper class

2018-12-05 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Dec 5 13:12:39 2018 New Revision: 348412 URL: http://llvm.org/viewvc/llvm-project?rev=348412=rev Log: NFC: Extract TextNodeDumper class Summary: Start by moving some utilities to it. It will eventually house dumping of individual nodes (after indentation etc has

r348409 - NFC: Inline handling of DependentSizedArrayType

2018-12-05 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Wed Dec 5 12:34:07 2018 New Revision: 348409 URL: http://llvm.org/viewvc/llvm-project?rev=348409=rev Log: NFC: Inline handling of DependentSizedArrayType Summary: Re-order handling of getElementType and getBracketsRange. It is necessary to perform all printing before any

r348093 - Add dump tests for ArrayInitLoopExpr and ArrayInitIndexExpr

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 08:36:23 2018 New Revision: 348093 URL: http://llvm.org/viewvc/llvm-project?rev=348093=rev Log: Add dump tests for ArrayInitLoopExpr and ArrayInitIndexExpr Added: cfe/trunk/test/AST/ast-dump-array.cpp Added: cfe/trunk/test/AST/ast-dump-array.cpp URL:

r348101 - Replace FullComment member being visited with parameter

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 09:30:40 2018 New Revision: 348101 URL: http://llvm.org/viewvc/llvm-project?rev=348101=rev Log: Replace FullComment member being visited with parameter Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55070

r348099 - Remove unecessary methods

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 09:30:26 2018 New Revision: 348099 URL: http://llvm.org/viewvc/llvm-project?rev=348099=rev Log: Remove unecessary methods The base class calls VisitExpr Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r348100 - Extend the CommentVisitor with parameter types

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 09:30:34 2018 New Revision: 348100 URL: http://llvm.org/viewvc/llvm-project?rev=348100=rev Log: Extend the CommentVisitor with parameter types Summary: This has precedent in the StmtVisitor. This change will make it possible to clean up the comment handling in

r348094 - Fix whitespace

2018-12-02 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Sun Dec 2 08:42:34 2018 New Revision: 348094 URL: http://llvm.org/viewvc/llvm-project?rev=348094=rev Log: Fix whitespace Modified: cfe/trunk/test/AST/ast-dump-array.cpp Modified: cfe/trunk/test/AST/ast-dump-array.cpp URL:

r348189 - NFC: Simplify dumpStmt child handling

2018-12-03 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Mon Dec 3 13:05:52 2018 New Revision: 348189 URL: http://llvm.org/viewvc/llvm-project?rev=348189=rev Log: NFC: Simplify dumpStmt child handling Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55068 Modified:

r348469 - Make test resistant to line numbers changing

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 01:22:12 2018 New Revision: 348469 URL: http://llvm.org/viewvc/llvm-project?rev=348469=rev Log: Make test resistant to line numbers changing Modified: cfe/trunk/test/AST/dump.cpp Modified: cfe/trunk/test/AST/dump.cpp URL:

Re: r348471 - Add test for ObjC generics

2018-12-06 Thread Stephen Kelly via cfe-commits
On 06/12/2018 12:48, Aaron Ballman wrote: On Thu, Dec 6, 2018 at 4:26 AM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Thu Dec 6 01:23:59 2018 New Revision: 348471 URL: http://llvm.org/viewvc/llvm-project?rev=348471=rev Log: Add test for ObjC generics Modified: cfe/trunk

r348545 - NFC: Move VisitStmt code to dumpStmt

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 15:33:27 2018 New Revision: 348545 URL: http://llvm.org/viewvc/llvm-project?rev=348545=rev Log: NFC: Move VisitStmt code to dumpStmt Summary: This call is duplicated in Visits of all direct subclasses of Stmt. Reviewers: aaron.ballman Subscribers: cfe-commits

  1   2   3   4   >