Re: [PATCH] D14200: Make FP_CONTRACT ON default.

scanon updated this revision to Diff 39205. scanon added a comment. Additionally test contraction of compound assignment expressions. http://reviews.llvm.org/D14200 Files: include/clang/Basic/LangOptions.def lib/Frontend/CompilerInvocation.cpp test/CodeGen/aarch64-neon-fma.c

Re: [PATCH] D15165: change an assert when generating fmuladd to an ordinary 'if' check (PR25719)

scanon added a comment. LGTM. http://reviews.llvm.org/D15165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14891: Replace assert with early-out in tryEmitFMulAdd

scanon abandoned this revision. scanon added a comment. Abandoned for http://reviews.llvm.org/D15165. http://reviews.llvm.org/D14891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15165: change an assert when generating fmuladd to an ordinary 'if' check (PR25719)

scanon added a comment. This is mostly http://reviews.llvm.org/D14891 with a test case added, but http://reviews.llvm.org/D14891 also fixed a second very minor issue: that the "else if" should just be "if". Also, majnemer made a few style suggestions there that it would be nice to adopt.

Re: [PATCH] D14891: Replace assert with early-out in tryEmitFMulAdd

scanon added a comment. Friendly ping. http://reviews.llvm.org/D14891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14891: Replace assert with early-out in tryEmitFMulAdd

scanon created this revision. scanon added reviewers: hfinkel, resistor, lhames. scanon added a subscriber: cfe-commits. r253269 exposed a pre-existing issue in tryEmitFMulAdd, where we would assert if a fusable operation had operands with multiple uses (we didn't see it previously because

Re: [PATCH] D20341: [CUDA] Enable fusing FP ops for CUDA by default.

scanon added a comment. `-ffp-contract=on` obeys the semantics of C's FP_CONTRACT pragma. In particular, it will not fuse: float m = x*y; float a = m + z; Whereas you probably want that to fuse for your purposes. `-ffp-contract=fast` seems more in line with your needs.

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

scanon added a comment. I am not the right person to review the C++ template details, but everything else seems OK to me. https://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

scanon added a comment. I agree with Marshall. Aside from the points he raises, this approach looks fine. http://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

Without digging into them yet, these are almost caused by overly-sensitive tests that are erroneously expecting bit-exact results. - Steve Sent from my iPhone > On Sep 23, 2016, at 4:42 PM, Renato Golin wrote: > > rengolin added a subscriber: rengolin. > rengolin

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

That's not a great long-term solution for obvious reasons, but I think it's a great quick fix. Sent from my iPhone > On Sep 23, 2016, at 5:53 PM, Hal Finkel wrote: > > We currently have logic in the test suite that sets -ffp-contract=off on > PowerPC (because the default for

Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

scanon accepted this revision. scanon added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D24481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org