[PATCH] D94396: Fix macos target assumption in test

This revision was automatically updated to reflect the committed changes. Closed by commit rG305ac81e1d4b: Fix macos target assumption in test (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94396/new/

[PATCH] D94396: Fix macos target assumption in test

thopre added reviewers: hans, jyknight, steven_wu. thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94396/new/ https://reviews.llvm.org/D94396 ___ cfe-commits mailing list

[PATCH] D94396: Fix macos target assumption in test

thopre created this revision. thopre added a reviewer: arphaman. thopre requested review of this revision. Herald added a project: clang. Clang test Driver/macos-apple-silicon-slice-link-libs-darwin-only.cpp assumes the target is darwin when the host is darwin which is not necessarily the case,

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93347/new/ https://reviews.llvm.org/D93347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

This revision was automatically updated to reflect the committed changes. Closed by commit rGacbb3652931a: [AST][NFC] Silence GCC warning about multiline comments (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2481300 , @rjmccall wrote: > People can't actually just copy/paste from the comment anyway because of the > comment characters on the line, and I don't think anyone will misunderstand > the example if the backslash is

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre updated this revision to Diff 315080. thopre added a comment. Change approach to remove continuation line instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 Files:

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2450897 , @thopre wrote: > In D92409#2450690 , @rsmith wrote: > >> In D92409#2450550 , @thopre wrote: >> >>> In D92409#2426196

[PATCH] D93350: [Test] Fix undef var in catch-undef-behavior.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG150fe05db441: [Test] Fix undef var in catch-undef-behavior.c (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93350: [Test] Fix undef var in catch-undef-behavior.c

thopre created this revision. thopre added reviewers: rsmith, rnk, BillyONeal, spatel. thopre requested review of this revision. Herald added a project: clang. Commit 9e52c43090f8cd980167bbd2719878ae36bcf6b5 removed the directive defining LINE_1600 but left a string substitution to that variable

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre created this revision. thopre added reviewers: zbrid, chandlerc, EricWF. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix use of undefined variable in CHECK-NOT directive in clang test

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2450690 , @rsmith wrote: > In D92409#2450550 , @thopre wrote: > >> In D92409#2426196 , @thopre wrote: >> >>> Is there a way to disable it

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426196 , @thopre wrote: > In D92409#2426188 , @rsmith wrote: > >> Let's just disable this broken GCC warning. IIRC, the corresponding clang >> warning covers the actual bugs

[PATCH] D92384: [AST][NFC] Silence GCC warning about broken strict aliasing rules

This revision was automatically updated to reflect the committed changes. Closed by commit rG507bbc45bba9: [AST][NFC] Silence GCC warning about broken strict aliasing rules (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426188 , @rsmith wrote: > Let's just disable this broken GCC warning. IIRC, the corresponding clang > warning covers the actual bugs caused by line continuation in comments, and > doesn't warn if the next line begins

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426160 , @ABataev wrote: > I would just remove this extra symbol. But then the example code is no longer copy/pastable. Note that I expect people to copy/paste but it's nice if it looks authentic. Note that I don't

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre created this revision. thopre added reviewers: ABataev, rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. thopre requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. GCC's -Wcomment warning is

[PATCH] D92384: [AST][NFC] Silence GCC warning about broken strict aliasing rules

thopre created this revision. thopre added reviewers: jdenny, aaron.ballman, hfinkel, llvm-commits. Herald added a project: clang. Herald added a subscriber: cfe-commits. thopre requested review of this revision. The deserialize() method would trigger the following warning on GCC <7: warning:

[PATCH] D85367: [clang, test, Darwin] Fix tests expecting Darwin target

This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc863cd858f: [clang, test, Darwin] Fix tests expecting Darwin target (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85367/new/

[PATCH] D85367: [clang, test, Darwin] Fix tests expecting Darwin target

thopre created this revision. thopre added reviewers: zixuw, arphaman, ributzka, steven_wu, dexonsmith. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. thopre requested review of this revision. Clang tests Driver/apple-arm64-arch.c and

[PATCH] D81422: Change filecheck default to dump input on failure

thopre accepted this revision. thopre added a comment. In D81422#2080758 , @probinson wrote: > I don't remember the exact reasoning but I believe it had something to do > with bot logs? @jdenny or @thopre might remember. I guess -dump-input just

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

thopre added a comment. That was a speedy patch! I can confirm that my non reduced testcase (git diff -U0 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b ^ 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b

[PATCH] D79276: [FileCheck] Support comment directives

thopre accepted this revision. thopre added a comment. LGTM. Sorry for the late review. Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + jdenny wrote: > jdenny wrote: > > thopre wrote: > > >

[PATCH] D79276: [FileCheck] Support comment directives

thopre added inline comments. Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + How about characters that cannot be part of an identifier? E.g. would "@COM:" be interpreted as a comment? Should

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

thopre added a subscriber: nemanjai. thopre added a comment. Herald added a subscriber: wuzish. In D71408#1787959 , @jdenny wrote: > This breaks the lit test suite. `llvm/utils/lit/tests/shtest-format.py` > needs to be updated for the removed tests.

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGddd0bb8dba2a: [lit] Remove lits REQUIRES-ANY directive (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

thopre updated this revision to Diff 233712. thopre added a comment. Herald added subscribers: Sanitizers, cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, delcypher, niosHD,

[PATCH] D70748: [clang test] Do not assume default target

thopre closed this revision. thopre added a comment. Committed as 717140a0dcc651ca2fec23248d1675fb2d388b9c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70748/new/

[PATCH] D70748: [clang test] Do not assume default target

thopre created this revision. thopre added a reviewer: thegameg. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang test Driver/darwin-opt-record.c assumes the default target is x86_64 by its uses of the -arch x86_64 and -arch x86_64h and thus fail on systems where it is

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

thopre added a comment. My sincere apologies, I forgot to change the author in the commit. I don't often commit on behalf of others so didn't think enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68155/new/ https://reviews.llvm.org/D68155

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

This revision was automatically updated to reflect the committed changes. Closed by commit rGb81cc6032902: [clang][NFC] Make various uses of Regex const (authored by thopre). Changed prior to commit: https://reviews.llvm.org/D68155?vs=26=230079#toc Repository: rG LLVM Github Monorepo

[PATCH] D68155: [clang][NFC] Make various uses of Regex const

thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68155/new/ https://reviews.llvm.org/D68155 ___ cfe-commits

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. That's much better thank you. I like the stream shift operator overload, nice touch. LGTM but give it a day for other to give feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

thopre added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:95 + +static size_t argPrefixesSize(size_t len) { + if (len == 1) Any reason why not take a StringRef of the option to compute the prefix of? That would put the .size() gymnastic in one

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55428/new/ https://reviews.llvm.org/D55428 ___ cfe-commits mailing list

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

thopre added inline comments. Comment at: include/clang/Driver/Options.td:1636 def fstack_protector_all : Flag<["-"], "fstack-protector-all">, Group, HelpText<"Force the usage of stack protectors for all functions">; def fstack_protector_strong : Flag<["-"],

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

thopre added inline comments. Comment at: include/clang/Driver/Options.td:1634-1636 + HelpText<"Uses a stronger heuristic to apply stack protectors to functions " + "that include arrays of any size (and any type), " + "as well as any calls to alloca or the

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

thopre added a comment. Hi George, This commit seems to be causing some testsuite regression on Armv8 (both Aarch64 and ARM) architectures: http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/5450 http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/5625 Best regards,

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre accepted this revision. thopre added a comment. This revision is now accepted and ready to land. As I said, LGTM. Please wait a few days (say next Monday) in case anyone else has any objection. https://reviews.llvm.org/D45965 ___

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added a comment. FWIW LGTM. https://reviews.llvm.org/D45965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + miyuki wrote: > thopre

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + From what I understood

<    1   2