[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang created this revision. tingwang added reviewers: PowerPC, jsji, nemanjai, shchenz. tingwang added a project: LLVM. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. tingwang requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang added a comment. Since this is compatibility support, I'm trying to match the result from XLC in scenarios where there is all kinds of QNaN, SNaN, +/-Infinity, +/-ZERO. Currently maxfl and maxfs still give different result compared with XLC in above scenario. This is one thing I'm

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 418509. tingwang added a comment. Update test case to show that we need D122462 to fix the crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 418485. tingwang added a comment. Option -mlong-double-128 is not supported on AIX currently, and clang fails due to type mismatch in the fe case. Add check logic to print diag message in this case. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:192 + [llvm_float_ty, llvm_float_ty, llvm_float_ty, llvm_vararg_ty], + [IntrNoMem]>; } qiucf wrote: > Will we support `llvm_f128_ty`? I'm

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 418544. tingwang marked 11 inline comments as done. tingwang added a comment. Update based on Chaofan's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.llvm.org/D122478

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 419704. tingwang added a comment. Update based on comments: (1) Reuse diag error message. (2) Update clang test case for those diag messages. (3) Add TODO comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang marked an inline comment as done. tingwang added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9897 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding :

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb389354b2857: [Clang][PowerPC] Add max/min intrinsics to Clang and PPC backend (authored by tingwang). Repository: rG LLVM Github Monorepo

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:522 EmitCXXThreadLocalInitFunc(); + if (getTriple().isOSAIX()) { +genAssocMeta(); shchenz wrote: > Seems this dos not follow other functions call's style. Can we call a >

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 442419. tingwang added a comment. Update according to comments: (1) Merged cleanupAssoc() into genAssocMeta(), and renamed genAssocMeta() to EmitAssociatedMetadata(). (2) Removed "-debug-info-kind=limited" from all test cases. Repository: rG LLVM Github

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 443201. tingwang added a comment. Add guards against TLS variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Gentle ping. Verified the patch works with latest code base, all tests green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 ___

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 442773. tingwang added a comment. Drop TLS related .ref for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 435107. tingwang added a comment. Herald added subscribers: llvm-commits, jdoerfert. Update according to comments: (1) Update docs (2) Use `addVarTermAssoc` (3) Remove redundant call to `updateAssociatedFunc(FFDtorTermAssoc...` (4) Remove unnecessary

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang marked an inline comment as done. tingwang added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:688 +updateAssociatedFunc(VFInitTermAssoc, LocalCXXGlobalInits, GetElem, Fn); +updateAssociatedFunc(FFDtorTermAssoc, LocalCXXGlobalInits,

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. In D125095#3552451 , @shchenz wrote: > Thanks for doing this. I am not familiar with the frontend, so I may be > wrong/stupid in the follow comments : ) > Hope other experts like @hubert.reinterpretcast can give more meaningful

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang created this revision. tingwang added reviewers: jsji, nemanjai, shchenz, hubert.reinterpretcast, PowerPC. tingwang added projects: LLVM, clang. Herald added a project: All. tingwang requested review of this revision. Herald added a subscriber: cfe-commits. This is the frontend part of

[PATCH] D125203: [PowerPC] Fix PPCISD::STBRX selection issue on A2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG289236d597a2: [PowerPC] Fix PPCISD::STBRX selection issue on A2 (authored by tingwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125203: [PowerPC] Fix PPCISD::STBRX selection issue on A2

tingwang updated this revision to Diff 428294. tingwang added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update according to Nemanja's comment: add A2 to frontend isa-v206-instructions feature list, together with test case update. Repository: rG LLVM

[PATCH] D125203: [PowerPC] Fix PPCISD::STBRX selection issue on A2

tingwang added a comment. In D125203#3502433 , @nemanjai wrote: > Why not also fix this in the front end so that we allow the builtin on the A2 > CPU as well (since it's supported)? Oh I missed that. Thank you for pointing out! Just now updated the

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 428268. tingwang added a comment. Update the three test cases introduced in this patch to use opaque-pointer clang/test/CodeGen/PowerPC/aix-init-ref-null.cpp clang/test/CodeGen/PowerPC/aix-ref-static-var.cpp clang/test/CodeGen/PowerPC/aix-ref-tls_init.cpp

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2d77e050b32: [PowerPC][Coroutines] Add tail-call check with call information for coroutines (authored by tingwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang created this revision. tingwang added reviewers: uweigand, wschmidt, PowerPC. tingwang added a project: clang. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. tingwang requested review of this revision. Herald added a subscriber: cfe-commits. This is an

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee703b5cb134: [clang][PowerPC] PPC64 VAArg fix right-alignment for aggregates fit in register (authored by tingwang). Repository: rG LLVM Github

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added a comment. (Inviting reviewers from D21611 to look into the change here.) The expected pattern `test8va()` added in this patch was broken by D21611 . Now as suggested by Ulrich, we are planning to create a flag

[PATCH] D133749: [clang][NFC] Update test case struct-union-BE.c for opaque-pointers

tingwang created this revision. tingwang added reviewers: dsanders, rjmccall, spetrovic, vkalintiris, john.brawn, petarj. tingwang added a project: clang. Herald added a project: All. tingwang requested review of this revision. Herald added a subscriber: cfe-commits. Update patterns in this test

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 458721. tingwang added a comment. Update according to comments: (1) The argument type is not touched. (2) Add flag in APIs to force right-adjust the parameter for this issue. (3) One change on if check logic: now use CoerceTy->getIntegerBitWidth() directly

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

tingwang created this revision. tingwang added reviewers: uweigand, wschmidt, PowerPC. tingwang added a project: clang. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. tingwang requested review of this revision. Herald added a subscriber: cfe-commits. Add base

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added a comment. > It looks like the only change needed for ppc would be to remove the > `!DirectTy->isStructTy()` check here? (I guess to avoid inadvertently > change other targets, this might need to be triggered by a flag passed as > argument. On the other hand, maybe there is

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 458735. tingwang added a comment. Update according to comments: Remove all those checks, they are redundant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files:

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5471 +if (CoerceTy->isIntegerTy() && CoerceTy->getIntegerBitWidth() < GPRBits) + ForceRightAdjust = true; + } uweigand wrote: > Are all these checks really necessary

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 462113. tingwang added a comment. Add TODO comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added a comment. In D18#3786406 , @nemanjai wrote: > I am not crazy about adding the Boolean parameter here or about the name. > Seems somewhat unclear when a caller wants to pass `true` there. > > What I think would be a more robust

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 466992. tingwang added a comment. Address comment: move TODO close to PPC64 specific case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files:

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added a comment. In D18#3850091 , @rjmccall wrote: > This seems be to a genuine target difference, right? PPC64 has this ABI rule: > >> An aggregate or union smaller than one doubleword in size is padded so that >> it appears in the least

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 466710. tingwang added a comment. Rebase && Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

tingwang updated this revision to Diff 466708. tingwang added a comment. Rebase on opaque-pointers test case changes && Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133488/new/ https://reviews.llvm.org/D133488 Files:

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:327 +/// if the argument is smaller than a slot, set this flag will force +/// right-adjust the argument in its slot irrespective of the type. static Address emitVoidPtrDirectVAArg(CodeGenFunction

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

tingwang updated this revision to Diff 467040. tingwang added a reviewer: rjmccall. tingwang added a comment. Add test case according to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133488/new/ https://reviews.llvm.org/D133488 Files:

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 467048. tingwang added a comment. Update according to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

This revision was automatically updated to reflect the committed changes. Closed by commit rG00b9bed1f05a: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than… (authored by tingwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

tingwang updated this revision to Diff 453188. tingwang added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update according to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131953/new/

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

tingwang updated this revision to Diff 453193. tingwang added a comment. For default implementation of `supportsTailCallFor`, return `supportsTailCalls()` as suggested in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131953/new/

[PATCH] D131953: [PowerPC][Coroutines] Add tail-call check with context information for coroutines

tingwang marked an inline comment as done. tingwang added a comment. In D131953#3727900 , @ChuanqiXu wrote: > LGTM with comment addressed. Thanks! Thank you! I'm looking forward to comments from ppc. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Currently this patch does not work due to limit set on associated metadata operand count (forced to be single operand). commit 87f2e9448e82bbed4ac59bb61bea03256aa5f4de Author: Matt Arsenault Date: Mon Jan 9 12:17:38 2023 -0500 Verifier: Add checks for

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 504031. tingwang added a comment. Herald added a subscriber: hiraditya. Rebase and update patch (1) Update verifier check on associated metadata to allow multiple operands for AIX. (2) Update test cases to use opaque pointer. Repository: rG LLVM Github

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

tingwang updated this revision to Diff 504952. tingwang added a reviewer: PowerPC. tingwang added a comment. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Address comments: (1) Add test case to show how associated metadata will be used on AIX (currently not

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

tingwang updated this revision to Diff 505709. tingwang added a comment. Add empty case in Verifier/associated-metadata-aix-xcoff.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145767/new/ https://reviews.llvm.org/D145767 Files:

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 505720. tingwang added a comment. As verifier change and baseline test cases have been moved into https://reviews.llvm.org/D145767, update this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

tingwang updated this revision to Diff 505372. tingwang added a comment. Address comments: (1) Duplicated associated test cases to make copies for AIX XCOFF, and added `multiple operands` and `null operand` as legal cases. (2) Updated verifier logic to check for AIX target. (3) Moved XFAIL check

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

tingwang added inline comments. Comment at: clang/test/CodeGen/PowerPC/aix-init-ref-null.cpp:2 +// RUN: %clang_cc1 -triple powerpc64-ibm-aix-xcoff -emit-llvm -O3 -x c++ < %s | FileCheck %s +// XFAIL: * +// This function should fail until .ref is support on AIX.

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

tingwang planned changes to this revision. tingwang added a comment. Hi Matt @arsenm, thank you for your comments, and I will incorporate your suggestions in the next version. Since the review process of dependent patch https://reviews.llvm.org/D125095 didn't get any progress for a long time,