[PATCH] D46791: Make -gsplit-dwarf generally available

trixirt created this revision. trixirt added reviewers: echristo, jakehehrlich, emaste. Herald added subscribers: cfe-commits, JDevlieghere, krytarowski, aprantl, mgorny. Herald added a reviewer: alexshap. Change CLANG_DEFAULT_OBJCOPY from objcopy to llvm-objcopy Remove is-linux checks Add dwarf

[PATCH] D47260: Testcase for dwarf 5 crash/assert when calculating a checksum for an expansion

trixirt added a comment. commandeer away! Sure that is fine. Repository: rC Clang https://reviews.llvm.org/D47260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41881: [analyzer] Flag bcmp, bcopy and bzero as obsolete

trixirt added a comment. Herald added a reviewer: george.karpenkov. I need someone to commit this.. Repository: rC Clang https://reviews.llvm.org/D41881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46791: Make -gsplit-dwarf generally available

trixirt updated this revision to Diff 146970. trixirt added a comment. Improve comment in CLANG_DEFAULT_OBJCOPY to specify what is required of objcopy. Remove the llvm- prefix from testing to allow for override of default value. https://reviews.llvm.org/D46791 Files: CMakeLists.txt

[PATCH] D47260: Testcase for dwarf 5 crash/assert when calculating a checksum for an expansion

trixirt created this revision. trixirt added a reviewer: probinson. Herald added subscribers: cfe-commits, JDevlieghere, aprantl. Test is a reduction from running csmith with -gdwarf-5 The checksums are required for all 'files'. The clang source manager does not provide them for expansions.

[PATCH] D47260: Testcase for dwarf 5 crash/assert when calculating a checksum for an expansion

trixirt updated this revision to Diff 148228. trixirt added a comment. Rename test to dwarf5-expansion-checksum.c Repository: rC Clang https://reviews.llvm.org/D47260 Files: test/CodeGen/dwarf5-expansion-checksum.c Index: test/CodeGen/dwarf5-expansion-checksum.c

[PATCH] D47554: [analyzer] Check for dead/impossible status checks

trixirt created this revision. trixirt added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun, mgorny. Herald added a reviewer: george.karpenkov. The c++ 'new' function has several variants. Only the no-throw versions of these return a nullptr on failure.

[PATCH] D47554: [analyzer] Check for dead/impossible status checks

trixirt updated this revision to Diff 149868. trixirt added a comment. Herald added a subscriber: klimek. Convert to AST Visitor Remove Ctx parameter from shouldNullCheckAllocation Add a shouldNullCheckAllocation ASTMatcher Repository: rC Clang https://reviews.llvm.org/D47554 Files:

[PATCH] D47554: [analyzer] Check for dead/impossible status checks

trixirt updated this revision to Diff 150003. trixirt added a comment. cleanup of last patch Repository: rC Clang https://reviews.llvm.org/D47554 Files: include/clang/AST/ExprCXX.h include/clang/ASTMatchers/ASTMatchers.h include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D47554: [analyzer] Check for dead/impossible status checks

trixirt added a comment. Sorry for the delay, i will have something (hopefully) this weekend. Repository: rC Clang https://reviews.llvm.org/D47554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41881: [analyzer] Flag bcmp, bcopy and bzero as obsolete

trixirt created this revision. trixirt added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun. bcmp, bcopy and bzero are obsolete functions. Flag them as such so users will not use them. Repository: rC Clang https://reviews.llvm.org/D41881 Files:

[PATCH] D42310: Formalize FreeBSD support of compiler rt

trixirt created this revision. trixirt added reviewers: emaste, filcab, rsmith. Herald added subscribers: cfe-commits, krytarowski. FreeBSD's libgcc and libgcc_p are symlinks to libcompiler_rt and libcompiler_rt_p Start using the compiler rt libs directly. Repository: rC Clang

[PATCH] D42310: Formalize FreeBSD support of compiler rt

trixirt added a comment. I think it is overkill to look for fbsd 8, it was eol-ed 2015, and 9 in 2016. A native build of clang 7 on fbsd 8 would be difficult to pull off, needing at least 1-3 intermediate clang's/gcc's Repository: rC Clang https://reviews.llvm.org/D42310

[PATCH] D42310: Formalize FreeBSD support of compiler rt

trixirt added a comment. The symlinks were useful in the transition from gcc to clang. Now they don't serve any purpose. Clang uses libcompiler_rt, not libgcc. Repository: rC Clang https://reviews.llvm.org/D42310 ___ cfe-commits mailing list

[PATCH] D44447: Treat libclang_rt.* as normal library if the user uses --sysroot=

trixirt created this revision. trixirt added reviewers: rsmith, atanasyan, vkalintiris. trixirt added a project: clang. Herald added a subscriber: cfe-commits. In cross compiling, one normally assumes that the user supplied sysroot contains all of the libraries needed in the link. And so the

[PATCH] D44964: Change order of libclang_rt.profile link for freebsd

trixirt created this revision. trixirt added reviewers: emaste, rsmith. Herald added a subscriber: cfe-commits. clang -static -coverage foo.c fails because the -lclang_rt.profile-*.a has a dependency on libc but is placed after libc in the link line. This change place -lclang_rt.profile before

[PATCH] D54047: Check TUScope is valid before use

trixirt created this revision. trixirt added reviewers: rsmith, stephenkelly. Herald added a subscriber: cfe-commits. Include-what-you-use crashes when run against llvm because of late use of TUScope. The testcase is

[PATCH] D54047: Check TUScope is valid before use

trixirt added a comment. Since the crash happens with the iwyu tool, a bit ago i added the testcase at the iwyu project here. https://github.com/include-what-you-use/include-what-you-use/pull/601 I don't know if it makes sense to run iwyu from clang/test. Repository: rC Clang

[PATCH] D59998: [Sema] Remove unneeded call to LookupResult::resolveKind

trixirt created this revision. trixirt added a reviewer: rjmccall. trixirt added a project: clang. Herald added a subscriber: cfe-commits. >From code inspection it was noticed that CppNamespaceLookup's caller CppLookupName calls LookupResult::resolveKind when CppNamespaceLookup was successful or

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

trixirt added a comment. A comment by whisperity in the origin WIP did not seem to be addressed. Have you looked at IWYU https://github.com/include-what-you-use/include-what-you-use ? The end goals of clang-scan-deps and iwyu seem similar so their implementation problems would also be similar.

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 199358. trixirt added a comment. llvm-header-guard is an alias to bugprone-header-guard. The style is passed through the option 'GuardStyle' A regression test was added for llvm-header-guard. llvm unit tests were modified to the new class and option

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 200630. trixirt added a comment. Add a newline to separate functions Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61508/new/ https://reviews.llvm.org/D61508 Files: clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt marked an inline comment as done. trixirt added inline comments. Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:30 +} +std::string BugproneHeaderGuardCheck::getHeaderGuard(StringRef Filename, + StringRef OldGuard)

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 200380. trixirt added a comment. Change the GuardStyle data type from a string to an enum. Add test cases for explicitly setting valid style. Document valid style values. Reduce llvm-header-guard doc to point to bugprone-header-guard. Repository: rCTE

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt added a comment. Latest change addresses most of issues. Outstanding is adding a test when garbage GuardStyle value is fed into config. The trial testcase used only CHECK-*-NOT which caused complaining from test harness looking for the CHECK- cases. Looking for something similar in the

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 198352. trixirt retitled this revision from "[clang-tidy] misc-header-guard : a simple version of llvm-header-guard" to "[clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard". trixirt added a comment. Move from misc to bugprone

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt added a comment. All of the real work is the header-guard checks is done by their common base class utils/HeaderGuard. The much smaller llvm and bugprone subclasses are only concerned with the style of the fix. My understanding of the directory layout guidance in the docs is that

[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

trixirt created this revision. trixirt added reviewers: alexfh, bkramer. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. A general use, missing header guard finder and fixer. No style checks. If there is already a working header guard, it is used. If the

[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 198146. trixirt edited the summary of this revision. trixirt added a comment. Addressed issue with returning early and using backtick in doc. Since misc-header-guard doc was a cut-n-paste of llvm-header-guard, that and other similar docs were changed.

[PATCH] D83984: Explicitly use utf-8 in send_string

trixirt added a comment. Yes, this break on py2, and py3 the change is a noop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984 ___ cfe-commits mailing list

[PATCH] D88784: Improve ccc-analyzer error message

trixirt created this revision. trixirt added a reviewer: dcoughlin. trixirt added a project: clang. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. trixirt requested review of this revision. When ccc-analyzer

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt updated this revision to Diff 301059. trixirt added a comment. fix precheckin lint issues with auto vs const auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90180/new/ https://reviews.llvm.org/D90180 Files:

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt added a comment. Discussion of change on LKML https://lkml.org/lkml/2020/10/27/2538 On why the existing clang fixit is not practical. tl;dr 10,000 changes to look for a treewide fix The fixit has whitespace issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt added a comment. Yes, this automates the fixit to something precise. There are about 10,000 problems in the kernel with -Wextra-semi, all of those fixes would be too many and diverse to practically submit. Also the -Wextra-semi fix removes just the semi and so it's fix will fail the

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt updated this revision to Diff 300830. trixirt added a comment. Comment on the matcher Comment explaining need to look for empty macro Add test for normal switch Add test for switch with empty macro Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt updated this revision to Diff 300965. trixirt added a comment. precheckin lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90180/new/ https://reviews.llvm.org/D90180 Files: clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt added a comment. The 10,000 problems are for all the extra semicolon problems. Those after switch are a small subset, chosen because is ok to automagically fix them. The checker is in the linuxkernel/ because it is being used to fix the linux kernel now. And to enforce it stays fixed.

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt created this revision. trixirt added reviewers: alexfh, nickdesaulniers. trixirt added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. trixirt requested review of this revision. Cleaning up -Wextra-semi-stmt in the linux kernel shows a high

[PATCH] D83984: Explicitly use utf-8 in send_string

trixirt created this revision. trixirt added reviewers: serge-sans-paille, michaelplatings. trixirt added a project: clang. Herald added a subscriber: cfe-commits. send_patched_file decodes with utf-8. The default encoder for python 2 is ascii. So it is necessary to also change send_string to

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 307602. trixirt added a comment. Addresses issues before refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files:

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 309270. trixirt added a comment. move enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files: clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt added a comment. How this is run in the kernel is a wip so adding it to the commit log is not very helpful. Here is the lkml rfc https://lkml.org/lkml/2020/11/21/190 This calling in the kernel needs needs to change because of the refactor. The auto suggestions fail to build, so they are

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 308214. trixirt edited the summary of this revision. trixirt added a comment. Refactor to combine switch and trailing macro into one fixer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 308963. trixirt added a comment. address precheckin issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files:

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

trixirt added a comment. Yes, this change has problems, I will resubmit. There are many log function checks in checkpatch, and i need to write another one to find the unattibuted decls. I don't think adding linux specific warnings is -Wformat is needed, that doesn't scale with all the other

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

trixirt created this revision. trixirt added reviewers: nickdesaulniers, alexfh, hokein, aaron.ballman, njames93. trixirt added a project: clang-tools-extra. Herald added subscribers: Charusso, xazax.hun, mgorny. trixirt requested review of this revision. Herald added a project: clang. Herald

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt created this revision. trixirt added reviewers: nickdesaulniers, alexfh, hokein, aaron.ballman. trixirt added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. trixirt requested review of this revision. Cleaning up

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt marked 2 inline comments as done. trixirt added a comment. I am trying to address problems treewide so around 100 changes per fix. Doing that requires consensus that the fix is generally ok for every subsystem in the code base. So while clang will fix switch () {} ; it will also fix for