[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev added inline comments. Comment at: clang/docs/index.rst:96 ClangRepl + ExecutionResultsHandling We should probably move that under `ClangRepl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156877: Update Clang-REPL docs with removing the redundant subsections

This revision was automatically updated to reflect the committed changes. Closed by commit rG54081868dd22: [clang-repl] Remove redundant subsections from the table of content. (authored by Krishna-13-cyber, committed by v.g.vassilev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added a comment. In D148997#4559646 , @bnbarham wrote: >> Are there other users of incremental processing mode, other than the REPL / >> IncrementalParser? > > It seems Swift's clang importer also uses incremental processing mode, I'm >

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

v.g.vassilev added a comment. This LGTM but I'd like to wait for @rjmccall for a week or so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157379/new/ https://reviews.llvm.org/D157379 ___ cfe-commits

[PATCH] D157477: [clang-repl] Add test for disambiguation of templates

v.g.vassilev added a comment. If you have not merged this patch please consider my comment. Comment at: clang/test/Interpreter/namespace-template-disambiguate.cpp:7 +namespace NS2 { struct A { public: using S = int; }; } +namespace NS2 { A::S f(A::S a); } + It

[PATCH] D157477: [clang-repl] Add test for disambiguation of templates

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks, @Hahnfeld! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157477/new/ https://reviews.llvm.org/D157477

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/global-namespace-disambiguate.cpp:6 +struct A { ~A(); }; +::A::~A() {} + Can we add this test to `disambiguate-decl-stmt.cpp` instead where we track these things? Repository: rG LLVM

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157480/new/ https://reviews.llvm.org/D157480 ___ cfe-commits mailing list

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev added inline comments. Comment at: clang/docs/ExecutionResultsHandling.rst:80 + +For example, the CPPYY code makes use of this feature to enable running +C++ within Python. It enables transporting values/information between C++ cppyy seems

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

v.g.vassilev added a comment. Looks reasonable to me. Let's give @rjmccall couple of more days to respond. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156897/new/ https://reviews.llvm.org/D156897 ___

[PATCH] D156660: [CodeGen] Assert that EmittedDeferredDecls is empty

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156660/new/ https://reviews.llvm.org/D156660

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

v.g.vassilev added a comment. In D153003#4462388 , @ChuanqiXu wrote: >> Oh, I guess we're somehow adding a semi-resolved form of the base class type >> of D into the ODR hash, which then includes details of the >> using-declaration. That seems wrong --

[PATCH] D152109: Update clang-repl documentation

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM! If you don't have commit access I can commit this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/ https://reviews.llvm.org/D152109

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

This revision was automatically updated to reflect the committed changes. Closed by commit rG743ff9c8bad3: [clang-repl] Do not assert if we have weak references left. (authored by v.g.vassilev). Herald added a project: clang. Changed prior to commit:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:160-162 + // Interpreter, QualType are stored as void* to reduce dependencies. + void *Interp = nullptr; + void *OpaqueType = nullptr; sgraenitz wrote: > v.g.vassilev

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added inline comments. Comment at: clang/include/clang/AST/Decl.h:4345 + } + bool isValuePrinting() const { return IsSemiMissing; } + void setValuePrinting(bool Missing = true) { IsSemiMissing = Missing; } We should change the accessors to the

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

v.g.vassilev updated this revision to Diff 520286. v.g.vassilev added a comment. Provide a better test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148435/new/ https://reviews.llvm.org/D148435 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added a comment. @rsmith, any ideas how to support value printing of constructs such as `int i = 12`, eg, that's not a top-level statement declaration but worth printing its value? It is the shorthand of `int i = 12; i`. Comment at:

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev updated this revision to Diff 520322. v.g.vassilev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. Let's rely on a post-commit review here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. Thanks! That was blocking our jupyter integration so I decided to go ahead here since we already missed the clang17 train... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev updated this revision to Diff 520368. v.g.vassilev added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2c4620c1dadc: [clang-repl] Consider the scope spec in template lookups for deduction guides. (authored by v.g.vassilev).

[PATCH] D150139: [clang-repl] Enable basic multiline support.

v.g.vassilev created this revision. v.g.vassilev added reviewers: junaire, sunho, aaron.ballman. Herald added a project: All. v.g.vassilev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. This patch allows the users to use

[PATCH] D150139: [clang-repl] Enable basic multiline support.

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/multiline.cpp:12-17 +void f(int x) \ +{ \ + printf("x=\ + %d", x); \ +} +f(i); aaron.ballman wrote: > Another fun test case: > ``` >

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:39 const PreprocessorOptions // Only used for debug info. -const CodeGenOptions CodeGenOpts; // Intentionally copied in. +CodeGenOptions CodeGenOpts; // Intentionally copied in.

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:39 const PreprocessorOptions // Only used for debug info. -const CodeGenOptions CodeGenOpts; // Intentionally copied in. +CodeGenOptions CodeGenOpts; // Intentionally copied in.

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. This is looking good. Can you address my minor comments and run clang-format? Comment at: clang/lib/Interpreter/DeviceOffload.cpp:1 +//===-- Offload.cpp - CUDA Offloading ---*- C++ -*-===// +//

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Thanks for putting so much efforts into this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I believe we are at the stage of better is enemy of good now. This looks good to me. I'd recommend to wait for @aaron.ballman's final review. Repository: rG LLVM Github

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:23 +// +// NOTE: Since the REPL itself could also include this runtime, extreme caution +// should be taken when MAKING CHANGES to this file, especially when INCLUDE NEW I

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146389/new/ https://reviews.llvm.org/D146389

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:160-162 + // Interpreter, QualType are stored as void* to reduce dependencies. + void *Interp = nullptr; + void *OpaqueType = nullptr; aaron.ballman wrote: > junaire

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. Generally lgtm, let's extend the test coverage. Comment at: clang/lib/Interpreter/DeviceOffload.cpp:1 +//===-- Offload.cpp - CUDA Offloading ---*- C++ -*-===// +// Likewise. Comment at:

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:144-146 ClangArgv.insert(ClangArgv.end(), "-Xclang"); ClangArgv.insert(ClangArgv.end(), "-fincremental-extensions"); ClangArgv.insert(ClangArgv.end(), "-c"); Hahnfeld

[PATCH] D150139: [clang-repl] Enable basic multiline support.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in c96c5edb58ed29e0fd936bc082ec6cae7082854e Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150139/new/

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. In D146389#4358358 , @argentite wrote: > Added some std::move fixes for Error -> Expected conversions > > We need to figure out a solution when NVPTX backend is not enabled. > clang-repl probably should not depends on that.

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev added inline comments. Comment at: clang/docs/ClangRepl.rst:221 + +Execution Results Handling features discussed below help extend the Clang-REPL +functionality by creating an interface between the execution results of a We should probably spell

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.h:91 + +class IncrementalSyntaxOnlyAction : public SyntaxOnlyAction { + const CompilerInstance *ParentCI; Can we not move this class definition locally to the CodeComplete

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

v.g.vassilev added a comment. @argentite what is the fate of this patch? Should we move forward with it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151904/new/ https://reviews.llvm.org/D151904 ___

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev added a reviewer: sammccall. v.g.vassilev added a subscriber: sammccall. v.g.vassilev added a comment. This looks mostly good to me. I noticed that @sammccall has done some work in that area in clangd and I was wondering if he has some thoughts about this patch. Repository: rG

<    2   3   4   5   6   7