Re: r245779 - [modules] Rearrange how redeclaration chains are loaded, to remove a walk over

On 22/08/15 03:47, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri Aug 21 20:47:18 2015 New Revision: 245779 URL: http://llvm.org/viewvc/llvm-project?rev=245779view=rev Log: [modules] Rearrange how redeclaration chains are loaded, to remove a walk over all modules and reduce the

Fwd: [modules] PR24954

Forwarding to cfe-commits Forwarded Message Subject:[modules] PR24954 Date: Thu, 8 Oct 2015 15:53:55 +0200 From: Vassil Vassilev To: Richard Smith , cfe-...@cs.uiuc.edu CC: Ben Langmuir

r273159 - [modules] Allow emission of update records for predefined __va_list_tag.

Author: vvassilev Date: Mon Jun 20 10:10:40 2016 New Revision: 273159 URL: http://llvm.org/viewvc/llvm-project?rev=273159=rev Log: [modules] Allow emission of update records for predefined __va_list_tag. Handles the cases where old __va_list_tag is coming from a module and the new is not,

Re: [libcxx] r249738 - Split out of .

On 17/10/15 01:27, Richard Smith via cfe-commits wrote: On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > wrote: On Oct 14, 2015, at 5:07 PM, Richard Smith > wrote: Ack, there are

Re: [PATCH] D21390: redefinition of '__true_type' struct __true_type {}; - Bug 27991

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r272877. Comment at: include/llvm/module.modulemap:121-126 @@ -106,8 +120,8 @@ // FIXME: Is this the right place for these? module Pass { header "Pass.h" export * } module PassSupport { header

[PATCH][Modules][PR26179]

Hi, Could somebody review the attached patch. It fixes https://llvm.org/bugs/show_bug.cgi?id=26179 Many thanks! Vassil From 947a163ab4e13c44625085dd51faa656b72de3ac Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Sat, 16 Jan 2016 23:52:40 +0100 Subject: [PATCH]

Re: [PATCH][Modules][PR26179]

Thanks! Could you check it in? -- Vassil On 18/01/16 21:38, Richard Smith via cfe-commits wrote: LGTM On Jan 18, 2016 12:06 PM, "Vassil Vassilev" > wrote: Attaching v3 of the patch. Added your case to the current test and fixed my silly

Re: [PATCH][Modules][PR26179]

Attaching v3 of the patch. Added your case to the current test and fixed my silly non-array mistake. -- Vassil On 18/01/16 20:38, Richard Smith wrote: Please also add a test case that your old patch would have failed on, such as: m1.h: extern int a[]; m2.h: extern int a[5]; x.cc: #include

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

v.g.vassilev added a comment. @bkramer are those modifications enough to accept this patch? It is holding back quite a lot of ongoing development from @teemperor as part of his GSoC project. http://reviews.llvm.org/D20382 ___ cfe-commits mailing

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

Good point. Do you have in mind calling 'clang::Sema::MergeVarDeclTypes' or we to just "duplicate" the logic in clang::ASTDeclReader::mergeRedeclarable? On 05/02/16 02:50, Richard Smith via cfe-commits wrote: I suspect we'll need to do a little more than this: when we rebuild the redeclaration

Re: r245794 - Improve the performance of resolving a lookup result. We usually don't need to

On 22/08/15 23:37, Richard Smith via cfe-commits wrote: Author: rsmith Date: Sat Aug 22 16:37:34 2015 New Revision: 245794 URL: http://llvm.org/viewvc/llvm-project?rev=245794=rev Log: Improve the performance of resolving a lookup result. We usually don't need to pick the most recent

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

Would this patch be any better? --Vassil On 05/02/16 21:49, Richard Smith wrote: This belongs in ASTDeclReader::attachPreviousDecl[Impl]. That's where we propagate data that's supposed to be consistent across a redeclaration chain from earlier declarations to later ones. There's another

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

Improve a comment. --Vassil On 07/02/16 20:48, Vassil Vassilev wrote: Would this patch be any better? --Vassil On 05/02/16 21:49, Richard Smith wrote: This belongs in ASTDeclReader::attachPreviousDecl[Impl]. That's where we propagate data that's supposed to be consistent across a redeclaration

Re: r260124 - Remove dead code.

On 08/02/16 20:38, Richard Smith wrote: On Mon, Feb 8, 2016 at 11:25 AM, Vassil Vassilev > wrote: On 08/02/16 20:10, Richard Smith via cfe-commits wrote: Author: rsmith Date: Mon Feb 8 13:10:14 2016 New

Re: r260124 - Remove dead code.

On 08/02/16 20:10, Richard Smith via cfe-commits wrote: Author: rsmith Date: Mon Feb 8 13:10:14 2016 New Revision: 260124 URL: http://llvm.org/viewvc/llvm-project?rev=260124=rev Log: Remove dead code. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified:

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

I am not sure where else to put this logic if not in isSameEntity... Could you point me to a better place? --Vassil On 05/02/16 19:56, Richard Smith wrote: On Fri, Feb 5, 2016 at 7:04 AM, Vassil Vassilev > wrote: Good point. Do you

Re: [modules] PR24954

Would this patch be more reasonable? It follows what RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this adds an update record far less often. --Vassil On 12/12/15 16:13, Vassil Vassilev wrote: I couldn't find GetDecl routine in the ASTWriter. Could you elaborate?

Re: [PATCH][modules][PR26237]

ather than only citing the bug number On Jan 30, 2016 6:49 AM, "Vassil Vassilev via cfe-commits" <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: Attaching a fix to https://llvm.org/bugs/show_bug.cgi?i

Re: [PATCH][modules][PR26237]

than only citing the bug number On Jan 30, 2016 6:49 AM, "Vassil Vassilev via cfe-commits" <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: Attaching a fix to https://llvm.org/bugs/show_bug.cgi?id=26237 Please review.

Re: [PATCH][modules][PR26237]

eview (& certainly in the commit) message rather than only citing the bug number On Jan 30, 2016 6:49 AM, "Vassil Vassilev via cfe-commits" <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: Attaching a fix to https://llvm.org/b

[PATCH][modules][PR26237]

Attaching a fix to https://llvm.org/bugs/show_bug.cgi?id=26237 Please review. Many thanks! --Vassil From da6b27875042ee23afaf898f189e410f177311ad Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Sat, 30 Jan 2016 14:50:06 +0100 Subject: [PATCH] [modules] Writing out

Re: [modules] PR24954

On 02/02/16 02:52, Richard Smith via cfe-commits wrote: On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote: Would this patch be more reasonable? It follows what RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this adds an update record far less often.

Re: [PATCH][modules][PR26237]

te: It might be handy to give an overview of the issue in the review (& certainly in the commit) message rather than only citing the bug number On Jan 30, 2016 6:49 AM, "Vassil Vassilev via cfe-commits" <cfe-commits@lists.llvm.org> wrote: Attaching a

Re: [PATCH][modules][PR26237]

grind reports in the bug report). Unfortunately I haven't been able to make the reproducer independent on STL. --Vassil On 30/01/16 17:08, David Blaikie wrote: It might be handy to give an overview of the issue in the review (& certainly in the commit) message rather than only citing the bug

Re: [PATCH] Canonicalize UnaryTransformType types when they don't have a known underlying type

ping... On 07/01/16 08:09, Vassil Vassilev via cfe-commits wrote: Hi all, I am attaching a fix for https://llvm.org/bugs/show_bug.cgi?id=26014 To which type should I tie the canonical type of the unknown underlying type? Currently it is tied to its BaseType. Please review. --Vassil

r262189 - [modules] Prefer more complete array types.

Author: vvassilev Date: Sun Feb 28 13:08:24 2016 New Revision: 262189 URL: http://llvm.org/viewvc/llvm-project?rev=262189=rev Log: [modules] Prefer more complete array types. If we import a module that has a complete array type and one that has an incomplete array type, the declaration found by

r261999 - Test commit.

Author: vvassilev Date: Fri Feb 26 04:43:34 2016 New Revision: 261999 URL: http://llvm.org/viewvc/llvm-project?rev=261999=rev Log: Test commit. Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp URL:

Re: [PATCH][modules][PR26237]

commit) message rather than only citing the bug number On Jan 30, 2016 6:49 AM, "Vassil Vassilev via cfe-commits" <cfe-commits@lists.llvm.org> wrote: Attaching a fix to https://llvm.org/bugs/show_bug.cgi?id=26237

Re: [PATCH][modules][PR26237]

6 17:08, David Blaikie wrote: It might be handy to give an overview of the issue in the review (& certainly in the commit) message rather than only citing the bug number On Jan 30, 2016 6:49 AM, "Vassil Vassilev via cfe-commits" <cfe-commits@lists.llvm.org> wrote:

Re: [PATCH][Modules][PR26179]

ping... (perhaps someone else with commit rights can check it it...) --Vassil On 18/01/16 22:07, Vassil Vassilev wrote: Thanks! Could you check it in? -- Vassil On 18/01/16 21:38, Richard Smith via cfe-commits wrote: LGTM On Jan 18, 2016 12:06 PM, "Vassil Vassilev"

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

ping... On 07/02/16 22:33, Vassil Vassilev wrote: Improve a comment. --Vassil On 07/02/16 20:48, Vassil Vassilev wrote: Would this patch be any better? --Vassil On 05/02/16 21:49, Richard Smith wrote: This belongs in ASTDeclReader::attachPreviousDecl[Impl]. That's where we propagate data

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

On 16/02/16 22:20, Richard Smith wrote: --- a/lib/Sema/SemaLookup.cpp +++ b/lib/Sema/SemaLookup.cpp @@ -419,6 +419,25 @@ static bool isPreferredLookupResult(Sema , Sema::LookupNameKind Kind, } } + // VarDecl can have incomplete array types, prefer the one with more complete + //

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

Тhanks, could you (or smb else with commit perms) check it in? --Vassil On 18/02/16 03:24, Richard Smith wrote: (And otherwise this LGTM.) On Wed, Feb 17, 2016 at 5:24 PM, Richard Smith wrote: + // TODO: Check visibility. New is hidden but has a complete type. If

Re: [PATCH] Canonicalize UnaryTransformType types when they don't have a known underlying type

). It should definitely not be treated as being canonically equivalent to its BaseType. On Wed, Feb 24, 2016 at 2:03 PM, Vassil Vassilev <v.g.vassi...@gmail.com> wrote: ping... On 07/01/16 08:09, Vassil Vassilev via cfe-commits wrote: Hi all, I am attaching a fix for https://llvm.org/bugs/show_b

Re: [modules] PR24954

On 16/03/16 03:22, Richard Smith wrote: Please restrict this to the case where the function template is a friend (check D->getFriendObjectKind()). Otherwise, this looks good to me. Thanks! Done and committed in r263634. Thanks! On Mon, Mar 7, 2016 at 2:23 AM, Vassil Vassilev

r264913 - [modules] Write out identifiers if the ID is local, too.

Author: vvassilev Date: Wed Mar 30 15:16:03 2016 New Revision: 264913 URL: http://llvm.org/viewvc/llvm-project?rev=264913=rev Log: [modules] Write out identifiers if the ID is local, too. In some cases a slot for an identifier is requested but it gets written to another module, causing an

r264908 - [modules] Add a regression test for PR21547.

Author: vvassilev Date: Wed Mar 30 15:10:07 2016 New Revision: 264908 URL: http://llvm.org/viewvc/llvm-project?rev=264908=rev Log: [modules] Add a regression test for PR21547. Added: cfe/trunk/test/Modules/Inputs/PR21547/ cfe/trunk/test/Modules/Inputs/PR21547/FirstHeader.h

Re: [PATCH] Canonicalize UnaryTransformType types when they don't have a known underlying type

. On Thu, Mar 17, 2016 at 11:55 AM, Vassil Vassilev via cfe-commits <cfe-commits@lists.llvm.org> wrote: ping... On 10/03/16 15:33, Vassil Vassilev wrote: Would this one more reasonable to commit. As you suggested if the base type is dependent, create a unique canonical UnaryTransfo

Re: r264908 - [modules] Add a regression test for PR21547.

On 31/03/16 00:08, Richard Smith wrote: On Wed, Mar 30, 2016 at 1:10 PM, Vassil Vassilev via cfe-commits <cfe-commits@lists.llvm.org> wrote: Author: vvassilev Date: Wed Mar 30 15:10:07 2016 New Revision: 264908 URL: http://llvm.org/viewvc/llvm-project?rev=264908=rev Log: [module

r264937 - Canonicalize UnaryTransformType types when they don't have a known underlying type.

Author: vvassilev Date: Wed Mar 30 17:18:29 2016 New Revision: 264937 URL: http://llvm.org/viewvc/llvm-project?rev=264937=rev Log: Canonicalize UnaryTransformType types when they don't have a known underlying type. Fixes https://llvm.org/bugs/show_bug.cgi?id=26014 Reviewed by Richard Smith.

Re: r264908 - [modules] Add a regression test for PR21547.

On 31/03/16 00:08, Richard Smith wrote: On Wed, Mar 30, 2016 at 1:10 PM, Vassil Vassilev via cfe-commits <cfe-commits@lists.llvm.org> wrote: Author: vvassilev Date: Wed Mar 30 15:10:07 2016 New Revision: 264908 URL: http://llvm.org/viewvc/llvm-project?rev=264908=rev Log: [module

r264939 - Add -emit-llvm-only to the regression test for PR21547.

Author: vvassilev Date: Wed Mar 30 17:22:50 2016 New Revision: 264939 URL: http://llvm.org/viewvc/llvm-project?rev=264939=rev Log: Add -emit-llvm-only to the regression test for PR21547. Modified: cfe/trunk/test/Modules/pr21547.cpp Modified: cfe/trunk/test/Modules/pr21547.cpp URL:

r265599 - [modules] Add forgotten test case to r265597.

Author: vvassilev Date: Wed Apr 6 15:58:12 2016 New Revision: 265599 URL: http://llvm.org/viewvc/llvm-project?rev=265599=rev Log: [modules] Add forgotten test case to r265597. Added: cfe/trunk/test/Modules/Inputs/PR27186/ cfe/trunk/test/Modules/Inputs/PR27186/Rtypes.h

r265597 - [modules] Don't try to add lookup results to non-lookup contexts.

Author: vvassilev Date: Wed Apr 6 15:56:03 2016 New Revision: 265597 URL: http://llvm.org/viewvc/llvm-project?rev=265597=rev Log: [modules] Don't try to add lookup results to non-lookup contexts. Fixes https://llvm.org/bugs/show_bug.cgi?id=27186 Patch reviewed by Richard Smith. Modified:

Re: r259734 - Fix predefine for __NSConstantString struct type

n <yaron.ke...@gmail.com <mailto:yaron.ke...@gmail.com>> wrote: +1, if possible. There is a if (getLangOpts().ObjC1) block just before this. 2016-04-03 14:21 GMT+03:00 Vassil Vassilev via cfe-commits <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org&g

Re: r265640 - Basic: thread CodeGenOptions into TargetInfo

On 07/04/16 07:41, Saleem Abdulrasool via cfe-commits wrote: Author: compnerd Date: Thu Apr 7 00:41:11 2016 New Revision: 265640 URL: http://llvm.org/viewvc/llvm-project?rev=265640=rev Log: Basic: thread CodeGenOptions into TargetInfo This threads CodeGenOptions into the TargetInfo hierarchy.

r263634 - [modules] Fix adding a templated friend functions to a namespace from another module.

Author: vvassilev Date: Wed Mar 16 06:17:04 2016 New Revision: 263634 URL: http://llvm.org/viewvc/llvm-project?rev=263634=rev Log: [modules] Fix adding a templated friend functions to a namespace from another module. When clang adds argument dependent lookup candidates, it can perform template

Re: [PATCH] Canonicalize UnaryTransformType types when they don't have a known underlying type

-- that is, its CanonicalType should be QualType(this, 0). It should definitely not be treated as being canonically equivalent to its BaseType. On Wed, Feb 24, 2016 at 2:03 PM, Vassil Vassilev <v.g.vassi...@gmail.com> wrote: ping... On 07/01/16 08:09, Vassil Vassilev via cfe-commits wrote: Hi all,

Re: r259734 - Fix predefine for __NSConstantString struct type

On 04/02/16 01:55, Ben Langmuir via cfe-commits wrote: Author: benlangmuir Date: Wed Feb 3 18:55:24 2016 New Revision: 259734 URL: http://llvm.org/viewvc/llvm-project?rev=259734=rev Log: Fix predefine for __NSConstantString struct type Per review feedback the name was wrong and it can be used

Re: r267744 - Revert r267691, it caused PR27535.

Hi Nico, I have a fix. What is the right way of putting it in? Shall I revert the "revert" and commit the fix afterwards? Many thanks Vassil On 27/04/16 19:26, Nico Weber via cfe-commits wrote: Author: nico Date: Wed Apr 27 12:26:08 2016 New Revision: 267744 URL:

r267882 - Reland r267691 fixing PR27535.

Author: vvassilev Date: Thu Apr 28 09:13:28 2016 New Revision: 267882 URL: http://llvm.org/viewvc/llvm-project?rev=267882=rev Log: Reland r267691 fixing PR27535. Added: cfe/trunk/test/Modules/Inputs/PR27401/ cfe/trunk/test/Modules/Inputs/PR27401/a.h

Re: r267744 - Revert r267691, it caused PR27535.

r267882. On 28/04/16 15:23, Nico Weber wrote: I'd reland with the fix, and with an additional test that catches the problem this introduced. On Apr 28, 2016 8:16 AM, "Vassil Vassilev via cfe-commits" <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>>

r267691 - [modules] Fix Decl's Used invariant.

Author: vvassilev Date: Wed Apr 27 05:46:06 2016 New Revision: 267691 URL: http://llvm.org/viewvc/llvm-project?rev=267691=rev Log: [modules] Fix Decl's Used invariant. The Decl::isUsed has a value for every decl. In non-module builds it is very difficult (but possible) to break this invariant

r270553 - [modules] Ask the canonical decl whether the constructor was defaulted.

Author: vvassilev Date: Tue May 24 07:10:36 2016 New Revision: 270553 URL: http://llvm.org/viewvc/llvm-project?rev=270553=rev Log: [modules] Ask the canonical decl whether the constructor was defaulted. In case of template instantiations query the template instantiation pattern, which had

Re: r269398 - Add support for derived class special members hiding functions brought in from

Hi Richard, I believe this broke our modules builds. Last successful one was with r269388 and the current with r269389 fails with: /usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/type_traits:69:12: error: constructor cannot be redeclared struct integral_constant

[PATCH] D20302: Remove LazyDefinitionDataPtr and rely on getMostRecentDecl. Fixes PR27754.

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D20302 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp

Re: r269398 - Add support for derived class special members hiding functions brought in from

The reduced reproducer: https://llvm.org/bugs/show_bug.cgi?id=27754 On 14/05/16 01:23, Richard Smith wrote: Update: Vassil and I have dug into this a bit offline. It looks like the root cause is a likely-pre-existing bug where we somehow import a default constructor for a class from a module

r269935 - Teach Sema::MergeFunctionDecl to properly check for an out-of-line definition of a function that is declared as =default in its class definition.

Author: vvassilev Date: Wed May 18 10:14:46 2016 New Revision: 269935 URL: http://llvm.org/viewvc/llvm-project?rev=269935=rev Log: Teach Sema::MergeFunctionDecl to properly check for an out-of-line definition of a function that is declared as =default in its class definition. First part of

Re: r265766 - [modules] Add a comment to explain why -E leaves some #includes in the preprocessed output.

On 18/04/16 21:06, Richard Smith wrote: On Mon, Apr 18, 2016 at 11:49 AM, Vassil Vassilev > wrote: On 18/04/16 20:32, Richard Smith wrote: On Mon, Apr 18, 2016 at 6:28 AM, Vassil Vassilev

Re: r265766 - [modules] Add a comment to explain why -E leaves some #includes in the preprocessed output.

On 18/04/16 20:32, Richard Smith wrote: On Mon, Apr 18, 2016 at 6:28 AM, Vassil Vassilev > wrote: On 08/04/16 03:24, Richard Smith via cfe-commits wrote: Author: rsmith Date: Thu Apr 7 20:23:59 2016 New

Re: r265766 - [modules] Add a comment to explain why -E leaves some #includes in the preprocessed output.

On 08/04/16 03:24, Richard Smith via cfe-commits wrote: Author: rsmith Date: Thu Apr 7 20:23:59 2016 New Revision: 265766 URL: http://llvm.org/viewvc/llvm-project?rev=265766=rev Log: [modules] Add a comment to explain why -E leaves some #includes in the preprocessed output. Modified:

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

v.g.vassilev added a comment. Could we stress test the implementation by running on files from llvm's/clang's test suite. For example, for a test TST we could do something like: cat TST >> tmp_TST; cat TST >> tmp_TST and run our our copy-paste checker on tmp_TST. This way we know how many

r276473 - [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader.

Author: vvassilev Date: Fri Jul 22 16:08:24 2016 New Revision: 276473 URL: http://llvm.org/viewvc/llvm-project?rev=276473=rev Log: [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader. Processing update records (and loading a module, in general) might trigger unexpected

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM, given the comments are addressed. Comment at: include/clang/Analysis/CloneDetection.h:37 @@ +36,3 @@ + /// Stmt, then S is a pointer to this Stmt. + Stmt

r276469 - Add regression test for PR27699.

Author: vvassilev Date: Fri Jul 22 15:49:31 2016 New Revision: 276469 URL: http://llvm.org/viewvc/llvm-project?rev=276469=rev Log: Add regression test for PR27699. Added: cfe/trunk/test/Modules/Inputs/PR27699/ cfe/trunk/test/Modules/Inputs/PR27699/Subdir/

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev added a subscriber: v.g.vassilev. Comment at: include/clang/Lex/Preprocessor.h:270 @@ +269,3 @@ + /// on the stem that is to be code completed. + IdentifierInfo *CodeCompletionII; + Can you initialize this variable in the PP's ctor? Repository:

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r276878. Repository: rL LLVM https://reviews.llvm.org/D17820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r276878 - Implement filtering for code completion of identifiers.

Author: vvassilev Date: Wed Jul 27 09:56:59 2016 New Revision: 276878 URL: http://llvm.org/viewvc/llvm-project?rev=276878=rev Log: Implement filtering for code completion of identifiers. Patch by Cristina Cristescu and Axel Naumann! Agreed on post commit review (D17820). Modified:

Re: r276889 - Fix unnecessary default switch warning

Thanks a lot! On 27/07/16 18:41, Simon Pilgrim via cfe-commits wrote: Author: rksimon Date: Wed Jul 27 11:41:56 2016 New Revision: 276889 URL: http://llvm.org/viewvc/llvm-project?rev=276889=rev Log: Fix unnecessary default switch warning Modified:

Re: [PATCH] D17820: Clang Code Completion Filtering

Fixed in r276889 by Simon Pilgrim! On 27/07/16 22:03, Vassil Vassilev wrote: Looking into it. On 27/07/16 18:34, Jun Bum Lim wrote: junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change :

Re: [PATCH] D17820: Clang Code Completion Filtering

Looking into it. On 27/07/16 18:34, Jun Bum Lim wrote: junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change : llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label in switch which covers all enumeration values

Re: r276508 - Add -fmodules-ts flag to cc1 for the provisional C++ modules TS, and mark

On 23/07/16 04:32, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri Jul 22 21:32:21 2016 New Revision: 276508 URL: http://llvm.org/viewvc/llvm-project?rev=276508=rev Log: Add -fmodules-ts flag to cc1 for the provisional C++ modules TS, and mark 'module' and 'import' as keywords

Re: r275590 - [AST] Keep track of the left brace source location of a tag decl.

(forgot to click "reply all") Thanks! This is really handy interface. Would it make sense adding the same for NamespaceDecl for consistency? On 15/07/16 20:11, Argyrios Kyrtzidis via cfe-commits wrote: Author: akirtzidis Date: Fri Jul 15 13:11:33 2016 New Revision: 275590 URL:

Re: r275590 - [AST] Keep track of the left brace source location of a tag decl.

Thanks! This is really handy interface. Would it make sense adding the same for NamespaceDecl for consistency? On 15/07/16 20:11, Argyrios Kyrtzidis via cfe-commits wrote: Author: akirtzidis Date: Fri Jul 15 13:11:33 2016 New Revision: 275590 URL:

Re: r276473 - [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader.

It could, it fixes a set of issues wrt to modules. On 25/07/16 22:39, Hans Wennborg wrote: Should this be merged to 3.9? On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev via cfe-commits <cfe-commits@lists.llvm.org> wrote: Author: vvassilev Date: Fri Jul 22 16:08:24 2016 New Revision:

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev requested changes to this revision. v.g.vassilev added a reviewer: v.g.vassilev. This revision now requires changes to proceed. Comment at: lib/Lex/Preprocessor.cpp:748 @@ +747,3 @@ + if (Result.is(tok::code_completion)) +

[PATCH] D23400: Implement Use-Define Chain.

v.g.vassilev created this revision. v.g.vassilev added subscribers: teemperor, dergachev.a, krememek, cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. As a result of a few internal discussions, I'd like to continue the work done in this ancient thread

Re: [PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. My comments were clarified in a Skype chat. https://reviews.llvm.org/D22982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23492: Make function local tags visible.

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Upon instantiating function decls, we should mark visible any tag decl in the function's body. Repository: rL

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

v.g.vassilev requested changes to this revision. v.g.vassilev added a comment. I guess the question about the binary size holds here, too. What would be the impact on the binary size? Comment at: lib/Analysis/CloneDetection.cpp:104 @@ +103,3 @@ +/// defines what a 'similar'

r274859 - Don't crash when printing auto variables.

Author: vvassilev Date: Fri Jul 8 11:04:22 2016 New Revision: 274859 URL: http://llvm.org/viewvc/llvm-project?rev=274859=rev Log: Don't crash when printing auto variables. Patch by Axel Naumann! Modified: cfe/trunk/lib/AST/DeclPrinter.cpp cfe/trunk/test/SemaCXX/ast-print.cpp Modified:

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

v.g.vassilev requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/AST/CloneDetection.h:148 @@ +147,3 @@ +/// This class only searches for clones in exectuable source code +/// (e.g. function bodies). Other clones (e.g.

r274930 - Teach -ast-print to print constexpr variables.

Author: vvassilev Date: Fri Jul 8 16:09:08 2016 New Revision: 274930 URL: http://llvm.org/viewvc/llvm-project?rev=274930=rev Log: Teach -ast-print to print constexpr variables. Patch reviewed by Richard Smith (D22168). Modified: cfe/trunk/lib/AST/DeclPrinter.cpp

r274830 - Recommit r274348 and r274349. The Windows failures should be fixed.

Author: vvassilev Date: Fri Jul 8 03:33:56 2016 New Revision: 274830 URL: http://llvm.org/viewvc/llvm-project?rev=274830=rev Log: Recommit r274348 and r274349. The Windows failures should be fixed. Original commit message: "Add postorder traversal support to the RecursiveASTVisitor. This

r278110 - [analyzer] Try to fix coverity CID 1360469.

Author: vvassilev Date: Tue Aug 9 05:00:23 2016 New Revision: 278110 URL: http://llvm.org/viewvc/llvm-project?rev=278110=rev Log: [analyzer] Try to fix coverity CID 1360469. Patch by Raphael Isemann! Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified:

Re: [PATCH] D23320: [analyzer] Fixed crash in CloneDetector in function calls.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D23320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

v.g.vassilev added inline comments. Comment at: lib/Analysis/CloneDetection.cpp:431 @@ +430,3 @@ +// level of it's containing clone. This prevents false-positives caused by +// complex macros. For example 'assert(false)' could be reported as a clone +// if the assert

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

v.g.vassilev requested changes to this revision. This revision now requires changes to proceed. Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:83 @@ +82,3 @@ +auto WarnID = DiagEngine.getCustomDiagID( +DiagnosticsEngine::Warning, "Maybe you wanted to use %0

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r274348 and r274349. http://reviews.llvm.org/D20382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274348 - Add postorder traversal support to the RecursiveASTVisitor.

Author: vvassilev Date: Fri Jul 1 08:28:31 2016 New Revision: 274348 URL: http://llvm.org/viewvc/llvm-project?rev=274348=rev Log: Add postorder traversal support to the RecursiveASTVisitor. This feature needs to be explicitly enabled by overriding shouldTraversePostOrder() as it has

r274349 - Add forgotten test to r274348.

Author: vvassilev Date: Fri Jul 1 08:30:08 2016 New Revision: 274349 URL: http://llvm.org/viewvc/llvm-project?rev=274349=rev Log: Add forgotten test to r274348. Added: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp Added: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp URL:

r274359 - Revert r274348 and r274349 until the Windows failures are fixed.

Author: vvassilev Date: Fri Jul 1 11:07:57 2016 New Revision: 274359 URL: http://llvm.org/viewvc/llvm-project?rev=274359=rev Log: Revert r274348 and r274349 until the Windows failures are fixed. Removed: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp Modified:

Re: [PATCH] D20795: Added ASTStructure for analyzing the structure of Stmts.

v.g.vassilev requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/Basic/SourceManager.h:1173 @@ +1172,3 @@ + + // + A leftover from something else? Comment at:

Re: [PATCH] D23555: [analyzer] CloneDetector now checks template arguments of function calls.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM once the @NoQ remarks are addressed. https://reviews.llvm.org/D23555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68354. v.g.vassilev added a comment. Add forgotten change. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateInstantiate.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 68349. v.g.vassilev added a comment. Do not instantiate function declarations which are not visible. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68536. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Add setHidden(false) and update fixme. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp

r279164 - PR28794: Don't try to instantiate function templates which are not visible.

Author: vvassilev Date: Thu Aug 18 17:01:25 2016 New Revision: 279164 URL: http://llvm.org/viewvc/llvm-project?rev=279164=rev Log: PR28794: Don't try to instantiate function templates which are not visible. Reviewed by Richard Smith. Added: cfe/trunk/test/Modules/Inputs/PR28794/

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68620. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Move DiagnoseUninstantiableTemplate before the late template parsing. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D22515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   7   8   >