[PATCH] D61345: Allow 'CodeGenObjC/illegal-UTF8.m' test for 32-bit targets.

vvereschaka created this revision. vvereschaka added a project: clang. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. The 'CodeGenObjC/illegal-UTF8.m' get failed with Clang built with 32-bit targets only (as example ARM-only) with the following error: error: unable to create

[PATCH] D69651: [CMake] Add cross Windows to ARM Linux toolchain CMake cache file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa264e85dd9f9: [CMake] Add cross Windows to ARM Linux toolchain CMake cache file. (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69651: [CMake] Add cross ARM toolchain CMake cache file.

vvereschaka updated this revision to Diff 227501. vvereschaka edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69651/new/ https://reviews.llvm.org/D69651 Files: clang/cmake/caches/CrossWinToARMLinux.cmake Index:

[PATCH] D69651: [CMake] Add cross ARM toolchain CMake cache file.

vvereschaka created this revision. vvereschaka added reviewers: andreil99, gkistanova. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. This cache file can be used to build CrossARM toolchain on Windows platform. Also it is going to be used by the

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

vvereschaka created this revision. vvereschaka added reviewers: aorlov, andreil99, broadwaylamb. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. Added two confguration argument to provide a host name and SSH user name to run the tests on the remote

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

vvereschaka updated this revision to Diff 234407. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71625/new/ https://reviews.llvm.org/D71625 Files: clang/cmake/caches/CrossWinToARMLinux.cmake Index: clang/cmake/caches/CrossWinToARMLinux.cmake

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

vvereschaka marked 2 inline comments as done. vvereschaka added a comment. I have updated the diff without using those options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71625/new/ https://reviews.llvm.org/D71625

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

vvereschaka accepted this revision. vvereschaka added a comment. Thank you Sergej. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 ___ cfe-commits mailing list

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f5aabb91a03: [CMake] Fix the path to CrossWinToARMLinux.cmake CMake cache. (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

vvereschaka added a comment. Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

vvereschaka updated this revision to Diff 234617. vvereschaka edited the summary of this revision. vvereschaka added a comment. Renamed configuration arguments to REMOTE_TEST_HOST and REMOTE_TEST_USER Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69876: Support output constraints on "asm goto"

vvereschaka added a comment. Hello @void , this commit breaks Aarch64 builder with failed `Clang::uninit-asm-goto.cpp` test http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/5020 - FAIL: Clang::uninit-asm-goto.cpp TEST 'Clang ::

[PATCH] D68720: Support -fstack-clash-protection for x86

vvereschaka added a comment. Also got failed clang tests on Arm/Aarch64 builders http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4295 http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4277 - FAIL: Clang::stack-clash-protection.c - FAIL:

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

vvereschaka added a comment. Hello @jdoerfert, `OpenMPIRBuilderTest.ParallelCancelBarrier` is failed on Windows builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/11242/steps/test-check-llvm-unit/logs/stdio

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

vvereschaka added a comment. it also gets failed on the Linux builders http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/2843 http://lab.llvm.org:8011/builders/lld-x86_64-ubuntu-fast/builds/11581 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74347/new/ https://reviews.llvm.org/D74347

[PATCH] D74704: Support -fuse-ld=lld for riscv

vvereschaka added a comment. Hello @serge-sans-paille, looks like these changes broke the ARM builders: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749 http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4752 failed tests: - FAIL: Clang::riscv64-toolchain.c

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. May be just keep a note in the comments that this lit parameter is required for the remote libcxx tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72717/new/ https://reviews.llvm.org/D72717

[PATCH] D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72850/new/ https://reviews.llvm.org/D72850

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. Hi Sergej, as far as I understood '--param enable_filesystem=False' argument is libc++ specific, but we pass those parameters to all the library tests. I think it is optimal to pass this parameter directly in the builder configuration only for libcxx as

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

vvereschaka added a comment. Hi Richard, http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l builder has been broken by this patch during few days (failed "Clang::virtual-compare.cpp" test). Sorry, but I'm going to revert these changes. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. > You mean, instead of ninja check-cxx just invoke LIT directly and pass this > argument? No, a little bit different. Probably we need something like 'LIBCXX_LLVM_LIT_ARGS` and pass the LIT arguments into the libc++ tests through that kind of parameter (and most

[PATCH] D72459: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72459/new/ https://reviews.llvm.org/D72459

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeadc97b0ec87: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache… (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka added a comment. I tried to reproduce the problem on the builder in a temporary folder and I found that CMAKE_SOURCE_DIR == CMAKE_BINARY_DIR == . Here is a list of all CMAKE_ variables available on a moment of initial configuration: -- CMAKE_AR:

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka added a comment. LGTM I was able to build with these changes successfully on the local builder host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74347/new/ https://reviews.llvm.org/D74347

[PATCH] D76774: [cmake] Link libc++ tests against static libc++/libc++abi in CrossWinToARMLinux.cmake

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76774/new/ https://reviews.llvm.org/D76774

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

vvereschaka added a comment. Hi @hokein, sorry, but looks like your changes break one of libc++ tests on ARM cross toolchain build on Windows: `libc++::function_type_default_deleter.fail.cpp` Here is the first failed build: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/945

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

vvereschaka added a comment. Hi Marco, the Clang sanitize-coverage.c test gets crashed on Windows platform for armv7 target: - FAIL: Clang::sanitize-coverage.c # command stderr: Pass 'Run-time bounds checking' is not initialized. Verify if there is a pass dependency cycle.

[PATCH] D90054: Added remotely ran compiler-rt tests.

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90054/new/ https://reviews.llvm.org/D90054

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

vvereschaka added a comment. Hello Eduardo, sorry, but one of your these commits break the clang unit tests on the following builders: - http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/18313 - http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/256 -

[PATCH] D82636: Work around a bug in MSVC in the syntax tree test

vvereschaka added a comment. Hi Dmitri, Eduardo, thank you for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82636/new/ https://reviews.llvm.org/D82636 ___ cfe-commits mailing list

[PATCH] D83490: [cmake] Support running compiler-rt tests in CrossWinToARMLinux.cmake

vvereschaka added a comment. Hi Sergei, sorry for a late answer. I have tested these changes on Windows cross build to Aarch64 and I found the following problems: - looks like `ssh.py` arguments have been changed since the diff file was placed. Currently the correct string for

[PATCH] D92291: clang/test: Remove platform-linker feature

vvereschaka accepted this revision. vvereschaka added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92291/new/ https://reviews.llvm.org/D92291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97993: [Driver] Suppress GCC detection under -B

vvereschaka added a comment. `CHECK: "-internal-isystem" "/usr/local/include"` didn't break the test on the cross builders before. Also, the `// CHECK: "-L[[TOOLCHAIN]]/usr/lib/i386-linux-gnu/gcc/i686-linux-gnu/4.5/../../../.."` check now is failing also (line 31). I tried to temporary

[PATCH] D97993: [Driver] Suppress GCC detection under -B

vvereschaka added a comment. Hi @MaskRay, sorry, but these changes break the `Clang::gcc-toolchain.cpp` test on the ARMv7/AArch64 cross builders: - https://lab.llvm.org/buildbot/#/builders/119/builds/2807 (Aarch64) - https://lab.llvm.org/buildbot/#/builders/60/builds/2416 (ARMv7) Repository:

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG155c49e0878d: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable. (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka added inline comments. Comment at: clang/docs/UsersManual.rst:799 + setting the ``CC_PRINT_PROC_STAT`` and ``CC_PRINT_PROC_STAT_FILE`` environment + variables. Use ``CC_PRINT_PROC_STAT_FILE`` to provide a file name to store + the statistics.

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 326477. vvereschaka added a comment. Updated diff: - rewording the doc part - removed `ClaimAllArgs` for `OPT_fproc_stat_report` - updated `if` statement for `CCPrintStatReportFilename` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 326729. vvereschaka added a comment. Updated diff: - updated doc parts @aganea thanks a lot for your suggestions for doc improvements. I have updated it accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 325930. vvereschaka added a comment. Thank you @aganea Updated diff: - removed `ClaimAllArgs` for `OPT_fproc_stat_report_EQ` (used in `getLastArg`); - used `const char*` instead of `std::string` for `CCPrintStatReportFilename`; - removed unnecessary

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4050 << ", mem=" << ProcStat->PeakMemory << " Kb\n"; - } - if (!StatReportFile.empty()) { + } else { // CSV format. aganea wrote: > The previous

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 325101. vvereschaka added a comment. Updated diff in according of the Lint/clang-format recommendations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97094/new/ https://reviews.llvm.org/D97094 Files:

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka created this revision. vvereschaka added a reviewer: sepavloff. vvereschaka added a project: clang. vvereschaka requested review of this revision. Herald added a subscriber: cfe-commits. Added supporting CC_PRINT_PROC_STAT and CC_PRINT_PROC_STAT_FILE environment variables to trigger

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka added a comment. @sepavloff would you add more persons in additional to the reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97094/new/ https://reviews.llvm.org/D97094 ___

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka marked an inline comment as done. vvereschaka added inline comments. Comment at: clang/include/clang/Driver/Driver.h:210 + /// Set CC_PRINT_PROC_STAT mode, which causes the frontend to dump + /// performance report to CC_PRINT_PROC_STAT_FILE or to stdout.

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 325579. vvereschaka added a comment. Fixed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97094/new/ https://reviews.llvm.org/D97094 Files: clang/docs/UsersManual.rst

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

vvereschaka added a comment. @phosek @rovka no need those changes for `CrossWinToARMLinux.cmake`. `TARGET_TRIPLE` is using to parametrize the cache file only. But if there is a goal to completely remove `TARGET_TRIPLE` from the source tree I will update the cache file and the buildbot

[PATCH] D121029: [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm cross toolchain cache file. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd860ac5da6d7: [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm… (authored by vvereschaka). Repository: rG LLVM

[PATCH] D121029: [CMake] Replace `TARGET_TRIPLE` with `TOOLCHAIN_TARGET_TRIPLE` for Win-to-Arm cross toolchain cache file.

vvereschaka created this revision. vvereschaka added a reviewer: vvereschaka. Herald added subscribers: kristof.beyls, mgorny. Herald added a project: All. vvereschaka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid using

[PATCH] D120383: [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain.

vvereschaka created this revision. vvereschaka added a reviewer: vvereschaka. Herald added subscribers: kristof.beyls, mgorny. vvereschaka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Provide CMAKE_SYSROOT for the

[PATCH] D120383: [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18fa0b15ccf6: [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain. NFC. (authored by vvereschaka). Repository: rG LLVM Github

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

vvereschaka added a comment. Hi @sammccall, also failed `FAIL: Clang-Unit::69` test on these builders - https://lab.llvm.org/buildbot/#/builders/86/builds/65581 - https://lab.llvm.org/buildbot/#/builders/60/builds/14027 - https://lab.llvm.org/buildbot/#/builders/119/builds/15226 Repository:

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

vvereschaka added a comment. Hi @serge-sans-paille, also on this builder: https://lab.llvm.org/buildbot/#/builders/60/builds/13587 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158558/new/ https://reviews.llvm.org/D158558

[PATCH] D124203: [clang][safestack] Remove triple from stack usage test

vvereschaka added a comment. Thank you @paulkirth. I have tested these changes locally on the builder. It works fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124203/new/ https://reviews.llvm.org/D124203

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

vvereschaka added a comment. Hi @paulkirth, using of specific triple within `stack-usage-safestack.c` test causes a failure for the compilers, which don't support these triples (arm/aarch64 in my case). Such as: error: unable to create target: 'No available targets are compatible with

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

vvereschaka added a comment. Hi @void , the `zero-call-used-regs.ll` test gets failed on `llvm-clang-x86_64-expensive-checks-ubuntu` builder with the following errors: ... *** Bad machine code: Illegal physical register for instruction *** - function:all_arg - basic block: %bb.0

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

vvereschaka added a comment. got it. Yes, looks like it fixed. The test got passed during the last build: https://lab.llvm.org/buildbot/#/builders/104/builds/7812 Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/

[PATCH] D134650: [runtimes] Remove all traces of the legacy testing configuration system

vvereschaka added inline comments. Comment at: clang/cmake/caches/CrossWinToARMLinux.cmake:163 set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_COMPILER_RT_EMULATOR "\\\"${Python3_EXECUTABLE}\\\" \\\"${LLVM_PROJECT_DIR}/llvm/utils/remote-exec.py\\\" --execdir %%T

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

vvereschaka added a comment. Hi @brad , would you fix the tests https://lab.llvm.org/buildbot/#/builders/60/builds/10125 looks like the problem is here: // DRIVER-PASS-INCLUDES: "-internal-externc-isystem" "/usr/include" could be another path instead of "/usr/include". this one should

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

vvereschaka added a comment. Hi @brad, thank you for fixing the broken tests. There is still a problem with `netbsd.c` test: https://lab.llvm.org/buildbot/#/builders/60/builds/10135/steps/9/logs/FAIL__Clang__netbsd_c Here: // DRIVER-PASS-INCLUDES-SAME: {{^}} "-internal-isystem"

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

vvereschaka added a comment. @ChuanqiXu, would you provide a complete rollback for the changes and fix the `C1689.cppm` test failures on the builders - https://lab.llvm.org/buildbot/#/builders/119/builds/11935/steps/9/logs/FAIL__Clang__P1689_cppm -