[PATCH] D62282: [X86] Add ENQCMD intrinsics.

tianqing updated this revision to Diff 202856. tianqing added a comment. Added doxygen comments of intrinsics in enqcmdintrin.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62282/new/ https://reviews.llvm.org/D62282 Files: docs/ClangCommandLineReference.rst

[PATCH] D62282: [X86] Add ENQCMD intrinsics.

tianqing created this revision. tianqing added reviewers: craig.topper, RKSimon, LuoYuanke, spatel. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. For more details about these instructions, please refer to the latest ISE document:

[PATCH] D69792: [NFC] Supress GCC "Bitfield too small to hold all values of enum" warning.

tianqing created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 974c8b7e2fd introduced a warning for GCC: llvm-project/clang/include/clang/Sema/Overload.h:835:48: warning: ‘clang::OverloadCandidate::RewriteKind’ is too small to hold all values of ‘enum

[PATCH] D71884: [OpenMP] Fix formatting of OpenMP error message.

tianqing added a comment. Could someone help commit this patch? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71884/new/ https://reviews.llvm.org/D71884 ___ cfe-commits mailing list

[PATCH] D71884: [OpenMP] Fix formatting of OpenMP error message.

tianqing created this revision. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. tianqing added a reviewer: ABataev. `getListOfPossibleValues()` formatted incorrectly when there is only one value, emitting something like

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing added a comment. Can I just check it in after the rebase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing updated this revision to Diff 256170. tianqing added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D77193: [X86] Add SERIALIZE instruction.

tianqing updated this revision to Diff 254114. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77193/new/ https://reviews.llvm.org/D77193 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/BuiltinsX86.def clang/include/clang/Driver/Options.td

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing created this revision. tianqing added reviewers: craig.topper, RKSimon, LuoYuanke. Herald added subscribers: cfe-commits, hiraditya, mgorny. Herald added a project: clang. For more details about these instructions, please refer to the latest ISE document:

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing updated this revision to Diff 254693. tianqing added a comment. Updated to resolve conflicts with https://reviews.llvm.org/D77193. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing updated this revision to Diff 254694. tianqing added a comment. Removed extra "//". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/BuiltinsX86.def

[PATCH] D77193: [X86] Add SERIALIZE instruction.

tianqing created this revision. tianqing added reviewers: craig.topper, RKSimon, LuoYuanke. Herald added subscribers: cfe-commits, hiraditya, mgorny. Herald added a project: clang. For more details about this instruction, please refer to the latest ISE document:

[PATCH] D89301: [X86] Add user-level interrupt instructions

tianqing created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya, mgorny. Herald added projects: clang, LLVM. tianqing requested review of this revision. For more details about these instructions, please refer to the latest ISE document:

[PATCH] D89301: [X86] Add user-level interrupt instructions

tianqing updated this revision to Diff 299317. tianqing added a comment. Herald added a subscriber: dexonsmith. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89301/new/ https://reviews.llvm.org/D89301 Files:

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

tianqing created this revision. Herald added a subscriber: dang. tianqing requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103943 Files:

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

tianqing updated this revision to Diff 353536. tianqing added a comment. Fix lint comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/X86.cpp

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

tianqing marked an inline comment as done. tianqing added inline comments. Comment at: clang/include/clang/Driver/Options.td:3214 -def mgeneral_regs_only : Flag<["-"], "mgeneral-regs-only">, Group, - HelpText<"Generate code which only uses the general purpose registers

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

tianqing updated this revision to Diff 352616. tianqing added a comment. Respect order of options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/X86.cpp

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

tianqing added a comment. In D103943#2812638 , @RKSimon wrote: > I don't know much about target feature inheritance - does this guarantee that > the entire sse/avx/avx512 level chain is correctly disabled? setFeatureEnabled queries ImpliedFeatures to

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8faf03807ac: [X86] Add -mgeneral-regs-only support. (authored by tianqing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing created this revision. Herald added subscribers: dexonsmith, dang, pengfei, hiraditya, mgorny. tianqing requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. d8faf03807ac

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: llvm/lib/Target/X86/X86.td:84 "Enable SSE 4.2 instructions", - [FeatureSSE41]>; + [FeatureSSE41, FeatureCRC32]>; // The

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

tianqing updated this revision to Diff 335426. tianqing added a comment. Update handling of -mcmodel=kernel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99708/new/ https://reviews.llvm.org/D99708 Files: clang/lib/Headers/uintrintrin.h llvm/lib/Target/X86/X86ExpandPseudo.cpp

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

tianqing created this revision. tianqing added reviewers: pengfei, LuoYuanke, craig.topper. Herald added a subscriber: hiraditya. tianqing requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add __uintr_frame structure and

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

tianqing updated this revision to Diff 335980. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99708/new/ https://reviews.llvm.org/D99708 Files: clang/lib/Headers/uintrintrin.h llvm/lib/Target/X86/X86ExpandPseudo.cpp llvm/test/CodeGen/X86/x86-64-intrcc-uintr.ll Index:

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

tianqing marked an inline comment as done. tianqing added a comment. Does anyone has further comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99708/new/ https://reviews.llvm.org/D99708 ___ cfe-commits mailing list

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 368793. tianqing added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105462/new/ https://reviews.llvm.org/D105462 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 368795. tianqing marked an inline comment as done. tianqing added a comment. Use existing code in X86.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105462/new/ https://reviews.llvm.org/D105462 Files:

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing marked an inline comment as done. tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:158 + // Enable CRC32 if SSE4.2 is enabled and CRC32 is not explicitly set. + I = Features.find("sse4.2"); craig.topper wrote: > Why

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing marked an inline comment as done. tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:160 + // enabled. + I = Features.find("sse4.2"); + if (I != Features.end() && I->getValue() && craig.topper wrote: > I guess I don't

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing marked 2 inline comments as done. tianqing added inline comments. Comment at: clang/lib/Headers/crc32intrin.h:31 +static __inline__ unsigned int __DEFAULT_FN_ATTRS +_mm_crc32_u8(unsigned int __C, unsigned char __D) +{ pengfei wrote: > ditto. Not sure

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 368589. tianqing added a comment. - Update behavior of -msse4.2 option. - Add test for -msse4.2 and -mno-crc32. - Fix some format error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105462/new/

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. pengfei wrote: > hjl.tools

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1;

[PATCH] D105462: [X86] Add CRC32 feature.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianqing marked an inline comment as done. Closed by commit rG12fa608af44a: [X86] Add CRC32 feature. (authored by tianqing). Changed prior to commit:

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 360338. tianqing added a comment. Herald added a subscriber: jfb. Instead of using ImpliedFeatures, manually enable CRC32 in presence of SSE4.2. This should mimic GCC better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. craig.topper wrote: > This