[clang-tools-extra] r319098 - add new check to find OSSpinlock usage

2017-11-27 Thread Yan Zhang via cfe-commits
Author: wizard Date: Mon Nov 27 13:30:10 2017 New Revision: 319098 URL: http://llvm.org/viewvc/llvm-project?rev=319098=rev Log: add new check to find OSSpinlock usage Summary: This check finds the use of methods related to OSSpinlock in Objective-C code, which should be deprecated due to

[clang-tools-extra] r318366 - add check to avoid throwing objc exception according to Google Objective-C guide

2017-11-15 Thread Yan Zhang via cfe-commits
Author: wizard Date: Wed Nov 15 17:28:29 2017 New Revision: 318366 URL: http://llvm.org/viewvc/llvm-project?rev=318366=rev Log: add check to avoid throwing objc exception according to Google Objective-C guide Summary: This is a small check to avoid throwing objc exceptions. In specific it will

[clang-tools-extra] r319459 - add new check to find NSError init invocation

2017-12-01 Thread Yan Zhang via cfe-commits
Author: wizard Date: Thu Nov 30 11:05:08 2017 New Revision: 319459 URL: http://llvm.org/viewvc/llvm-project?rev=319459=rev Log: add new check to find NSError init invocation Summary: This check will find out improper initialization of NSError objects. According to Apple developer document, we

[clang-tools-extra] r319460 - add new check to find NSError init invocation

2017-12-01 Thread Yan Zhang via cfe-commits
Author: wizard Date: Thu Nov 30 11:05:09 2017 New Revision: 319460 URL: http://llvm.org/viewvc/llvm-project?rev=319460=rev Log: add new check to find NSError init invocation Subscribers: klimek, mgorny, cfe-commits Differential Revision: https://reviews.llvm.org/D40528 Added:

[clang-tools-extra] r331545 - Add support for ObjC property name to be a single acronym.

2018-05-04 Thread Yan Zhang via cfe-commits
Author: wizard Date: Fri May 4 11:14:08 2018 New Revision: 331545 URL: http://llvm.org/viewvc/llvm-project?rev=331545=rev Log: Add support for ObjC property name to be a single acronym. Summary: This change will support cases like: ``` @property(assign, nonatomic) int ID; ``` Reviewers:

[clang-tools-extra] r332382 - add AR to acronyms of clang-tidy property check

2018-05-15 Thread Yan Zhang via cfe-commits
Author: wizard Date: Tue May 15 11:13:51 2018 New Revision: 332382 URL: http://llvm.org/viewvc/llvm-project?rev=332382=rev Log: add AR to acronyms of clang-tidy property check Reviewers: hokein, benhamilton Reviewed By: benhamilton Subscribers: klimek, cfe-commits Differential Revision:

[clang-tools-extra] r334448 - - Add "AV" as new default acronym. - Add support for "I" and "A" in lowerCamelCase pattern

2018-06-11 Thread Yan Zhang via cfe-commits
Author: wizard Date: Mon Jun 11 15:44:06 2018 New Revision: 334448 URL: http://llvm.org/viewvc/llvm-project?rev=334448=rev Log: - Add "AV" as new default acronym. - Add support for "I" and "A" in lowerCamelCase pattern Summary: Now we can support property names like "hasADog" correctly.

[clang-tools-extra] r323722 - add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

2018-01-30 Thread Yan Zhang via cfe-commits
Author: wizard Date: Mon Jan 29 17:44:00 2018 New Revision: 323722 URL: http://llvm.org/viewvc/llvm-project?rev=323722=rev Log: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html Reviewers: benhamilton,

[clang-tools-extra] r324407 - Support special acronyms inside property names and allow plural forms

2018-02-07 Thread Yan Zhang via cfe-commits
Author: wizard Date: Tue Feb 6 13:40:38 2018 New Revision: 324407 URL: http://llvm.org/viewvc/llvm-project?rev=324407=rev Log: Support special acronyms inside property names and allow plural forms Reviewers: benhamilton, hokein Reviewed By: benhamilton, hokein Subscribers: klimek, cfe-commits

[clang-tools-extra] r322602 - add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

2018-01-17 Thread Yan Zhang via cfe-commits
Author: wizard Date: Tue Jan 16 16:19:35 2018 New Revision: 322602 URL: http://llvm.org/viewvc/llvm-project?rev=322602=rev Log: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix. Reviewers: benhamilton, hokein

[clang-tools-extra] r326928 - do not register matcher for objc-only checks when analyzing non-objc sources to save resources

2018-03-07 Thread Yan Zhang via cfe-commits
Author: wizard Date: Wed Mar 7 10:59:25 2018 New Revision: 326928 URL: http://llvm.org/viewvc/llvm-project?rev=326928=rev Log: do not register matcher for objc-only checks when analyzing non-objc sources to save resources Summary: I did not put lang opt check in AvoidSpinlockCheck since

[clang-tools-extra] r326222 - add UUID to the acronyms list of objc property name checks

2018-02-27 Thread Yan Zhang via cfe-commits
Author: wizard Date: Tue Feb 27 10:35:53 2018 New Revision: 326222 URL: http://llvm.org/viewvc/llvm-project?rev=326222=rev Log: add UUID to the acronyms list of objc property name checks Reviewers: benhamilton, hokein Reviewed By: benhamilton Subscribers: klimek, cfe-commits Differential

[clang-tools-extra] r330286 - add extra acronyms for objc property names

2018-04-18 Thread Yan Zhang via cfe-commits
Author: wizard Date: Wed Apr 18 13:09:10 2018 New Revision: 330286 URL: http://llvm.org/viewvc/llvm-project?rev=330286=rev Log: add extra acronyms for objc property names Summary: This is to support general acronyms in Objective-C like 2G/3G/4G/... and coordinates X, Y, Z and W. Reviewers:

[clang-tools-extra] r330492 - [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-20 Thread Yan Zhang via cfe-commits
Author: wizard Date: Fri Apr 20 16:18:09 2018 New Revision: 330492 URL: http://llvm.org/viewvc/llvm-project?rev=330492=rev Log: [clang-tidy] add new check to find out objc ivars which do not have prefix '_' Summary: For code of ivar declaration: int barWithoutPrefix; The fix will be:

Re: [clang-tools-extra] r330492 - [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-20 Thread Yan Zhang via cfe-commits
e IRC channel to help coordinate this kind of > thing. > >> On Fri, Apr 20, 2018 at 4:45 PM Yan Zhang via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >> Author: wizard >> Date: Fri Apr 20 16:18:09 2018 >> New Revision: 330492 >> >> URL: htt

Re: [clang-tools-extra] r330492 - [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-21 Thread Yan Zhang via cfe-commits
; >>>> On Apr 20, 2018, at 19:08, Chandler Carruth <chandl...@gmail.com> wrote: >>>> >>>> This has broken most of the build bots. Are you working on a fix or revert? >>>> >>>> Might be useful to get on the IRC channel to help coor

Re: [clang-tools-extra] r330492 - [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-21 Thread Yan Zhang via cfe-commits
hing configuration specific here. Still, no hurry. > >> On Sat, Apr 21, 2018 at 6:02 PM Yan Zhang via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >> Sorry I was out today. What is the new error? Can u send it to me? >> >> Best regards >> Yan Zh

Re: [clang-tools-extra] r330492 - [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-22 Thread Yan Zhang via cfe-commits
sts > yourself? Nothing configuration specific here. Still, no hurry. > >> On Sat, Apr 21, 2018 at 6:02 PM Yan Zhang via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >> Sorry I was out today. What is the new error? Can u send it to me? >> >> Best regards

[clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Yan Zhang via cfe-commits
Author: wizard Date: Sun Apr 22 17:15:15 2018 New Revision: 330559 URL: http://llvm.org/viewvc/llvm-project?rev=330559=rev Log: update test to use ivar in implementation instead of class extension Summary: using ivar in class extension is not supported in 32-bit architecture of MacOS.

[clang-tools-extra] r330562 - update readability-identifier-naming-objc test to use interface ivar. Implementation ivars are not supported in 32-bits OS.

2018-04-22 Thread Yan Zhang via cfe-commits
Author: wizard Date: Sun Apr 22 18:05:02 2018 New Revision: 330562 URL: http://llvm.org/viewvc/llvm-project?rev=330562=rev Log: update readability-identifier-naming-objc test to use interface ivar. Implementation ivars are not supported in 32-bits OS. Reviewers: alexfh, chandlerc Subscribers:

Re: [clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Yan Zhang via cfe-commits
But if you can't figure out how to restore the bots > you'll end up needing to revert the whole series and get some help from > someone with access to another platform. > > On Sun, Apr 22, 2018, 18:03 Yan Zhang via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > &g

Re: [clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Yan Zhang via cfe-commits
hat you don't see these >> issues, but they seem to reproduce on many build bots and the error message >> doesn't seem to be architecture specific at all... >> >> I suspect something about how you are trying to run tests isn't actually >> running this test if you are

Re: [clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Yan Zhang via cfe-commits
ppc64be-linux/builds/17830 >>>> http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/1979 >>>> http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/11659 >>>> >>>> I'm not sure how you're running your tests that you don't see t

Re: [clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Yan Zhang via cfe-commits
specific at all... > > I suspect something about how you are trying to run tests isn't actually > running this test if you aren't able to locally reproduce. > > On Sun, Apr 22, 2018 at 5:19 PM Yan Zhang via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Aut

Re: [clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Yan Zhang via cfe-commits
to ensure they are > happy. But if you can't figure out how to restore the bots you'll end up > needing to revert the whole series and get some help from someone with access > to another platform. > >> On Sun, Apr 22, 2018, 18:03 Yan Zhang via cfe-commits >> &

[clang-tools-extra] r345858 - Fix the issue that not recognizing single acronym with prefix as ObjC property name.

2018-11-01 Thread Yan Zhang via cfe-commits
Author: wizard Date: Thu Nov 1 10:36:18 2018 New Revision: 345858 URL: http://llvm.org/viewvc/llvm-project?rev=345858=rev Log: Fix the issue that not recognizing single acronym with prefix as ObjC property name. Summary: This will make clang-tidy accept property names like xyz_URL (URL is a

r346566 - Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method.

2018-11-09 Thread Yan Zhang via cfe-commits
Author: wizard Date: Fri Nov 9 15:19:14 2018 New Revision: 346566 URL: http://llvm.org/viewvc/llvm-project?rev=346566=rev Log: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method. Summary: The issue is that for array

[clang-tools-extra] r354485 - Update property prefix regex to allow numbers.

2019-02-20 Thread Yan Zhang via cfe-commits
Author: wizard Date: Wed Feb 20 09:32:41 2019 New Revision: 354485 URL: http://llvm.org/viewvc/llvm-project?rev=354485=rev Log: Update property prefix regex to allow numbers. Subscribers: jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D56896 Modified:

[clang-tools-extra] r356220 - Fixed global constant/variable naming check on C++ class for ObjC++ files.

2019-03-14 Thread Yan Zhang via cfe-commits
Author: wizard Date: Thu Mar 14 17:17:41 2019 New Revision: 356220 URL: http://llvm.org/viewvc/llvm-project?rev=356220=rev Log: Fixed global constant/variable naming check on C++ class for ObjC++ files. Subscribers: cfe-commits Tags: #clang Differential Revision: