Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

yaron.keren added inline comments. Comment at: lib/Basic/FileManager.cpp:221-222 @@ -220,1 +220,4 @@ + SmallString1024 NativeFilename; + llvm::sys::path::native(Filename, NativeFilename); + rsmith wrote: I have two concerns with this: 1) It's needlessly

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

Hi Ivan, CHECK-EIGHT is failing bots, see http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24306/steps/check-all/logs/FAIL%3A%20Clang%3A%3Adependency-gen.c I disabled it in r244869. Yaron 2015-08-13 7:04 GMT+03:00 Ivan Krasin via cfe-commits cfe-commits@lists.llvm.org:

r244871 - Remove superfluous private:, TypeCache is private by default.

Author: yrnkrn Date: Thu Aug 13 02:12:03 2015 New Revision: 244871 URL: http://llvm.org/viewvc/llvm-project?rev=244871view=rev Log: Remove superfluous private:, TypeCache is private by default. Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

yaron.keren added a comment. Yes, go ahead. http://reviews.llvm.org/D11808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

Sorry to notice late (just diagnosed the issue from a failing boost::math test), according to i686 ABI, long double size on x86 is 12 bytes (the memory allocated, not the underlying 80 bits register), see https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/i386-and-x86-64-Options.html

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

-W64 project) sh-4.3$ g++ a.cpp sh-4.3$ ./a.exe 12 Without the patch clang outputs 16 and seg faults on a boost::math example. 2015-08-19 21:29 GMT+03:00 Richard Smith rich...@metafoo.co.uk: On Wed, Aug 19, 2015 at 10:02 AM, Yaron Keren via cfe-commits cfe-commits@lists.llvm.org wrote

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize filename in the diff ourput.

, Yaron Keren via cfe-commits cfe-commits@lists.llvm.org wrote: Author: yrnkrn Date: Fri Aug 21 04:27:24 2015 New Revision: 245683 URL: http://llvm.org/viewvc/llvm-project?rev=245683view=rev Log: Tweak clang-tidy-diff.py to recognize filename in the diff ourput Out of curiosity, when does

[clang-tools-extra] r245688 - Make test EOL tolerant by moving the symbol ot the first line

Author: yrnkrn Date: Fri Aug 21 05:46:46 2015 New Revision: 245688 URL: http://llvm.org/viewvc/llvm-project?rev=245688view=rev Log: Make test EOL tolerant by moving the symbol ot the first line before any EOL changes the byte offset count and enable it on Windows. Modified:

[clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize filename in the diff ourput.

Author: yrnkrn Date: Fri Aug 21 04:27:24 2015 New Revision: 245683 URL: http://llvm.org/viewvc/llvm-project?rev=245683view=rev Log: Tweak clang-tidy-diff.py to recognize filename in the diff ourput. Modified: clang-tools-extra/trunk/clang-tidy/tool/clang-tidy-diff.py Modified:

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

, 12-byte size, and this matches the behavior I observe with GCC. Does MinGW /really/ deviate from this and give long double a 16-byte alignment? 2015-08-19 21:29 GMT+03:00 Richard Smith rich...@metafoo.co.uk: On Wed, Aug 19, 2015 at 10:02 AM, Yaron Keren via cfe-commits cfe-commits

r245679 - Expand mingw-long-double.c to test for long double alignment.

Author: yrnkrn Date: Fri Aug 21 03:26:31 2015 New Revision: 245679 URL: http://llvm.org/viewvc/llvm-project?rev=245679view=rev Log: Expand mingw-long-double.c to test for long double alignment. Added: cfe/trunk/test/CodeGen/mingw-long-double.c Removed:

r245184 - Enable passing test on Windows + MSYS.

Author: yrnkrn Date: Sun Aug 16 14:02:49 2015 New Revision: 245184 URL: http://llvm.org/viewvc/llvm-project?rev=245184view=rev Log: Enable passing test on Windows + MSYS. Modified: cfe/trunk/test/Preprocessor/macro-multiline.c Modified: cfe/trunk/test/Preprocessor/macro-multiline.c URL:

r245620 - Revert the 64bit part of r245084; long double values were not changed by

Author: yrnkrn Date: Thu Aug 20 16:51:46 2015 New Revision: 245620 URL: http://llvm.org/viewvc/llvm-project?rev=245620view=rev Log: Revert the 64bit part of r245084; long double values were not changed by it as they are already set correctly by X86_64TargetInfo and X86TargetInfo. Modified:

r245618 - Revert the 32bit part of r245084; mingw values were correct before it.

Author: yrnkrn Date: Thu Aug 20 16:36:14 2015 New Revision: 245618 URL: http://llvm.org/viewvc/llvm-project?rev=245618view=rev Log: Revert the 32bit part of r245084; mingw values were correct before it. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. There is also the case insensitivity issue, see https://llvm.org/bugs/show_bug.cgi?id=17993 http://reviews.llvm.org/D11944 ___ cfe-commits mailing list

r244312 - Silence tools/clang/lib/Tooling/CompilationDatabase.cpp:328:12: warning:

Author: yrnkrn Date: Fri Aug 7 05:15:15 2015 New Revision: 244312 URL: http://llvm.org/viewvc/llvm-project?rev=244312view=rev Log: Silence tools/clang/lib/Tooling/CompilationDatabase.cpp:328:12: warning: ‘clang::tooling::JSONAnchorDest’ defined but not used [-Wunused-variable] from gcc 5.1.

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

locally and I didn't think about all the variety of the supported configs. :( Does LLVM have try bots, so that I can run the tests with my patch before committing it? krasin On Thu, Aug 13, 2015 at 3:40 AM, Renato Golin renato.go...@linaro.org wrote: On 13 August 2015 at 07:15, Yaron Keren via

r250921 - Rename clang config.h include guard from CONFIG_H to CLANG_CONFIG_H

Author: yrnkrn Date: Wed Oct 21 13:16:01 2015 New Revision: 250921 URL: http://llvm.org/viewvc/llvm-project?rev=250921=rev Log: Rename clang config.h include guard from CONFIG_H to CLANG_CONFIG_H to make it different from LLVM config.h include guard. Modified:

Re: r251567 - Fix the calling convention of Mingw64 long double values

Thanks! 2015-10-29 0:29 GMT+02:00 Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org>: > Author: rnk > Date: Wed Oct 28 17:29:52 2015 > New Revision: 251567 > > URL: http://llvm.org/viewvc/llvm-project?rev=251567=rev > Log: > Fix the calling convention of Mingw64 long double values > >

r252426 - Replace tab with 8 spaces, NFC.

Author: yrnkrn Date: Sun Nov 8 16:01:45 2015 New Revision: 252426 URL: http://llvm.org/viewvc/llvm-project?rev=252426=rev Log: Replace tab with 8 spaces, NFC. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL:

r253066 - Add test case for mingw -fuse-ld= support introduced in r242121.

Author: yrnkrn Date: Fri Nov 13 13:46:02 2015 New Revision: 253066 URL: http://llvm.org/viewvc/llvm-project?rev=253066=rev Log: Add test case for mingw -fuse-ld= support introduced in r242121. Added: cfe/trunk/test/Driver/mingw-useld.c Added: cfe/trunk/test/Driver/mingw-useld.c URL:

r253069 - Relax mingw-useld test to fix bot failures.

Author: yrnkrn Date: Fri Nov 13 14:02:08 2015 New Revision: 253069 URL: http://llvm.org/viewvc/llvm-project?rev=253069=rev Log: Relax mingw-useld test to fix bot failures. Modified: cfe/trunk/test/Driver/mingw-useld.c Modified: cfe/trunk/test/Driver/mingw-useld.c URL:

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

Sure, r253066. 2015-11-13 19:40 GMT+02:00 Rafael Espíndola : > This needs a testcase. Nothing is checking the linker invocation. > > On 14 July 2015 at 01:23, Yaron Keren wrote: > > Author: yrnkrn > > Date: Tue Jul 14 00:23:34 2015 > > New

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

r253161 2015-11-14 22:45 GMT+02:00 Martell Malone : > The reason why I didn't use -fuse-ld=lld2 was because on Windows we don't > have symlinks. > I figured passing flavor gets over this hurdle and the installation takes > up less space. > If you want to change it I have

r253161 - Make the mingw toolchain accept 'ld' and 'lld' only as values to -fuse-ld.

Author: yrnkrn Date: Sun Nov 15 02:06:27 2015 New Revision: 253161 URL: http://llvm.org/viewvc/llvm-project?rev=253161=rev Log: Make the mingw toolchain accept 'ld' and 'lld' only as values to -fuse-ld. Post-commit suggestion by Filipe Cabecinhas. Modified: cfe/trunk/lib/Driver/Tools.cpp

Re: [PATCH] D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target

yaron.keren added a subscriber: cfe-commits. yaron.keren added a comment. We did not have cfe-commits as subscriber so I'm adding it now (this is a clang commit), see if someone would like to further comment. http://reviews.llvm.org/D14164 ___

Re: [PATCH] D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target

yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. The formatting is wrong, aligned to the right, clang-format the new code. Can we control getInstalledDir() when running under LIT so this

r252404 - Remove spaces at start of line, NFC.

Author: yrnkrn Date: Sat Nov 7 10:24:52 2015 New Revision: 252404 URL: http://llvm.org/viewvc/llvm-project?rev=252404=rev Log: Remove spaces at start of line, NFC. Modified: cfe/trunk/include/clang/Frontend/CompilerInvocation.h Modified:

r252405 - Remove spaces in empty line, NFC.

Author: yrnkrn Date: Sat Nov 7 10:35:07 2015 New Revision: 252405 URL: http://llvm.org/viewvc/llvm-project?rev=252405=rev Log: Remove spaces in empty line, NFC. Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp URL:

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

yaron.keren added a comment. I have never used OSX, Try to add one of the Apple clang developers as reviewers, they know more than me about OSX. My guess there should not be empty paths in in TC.getFilePaths(). That patch seems only to sidestep the issue which will probably surface in other

r246391 - Fix test for Release builds, the label form is label:14, not label14.

Author: yrnkrn Date: Sun Aug 30 12:46:43 2015 New Revision: 246391 URL: http://llvm.org/viewvc/llvm-project?rev=246391view=rev Log: Fix test for Release builds, the label form is label:14, not label14. Modified: cfe/trunk/test/CodeGen/sanitize-trap.c Modified:

r246385 - Make test resistant to false matches of numbered (unnamed) labels inside other numbers.

Author: yrnkrn Date: Sun Aug 30 10:24:46 2015 New Revision: 246385 URL: http://llvm.org/viewvc/llvm-project?rev=246385view=rev Log: Make test resistant to false matches of numbered (unnamed) labels inside other numbers. In release builds labels are numbers. Matching just the number may result

r246520 - Fix path seperator for Windows.

Author: yrnkrn Date: Mon Aug 31 20:29:13 2015 New Revision: 246520 URL: http://llvm.org/viewvc/llvm-project?rev=246520=rev Log: Fix path seperator for Windows. Modified: cfe/trunk/test/Driver/solaris-ld.c Modified: cfe/trunk/test/Driver/solaris-ld.c URL:

[clang-tools-extra] r246575 - Add \n to the regex in clang-tidy-diff.py in order to fix http://llvm.org/PR24637,

Author: yrnkrn Date: Tue Sep 1 14:08:17 2015 New Revision: 246575 URL: http://llvm.org/viewvc/llvm-project?rev=246575=rev Log: Add \n to the regex in clang-tidy-diff.py in order to fix http://llvm.org/PR24637, git usecase for multiple files diff. Modified:

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

does not match quotes. >> There is surely some Python package to process filenames correctly if this ever become a problem. >> >> >> 2015-08-21 13:37 GMT+03:00 Alexander Kornienko <ale...@google.com>: >>> >>> On Fri, Aug 21, 2015 at 11:27 AM, Ya

Re: r246546 - Reverting r246497 (which requires also reverting r246524 and r246521 to avoid merge conflicts). It broke the build on MSVC 2015. It also broke an MSVC 2013 bot with testing issues.

Thanks! 2015-09-01 16:24 GMT+03:00 Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org>: > Author: aaronballman > Date: Tue Sep 1 08:24:39 2015 > New Revision: 246546 > > URL: http://llvm.org/viewvc/llvm-project?rev=246546=rev > Log: > Reverting r246497 (which requires also reverting

Move createEliminateAvailableExternallyPass earlier

Following the discussion on cfe-dev, this moves createEliminateAvailableExternallyPass earlier in the pass pipeline to save running many ModulePasses on available external functions that are thrown away anyhow. Index: lib/Transforms/IPO/PassManagerBuilder.cpp

Re: r246534 - [modules] When emitting line tables, only emit filenames that are actually referenced by the entries that we emit.

Hi Richard, Since yesterday I see several clang test failures which *may* be related to the series of patches of modules you comitted. These are: Clang :: Modules/cxx-templates.cpp Clang :: Modules/submodules-merge-defs.cpp Clang :: PCH/cxx-key-functions.cpp

Re: Move createEliminateAvailableExternallyPass earlier

> Teresa > > On Tue, Sep 1, 2015 at 1:32 PM, Yaron Keren via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Following the discussion on cfe-dev, this moves > > createEliminateAvailableExternallyPass earlier in the pass pipeline to > save > > running ma

Patch for PR23472

http://llvm.org/pr23472 As suggested by Reid, OK to commit? Index: tools/clang/lib/CodeGen/ItaniumCXXABI.cpp === --- tools/clang/lib/CodeGen/ItaniumCXXABI.cpp (revision 246575) +++ tools/clang/lib/CodeGen/ItaniumCXXABI.cpp

Re: Patch for PR23472

r246803, thanks! 2015-09-03 23:16 GMT+03:00 Reid Kleckner : > LGTM, but I would expand on the comment a bit: > // The ABI says: "It is suggested that it be emitted in the same > COMDAT group > // as the associated data object." In practice, this doesn't work for >

Re: r247410 - This test requires UTF-8 output to print the UT-8 characters.

right way to fix it was. > :-) > > ~Aaron > > On Fri, Sep 11, 2015 at 9:29 AM, Yaron Keren via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: yrnkrn > > Date: Fri Sep 11 08:29:12 2015 > > New Revision: 247410 > > > > URL: http://llv

Re: [PATCH] D13128: Fix backend crash on multiple close of stdout.

yaron.keren added a comment. Hi Dan, it makes sense that output streams should not usually be mixed together, especially if one is binary as you write. This may or may not be a problem depending on what the user really wants. He may want to mix the outputs for whatever purposes or it may

r249001 - C++11 rangify for loops, NFC.

Author: yrnkrn Date: Thu Oct 1 06:19:28 2015 New Revision: 249001 URL: http://llvm.org/viewvc/llvm-project?rev=249001=rev Log: C++11 rangify for loops, NFC. Modified: cfe/trunk/lib/Frontend/InitHeaderSearch.cpp Modified: cfe/trunk/lib/Frontend/InitHeaderSearch.cpp URL:

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. clang can't generate Visual C++ debug info except line numbers yet, so building with VC is essential to development on Windows. While most people and our bots are still using VC 2013 going forward supporting VC 2015 (even

r249235 - Replace double negation of !FileID.isInvalid() with FileID.isValid().

Author: yrnkrn Date: Sat Oct 3 05:46:20 2015 New Revision: 249235 URL: http://llvm.org/viewvc/llvm-project?rev=249235=rev Log: Replace double negation of !FileID.isInvalid() with FileID.isValid(). +couple more of double-negated !SourceLocation.isInvalid() unfixed in r249228. Modified:

[clang-tools-extra] r249235 - Replace double negation of !FileID.isInvalid() with FileID.isValid().

Author: yrnkrn Date: Sat Oct 3 05:46:20 2015 New Revision: 249235 URL: http://llvm.org/viewvc/llvm-project?rev=249235=rev Log: Replace double negation of !FileID.isInvalid() with FileID.isValid(). +couple more of double-negated !SourceLocation.isInvalid() unfixed in r249228. Modified:

Re: r249141 - Revert "Add support for the new mips-mti-linux toolchain."

The regular expression should match match clang.exe on Windows. 2015-10-02 18:00 GMT+03:00 Vasileios Kalintiris via cfe-commits < cfe-commits@lists.llvm.org>: > Author: vkalintiris > Date: Fri Oct 2 10:00:55 2015 > New Revision: 249141 > > URL:

r249152 - constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember.

Author: yrnkrn Date: Fri Oct 2 11:40:48 2015 New Revision: 249152 URL: http://llvm.org/viewvc/llvm-project?rev=249152=rev Log: constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember. Modified:

r249159 - constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h.

Author: yrnkrn Date: Fri Oct 2 12:38:57 2015 New Revision: 249159 URL: http://llvm.org/viewvc/llvm-project?rev=249159=rev Log: constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h. Modified: cfe/trunk/include/clang/AST/DeclTemplate.h Modified:

r249228 - Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid().

Author: yrnkrn Date: Sat Oct 3 00:15:57 2015 New Revision: 249228 URL: http://llvm.org/viewvc/llvm-project?rev=249228=rev Log: Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid(). Modified: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp cfe/trunk/lib/AST/TypeLoc.cpp

Re: [PATCH] D13128: Fix backend crash on multiple close of stdout.

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. When stdout goes elsewhere the console, the shell creates the the output file (pipe) and will close it when clang terminates so so why clang should close it at all ? it did not open it. Practically, we have been

Re: [PATCH] D13128: Fix backend crash on multiple close of stdout.

yaron.keren added a subscriber: sunfish. yaron.keren added a comment. The original commit http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20100816/106268.html by Dan Ghoman says: "Make raw_fd_ostream consider itself the owner of STDOUT_FILENO when constructed with an output filename

Re: [libcxxabi] r248129 - Let cxa_demangle.cpp compile with gcc/libstdc++ 4.8 and clang-cl/MSVC2013's STL.

Ah, OK. Maybe it would compile with VC 2013 by using LLVM_CONSTEXPR instead of constexpr. It's not available now in libcxx but the definition from Compiler.h is trivial. 2015-09-24 19:28 GMT+03:00 Nico Weber <tha...@chromium.org>: > On Thu, Sep 24, 2015 at 4:20 AM, Yaron Keren via cf

r248626 - Relax test to allow for __attribute__((thiscall)). Under Win32 c-index-test output is

Author: yrnkrn Date: Fri Sep 25 17:09:07 2015 New Revision: 248626 URL: http://llvm.org/viewvc/llvm-project?rev=248626=rev Log: Relax test to allow for __attribute__((thiscall)). Under Win32 c-index-test output is CXXMethod=foo:4:7 (unavailable) [type=int () __attribute__((thiscall))]

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Thanks, I have replied there. 2015-09-19 13:33 GMT+03:00 Hal Finkel <hfin...@anl.gov>: > FYI: https://llvm.org/bugs/show_bug.cgi?id=24398 was just reopened > pointing to a lack of resolution here. > > -Hal > > - Original Message - > > From: "Yaron

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

gt;> FYI: https://llvm.org/bugs/show_bug.cgi?id=24398 was just reopened >>> pointing to a lack of resolution here. >>> >>> -Hal >>> >>> - Original Message - >>> > From: "Yaron Keren via cfe-commits" <cfe-commits@lists.llvm.

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM with some tests cases. http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15579: Fix the failing windows clang unit tests. NFC

yaron.keren added a comment. http://bb.pgr.jp/grid http://reviews.llvm.org/D15579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}). Possibly changed in one of the Updates? 2015-12-14 23:35 GMT+02:00 Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org>: > aaron.ballman added a subscriber: aaron.ballman. > > > Comment at:

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

That's odd. I'm using the same update 5 exactly, added " for (bool SkipUnwritten : {false, true});" inside a LLVM source file and re-compiled. MSVC complained about the unused SkipUnwritten but was therwise OK with the code. 2015-12-14 23:43 GMT+02:00 Aaron Ballman : >

r255993 - Replace SM.getFileEntryForID(Lexer->getFileID()) with Lexer->getFileEntry().

Author: yrnkrn Date: Fri Dec 18 04:30:12 2015 New Revision: 255993 URL: http://llvm.org/viewvc/llvm-project?rev=255993=rev Log: Replace SM.getFileEntryForID(Lexer->getFileID()) with Lexer->getFileEntry(). Modified: cfe/trunk/lib/Lex/PPDirectives.cpp cfe/trunk/lib/Lex/PPLexerChange.cpp

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

yaron.keren added inline comments. Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:322 @@ +321,3 @@ + for (bool SkipUnwritten : SkipUnwrittenCases) { +llvm::SmallString<128> NodeName = StringRef("::"); +llvm::raw_svector_ostream OS(NodeName);

r256472 - Constify NestedNameSpecifier::dump and add a no-argument dump function suitable for calling from a debugger.

Author: yrnkrn Date: Sun Dec 27 08:34:22 2015 New Revision: 256472 URL: http://llvm.org/viewvc/llvm-project?rev=256472=rev Log: Constify NestedNameSpecifier::dump and add a no-argument dump function suitable for calling from a debugger. Modified:

r256349 - Replace isa+cast with dyn_cast and obey the no else after return rule.

Author: yrnkrn Date: Wed Dec 23 14:38:13 2015 New Revision: 256349 URL: http://llvm.org/viewvc/llvm-project?rev=256349=rev Log: Replace isa+cast with dyn_cast and obey the no else after return rule. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL:

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren added a comment. findGccDir() can return llvm::ErrorOr and then all Base assignments happen at the same if-elseif-else: if (getDriver().SysRoot.size()) Base = getDriver().SysRoot; else if (llvm::ErrorOr GPPName = findGccDir()) Base = llvm::sys::path::parent_path(

Re: [PATCH] D7718: Itanium ABI: Properly mangle extern "C" template arguments

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. There is another copy of getEffectiveDeclContext in MicrosoftMangle.cpp which pre-commit was identical to this one. Should it get this commit as well to keep both identical? If so, could both copies of

r254392 - Remove superfluous StringRef casts, NFC.

Author: yrnkrn Date: Tue Dec 1 02:14:39 2015 New Revision: 254392 URL: http://llvm.org/viewvc/llvm-project?rev=254392=rev Log: Remove superfluous StringRef casts, NFC. Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp URL:

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren added a comment. This always searches for something-gcc and then discards the result if sysroot was provided, which is a waste. Move the searching to a helper function and then it can be done only if sysroot was not provided, as it is now. The break is needed to avoid looking for

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

Searching for gcc on Linux is not a good idea, you'll find the system one not the mingw one. Searching for i686-w64-mingw32-gcc or x86_64-w64-mingw32-gcc should work better, that is searching for: getTriple().getArchName()) + "-w64-mingw32-gcc" Moreover, this should work on Windows as well,

Re: [PATCH] D21117: Specify target in lifetime-asan test.

yaron.keren added a subscriber: yaron.keren. yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. You mean Some target platforms do not support -fsanitize=address.

r271392 - Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build.

Author: yrnkrn Date: Wed Jun 1 08:47:26 2016 New Revision: 271392 URL: http://llvm.org/viewvc/llvm-project?rev=271392=rev Log: Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build. tools/clang/tools/CMakeLists.txt does not create the clang-check target when CLANG_ENABLE_STATIC_ANALYZER=OFF.

Re: r271399 - It seems we need to add SemaExpr.cpp to the /bigobj list; I am getting consistent failures of hitting the section count limit.

Thanks! I've just noticed this today locally. It happens with unoptimized builds only so the bots are not catching it. 2016-06-01 18:17 GMT+03:00 Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org>: > Author: aaronballman > Date: Wed Jun 1 10:17:54 2016 > New Revision: 271399 > >

r260028 - Use CodeGenModule::addReplacement() instead of directly accessing Replacements[].

Author: yrnkrn Date: Sun Feb 7 06:44:35 2016 New Revision: 260028 URL: http://llvm.org/viewvc/llvm-project?rev=260028=rev Log: Use CodeGenModule::addReplacement() instead of directly accessing Replacements[]. This helps when trying to debug who inserted into Replacements. Modified:

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. We have tried to keep one copy of http://reviews.llvm.org/D11103 Can it share the Module->getDataLayout() ? http://reviews.llvm.org/D17183 ___ cfe-commits mailing list

r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

Author: yrnkrn Date: Fri Jan 29 07:46:15 2016 New Revision: 259192 URL: http://llvm.org/viewvc/llvm-project?rev=259192=rev Log: Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump(). Modified: cfe/trunk/include/clang/AST/TemplateBase.h

Re: [PATCH] D16478: Always build a new TypeSourceInfo for function templates with parameters

The instantiated does get a new collection of ParmVarDecls while getting the pattern Type which points to the pattern ParmVarDecls. So the ParmVarDecls pointed in the instantiated are not the same as those pointed by its Type. Traversing by Type or by the Decl finds a different set of

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

On 29 Jan 2016 5:50 a.m., "Yaron Keren via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > > > Author: yrnkrn > > Date: Fri Jan 29 07:46:15 2016 > > New Revision: 259192 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=259192=rev >

r259232 - Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment.

Author: yrnkrn Date: Fri Jan 29 13:38:18 2016 New Revision: 259232 URL: http://llvm.org/viewvc/llvm-project?rev=259232=rev Log: Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment. Modified: cfe/trunk/lib/AST/APValue.cpp

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

s > > TemplateName::dump(), NestedNameSpecifier::dump(), ASTReader::dump(), > > ModuleMap::dump(), MacroInfo::dump(), ... > > > > Annotate all dump() methods LLVM_DUMP_METHOD ? > > SGTM > > > 2016-01-29 19:37 GMT+02:00 Richard Smith <rich...@metafoo.co.uk>: > &

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

yaron.keren added a comment. It certainly makes sense to redirect the module request to its owner instead of duplicating it in a local copy. There may be a change in behaviour here, pre-patch CodeGenAction::EndSourceFileAction() would take the BackendConsumer Module, keeping CodeGen Module

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. Would be nice to have CodeGenAction::TheModule redirect to CodeGeneratorImpl::M if possible, but that's for another patch. LGTM.

r263635 - Directly get the canonical Type instead of going around through a CanQualType temporary, NFC.

Author: yrnkrn Date: Wed Mar 16 07:14:43 2016 New Revision: 263635 URL: http://llvm.org/viewvc/llvm-project?rev=263635=rev Log: Directly get the canonical Type instead of going around through a CanQualType temporary, NFC. Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp Modified:

Re: r259734 - Fix predefine for __NSConstantString struct type

If used only for Darwin, could this depend on Target.getTriple().isOSDarwin() ? 2016-04-11 17:18 GMT+03:00 Ben Langmuir : > > On Apr 3, 2016, at 10:57 AM, Yaron Keren wrote: > > I look at many AST dumps for small reduced code so it's mostly weird to

Re: r259734 - Fix predefine for __NSConstantString struct type

+1, if possible. There is a if (getLangOpts().ObjC1) block just before this. 2016-04-03 14:21 GMT+03:00 Vassil Vassilev via cfe-commits < cfe-commits@lists.llvm.org>: > On 04/02/16 01:55, Ben Langmuir via cfe-commits wrote: > >> Author: benlangmuir >> Date: Wed Feb 3 18:55:24 2016 >> New

Re: r259734 - Fix predefine for __NSConstantString struct type

I look at many AST dumps for small reduced code so it's mostly weird to see this in the AST (and takes a bit of screen real estate) as it's not something that originated in the code. By now I'm used to ignoring it but would expect NSConstantString would baffle new clang programmers. It would be

r269801 - Teach clang to look for libcxx in /usr/local/include/c++ on Linux

Author: yrnkrn Date: Tue May 17 14:01:16 2016 New Revision: 269801 URL: http://llvm.org/viewvc/llvm-project?rev=269801=rev Log: Teach clang to look for libcxx in /usr/local/include/c++ on Linux As The default CMAKE install prefix is /usr/local (

r269423 - Prune four superfluous ExternalSemaSource.h includes and one forward declaration in Sema.h

Author: yrnkrn Date: Fri May 13 09:53:19 2016 New Revision: 269423 URL: http://llvm.org/viewvc/llvm-project?rev=269423=rev Log: Prune four superfluous ExternalSemaSource.h includes and one forward declaration in Sema.h where ExternalSemaSource.h was already included due to ExternalSemaSource::

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

yaron.keren added a subscriber: yaron.keren. yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. result of r269402, LGTM http://reviews.llvm.org/D20240

Re: r268797 - Fix sysroot-prefix.c on Windows (/ vs \).

Hi Nico, In other tests, {{/|}} or {{/|\\}} are used match the forward or backward slash(es). clang escapes \ so we get two of them in output and four in the LIT test. It would be nice to have more elegant construct for this general problem, to avoid tests like:

r277334 - Allow .exe extension to ld to fix test with mingw.

Author: yrnkrn Date: Mon Aug 1 05:14:54 2016 New Revision: 277334 URL: http://llvm.org/viewvc/llvm-project?rev=277334=rev Log: Allow .exe extension to ld to fix test with mingw. Modified: cfe/trunk/test/Driver/offloading-interoperability.c Modified:

r275303 - Implement FunctionDecl::getDefinition() to be consistent with

Author: yrnkrn Date: Wed Jul 13 14:04:51 2016 New Revision: 275303 URL: http://llvm.org/viewvc/llvm-project?rev=275303=rev Log: Implement FunctionDecl::getDefinition() to be consistent with VarDecl, TagDecl, EnumDecl, RecordDecl, CXXRecordDecl. Use getDefinition in two locations to make the code

r276252 - Provide __GLIBCXX_TYPE_INT_N_0 and __GLIBCXX_BITSIZE_INT_N_0 when in C++ gnu language extensions.

Author: yrnkrn Date: Thu Jul 21 02:44:41 2016 New Revision: 276252 URL: http://llvm.org/viewvc/llvm-project?rev=276252=rev Log: Provide __GLIBCXX_TYPE_INT_N_0 and __GLIBCXX_BITSIZE_INT_N_0 when in C++ gnu language extensions. These are used by libstdc++ for is_integral<__int128>. Addresses

Re: r274257 - Don't instantiate a full host toolchain in ASTMatchersTest.

Seems this commit broke a builder, http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6 http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26133 http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26134 TEST 'Clang-Unit ::

r274149 - Add CapturedDecl::parameters() ArrayRef accessors following r273647.

Author: yrnkrn Date: Wed Jun 29 13:55:53 2016 New Revision: 274149 URL: http://llvm.org/viewvc/llvm-project?rev=274149=rev Log: Add CapturedDecl::parameters() ArrayRef accessors following r273647. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h

r295839 - Remove superfluous initializer.

Author: yrnkrn Date: Wed Feb 22 08:32:39 2017 New Revision: 295839 URL: http://llvm.org/viewvc/llvm-project?rev=295839=rev Log: Remove superfluous initializer. The following fully-covered switch either sets value to External or exits the function. Modified:

Re: r278984 - Add test missed from r278983.

Thanks! 2016-08-25 0:39 GMT+03:00 Richard Smith : > As of r279668, we shouldn't run this test for ASan builds any more. > Perhaps we should increase Clang's minimum stack allocation when built with > ASan to compensate for it making stack frames larger. > On Wed, Aug 24,

r283657 - Un-tabify source files, NFC.

Author: yrnkrn Date: Sat Oct 8 01:45:10 2016 New Revision: 283657 URL: http://llvm.org/viewvc/llvm-project?rev=283657=rev Log: Un-tabify source files, NFC. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/AST/NestedNameSpecifier.cpp

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. also, gcc warns if order of field initializators is different than the order of fields. Repository: rL LLVM https://reviews.llvm.org/D24754 ___ cfe-commits mailing list

Re: r278984 - Add test missed from r278983.

I see the same stack overflow asan error in a local buildbot. 2016-08-22 20:30 GMT+03:00 Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org>: > Hi Richard, > > This test has been failing since it was committed. > > http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2277/

  1   2   >