[PATCH] D18708: Set C99 as default C Standard for PS4 target

Forwarding to cfe-commits as I don't think I saw it appear there. > dyung created this revision. > > On the PS4, the default C standard is C99 which differs from the > current default of C11. This patch makes the default C99 when targeting > the PS4. > > http://reviews.llvm.org/D18708 > >

RE: [clang-tools-extra] r278257 - [clang-tidy] enhance readability-else-after-return

Hi Kirill, I believe your change is causing the PS4 bots to be red. Specifically, the test you added makes use of "throw" which doesn't work on the PS4 target since exceptions are disabled by default on the PS4 target. I think explicitly enabling exceptions should fix the test and propose the

RE: r293207 - PR0091R3: Implement parsing support for using templates as types.

Hi Richard, I've filed this issue as PR31783. Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Yung, Douglas via cfe-commits > Sent: Thursday, January 26, 2017 15:36 > To: Richard Smith > Cc: cfe-comm

RE: r293207 - PR0091R3: Implement parsing support for using templates as types.

Hi Richard, I don't know if you have noticed, but the test you added in this commit is failing on both the Linux and Windows PS4 bots. The test is failing with an assertion failure: Assertion failed: !A->getDeducedType().isNull() && "cannot request the size of an undeduced or dependent auto

RE: [clang-tools-extra] r295482 - [clang-tidy] Add -path option to clang-tidy-diff.py

Hi Ehsan, Your commit has caused the PS4 Windows bot to go red. Can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5661 $ "FileCheck" "-check-prefix=CHECK"

RE: r296171 - Try to unbreak tests after r296166

Hi Nico, The test you added is causing a failure on the PS4 Windows bot. The root of the cause is that the Windows version of rm does not accept wildcards unfortunately. To fix make it work on Windows, you likely need to specify exactly what files/directories you want to delete without using a

RE: [clang-tools-extra] r296110 - [change-namepsace] make it possible to whitelist symbols so they don't get updated.

Hi Eric, I don't know if you are aware, but one of the tests you added in this change is failing on the PS4 Windows bot. The test is " Clang Tools :: change-namespace/white-list.cpp". Can you please take a look? Douglas Yung > -Original Message- > From: cfe-commits

RE: r296414 - Reland: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

Hi Dominic, Did you forget to submit something to get this patch to work? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/6154/steps/test/logs/stdio: pickle.PicklingError: Can't pickle : it's not found as lit.TestingConfig.AnalyzerTest Douglas Yung >

RE: r296171 - Try to unbreak tests after r296166

Feb 24, 2017 8:13 PM, "Yung, Douglas via cfe-commits" <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote: Hi Nico, The test you added is causing a failure on the PS4 Windows bot. The root of the cause is that the Windows version of rm does not accept wildc

RE: r284777 - Fix off-by-one error in PPCaching.cpp token annotation assertion

Hi Reid, Just a heads up that the test you added fails if the compiler defaults to a different C++ standard. Our internal version defaults to c++11, and the test fails because the error "expected ';' after top level declarator" is not emitted. Douglas Yung > -Original Message- >

RE: r286714 - [AVX-512] Convert the rest of the masked shift by immediate and by single element builtins over to the newly added unmasked builtins and a select.

Hi Craig, One of our internal tests noticed a potential issue with your change that I wanted to see if you were aware of in the file avx512bwintrin.h. Specifically, you converted _mm512_slli_epi16, _mm512_srai_epi16, _mm512_srli_epi16 from macros into actual functions, but the functions don't

RE: r283802 - Change Builtins name to be stored as StringRef instead of raw pointers (NFC)

We noticed that this change also caused VS2015 to take a lot longer when building Targets.cpp. The revert in r283920 seems to have fixed it. The upstream PS4 Windows bot went from a build time of 17:53

RE: r289225 - Store decls in prototypes on the declarator instead of in the AST

Hi Reid, Following this change, we started seeing an assertion failure in one of our C tests. I have filed bug 31366 for the issue. Can you take a look? Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Reid Kleckner via

RE: r289995 - [libclang] Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType

Hi, this change seems to be causing the PS4 Windows build bot to be red, can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/2784 C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP -DCLANG_ENABLE_ARCMT

RE: [clang-tools-extra] r299119 - [clang-tidy] Reuse FileID in getLocation

Hi, this change seems to be causing the test clang-tidy/llvm-include-order.cpp to fail with a crash on the PS4 Windows bot: (From http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7487) TEST 'Clang Tools ::

RE: r297972 - [index/AST] Add references for ObjC getter=/setter= property attributes and related property getter/setter role fixes

[I can't find Nathan's email, so sending to the submitter, Argyrios] Hi Argyrios/Nathan, This change appears to be causing 9 tests on Windows to fail. It seems the compiler crashes when trying to run the tests. Can you please take a look? The affected tests are the following: Clang ::

RE: r297972 - [index/AST] Add references for ObjC getter=/setter= property attributes and related property getter/setter role fixes

Your change does seem to have done the trick. Thanks! Douglas Yung > -Original Message- > From: Argyrios Kyrtzidis [mailto:akyr...@gmail.com] > Sent: Thursday, March 16, 2017 18:03 > To: Yung, Douglas > Cc: cfe-commits > Subject: Re: r297972 - [index/AST] Add references for ObjC

RE: r298410 - Correct class-template deprecation behavior

Thanks, and yes, the PS4 target has slightly different defaults for both C and C++. I should have mentioned that in my original email, but I also was running out to lunch. :) Sorry about that. Douglas Yung > -Original Message- > From: Keane, Erich [mailto:erich.ke...@intel.com] > Sent:

RE: r298410 - Correct class-template deprecation behavior

Hi Erich, Your change is causing the Sema/attr-deprecated.c test to fail on the PS4 bot (http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7087). Can you take a look? Douglas Yung > -Original Message- > From: cfe-commits

RE: r299355 - [ASTImporter] Fix for importing unnamed structs

Hi Peter and Gabor, This change is causing a failure of the test "Clang :: ASTMerge/struct/test.c" on the PS4 Windows bot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7609 FAIL: Clang :: ASTMerge/struct/test.c (18568 of 32374)

RE: r310960 - Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""

Hi Dan, I don't know if you are aware, but the tests you added/changed in this commit are causing failures on the PS4 Windows bot. The root cause seems to be that you are looking for a forward slash, but Windows generates double backslashes, so the match fails:

RE: [clang-tools-extra] r308738 - [clangd] Replace ASTUnit with manual AST management.

Hi Ilya, Your change seems to be causing the test 'clangd/definitions.test' to fail on the PS4 Windows bot. Can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11222 FAIL: Clang Tools :: clangd/definitions.test (11935 of 34225)

RE: r301707 - Adapt to LLVM API change (DINamespace no longer takes line/file info).

Hi Adrian, This commit, or the previous one you made seems to be causing a failure in the clang test CodeGenCXX\debug-info-namespace.cpp on the ps4 Windows and Linux bots. It's failing when trying to match the CHECK line on line 79 of the test because the line it matches seems to have one

RE: r301597 - [Modules] Improve diagnostics for incomplete umbrella

Hi Bruno, I don’t know if you are still trying to figure out the problem here, but if you are, I believe the problem is that the forward slashes need to changed to search for either a forward slash or a backward slash since Windows will change them to a backslash. Locally I can get the test

RE: r312181 - Fix tests for ARM targets

Sorry about that, thanks for fixing it up for me! Douglas Yung > -Original Message- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans > Wennborg > Sent: Wednesday, August 30, 2017 16:28 > To: Yung, Douglas > Cc: cfe-commits > Subject: Re: r312181 - Fix tests

RE: [clang-tools-extra] r314989 - [clangd] Added async API to run code completion.

Hi Ilya, Your change has broken the build on the PS4 Windows bot. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12525 Can you take a look and fix it? Douglas Yung > -Original Message- > From: cfe-commits

RE: r315984 - [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

Hi Ivan, This change caused a compiler crash in one of our tests. I have put the details in PR34992, can you take a look? Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Ivan A. Kosarev via cfe-commits > Sent: Tuesday,

RE: [clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

Hi Sam, the FuzzyMatch tests you added in this commit seem to be failing on the Windows bot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13869 Can you take a look? Douglas Yung > -Original Message- > From: cfe-commits

RE: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

Hi Sam, Thanks for looking into this. Just to clarify, the real issue is the divide by zero errors. The encoding related messages are only warnings. JSONExprTests.cpp(134): error C2124: divide or mod by zero Douglas Yung From: Sam McCall [mailto:sam.mcc...@gmail.com] Sent: Tuesday, November

RE: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

Hi Sam, Your change is causing the PS4 Windows bot to fail because your test includes a divide by zero exception that the compiler is issuing an error for: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13639/ FAILED:

RE: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

Hi Sam, Thanks for the quick fixes! Fingers crossed that it all works now! Douglas Yung From: Sam McCall [mailto:sam.mcc...@gmail.com] Sent: Tuesday, November 21, 2017 11:39 To: Yung, Douglas Cc: cfe-commits Subject: Re: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection

RE: [clang] 6f428e0 - [AST] Fix crashes on decltype(recovery-expr).

Hi Haojian, I noticed that after your change, the compiler is now giving an error when trying to create a vector of >= 1024 elements when previously it worked, and gcc has no problem with the same code. Is that intentional? I have put the details in PR45387, can you take a look? Douglas Yung

RE: [clang] 466e8b7 - Add StringLiteral to SyntaxTree

Hi Eduardo, Your change is causing a build failure on PS4 Windows build bot, can you please take a look and fix it or revert the change if you cannot fix it soon so we can get the bot green again? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/33164

RE: [clang-tools-extra] f7dffc2 - Don't include None.h (NFC)

Hi Kazu, Your change caused the build of cross-project-tests to fail, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/32528 https://lab.llvm.org/buildbot/#/builders/216/builds/14213 Douglas Yung -Original Message- From: cfe-commits On Behalf Of Kazu Hirata