@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision
@@ -77,18 +77,18 @@ endif ()
target_include_directories(llvm_gtest
PUBLIC $
$
- $
- $
+ $
+ $
PRIVATE googletest googlemock
)
add_subdirectory(UnitTestMain)
if (LLVM_INSTALL_GTEST)
install(TARGETS llvm_gtest
@@ -77,18 +77,18 @@ endif ()
target_include_directories(llvm_gtest
PUBLIC $
$
- $
- $
+ $
+ $
zeroomega wrote:
My checkout just stales. Thanks for pointing it out.
https://github.com/llvm/llvm-project/pull/65823
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision
https://github.com/zeroomega resolved
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
zeroomega wrote:
I have addressed all review comments in the the latest amend commits. Please
take a look.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zeroomega wrote:
I have locally tested this PR using gcc 12.2.0 on Linux x64 and MSVC from
VS2019, both passed without issues. @pogo59 Do you have any concerns or
suggestions before we merge this?
https://github.com/llvm/llvm-project/pull/65823
___
zeroomega wrote:
> Ok, seems like the only problem is the MemProf unit test
> compiler-rt/lib/memprof/tests/
>
> So if I manually disable that I don't see any other failures with this patch.
I think any components that uses freshly built clang (stage1) could potentially
run into this problem
zeroomega wrote:
First bot failure: https://lab.llvm.org/buildbot/#/builders/127/builds/55068
```
[18/126] Generating SANITIZER_TEST_OBJECTS.sanitizer_lzw_test.cpp.x86_64.o
FAILED:
projects/compiler-rt/lib/sanitizer_common/tests/SANITIZER_TEST_OBJECTS.sanitizer_lzw_test.cpp.x86_64.o
https://github.com/zeroomega closed
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zeroomega wrote:
> I'm seeing some unused functions in files that haven't been changed in years,
> which I'm guessing come from this update - did the new googletest change how
> custom output works?
>
> ```
> llvm/unittests/Support/JSONTest.cpp:490:27: error: unused function
> 'operator<<'
zeroomega wrote:
I looked into the "unused functions" issue shown up in bots like:
https://lab.llvm.org/buildbot/#/builders/57/builds/29853 .
The root cause is that GoogleTest changed the way it converts an arbitrary
object into string. In the past, any object that cannot be printed to the
zeroomega wrote:
I look through all the bot failures from my mail box and I think so far there
are two issues:
* `error: unused function 'operator<<'` issue, this is caused by a type
matching bug I introduced in the roll and it will be addressed by:
https://github.com/zeroomega review_requested
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zeroomega review_requested
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zeroomega review_requested
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zeroomega review_requested
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zeroomega wrote:
Relanded as a866ce789eb99da4d7a486eeb60a53be6c75f4fd. I will monitor the bots
and manually trigger clean build if linker error appears again.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
20 matches
Mail list logo
