Re: [PATCH] D17491: Add performance check to flag function parameters of expensive to copy types that can be safely converted to const references.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. Can you add something to the docs/ReleaseNotes.rst for this new check, please? Repository: rL LLVM http://reviews.llvm.org/D17491 ___ cfe-commits mailing

Re: [PATCH] D17482: [clang-tidy] Allow tests to verify changes made to header files

LegalizeAdulthood added a comment. Squeak http://reviews.llvm.org/D17482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18210: [analyzer] Fix an assertion fail in hash generation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264851: [analyzer] Fix an assertion fail in hash generation. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D18210?vs=50819=52033#toc Repository: rL LLVM

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/DuplicateIncludeCheck.cpp:62 @@ +61,3 @@ +StringRef SearchPath, StringRef RelativePath, const Module *Imported) { + if (!SM_.isInMainFile(HashLoc)) { +return; LegalizeAdulthood

Re: [PATCH] D18717: [Clang-tidy] Improve checks documentation consistency

This revision was automatically updated to reflect the committed changes. Closed by commit rL265205: [Clang-tidy] Improve checks documentation consistency. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D18717?vs=52441=52451#toc Repository: rL LLVM

Re: [PATCH] D17482: [clang-tidy] Allow tests to verify changes made to header files

LegalizeAdulthood added a comment. As it stands currently, you can't commit a header with `CHECK-MESSAGES` and `CHECK-FIXES` lines and have them verified. That's the whole point of this changeset. Currently you have to do something very hacky in order to verify changes made to headers.

Re: [PATCH] D17482: [clang-tidy] Allow tests to verify changes made to header files

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D17482#390237, @alexfh wrote: > My main concern is that this change makes the already complicated and > unobvious testing mechanism [...] The complexity and obtuseness of the existing testing mechanism is unrelated to this

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D18509#388071, @hintonda wrote: > With this change, won't you need to update 2 different repos: clang and > extra? Is it possible to update both with a single Phabricator patch? This is updating the release notes in the extra

Re: [PATCH] D17955: [OpenCL] Fix pipe builtin bugs

This revision was automatically updated to reflect the committed changes. Closed by commit rL264825: [OpenCL] Fix pipe builtin bugs (authored by pxl). Changed prior to commit: http://reviews.llvm.org/D17955?vs=51629=52021#toc Repository: rL LLVM http://reviews.llvm.org/D17955 Files:

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

This revision was automatically updated to reflect the committed changes. Closed by commit rL265006: [OpenCL] Added nosvm attribute for OpenCL v2.0. (authored by stulova). Changed prior to commit: http://reviews.llvm.org/D17861?vs=52077=52185#toc Repository: rL LLVM

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

This revision was automatically updated to reflect the committed changes. Closed by commit rL266292: [ASTImporter] Implement some expression-related AST node import. (authored by dergachev). Changed prior to commit: http://reviews.llvm.org/D14286?vs=53389=53692#toc Repository: rL LLVM

Re: [PATCH] D19056: [MSVC] Fix check for wchar_t type in case of -fno-wchar

This revision was automatically updated to reflect the committed changes. Closed by commit rL266287: [MSVC] Fix check for wchar_t type in case of -fno-wchar (authored by dpolukhin). Changed prior to commit: http://reviews.llvm.org/D19056?vs=53542=53681#toc Repository: rL LLVM

Re: [PATCH] D19057: [analyzer] Let TK_PreserveContents span across the whole base region.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267413: [analyzer] Let TK_PreserveContents span across the whole base region. (authored by dergachev). Changed prior to commit: http://reviews.llvm.org/D19057?vs=53551=54852#toc Repository: rL LLVM

Re: [PATCH] D19361: [MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)

This revision was automatically updated to reflect the committed changes. Closed by commit rL268029: Recommit "[MS] Improved implementation of stack pragmas (vtordisp, *_seg)" (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D19361?vs=54484=55568#toc Repository: rL

Re: [PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268021: [find-all-symbols] Fix racy yaml file writing. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19717?vs=9=55562#toc Repository: rL LLVM

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268037: [find-all-symbols] Parallelize the merge step. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19720?vs=55577=55589#toc Repository: rL LLVM

Re: [PATCH] D19477: [MSVC] PR27337: allow static_cast from private base to derived for WTL

This revision was automatically updated to reflect the committed changes. Closed by commit rL267534: [MSVC] PR27337: allow static_cast from private base to derived for WTL (authored by dpolukhin). Changed prior to commit: http://reviews.llvm.org/D19477?vs=54829=54975#toc Repository: rL LLVM

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 54974. krystyna marked an inline comment as done. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp

Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

This revision was automatically updated to reflect the committed changes. Closed by commit rL267772: Set the default C standard to C99 when targeting the PS4. (authored by ssrivastava). Changed prior to commit: http://reviews.llvm.org/D19003?vs=54956=55299#toc Repository: rL LLVM

Re: [PATCH] D19693: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL268078: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D19693?vs=55626=55627#toc Repository: rL LLVM

Re: [PATCH] D19727: [MS] Improved implementation #pragma pack (MS pragmas, part 2)

This revision was automatically updated to reflect the committed changes. Closed by commit rL268085: [MS] Make #pragma pack use PragmaStack<> class. (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D19727?vs=55598=55634#toc Repository: rL LLVM

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

This revision was automatically updated to reflect the committed changes. Closed by commit rL268075: Improve test coverage of -Wdouble-promotion (authored by rlougher). Changed prior to commit: http://reviews.llvm.org/D16298?vs=45195=55625#toc Repository: rL LLVM

Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

This revision was automatically updated to reflect the committed changes. Closed by commit rL270160: [Lexer] Don't merge macro args from different macro files (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D20401?vs=57810=57880#toc Repository: rL LLVM

Re: [PATCH] D20521: [Clang][AVX512][Builtin] adding missing intrinsics for vpmultishiftqb{128|256|512} instruction set

This revision was automatically updated to reflect the committed changes. Closed by commit rL270441: [clang][AVX512][Builtin] adding missing intrinsics for… (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20521?vs=58086=58098#toc Repository: rL LLVM

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo updated this revision to Diff 58381. jojo added a comment. 1.include/llvm/Support/TargetParser.h Move move the declaration of getArchFeatures to a more reasonable place. Remove unnecessary parameter for getDefaultCPU. 2.lib/Support/TargetParser.cpp Make adjustments according to

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo added inline comments. Comment at: include/llvm/Support/TargetParser.h:173 @@ +172,3 @@ +StringRef getArchName(unsigned ArchKind); +bool getArchFeatures(unsigned ArchKind, std::vector ); +unsigned getArchAttr(unsigned ArchKind); rengolin wrote: > Nitpick,

Re: [PATCH] D20394: Fix cdp intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL270058: [ARM] Fix cdp intrinsic (authored by rsingh). Changed prior to commit: http://reviews.llvm.org/D20394?vs=57698=5#toc Repository: rL LLVM http://reviews.llvm.org/D20394 Files:

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

cameron314 added a subscriber: cameron314. cameron314 added a comment. I've seen rare cases where parses using the PCH files were yielding completely invalid data, almost as if they were corrupted. I wonder now if this could be the cause. (We're on Windows too.) http://reviews.llvm.org/D20243

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo added inline comments. Comment at: lib/Support/TargetParser.cpp:441 @@ +440,3 @@ + if (Extensions & AArch64::AEK_PROFILE) +Features.push_back("+spe"); + bsmith wrote: > For ARM there is a table that defines these extensions and how they map to >

Re: [PATCH] D20424: [include-fixer] Make search handle fully qualified names correctly.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270055: [include-fixer] Make search handle fully qualified names correctly. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20424?vs=57766=57772#toc Repository: rL LLVM

Re: [PATCH] D20514: [Clang][AVX512][BUILTIN]adding missing intrinsics for movdaq instruction set

This revision was automatically updated to reflect the committed changes. Closed by commit rL270401: [Clang][AVX512][BUILTIN]adding missing intrinsics for movdaq instruction set (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20514?vs=58050=58074#toc Repository: rL

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo added a comment. > There is an awful lot of duplication/passing through to another class in > this, it strikes me that this whole thing could benefit from some level of > inheritance. I think it would be good to have a base class that defines the > interface and have both ARM/AArch64 (and

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo removed rL LLVM as the repository for this revision. jojo changed the visibility of this Differential Revision from "All Users" to "Public (No Login Required)". jojo updated this revision to Diff 58071. jojo added a comment. 1.unsigned llvm::AArch64::getArchAttr(unsigned ArchKind)

Re: [PATCH] D20088: Using AArch64TargetParser in clang

jojo removed rL LLVM as the repository for this revision. jojo changed the visibility of this Differential Revision from "All Users" to "Public (No Login Required)". jojo updated this revision to Diff 58072. jojo added a comment. Remove checkARMArchValid & checkAArch64ArchValid logic.

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

WuZhao added a subscriber: WuZhao. WuZhao added a comment. Hi , I find one mistake in the lib/Basic/Targets.cpp. On my AIX 7.1 machine /usr/include/sys/inttypes.h, 64 bits wchar_t is unsigned int, not signed int. #ifndef _WCHAR_T #define _WCHAR_T #ifdef __64BIT__ typedef unsigned int

Re: [PATCH] D20088: Using AArch64TargetParser in clang

jojo added inline comments. Comment at: lib/Driver/Tools.cpp:707 @@ -696,3 +706,3 @@ std::string MArch = arm::getARMArch(ArchName, Triple); - if (llvm::ARM::parseArch(MArch) == llvm::ARM::AK_INVALID || + if (!checkARMArchValid(MArch) || llvm::ARM::parseArch(MArch) ==

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo added inline comments. Comment at: include/llvm/Support/AArch64TargetParser.def:20 @@ +19,3 @@ +AARCH64_ARCH("armv8-a", AK_ARMV8A, "8-A", "v8", ARMBuildAttrs::CPUArch::v8_A, + FK_CRYPTO_NEON_FP_ARMV8, (AArch64::AEK_CRC | AArch64::AEK_CRYPTO | AArch64::AEK_FP |

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo set the repository for this revision to rL LLVM. jojo changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". jojo updated this revision to Diff 58205. jojo added a comment. 1.include/llvm/Support/AArch64TargetParser.def Format this file.

Re: [PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

This revision was automatically updated to reflect the committed changes. Closed by commit rL270535: [MSVC2015] dllexport for defaulted special class members (authored by dpolukhin). Changed prior to commit: http://reviews.llvm.org/D20422?vs=58088=58197#toc Repository: rL LLVM

Re: [PATCH] D20088: Using AArch64TargetParser in clang

jojo set the repository for this revision to rL LLVM. jojo changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". jojo updated this revision to Diff 58210. jojo added a comment. Adjust "getAArch64ArchFeaturesFromMarch" logic.In file

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo added a comment. > While I agree with Bradley that the repetition is not pretty, I think it will > expose all issues to make a class design simple and straightforward, once we > get all the sharp edges out. But we need to know what are the difficulties on > Clang, llc and the back-ends,

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 added a comment. I'm not sure how to test this (originally I found this bug by stepping through with a debugger) -- is there a way to determine if an ASTUnit used a PCH for the preamble or not? I'd call the `getMainBufferWithPrecompiledPreamble` method manually but it's private.

Re: [PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

> On May 23, 2016, at 8:15 PM, Bob Wilson wrote: > > Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for > Objective-C properties marked with the IBOutlet attribute. Those properties > are supposed to be weak but they are only accessed from the main

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269167: [include-fixer] Add basic documentation. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20094?vs=56856=56867#toc Repository: rL LLVM http://reviews.llvm.org/D20094

[PATCH] D20129: [libclang] Properly expose linkage spec cursors

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. All the groundwork for `CXCursor_LinkageSpec` already existed, but because of a missing case in a switch, cursors of that type were never actually created for linkage

[PATCH] D20127: [libclang] Expose cursors for alias/weak attributes

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. This patch introduces `CXCursor_AliasAttr`/`CXCursor_WeakAttr` and `clang_getAliasTargetSpelling()` for inspecting alias attributes via libclang. http://reviews.llvm.org/D20127

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. cameron314 set the repository for this revision to rL LLVM. This fixes, for example, libclang's `clang_getAllSkippedRanges` returning zero ranges after reparsing a translation unit.

[PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. All the libclang functions for expanding a location, namely `clang_getExpansionLocation`, `clang_getPresumedLocation`, `clang_getInstantiationLocation`, and most surprisingly

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

cameron314 added a comment. Ah, I was wondering where the tests were. I found this in the CMake file: # FIXME: libclang unit tests are disabled on Windows due # to failures, mostly in libclang.VirtualFileOverlay_*. if(NOT WIN32 AND CLANG_TOOL_LIBCLANG_BUILD) add_subdirectory(libclang)

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

cameron314 updated this revision to Diff 56916. cameron314 added a comment. I've added a unit test. http://reviews.llvm.org/D20125 Files: include/clang-c/Index.h tools/libclang/CXSourceLocation.cpp unittests/libclang/LibclangTest.cpp Index: unittests/libclang/LibclangTest.cpp

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

cameron314 updated this revision to Diff 56917. http://reviews.llvm.org/D20125 Files: include/clang-c/Index.h tools/libclang/CXSourceLocation.cpp unittests/libclang/LibclangTest.cpp Index: unittests/libclang/LibclangTest.cpp

[PATCH] D20131: Fixed crash during code completion in file included within declaration

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. When triggering code completion within a file that is included in the middle of a declaration in another file, clang would crash while parsing the code. This occurred with

[PATCH] D20134: [libclang] Fixed bug where ranges in spelling locations (in macro expansions) would get mangled

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. The end location of the range would be changed into its expansion location, but the beginning of the range would stay as a spelling location. This would lead to very weird ranges

[PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. There were two bugs relating to remapped files, that are not specific to Windows but happen more often there: - When remapped files were changed, they would never cause the

[PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. This complements the `clang_getSkippedRanges` function which returns skipped ranges filtered by a specific file. This function is useful when all the ranges are desired (and a lot

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

cameron314 updated this revision to Diff 56964. cameron314 added a comment. Here's a test! http://reviews.llvm.org/D20132 Files: include/clang-c/Index.h tools/libclang/CIndex.cpp unittests/libclang/LibclangTest.cpp Index: unittests/libclang/LibclangTest.cpp

Re: [PATCH] D20131: Fixed crash during code completion in file included within declaration

cameron314 updated this revision to Diff 56961. cameron314 added a comment. Ah, perfect, thanks. Behold, a test that fails without the patch and passes with it :-) http://reviews.llvm.org/D20131 Files: lib/Lex/PPLexerChange.cpp test/CodeCompletion/include-within-declaration.c Index:

Re: [PATCH] D20131: Fixed crash during code completion in file included within declaration

cameron314 added a comment. I fixed this last July so the details are a little hazy, but fortunately it turns out I documented what I had found: > It seems when clang parses an enum declaration, it first parses the > declaration specifiers, then stops if a semicolon is present. > The trouble

Re: [PATCH] D20131: Fixed crash during code completion in file included within declaration

cameron314 added inline comments. Comment at: lib/Lex/PPLexerChange.cpp:380-383 @@ -379,4 +379,6 @@ CurLexer->FormTokenWithChars(Result, CurLexer->BufferEnd, tok::eof); CurLexer.reset(); +if (CurLexerKind == CLK_Lexer) + CurLexerKind =

Re: [PATCH] D20134: [libclang] Fixed bug where ranges in spelling locations (in macro expansions) would get mangled

cameron314 added a comment. You're right, this breaks that test. The corner case that it exercises is arguably less important than breaking all spelling ranges, though. But I'm going to see if I can fix both with a little wizardry (ideally there wouldn't be open ranges in the first place,

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 57007. krystyna marked 8 inline comments as done. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

This revision was automatically updated to reflect the committed changes. Closed by commit rL269769: [PCH] Fixed bug with preamble invalidation when overridden files change (authored by cameron314). Changed prior to commit: http://reviews.llvm.org/D20137?vs=57367=57477#toc Repository: rL

[PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. cameron314 set the repository for this revision to rL LLVM. Remapped files would always cause the preamble's PCH to be invalidated (even if they hadn't changed) because the file

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 added inline comments. Comment at: lib/Frontend/ASTUnit.cpp:1402-1406 @@ +1401,7 @@ + +vfs::Status Status; +if (FileMgr->getNoncachedStatValue(RB.first, Status)) { + AnyFileChanged = true; + break; +} + rsmith

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 updated the summary for this revision. cameron314 updated this revision to Diff 57367. cameron314 added a comment. This version of the patch takes into account potential changes between filenames and their unique IDs between parses. http://reviews.llvm.org/D20137 Files:

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jojo added a comment. Dear Bradley,Renato Sorry for late reply,I have been on leave the last three days. Thank you very much for your review and suggestons.I will re pondering the changes. Repository: rL LLVM http://reviews.llvm.org/D20089

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 updated this revision to Diff 57253. cameron314 added a comment. Removed workaround for case that can no longer happen. http://reviews.llvm.org/D20137 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 added inline comments. Comment at: lib/Basic/FileManager.cpp:304-307 @@ -303,1 +303,6 @@ + if (UFE.isVirtual()) { +UFE.Name = InterndFileName; +return + } + rsmith wrote: > It looks like this is unreachable: `IsVirtual` is only ever `true`

Re: [PATCH] D19902: [ProfileData] (clang) Use Error in InstrProf and Coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rL269492: Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D19902?vs=56346=57259#toc Repository: rL LLVM

Re: [PATCH] D20372: [include-fixer] Also look up prefixes of queries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269956: [include-fixer] Also look up prefixes of queries. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20372?vs=57635=57642#toc Repository: rL LLVM

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 updated this revision to Diff 57222. cameron314 added a comment. Updated patch to include later fixes I had made after the initial change. http://reviews.llvm.org/D20137 Files: include/clang/Basic/FileManager.h include/clang/Frontend/ASTUnit.h lib/Basic/FileManager.cpp

Re: [PATCH] D20213: [Clang] Fix Clang-tidy modernize-use-bool-literals in generated code.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269371: Fix Clang-tidy modernize-use-bool-literals in generated code. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D20213?vs=57106=57110#toc Repository: rL LLVM

Re: [PATCH] D20103: PR27132: Proper mangling for __unaligned qualifier (now with both PR27367 and PR27666 fixed)

This revision was automatically updated to reflect the committed changes. Closed by commit rL269220: [MSVC] Implementation of __unaligned as a proper type qualifier (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D20103?vs=56874=56945#toc Repository: rL LLVM

Re: [PATCH] D18088: Add a new warning to notify users of mismatched SDK and deployment target

This revision was automatically updated to reflect the committed changes. Closed by commit rL268127: Add a new warning to notify users of mismatched SDK and deployment target (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D18088?vs=55652=55678#toc Repository: rL

Re: [PATCH] D19524: [OpenCL] Fix pipe type dump.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268364: [OpenCL] Fix pipe type dump. (authored by pxl). Changed prior to commit: http://reviews.llvm.org/D19524?vs=55161=55946#toc Repository: rL LLVM http://reviews.llvm.org/D19524 Files:

Re: [PATCH] D19458: Add address space 258 to Clang documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL268432: Add address space 258 (X86 SS segment) to clang documentation. (authored by dlkreitz). Changed prior to commit: http://reviews.llvm.org/D19458?vs=54877=56056#toc Repository: rL LLVM

Re: [PATCH] D19952: AMDGPU: Use lld as the linker again

This revision was automatically updated to reflect the committed changes. Closed by commit rL268648: AMDGPU: Use lld as the linker again (authored by tstellar). Changed prior to commit: http://reviews.llvm.org/D19952?vs=56231=56307#toc Repository: rL LLVM http://reviews.llvm.org/D19952

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna marked 8 inline comments as done. krystyna added a comment. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna added a comment. hide done comments Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 55867. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp clang-tidy/modernize/UseUsingCheck.h

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna marked 4 inline comments as done. krystyna added a comment. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19947: [Clang] Fix some Clang-tidy readability-simplify-boolean-expr and Include What You Use warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL268674: Fix some Clang-tidy readability-simplify-boolean-expr and Include What You… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D19947?vs=56226=56337#toc Repository:

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

What Reid said... Yours, Andrey > 5 мая 2016 г., в 1:48, Reid Kleckner написал(а): > > rnk added inline comments. > > > Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584 > @@ -1579,2 +1582,4 @@ > case QMM_Result: > +// Presence of __unaligned qualifier

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

This revision was automatically updated to reflect the committed changes. Closed by commit rL268727: [MSVC] Implementation of __unaligned as a proper type qualifier (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D19654?vs=55588=56401#toc Repository: rL LLVM

[PATCH] D20089: Adding a TargetParser for AArch64

jojo created this revision. jojo added reviewers: bsmith, jmolloy, rengolin. jojo added subscribers: llvm-commits, cfe-commits. jojo set the repository for this revision to rL LLVM. jojo changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Herald

Re: [PATCH] D20100: [NFC] Header cleanup

kevgs added a comment. Sadly, I dont know such a tool. I was using a simple script to find unused headers ack --cpp -l 'SmallString\.h"' | xargs grep -L 'SmallString[ (

Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

This revision was automatically updated to reflect the committed changes. Closed by commit rL266648: Block: Fix a crash when we have type attributes or qualifiers with omitted (authored by mren). Changed prior to commit: http://reviews.llvm.org/D18567?vs=52398=54090#toc Repository: rL LLVM

Re: [PATCH] D19262: [clang-tidy] readability-container-size-empty fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL266734: [clang-tidy] readability-container-size-empty fixes (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D19262?vs=54182=54187#toc Repository: rL LLVM

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna removed rL LLVM as the repository for this revision. krystyna updated this revision to Diff 54007. krystyna marked 5 inline comments as done. http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

This revision was automatically updated to reflect the committed changes. Closed by commit rL266870: [include-fixer] Add a prototype for a new include fixing tool. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19314?vs=54344=54350#toc Repository: rL LLVM

Re: [PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL266415: [MSVC Compat] Implementation of __unaligned (MS extension) as a type qualifier (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D18596?vs=53509=53854#toc Repository:

[PATCH] D19108: [Sema] Fixed assert failure in template code analyzer

kevgs created this revision. kevgs added reviewers: rsmith, dblaikie. kevgs added a subscriber: cfe-commits. Fix for this bug https://llvm.org/bugs/show_bug.cgi?id=27312 http://reviews.llvm.org/D19108 Files: lib/Sema/SemaAccess.cpp test/SemaTemplate/crash-bug-27258.cpp Index:

Re: [PATCH] D19068: Lit C++11 Compatibility Patch #7

This revision was automatically updated to reflect the committed changes. Closed by commit rL266239: Lit C++11 Compatibility Patch #7 (authored by lcharles). Changed prior to commit: http://reviews.llvm.org/D19068?vs=53603=53607#toc Repository: rL LLVM http://reviews.llvm.org/D19068

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

edyp87 added a comment. Yes, please apply this patch for me. As for macro cases - I also thought about this but check's author has taken care of macros in `check()` method : void RawStringLiteralCheck::check(const MatchFinder::MatchResult ) { [...] if

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

edyp87 removed rL LLVM as the repository for this revision. edyp87 updated this revision to Diff 54401. edyp87 added a comment. Extended diff range + removed unnecessary variable. http://reviews.llvm.org/D19331 Files: clang-tidy/modernize/RawStringLiteralCheck.cpp

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

edyp87 marked an inline comment as done. edyp87 added a comment. 1. Extended diff has been generated - sorry, I am new to Phabricator. 2. AST for this case looks like this: > AST for crashing case: > > -VarDecl 0x2b27370 col:19 function 'const char *const' > callinit >

Re: [PATCH] D19356: [Tooling] Inject -resource-dir instead of overwriting argv[0].

This revision was automatically updated to reflect the committed changes. Closed by commit rL266973: [Tooling] Inject -resource-dir instead of overwriting argv[0]. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19356?vs=54474=54478#toc Repository: rL LLVM

Re: [PATCH] D18652: [Inline asm] Correctly parse GCC-style asm line following MS-style asm line

This revision was automatically updated to reflect the committed changes. Closed by commit rL266976: Correctly parse GCC-style asm line following MS-style asm line. (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D18652?vs=53543=54480#toc Repository: rL LLVM

Re: [PATCH] D20066: [include-fixer] Autodetect yaml databases in parent directories.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268920: [include-fixer] Autodetect yaml databases in parent directories. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20066?vs=56570=56575#toc Repository: rL LLVM

Re: [PATCH] D20011: [OpenMP 4.5] Parse+Sema for '#pragma omp declare target' clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rL268925: [OpenMP] Parse+Sema for '#pragma omp declare target' syntax version 4.5 (authored by dpolukhin). Changed prior to commit: http://reviews.llvm.org/D20011?vs=56387=56582#toc Repository: rL

<    1   2   3   4   5   6   7   8   9   10   >