Re: [PATCH] D16317: [Analyzer] Fix for PR23790: bind real value returned from strcmp when modelling strcmp.

ayartsev added a comment. Ping. http://reviews.llvm.org/D16317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16317: [Analyzer] Fix for PR23790: bind real value returned from strcmp when modelling strcmp.

ayartsev updated this revision to Diff 46538. ayartsev added a comment. Updated the patch, please review. http://reviews.llvm.org/D16317 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.c Index: test/Analysis/string.c

[PATCH] D16317: [Analyzer] Fix for PR23790: bind real value returned from strcmp when modelling strcmp.

ayartsev created this revision. ayartsev added a reviewer: zaks.anna. ayartsev added a subscriber: cfe-commits. The patch is a fix for [[ https://llvm.org/bugs/show_bug.cgi?id=23790 | PR23790 ]]. Call to StringRef::Compare() returning [1,0,-1] is replaced with the real call to strcmp to be more

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

ayartsev added a comment. Ping. http://reviews.llvm.org/D14629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

ayartsev added a comment. Ping http://reviews.llvm.org/D14629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

ayartsev updated this revision to Diff 42762. ayartsev added a comment. Updated the patch following Laszlo's advises: + Changed config file format to YAML. + Dump current configuration. + Search for config file from the current folder and upper. In http://reviews.llvm.org/D14629#294023,

Re: [PATCH] D14629: [analyzer] Configuration file for scan-build.

ayartsev added a comment. Upd: Forgot to remove the printHash() subroutine from libscanbuild.pm. Using it locally for debug purpose. http://reviews.llvm.org/D14629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added a comment. Ping. http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added a comment. Ping. http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12827: [analyzer] fix an error finding clang path

ayartsev added a comment. Thanks, Honggyu! http://reviews.llvm.org/D12827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added a comment. Ping. http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D6551: Improvements to scan-build.

ayartsev added a comment. Removed trailing whitespaces and committed as r246710. Thanks for reviews and assistance! http://reviews.llvm.org/D6551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev updated this revision to Diff 33740. http://reviews.llvm.org/D9040 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c === --- test/Analysis/malloc.c +++

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added a comment. Ping http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:523 @@ -510,2 +522,3 @@ REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair) +REGISTER_MAP_WITH_PROGRAMSTATE(ReallocSizeZeroFlag, SymbolRef, ReallocSizeZero)

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev updated this revision to Diff 33134. http://reviews.llvm.org/D9040 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c === --- test/Analysis/malloc.c +++

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added a comment. Please review! Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:158 @@ +157,3 @@ +/// zero-allocated memory returned by 'realloc(ptr, 0)'. +struct ReallocSizeZero { + void Profile(llvm::FoldingSetNodeID ID) const { zaks.anna

Re: [PATCH] D6551: Improvements to scan-build.

ayartsev updated this revision to Diff 32969. ayartsev added a comment. Updated the patch with r245621. OK to commit? http://reviews.llvm.org/D6551 Files: tools/scan-build/scan-build Index: tools/scan-build/scan-build === ---

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

ayartsev added inline comments. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:746 @@ -739,1 +745,3 @@ +return static_castDERIVED*(this)-hasTrait(MR, IK); + } }; Hmm.. Either we completely encapsulate 'RegionAndSymbolInvalidationTraits' in the

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

ayartsev added inline comments. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:2359 @@ -2314,1 +2358,3 @@ +RegionAndSymbolInvalidationTraits ITraits; +W.AddToWorkList(*I, ITraits); } Too much unnecessary passing around of