[PATCH] D106463: [HIP] Fix no matching constructor for init of shared_ptr and malloc

2021-07-22 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ce931bd7185: [HIP] Fix no matching constructor for init of shared_ptr and malloc (authored by ashi1). Herald added a project: clang. Herald added a

[PATCH] D106069: [HIP] Add test with_fopenmp.hip

2021-07-15 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106069/new/ https://reviews.llvm.org/D106069 ___

[PATCH] D106070: [HIP] Remove workaround in __clang_hip_runtime_wrapper.h

2021-07-15 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106070/new/ https://reviews.llvm.org/D106070 ___ cfe-commits mailing list

[PATCH] D105707: [HIP] Move std headers after device malloc/free

2021-07-09 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccb10266f56b: [HIP] Move std headers after device malloc/free (authored by ashi1). Herald added a project: clang. Herald added a subscriber:

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

2021-06-28 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. A few small comments, otherwise LGTM on the HIP header side. Comment at: clang/lib/Headers/__clang_hip_cmath.h:30 +#ifdef __OPENMP_AMDGCN__ +#define __DEVICE__ static __attribute__((always_inline, nothrow)) +#define __CONSTEXPR__ constexpr

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

2021-06-22 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Looks OK to me, please address other review comments. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://reviews.llvm.org/D104677 ___ cfe-commits mailing

[PATCH] D104062: [HIP] Fix --hip-version flag with 0 as component

2021-06-11 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf2cc0427b13e: [HIP] Fix --hip-version flag with 0 as component (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100794: [HIP] Support overloaded math functions for hipRTC

2021-05-21 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:20 #include #include #include we may not need to `#include` limits and/or type_traits if we replaced them with `__hip::is_integral` and `__hip::is_arithmetic`.

[PATCH] D102508: [HIP] Add test libstd_functional

2021-05-14 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. In D102508#2759906 , @yaxunl wrote: > In D102508#2759905 , @ashi1 wrote: > >> Looks good, let me verify on HIP builder. > > It depends on https://reviews.llvm.org/D102507 Okay, let's wait

[PATCH] D102508: [HIP] Add test libstd_functional

2021-05-14 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Looks good, let me verify on HIP builder. Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102508/new/ https://reviews.llvm.org/D102508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102427: [HIP] Clean up llvm intrinsics using __asm

2021-05-13 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa249ffa42137: [HIP] Clean up llvm intrinsics using __asm (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D102403: [HIP] Add __builtin_amdgcn_groupstaticsize

2021-05-13 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a67e05a26eb: [HIP] Add __builtin_amdgcn_groupstaticsize (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D100045: [HIP] Fix rocm-detect.hip test path

2021-04-07 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdf59850038d8: [HIP] Fix rocm-detect.hip test path (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D99738: [HIP] remove overloaded abs in header

2021-04-01 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99738/new/ https://reviews.llvm.org/D99738 ___ cfe-commits mailing list

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

2021-03-18 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. In D98278#2618936 , @zero9178 wrote: > In D98278#2616932 , @mstorsjo wrote: > >> In D98278#2616916 , @zero9178 wrote: >> >>> Add

[PATCH] D93062: [HIP] Add signbit(long double) decl

2021-01-14 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbe40c12040a0: [HIP] Add signbit(long double) decl (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92130: [HIP] cmath promote long double args to double

2020-12-03 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. In D92130#2423801 , @tra wrote: > LGTM in general. Will defer to Sam as it's HIP. > > Nit: > >> long double, promote them to double, and use the fp64 > > I'd say `long double` -> `double` qualifies as a demotion. Thanks, I've

[PATCH] D92130: [HIP] cmath promote long double args to double

2020-12-03 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGba2612ce01ea: [HIP] cmath demote long double args to double (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92418: [hip] Fix host object creation from fatbin

2020-12-01 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Looks good to me, were you able to run staging on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92418/new/ https://reviews.llvm.org/D92418 ___ cfe-commits mailing list

[PATCH] D92342: [HIP] Fix HIP test on windows due to lld suffix

2020-12-01 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. In D92342#2425271 , @RKSimon wrote: > @ashi1 This is causing build failures - please can you take a look ? > http://lab.llvm.org:8011/#/builders/14/builds/2514 > > :17:66: note: possible intended match here >

[PATCH] D92342: [HIP] Fix HIP test on windows due to lld suffix

2020-11-30 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf89e9c8201ea: [HIP] Fix HIP test on windows due to lld suffix (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90409: [HIP] Math Headers to use type promotion

2020-11-03 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca5b31502c82: [HIP] Math Headers to use type promotion (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

2020-10-02 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88377/new/ https://reviews.llvm.org/D88377 ___ cfe-commits mailing list

[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

2020-09-28 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Could you please add full context? Mostly looks good to me. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:243 - // Allow using target ID in --offload-arch. - StringRef GpuArch = translateTargetID(DriverArgs, CC1Args); + StringRef GpuArch =

[PATCH] D87461: Disable sanitizer options for AMDGPU

2020-09-10 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87461/new/ https://reviews.llvm.org/D87461 ___ cfe-commits mailing list

[PATCH] D87324: [HIP] Add gfx1030 and gfx1031

2020-09-08 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. LGTM, looks like its already in clang/include/clang/Basic/Cuda.h and clang/lib/Basic/Targets/AMDGPU.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87324/new/ https://reviews.llvm.org/D87324

[PATCH] D85442: [HIP] Ignore invalid ar linker options

2020-08-06 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG96c2d5e99e32: [HIP] Ignore invalid ar linker options (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83145: [HIP] Use default triple in llvm-mc for system ld

2020-07-07 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc64bb3f7367a: [HIP] Use default triple in llvm-mc for system ld (authored by ashi1). Herald added a project: clang.

[PATCH] D83145: [HIP] Use default triple in llvm-mc for system ld

2020-07-07 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc64bb3f7367a: [HIP] Use default triple in llvm-mc for system ld (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D78759: Add Statically Linked Libraries

2020-06-29 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Hi Jon, I may have committed this in combination with D81963 as the parent commit. It should have waited for a LGTM from someone outside our org. Please let me know unaddressed comments on this change, and I will fix them asap. Sorry

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

2020-06-25 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added inline comments. Comment at: clang/test/CodeGenCUDA/lambda.cu:53 +// DEV: call void @_ZZ12test_resolvevENKUlvE_clEv +// DEV-LABE: define internal void @_ZZ12test_resolvevENKUlvE_clEv +// DEV: call i32 @_Z10overloadedIiET_v There is a typo here,

[PATCH] D78759: Add Statically Linked Libraries

2020-06-22 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4bafb0adcf38: Add Statically Linked Libraries (authored by ashi1). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D78759?vs=271220=272526#toc Repository:

[PATCH] D81963: [HIP] Move HIP Linking Logic into HIP ToolChain

2020-06-22 Thread Aaron Enye Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG77df5a8283ed: [HIP] Move HIP Linking Logic into HIP ToolChain (authored by ashi1). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D81963?vs=271210=272525#toc

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-06-22 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added subscribers: yaxunl, ashi1. ashi1 added a comment. Hi, I am getting a compiler error due to this patch. I am using cmake command: cmake ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;lld;clang-tools-extra" -DLLVM_TARGETS_TO_BUILD="AMDGPU;X86"

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

2020-06-15 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM, ready to submit if @tra and @arsenm are okay with this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81861/new/ https://reviews.llvm.org/D81861

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

2020-06-15 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Thank you for this patch, it looks good, and I have a few minor questions/comments. Comment at: clang/test/Driver/hip-phases.hip:34 +// RDC-DAG: [[P6:[0-9]+]]: backend, {[[P5]]}, ir, (device-[[T]], [[ARCH]]) +// RDC-DAG: [[P10:[0-9]+]]: linker,

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

2020-06-15 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. LGTM, thank you for splitting the cuda-phases from hip-phases, and opening up a follow-up patch for RDC case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627

[PATCH] D70980: [HIP] Remove opencl.amdgcn.lib

2019-12-03 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70980/new/ https://reviews.llvm.org/D70980 ___ cfe-commits mailing list

[PATCH] D68665: [HIP] Fix -save-temps

2019-10-09 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68665/new/ https://reviews.llvm.org/D68665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68300: [HIP] Use option -nogpulib to disable linking device lib

2019-10-03 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. LGTM - Thanks for generalizing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68300/new/ https://reviews.llvm.org/D68300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68300: [HIP] Add option -fno-link-builtin-bitcode to disable linking device lib

2019-10-02 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. LGTM thank you Comment at: include/clang/Driver/Options.td:606 +def flink_builtin_bitcode : Flag<["-"], "flink-builtin-bitcode">, + Flags<[CC1Option]>, HelpText<"Link builtin bitcode for HIP device compilation.">; +def fno_link_builtin_bitcode :

[PATCH] D64364: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012

2019-07-10 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64364/new/ https://reviews.llvm.org/D64364 ___ cfe-commits mailing list

[PATCH] D60513: [HIP] Use -mlink-builtin-bitcode to link device library

2019-04-10 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60513/new/ https://reviews.llvm.org/D60513 ___ cfe-commits mailing list

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

2019-04-03 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Thank you, I submitted a clang-formatted fix for the if statement. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-commits mailing list

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

2019-04-02 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Hi Artem, I had just committed the change. IS this change OK or should I revert it? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-commits

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

2019-04-02 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 created this revision. ashi1 added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not produce Fat binary functions for HIP when no device code is present. Repository: rC Clang https://reviews.llvm.org/D60141 Files:

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

2019-03-13 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Hi Matt, that solution will need refactoring and testing. Currently, HIP-Clang is following the same link flow as HCC Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59316/new/ https://reviews.llvm.org/D59316

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

2019-03-13 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 created this revision. ashi1 added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. I've updated the HIP ToolChain to pass OPT_mllvm options into OPT and LLC stages. Also added a lit test to verify its properly passed down. All check-clang tests

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

2019-02-19 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. This was submitted again with the fix. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

2019-02-12 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. Yes, but it will need this PR: https://github.com/ROCm-Developer-Tools/HIP/pull/910 So that the default is set. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

2019-02-12 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 186528. ashi1 added a comment. I've added a lit test to check for options such as -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

2019-02-12 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 186519. ashi1 added a comment. Herald added a subscriber: jdoerfert. Changed patch to us handleTargetFeatures, to consume all -m options passed into clang. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

2019-02-08 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 created this revision. ashi1 added reviewers: yaxunl, kzhuravl. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows the compile option -mcode-object-v3 to be set by default, unless the -mno-code-object-v3 is added to the compile options. Repository:

[PATCH] D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

2019-01-04 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. I've commit the changes, but forgot to tag the proper Diff link in the commit message. I just updated it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56321/new/ https://reviews.llvm.org/D56321 ___ cfe-commits

[PATCH] D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

2019-01-04 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 180289. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56321/new/ https://reviews.llvm.org/D56321 Files: lib/Driver/Driver.cpp test/Driver/hip-link-shared-library.hip Index: test/Driver/hip-link-shared-library.hip

[PATCH] D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types

2019-01-04 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 created this revision. ashi1 added a reviewer: yaxunl. Herald added a subscriber: cfe-commits. The offload bundler action should not unbundle the input file types that does not match the action type. This fixes an issue where .so files are unbundled when the action type is object files.

[PATCH] D52673: [HIP] Remove disabled irif library

2018-10-09 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 168855. ashi1 marked an inline comment as done. ashi1 added a comment. I've moved the hip.amdgcn.bc to the top of the libs. Updated test as well. https://reviews.llvm.org/D52673 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/hip-device-libs.hip

[PATCH] D52673: [HIP] Remove disabled irif library

2018-10-09 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 168836. ashi1 added a comment. The device libraries has been updated, and the hip.amdgcn.bc library is now available there. Repository: rC Clang https://reviews.llvm.org/D52673 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/hip-device-libs.hip

[PATCH] D52673: [HIP] Remove disabled irif library

2018-10-04 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 added a comment. I've added a hip.amdgcn.bc library for the fence functions that were originally in irif library. https://reviews.llvm.org/D52673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52673: [HIP] Remove disabled irif library

2018-10-04 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 168384. ashi1 edited the summary of this revision. Herald added a subscriber: jfb. https://reviews.llvm.org/D52673 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/hip-device-libs.hip Index: test/Driver/hip-device-libs.hip

[PATCH] D52673: [HIP] Remove disabled irif library

2018-10-01 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 167741. ashi1 added a comment. Added diff with full context. Also, I need to find replacements for few functions in HIP github before this can be submitted. https://reviews.llvm.org/D52673 Files: lib/Driver/ToolChains/HIP.cpp

[PATCH] D52673: [HIP] Remove disabled irif library

2018-09-28 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 created this revision. ashi1 added reviewers: yaxunl, b-sumner, scchan. Herald added a subscriber: cfe-commits. Device Libraries has removed irif.amdgcn.bc, so we need to remove this requirement from HIP Toolchains. Also a few header functions need to be updated. Repository: rC Clang

[PATCH] D48667: [HIP] Fix ordering of device-lib linking

2018-06-27 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 153154. ashi1 added a comment. Updated diff with a lit test. https://reviews.llvm.org/D48667 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/hip-device-libs.hip Index: test/Driver/hip-device-libs.hip

[PATCH] D48667: [HIP] Fix ordering of device-lib linking

2018-06-27 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 created this revision. ashi1 added reviewers: yaxunl, b-sumner. ashi1 added projects: clang, AMDGPU. Herald added a subscriber: cfe-commits. Should link the bitcodes with caller functions before callee functions. Repository: rC Clang https://reviews.llvm.org/D48667 Files:

[PATCH] D48493: [HIP] Support flush denorms bitcode

2018-06-27 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 153146. ashi1 added a comment. Merged checks for flush denorm on and off into single test hip-device-libs.hip https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc

[PATCH] D48493: [HIP] Support flush denorms bitcode

2018-06-27 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 153140. https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc test/Driver/Inputs/hip_dev_lib/ockl.amdgcn.bc test/Driver/Inputs/hip_dev_lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc

[PATCH] D48493: [HIP] Support flush denorms bitcode

2018-06-27 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 153136. ashi1 added a comment. I've updated. Moved the bitcode files into hip_dev_lib and added test for both on and off flush denorms to zero option. https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp

[PATCH] D48493: [HIP] Support flush denorms bitcode

2018-06-27 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 153131. ashi1 added a comment. Fix diff file https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_multiple_inputs/dev_lib/irif.amdgcn.bc test/Driver/Inputs/hip_multiple_inputs/dev_lib/ockl.amdgcn.bc

[PATCH] D48493: [HIP] Support flush denorms bitcode

2018-06-27 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 153127. ashi1 added a comment. Added diff with full context. https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/Inputs/hip_multiple_inputs/dev_lib/irif.amdgcn.bc

[PATCH] D48493: [HIP] Support flush denorms bitcode

2018-06-27 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 updated this revision to Diff 153124. ashi1 added a comment. I've changed the string to a more meaningful name, and also added a lit test to check that oclc_daz_opt_on.amdgcn.bc is used. https://reviews.llvm.org/D48493 Files: lib/Driver/ToolChains/HIP.cpp

[PATCH] D48493: [HIP] Support flush denorms bitcode

2018-06-22 Thread Aaron Enye Shi via Phabricator via cfe-commits
ashi1 created this revision. ashi1 added a reviewer: yaxunl. ashi1 added projects: clang, AMDGPU. Herald added a subscriber: cfe-commits. We need to use oclc_daz_opt_on.amdgcn.bc bitcode when option fcuda-flush-denormal-to-zero is enabled for HIP. Repository: rC Clang