[PATCH] D49941: [ARM] Add ARMv8.2-A FP16 scalar intrinsic

2018-07-27 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az created this revision. az added a reviewer: SjoerdMeijer. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, chrib, kristof.beyls. This patch adds the fp16 scalar intrinsic for ARM as described in the ARM ACLE document. Only the frontend work is done here and some

[PATCH] D44591: [AArch64] Add vmulxh_lane FP16 vector intrinsic

2018-03-19 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az updated this revision to Diff 139015. az added a comment. add LLVM codegen tests as suggested in the reviews. https://reviews.llvm.org/D44591 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/aarch64-v8.2a-neon-intrinsics.c

[PATCH] D44222: [AArch64] Add vmulxh_lane FP16 intrinsics

2018-03-16 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az added a comment. Was not able to update this particular review with the new code, So I created a new one in https://reviews.llvm.org/D44591 I manage to reuse the mulx scalar intrinsic work, not exactly calling the fp16 scalar intrinsic itself which is not available here but the same

[PATCH] D44591: [AArch64] Add vmulxh_lane FP16 vector intrinsic

2018-03-16 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az created this revision. az added a reviewer: SjoerdMeijer. Herald added subscribers: kristof.beyls, javed.absar, rengolin. Add the two missing vmulxh_lane vector intrinsics that were originally left out. https://reviews.llvm.org/D44591 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D44222: [AArch64] Add vmulxh_lane FP16 intrinsics

2018-03-08 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az added inline comments. Comment at: include/clang/Basic/arm_neon.td:1504 + // Scalar floating point multiply extended (scalar, by element) + def SCALAR_FMULX_LANEH : IOpInst<"vmulx_lane", "ssdi", "Sh", OP_SCALAR_MUL_LN>; + def SCALAR_FMULX_LANEQH : IOpInst<"vmulx_laneq",

[PATCH] D43650: [ARM] Add ARMv8.2-A FP16 vector intrinsics

2018-02-22 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az created this revision. az added a reviewer: SjoerdMeijer. Herald added subscribers: kristof.beyls, javed.absar. This patch adds the fp16 neon vector intrinsic for ARM as described in the ARM ACLE document. While this patch may seem large at first but it is essentially a

[PATCH] D42993: [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic

2018-02-12 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az closed this revision. az added a comment. Committed as r324940 and r324912 https://reviews.llvm.org/D42993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42993: [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic

2018-02-08 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az updated this revision to Diff 133505. az added a comment. > Question about the failures: I am now wondering if this means we were and > still are missing tests? Given that this work is fixing https://reviews.llvm.org/D41792 which is mainly about adding frontend intrinsic support, then

[PATCH] D42993: [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic

2018-02-06 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az created this revision. az added a reviewer: SjoerdMeijer. Herald added subscribers: hiraditya, kristof.beyls, javed.absar, rengolin, aemerson. A couple of fixes on top of https://reviews.llvm.org/D41792: - Fixes for freceprical, and fsqrt instructions in the backend. - The intrinsics that

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

2018-01-11 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az marked 6 inline comments as done. az added inline comments. Comment at: clang/include/clang/Basic/arm_fp16.td:58 +class IInst : Inst {} + +// ARMv8.2-A FP16 intrinsics. SjoerdMeijer wrote: > az wrote: > > SjoerdMeijer wrote: > > > There's a

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

2018-01-11 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az updated this revision to Diff 129513. az marked 3 inline comments as done. https://reviews.llvm.org/D41792 Files: clang/include/clang/Basic/BuiltinsNEON.def clang/include/clang/Basic/CMakeLists.txt clang/include/clang/Basic/arm_fp16.td clang/include/clang/Basic/arm_neon.td

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

2018-01-10 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az marked 8 inline comments as done. az added inline comments. Comment at: clang/include/clang/Basic/arm_fp16.td:58 +class IInst : Inst {} + +// ARMv8.2-A FP16 intrinsics. SjoerdMeijer wrote: > There's a little bit of duplication here: the

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

2018-01-10 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az updated this revision to Diff 129360. https://reviews.llvm.org/D41792 Files: clang/include/clang/Basic/BuiltinsNEON.def clang/include/clang/Basic/CMakeLists.txt clang/include/clang/Basic/arm_fp16.td clang/include/clang/Basic/arm_neon.td clang/include/clang/Basic/arm_neon_incl.td

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

2018-01-05 Thread Abderrazek Zaafrani via Phabricator via cfe-commits
az created this revision. az added a reviewer: SjoerdMeijer. Herald added subscribers: kristof.beyls, javed.absar, mgorny, rengolin, aemerson. ARMv8.2-A introduces half-precision floating point data processing. This patch adds the fp16 scalar intrinsics for this architecture as described in the