Author: anemet
Date: Thu Dec 13 16:43:34 2018
New Revision: 349117
URL: http://llvm.org/viewvc/llvm-project?rev=349117&view=rev
Log:
Revert "Make -Wstring-plus-int warns even if when the result is not out of
bounds"
This reverts commit r349054.
It's causing:
FAILED: tools/clang/bindings/python
Author: anemet
Date: Thu Dec 13 16:43:36 2018
New Revision: 349118
URL: http://llvm.org/viewvc/llvm-project?rev=349118&view=rev
Log:
Revert "Try to update the test to fix the breakage With the new warning, we are
showing one more output in the test."
This reverts commit r349064.
This wasn't upd
; [-Wunused-command-line-argument]
> clang-7.0: warning: argument unused during compilation: ‘-U
> sers/buildslave/jenkins/workspace/apple-clang-master-RA-stage1-cmake-incremental/clang/src/tools/clang/test/Driver/codeview-column-info.c'
> [-Wunused-command-line-argument]
>
>
rs/buildslave/jenkins/workspace/apple-clang-master-RA-stage1-cmake-incremental/clang/src/tools/clang/test/Driver/codeview-column-info.c'
> [-Wunused-command-line-argument]
>
> Anyhow as I said to Reid, feel free to improve the patch, I am just bringing
> back a bot that has been r
tal/clang/src/tools/clang/test/Driver/codeview-column-info.c'
> [-Wunused-command-line-argument]
>
> Anyhow as I said to Reid, feel free to improve the patch, I am just bringing
> back a bot that has been red for hours.
>
> Adam
>
>
>
> On Feb 26, 2018,
ing: argument unused during compilation: ‘-U
>> sers/buildslave/jenkins/workspace/apple-clang-master-RA-stage1-cmake-incremental/clang/src/tools/clang/test/Driver/codeview-column-info.c'
>> [-Wunused-command-line-argument]
>>
>> Anyhow as I said to Reid,
ument]
>
> Anyhow as I said to Reid, feel free to improve the patch, I am just bringing
> back a bot that has been red for hours.
>
> Adam
>
>
>
> On Feb 26, 2018, at 9:22 PM, Shoaib Meenai <mailto:smee...@fb.com>> wrote:
>
> This seems bogus t
6, 2018, at 9:22 PM, Shoaib Meenai <mailto:smee...@fb.com>> wrote:
>
> This seems bogus to me. CodeView can be generated on any build platform; it
> just needs the correct triple, which Reid added in r326144.
>
> From: cfe-commits <mailto:cfe-commits-boun...@lists.
; This seems bogus to me. CodeView can be generated on any build platform; it
> just needs the correct triple, which Reid added in r326144.
>
> From: cfe-commits <mailto:cfe-commits-boun...@lists.llvm.org>> on behalf of Adam Nemet via
> cfe-commits mailto:cfe-commits@lists
Author: anemet
Date: Mon Feb 26 20:49:26 2018
New Revision: 326168
URL: http://llvm.org/viewvc/llvm-project?rev=326168&view=rev
Log:
Attempt to fix greendragon bot after r326141
Modified:
cfe/trunk/test/Driver/codeview-column-info.c
Modified: cfe/trunk/test/Driver/codeview-column-info.c
URL:
Author: anemet
Date: Mon Feb 26 10:38:11 2018
New Revision: 326108
URL: http://llvm.org/viewvc/llvm-project?rev=326108&view=rev
Log:
[Driver] Forward opt-remark hotness threshold to LTO
Modified:
cfe/trunk/lib/Driver/ToolChains/Darwin.cpp
cfe/trunk/test/Driver/darwin-ld.c
Modified: cfe/t
Author: anemet
Date: Fri Dec 1 11:59:45 2017
New Revision: 319578
URL: http://llvm.org/viewvc/llvm-project?rev=319578&view=rev
Log:
Fix the second part of the broken comment from r306079
The driver-based test is still not identical to the front-end line, remove the
hotness threshold from there a
Author: anemet
Date: Fri Dec 1 11:59:42 2017
New Revision: 319577
URL: http://llvm.org/viewvc/llvm-project?rev=319577&view=rev
Log:
Fix opt-remark with hotness testcase for sample-based PGO
1. Require hotness on all remark lines with -verify.
3. Fix the samplePGO file to actually produce hotnes
Author: anemet
Date: Fri Dec 1 11:59:37 2017
New Revision: 319576
URL: http://llvm.org/viewvc/llvm-project?rev=319576&view=rev
Log:
Partially fix comment in test broken in r306079 and r306948
A RUN line was referring to the previous RUN line but a new test was added in
between them. Just reorde
Author: anemet
Date: Thu Oct 12 16:56:54 2017
New Revision: 315643
URL: http://llvm.org/viewvc/llvm-project?rev=315643&view=rev
Log:
Handle/assert on DK_Remark
We don't generate remarks during inline assembly parsing so no need to handle
these for now.
Modified:
cfe/trunk/lib/CodeGen/CodeGen
Author: anemet
Date: Tue Oct 3 21:25:31 2017
New Revision: 314873
URL: http://llvm.org/viewvc/llvm-project?rev=314873&view=rev
Log:
Move verbosity check for opt remarks to the diag handler.
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
U
Author: anemet
Date: Tue Sep 19 16:00:59 2017
New Revision: 313693
URL: http://llvm.org/viewvc/llvm-project?rev=313693&view=rev
Log:
Add override for ClangDiagnosticHandler::isAnyRemarkEnabled()
This is used by the new closure-based variant of
OptimizationRemarkEmitter::emit().
Modified:
cfe
Author: anemet
Date: Tue Sep 19 10:59:40 2017
New Revision: 313653
URL: http://llvm.org/viewvc/llvm-project?rev=313653&view=rev
Log:
Fix ClangDiagnosticHandler::is*RemarkEnabled members
Apparently these weren't really working. I added test coverage and fixed the
typo in the name and the parameter
Author: anemet
Date: Mon May 15 13:14:31 2017
New Revision: 303093
URL: http://llvm.org/viewvc/llvm-project?rev=303093&view=rev
Log:
Revert "Fix windows buildbots - missing include and namespace"
This reverts commit r303078.
One test is still failing even after this:
http://green.lab.llvm.org/gr
Author: anemet
Date: Mon May 15 13:14:35 2017
New Revision: 303094
URL: http://llvm.org/viewvc/llvm-project?rev=303094&view=rev
Log:
Revert "[ClangD] Refactor clangd into separate components"
This reverts commit r303067.
Caused http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/34305/
Author: anemet
Date: Thu Apr 20 12:09:35 2017
New Revision: 300858
URL: http://llvm.org/viewvc/llvm-project?rev=300858&view=rev
Log:
Don't pass FPOpFusion::Strict to the backend
This restores the behavior prior to D31167 where the code-gen default was
FPC_On which mapped to FPOpFusion::Standard.
Author: anemet
Date: Tue Apr 4 18:46:34 2017
New Revision: 299488
URL: http://llvm.org/viewvc/llvm-project?rev=299488&view=rev
Log:
Another attempt to fix the sphinx warning from r299470
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
ht
Author: anemet
Date: Tue Apr 4 17:45:20 2017
New Revision: 299481
URL: http://llvm.org/viewvc/llvm-project?rev=299481&view=rev
Log:
Fix sphinx warning from r299470
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
http://llvm.org/viewvc/ll
Author: anemet
Date: Tue Apr 4 16:18:36 2017
New Revision: 299470
URL: http://llvm.org/viewvc/llvm-project?rev=299470&view=rev
Log:
Add #pragma clang fp
This adds the new pragma and the first variant, contract(on/off/fast).
The pragma has the same block scope rules as STDC FP_CONTRACT, i.e. it
Author: anemet
Date: Tue Apr 4 16:18:30 2017
New Revision: 299469
URL: http://llvm.org/viewvc/llvm-project?rev=299469&view=rev
Log:
Set FMF for -ffp-contract=fast
With this, FMF(contract) becomes an alternative way to express the request to
contract.
These are currently only propagated for FMul
Author: anemet
Date: Wed Mar 29 16:54:24 2017
New Revision: 299033
URL: http://llvm.org/viewvc/llvm-project?rev=299033&view=rev
Log:
Use FPContractModeKind universally
FPContractModeKind is the codegen option flag which is already ternary (off,
on, fast). This makes it universally the type for t
Author: anemet
Date: Wed Mar 29 16:24:19 2017
New Revision: 299029
URL: http://llvm.org/viewvc/llvm-project?rev=299029&view=rev
Log:
Revert "Use FPContractModeKind universally"
This reverts commit r299027.
It's causing a test failure in clang's CodeGenCUDE/fp-contract.cu
Modified:
cfe/trunk
Author: anemet
Date: Wed Mar 29 15:39:49 2017
New Revision: 299027
URL: http://llvm.org/viewvc/llvm-project?rev=299027&view=rev
Log:
Use FPContractModeKind universally
FPContractModeKind is the codegen option flag which is already ternary (off,
on, fast). This makes it universally the type for t
Author: anemet
Date: Mon Mar 27 14:17:25 2017
New Revision: 298877
URL: http://llvm.org/viewvc/llvm-project?rev=298877&view=rev
Log:
Encapsulate FPOptions and use it consistently
Sema holds the current FPOptions which is adjusted by 'pragma STDC
FP_CONTRACT'. This then gets propagated into expre
Author: anemet
Date: Tue Mar 21 19:58:18 2017
New Revision: 298469
URL: http://llvm.org/viewvc/llvm-project?rev=298469&view=rev
Log:
Remove -ffp-contract=fast from this test
It does not need it and causes mismatch after -ffp-contract=fast is turned
into an FMF.
Modified:
cfe/trunk/test/CodeG
Author: anemet
Date: Tue Mar 21 19:58:15 2017
New Revision: 298468
URL: http://llvm.org/viewvc/llvm-project?rev=298468&view=rev
Log:
Change -ffp-contract=fast test to run on Aarch64
(I don't have powerpc enabled in my build and I am changing
how -ffp-contract=fast works.)
Modified:
cfe/trunk
Author: anemet
Date: Mon Jan 30 10:22:50 2017
New Revision: 293493
URL: http://llvm.org/viewvc/llvm-project?rev=293493&view=rev
Log:
Adjust tests after folding inlining analysis into missed remarks
Modified:
cfe/trunk/test/Frontend/optimization-remark-with-hotness.c
cfe/trunk/test/Fronten
Author: anemet
Date: Wed Jan 25 22:34:07 2017
New Revision: 293149
URL: http://llvm.org/viewvc/llvm-project?rev=293149&view=rev
Log:
Further fixes to test from r293146
Require aarch64 and avoid filename in YAML since it may require quotation.
Modified:
cfe/trunk/test/CodeGen/opt-record-MIR.c
Author: anemet
Date: Wed Jan 25 22:14:04 2017
New Revision: 293147
URL: http://llvm.org/viewvc/llvm-project?rev=293147&view=rev
Log:
Fix test from r293146
Modified:
cfe/trunk/test/CodeGen/opt-record-MIR.c
Modified: cfe/trunk/test/CodeGen/opt-record-MIR.c
URL:
http://llvm.org/viewvc/llvm-pro
Author: anemet
Date: Wed Jan 25 22:07:11 2017
New Revision: 293146
URL: http://llvm.org/viewvc/llvm-project?rev=293146&view=rev
Log:
Support MIR opt-remarks with -fsave-optimization-record
The handler that deals with IR passed/missed/analysis remarks is extended to
also handle the corresponding M
Author: anemet
Date: Fri Dec 2 11:54:34 2016
New Revision: 288520
URL: http://llvm.org/viewvc/llvm-project?rev=288520&view=rev
Log:
With LTO and profile-use, enable hotness info in opt remarks
This is to match the behavior of non-LTO;
when -fsave-optimization-record is passed and PGO is availabl
Author: anemet
Date: Tue Nov 22 01:35:19 2016
New Revision: 287628
URL: http://llvm.org/viewvc/llvm-project?rev=287628&view=rev
Log:
Rename option to -lto-pass-remarks-output
The new option -pass-remarks-output broke LLVM_LINK_LLVM_DYLIB because
of the duplicate option name with opt.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287358: LTO support for -fsave-optimization-record on Darwin
(authored by anemet).
Changed prior to commit:
https://reviews.llvm.org/D26833?vs=78464&id=78552#toc
Repository:
rL LLVM
https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287357: Fix a comment for -fsave-optimization-record
(authored by anemet).
Changed prior to commit:
https://reviews.llvm.org/D26807?vs=78389&id=78551#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: anemet
Date: Fri Nov 18 12:17:33 2016
New Revision: 287357
URL: http://llvm.org/viewvc/llvm-project?rev=287357&view=rev
Log:
Fix a comment for -fsave-optimization-record
Differential Revision: https://reviews.llvm.org/D26807
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/tru
Author: anemet
Date: Fri Nov 18 12:17:36 2016
New Revision: 287358
URL: http://llvm.org/viewvc/llvm-project?rev=287358&view=rev
Log:
LTO support for -fsave-optimization-record on Darwin
I guess this would have to be added for each linker.
Differential Revision: https://reviews.llvm.org/D26833
M
anemet added a comment.
Mehdi offered to help out making this work for ThinLTO on the LLVM side. For
now this option will be ignored by ThinLTO.
https://reviews.llvm.org/D26833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
anemet added a comment.
Nothing strong, just trying to go step-by-step. I haven't thought about it how
this should map to ThinLTO. We can discuss it tomorrow.
https://reviews.llvm.org/D26833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
anemet added a comment.
In https://reviews.llvm.org/D26833#599382, @mehdi_amini wrote:
> Well, maybe not entirely, what do you expect for output with ThinLTO?
For now, I'd like to just ignore it. So I need to somehow restrict this to
LTO-only...
https://reviews.llvm.org/D26833
__
anemet created this revision.
anemet added reviewers: hfinkel, mehdi_amini.
anemet added a subscriber: cfe-commits.
I guess this would have to be added for each linker.
https://reviews.llvm.org/D26833
Files:
lib/Driver/Tools.cpp
test/Driver/darwin-ld.c
Index: test/Driver/darwin-ld.c
=
anemet created this revision.
anemet added a reviewer: hfinkel.
anemet added a subscriber: cfe-commits.
https://reviews.llvm.org/D26807
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib/
anemet added a comment.
LGTM, thanks. I also like the option name but will let the the other reviewers
official approve that part.
https://reviews.llvm.org/D25225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
anemet added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:198
+
+Ctx.setDiagnosticsOutputFile(new yaml::Output(OptRecordFile->os()));
+ }
Sorry, one more thing: if PGO is available, I think we want to set
Ctx.setDiagnosticHotnessReques
anemet added inline comments.
Comment at: test/CodeGen/opt-record.c:17-25
+// CHECK: --- !Missed
+// CHECK: Pass:inline
+// CHECK: Name:NoDefinition
+// CHECK: Function:foo
+
+// CHECK: --- !Passed
+// CHECK: Pass:loop-vectorize
---
Hi Eric,
Thanks for your work.
> On Sep 29, 2016, at 11:04 PM, Eric Liu via cfe-dev
> wrote:
>
> I've switched the default email format to be plain text only now. This option
> should be per-user configurable, but somehow it is not shown in the
> "Settings"; I'll try if I can make the option
Author: anemet
Date: Tue Sep 27 17:19:29 2016
New Revision: 282545
URL: http://llvm.org/viewvc/llvm-project?rev=282545&view=rev
Log:
Shorten DiagnosticInfoOptimizationRemark* to OptimizationRemark*. NFC
With the new streaming interface in LLVM, these class names need to be
typed a lot and it's wa
Author: anemet
Date: Tue Sep 27 15:55:12 2016
New Revision: 282540
URL: http://llvm.org/viewvc/llvm-project?rev=282540&view=rev
Log:
Adapt to LLVM optimization remark interface change. NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL
Author: anemet
Date: Tue Sep 27 11:39:27 2016
New Revision: 282504
URL: http://llvm.org/viewvc/llvm-project?rev=282504&view=rev
Log:
Revert "Adapt to LLVM optimization remark interface change. NFC"
This reverts commit r282500.
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/
Author: anemet
Date: Tue Sep 27 11:15:21 2016
New Revision: 282500
URL: http://llvm.org/viewvc/llvm-project?rev=282500&view=rev
Log:
Adapt to LLVM optimization remark interface change. NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL
Author: anemet
Date: Mon Sep 12 23:32:40 2016
New Revision: 281293
URL: http://llvm.org/viewvc/llvm-project?rev=281293&view=rev
Log:
Reapply r281276 with passing -emit-llvm in one of the tests
Original commit message:
Add -fdiagnostics-show-hotness
Summary:
I've recently added the ability for o
Author: anemet
Date: Mon Sep 12 19:16:49 2016
New Revision: 281279
URL: http://llvm.org/viewvc/llvm-project?rev=281279&view=rev
Log:
Revert "Add -fdiagnostics-show-hotness"
This reverts commit r281276.
Many bots are failing.
Removed:
cfe/trunk/test/Frontend/Inputs/optimization-remark-with-h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281276: Add -fdiagnostics-show-hotness (authored by anemet).
Changed prior to commit:
https://reviews.llvm.org/D23284?vs=70547&id=71078#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23284
Files:
Author: anemet
Date: Mon Sep 12 18:48:16 2016
New Revision: 281276
URL: http://llvm.org/viewvc/llvm-project?rev=281276&view=rev
Log:
Add -fdiagnostics-show-hotness
Summary:
I've recently added the ability for optimization remarks to include the
hotness of the corresponding code region. This uses
Author: anemet
Date: Mon Sep 12 18:48:11 2016
New Revision: 281275
URL: http://llvm.org/viewvc/llvm-project?rev=281275&view=rev
Log:
Fix a long comment line
Modified:
cfe/trunk/include/clang/Frontend/CodeGenOptions.def
Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.def
URL:
http:
anemet updated this revision to Diff 70547.
anemet updated the summary for this revision.
anemet added a comment.
Address Richard's comment
https://reviews.llvm.org/D23284
Files:
docs/UsersManual.rst
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
include/cl
anemet marked an inline comment as done.
anemet added a comment.
https://reviews.llvm.org/D23284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
anemet updated this revision to Diff 70502.
anemet added a comment.
This renames the flag to -fdiagnostics-show-hotness as requested by Richard.
Also added the missing documentation bits.
https://reviews.llvm.org/D23284
Files:
docs/UsersManual.rst
include/clang/Basic/DiagnosticDriverKinds.t
anemet added a comment.
In https://reviews.llvm.org/D23284#535258, @rsmith wrote:
> I think this should start with `-fdiagnostics` to group it with other similar
> flags. `-fdiagnostics-include-hotness-in-remarks` seems too specific to me --
> I could imagine generating warnings from the middle
anemet added a comment.
In https://reviews.llvm.org/D23284#534879, @rsmith wrote:
> I think this should not be an -R option at all; like -W flags, the idea is
> for -R to only act as a filter for which diagnostics are shown. This option
> seems much more closely related to options like -fdiagno
anemet added a comment.
In https://reviews.llvm.org/D23284#526413, @dnovillo wrote:
> I'm fine with it, but I don't have much of a say in how option groups are
> organized. If Richard agrees, then it LGTM.
Ping. Would it be OK to commit this with the two LGTMs? I am around to fix
any fall-
anemet added a comment.
@dnovillo or @rsmith, can you please confirm if you agree that this new option
-Rpass-with-hotness should not be part of R_group. R_group options
enable/disable groups of remarks whereas this one is only modifying the text of
the remarks. Thanks!
https://reviews.llvm
Author: anemet
Date: Tue Aug 23 23:31:56 2016
New Revision: 279608
URL: http://llvm.org/viewvc/llvm-project?rev=279608&view=rev
Log:
[Pragma] Clear loop distribution attribute between loops
Added:
cfe/trunk/test/CodeGenCXX/pragma-loop-distribute.cpp
Modified:
cfe/trunk/lib/CodeGen/CGLoopI
anemet updated this revision to Diff 67653.
anemet added a comment.
Since -Rpass-with-hotness is not part of R_group, we need to manually forward
it to clang -cc1. I've also extended the test to cover this bug.
https://reviews.llvm.org/D23284
Files:
include/clang/Basic/DiagnosticDriverKinds.
anemet added reviewers: dnovillo, rsmith.
anemet marked an inline comment as done.
anemet added subscribers: dnovillo, rsmith.
anemet added a comment.
Add more reviewers suggested by Aaron. @dnovillo, @rsmith, is my thinking
correct that this new flag does not belong to the R_Group.
https://re
anemet updated this revision to Diff 67379.
anemet added a comment.
Address Aaron's comment
https://reviews.llvm.org/D23284
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenAction.cpp
lib/F
anemet created this revision.
anemet added reviewers: hfinkel, rjmccall, aaron.ballman.
anemet added a subscriber: cfe-commits.
I've recently added the ability for optimization remarks to include the
hotness of the corresponding code region. This uses PGO and allows
filtering of the optimization
Author: anemet
Date: Tue Jun 28 23:55:31 2016
New Revision: 274101
URL: http://llvm.org/viewvc/llvm-project?rev=274101&view=rev
Log:
[Diag] Add getter shouldAlwaysPrint. NFC
For the new hotness attribute, the API will take the pass rather than
the pass name so we can no longer play the trick of A
anemet added a comment.
In http://reviews.llvm.org/D21773#469596, @lihuang wrote:
> IV is promoted to 64-bit but the trunc/zext cannot be eliminated (at least
> cannot be eliminated with the -O1 pass pipeline). Then optimzation remark
> becomes:
>
> optimization-remark-options.c:17:3: remark:
anemet added a comment.
> This test checks the loop-vectorization remarks when pointer checking
> threshold is exceeded. The change in http://reviews.llvm.org/D18777 would
> introduce zexts that cannot be removed so that the "loop not vectorized"
> reason is changed, hence breaking this test.
r272699 should do it.
> On Jun 14, 2016, at 9:32 PM, Adam Nemet via cfe-commits
> wrote:
>
> On it, sorry about it.
>
>> On Jun 14, 2016, at 4:51 PM, Rafael Espíndola
>> wrote:
>>
>> Looks like this broke the docs:
>> http://lab.llvm.org:8011/
Author: anemet
Date: Tue Jun 14 14:33:16 2016
New Revision: 272699
URL: http://llvm.org/viewvc/llvm-project?rev=272699&view=rev
Log:
Fix documentation bot after r272656
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
http://llvm.org/viewv
On it, sorry about it.
> On Jun 14, 2016, at 4:51 PM, Rafael Espíndola
> wrote:
>
> Looks like this broke the docs:
> http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/14690/steps/docs-clang-html/logs/stdio
>
> Cheers,
> Rafael
>
>
> On 14 June
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272656: Add loop pragma for Loop Distribution (authored by
anemet).
Changed prior to commit:
http://reviews.llvm.org/D19403?vs=55445&id=60665#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19403
Author: anemet
Date: Tue Jun 14 07:04:26 2016
New Revision: 272656
URL: http://llvm.org/viewvc/llvm-project?rev=272656&view=rev
Log:
Add loop pragma for Loop Distribution
Summary:
This is similar to other loop pragmas like 'vectorize'. Currently it
only has state values: distribute(enable) and d
anemet added a comment.
Thanks, Aaron!
http://reviews.llvm.org/D19403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
anemet added a comment.
Ping^3
http://reviews.llvm.org/D19403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
anemet added a comment.
Ping.
(I am getting a bit concerned that because this was already marked accepted, it
does not show up @rsmith' active queue...)
http://reviews.llvm.org/D19403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
anemet added a comment.
@rsmith, hi! Do you have any comments on this or you're OK with this per
Aaron's LGTM?
Thanks,
Adam
http://reviews.llvm.org/D19403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
anemet added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:734-737
@@ +733,6 @@
+
+ OS << llvm::format_decimal(L + 1, LNDigits) << " ";
+ OS << (LLI.Inlined.Transformed && InlinedCols < 2 ? "I" : " ");
+ OS << (LLI.Unrolled.Transformed && UnrolledCols <
anemet updated this revision to Diff 55445.
anemet added a comment.
A little tweak to the example to make it clear that 'i' is the induction
variable
http://reviews.llvm.org/D19403
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticParseKinds.td
anemet updated this revision to Diff 55439.
anemet added a comment.
Added more context to the documentation per Aaron's comments.
http://reviews.llvm.org/D19403
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticParseKinds.td
lib/CodeGen/CGLoopI
anemet added inline comments.
Comment at: docs/LanguageExtensions.rst:2161
@@ +2160,3 @@
+
+ #pragma clang loop distribute(enable)
+ for(...) {
aaron.ballman wrote:
> It would be nice to use a more compelling example than an empty for loop.
> Also, it would be
anemet created this revision.
anemet added reviewers: aaron.ballman, rsmith.
anemet added subscribers: hfinkel, cfe-commits.
This is similar to other loop pragmas like 'vectorize'. Currently it
only has state values: distribute(enable) and distribute(disable). When
one of these is specified the
anemet added a comment.
> How did you build povray?
> can you show me your command line in building (for example, csg.cpp) for
> both--fprofile-instr-use and -fprofile-instr-generate?
Sent it in an email.
http://reviews.llvm.org/D18624
___
cfe
anemet added a comment.
Rong, do you have full paths or just the filename?
http://reviews.llvm.org/D18624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
anemet added a comment.
Still does not to work. The metadata has the full path for the file while the
prof data only has the filename.
FTR, I applied this and the ICP patch on top of r266465.
http://reviews.llvm.org/D18624
___
cfe-commits mailing
Author: anemet
Date: Tue Apr 19 17:29:24 2016
New Revision: 266829
URL: http://llvm.org/viewvc/llvm-project?rev=266829&view=rev
Log:
[Parse] Reuse OptionUnroll rather than matching it again. NFC
Modified:
cfe/trunk/lib/Parse/ParsePragma.cpp
Modified: cfe/trunk/lib/Parse/ParsePragma.cpp
URL:
Author: anemet
Date: Tue Apr 19 17:17:45 2016
New Revision: 266827
URL: http://llvm.org/viewvc/llvm-project?rev=266827&view=rev
Log:
[Parse] Use StringSwitch to improve readability. NFC
A subsequent patch will propose a "distribute" loop hint. Similarly to
unroll, this does not have a "assume_sa
anemet added a comment.
Sure, I'll try.
Also sounds like you are missing a test in this patch that fails with the old
version but passes with the new?!
http://reviews.llvm.org/D18624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
anemet added a comment.
Thanks, the indirect call is via the All_Intersections macro in
All_CSG_Intersect_Intersections and the top targets are:
All_Sphere_Intersections and All_Plane_Intersections.
http://reviews.llvm.org/D18624
___
cfe-commits m
anemet added a comment.
As discussed under http://reviews.llvm.org/D17864, I did a run with this and I
don't get the indirect call promoted that calls static functions in povray. I
will dig more but do I need to pass some extra flag?
http://reviews.llvm.org/D18624
anemet added a comment.
The summary of commits:
llvm: http://reviews.llvm.org/rL264678
compiler-rt: http://reviews.llvm.org/rL264680
clang: http://reviews.llvm.org/rL264681
Repository:
rL LLVM
http://reviews.llvm.org/D18489
___
cfe-commits maili
Author: anemet
Date: Mon Mar 28 17:18:53 2016
New Revision: 264681
URL: http://llvm.org/viewvc/llvm-project?rev=264681&view=rev
Log:
[PGO] More comments how function pointers for indirect calls are mapped
to function names
Summary:
Hopefully this will make it easier for the next person to figure
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264678: [PGO] More comments how function pointers for
indirect calls are mapped (authored by anemet).
Changed prior to commit:
http://reviews.llvm.org/D18489?vs=51713&id=51845#toc
Repository:
rL LLVM
anemet accepted this revision.
anemet added a reviewer: anemet.
anemet added a comment.
This revision is now accepted and ready to land.
Was accepted by davidxl.
http://reviews.llvm.org/D18489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
1 - 100 of 108 matches
Mail list logo
