[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

2023-08-23 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I will revert this for now, as this change broke Darwin CI: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/37169/ Clang.Tooling.clang-check-mac-libcxx-abspath.cpp Clang.Tooling.clang-check-mac-libcxx-relpath.cpp @ldionne has a patch for these

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

2023-05-22 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:431 + // libc++.dylib in the toolchain. + if ((!Args.hasArg(options::OPT_nostdinc, options::OPT_nostdlibinc, +options::OPT_nostdincxx)) && ldionne wrote: >

[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

2023-03-28 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. How is this attribute going to handle a trampoline that performs a virtual dispatch from C++ call into Swift? In that case, the target is not known. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-02-23 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b37e48f6f0: [clang] extend external_source_symbol attribute with USR clause (authored by arphaman). Herald added a project: clang. Changed prior

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-02-06 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 495202. arphaman added a comment. updated test file with correct version check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Attr.td

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-02-06 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 495165. arphaman added a comment. - Updated version to be the date. - Updated release notes. - Fixed a bug in my changed tablegen code in previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-31 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @erichkeane ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-24 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety") ==

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-24 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 491865. arphaman added a comment. updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-20 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety") ==

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-19 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:962 + let Spellings = [Clang<"external_source_symbol", /*allowInC=*/1, + /*version=*/2>]; let Args = [StringArgument<"language", 1>, erichkeane wrote: > For

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-19 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 490547. arphaman added a comment. Updated `__has_attribute(attribute_external_source_symbol)` to return a version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files:

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-18 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > arphaman wrote: > > >

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-18 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > I don't think we can

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-18 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @erichkeane I've added more test coverage with different USR values, C++ decls and some dependent C++ decls too. How does it look now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-18 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 490214. arphaman added a comment. add more test coverage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-18 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I posted the Swift patch here: https://github.com/apple/swift/pull/63002 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing list

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-10 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D141324#4039629 , @erichkeane wrote: > I'm disturbed that the string-literal diagnostic you changed never shows up > in the tests. I suspect this attribute needs significantly better test > coverage. Please elaborate.

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-10 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 487944. arphaman marked 3 inline comments as done. arphaman added a comment. Herald added a subscriber: jdoerfert. Updated to address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

2023-01-09 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: bnbarham, ravikandhadai. Herald added a subscriber: ributzka. Herald added a reviewer: aaron.ballman. Herald added a project: All. arphaman requested review of this revision. Allow the user to specify a concrete USR in the

[PATCH] D127442: [Sema] Fix a bug where clang doesn't detect uses of unavailable decls in C++ base or member initializers

2022-12-19 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127442/new/ https://reviews.llvm.org/D127442

[PATCH] D139938: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

2022-12-13 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139938/new/ https://reviews.llvm.org/D139938

[PATCH] D131858: [clang] Track the templated entity in type substitution.

2022-12-09 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Ping @mizvekov. Unfortunately I'm unable to revert this commit now so we won't be able to get the bot back to green until it's fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/

[PATCH] D131858: [clang] Track the templated entity in type substitution.

2022-11-29 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Herald added a reviewer: njames93. Hi @mizvekov. This change has caused a failure in Clang's stage 2 CI on the green dragon Darwin CI: https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console. Assertion failed: (lvaluePath->getType() == elemTy &&

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

2022-11-17 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, this LGTM. You might want to get another reviewers approval as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

2022-11-16 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:69 + if (PA.isGNUAttribute()) +Diag(PA.getLoc(), diag::err_objc_unexpected_attr); + } I think it might be better to still report this error at the location of the `@` token

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-11-10 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/ https://reviews.llvm.org/D136844 ___ cfe-commits mailing list

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

2022-10-12 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, this looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135729/new/ https://reviews.llvm.org/D135729

[PATCH] D126332: [clang] Fix the begin location of concepts specialization expression

2022-05-25 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79e09af1d6e1: [clang] Fix the begin location of concepts specialization expression (authored by arphaman). Herald added a project: clang. Herald

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

2022-05-24 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Marked them as unsupported on AIX in 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

2022-05-24 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @Jake-Egan I'm going to disable these tests for `aix` for now to unblock the bot as they're still failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

2022-05-24 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @Jake-Egan Do you happen to have suggestions for how to try to reproduce this? Looking at the failure it looks like this CI job somehow was unable to be affected by this change, for instance the CI output of `index-concept-kind.cpp` does not have any concepts output:

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

2022-05-24 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Sure, investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

2022-05-24 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee8524087c78: [libclang] add supporting for indexing/visiting C++ concepts (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

2022-05-23 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 431506. arphaman added a comment. Herald added a project: clang. Fix the windows test failure (add -fno-delayed-template-parsing) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

2022-05-23 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Yes, I'm going to check what's wrong with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

2022-05-19 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: egorzhdan, jansvoboda11, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. arphaman requested review of this revision. This patch builds upon recently added indexing support for C++ concepts from

[PATCH] D121911: [Clang] Add DriverKit support

2022-05-12 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a subscriber: NoQ. arphaman added a comment. This revision is now accepted and ready to land. Herald added a subscriber: MaskRay. LGTM, with one request. Can you please take the static analyzer changes (RetainSummaryManager.h/cpp) and make them

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

2022-04-18 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Great, thanks for adding the test case! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122691/new/ https://reviews.llvm.org/D122691

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

2022-04-13 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. The change itself LGTM. It would be really good if we can have a unit test that tests the new API when it lands, to ensure that this is tested in LLVM-project itself , in addition to Swift. Do you think it's possible to write a unit tests that constructs a compiler

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

2022-03-21 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. `clang -x objective-c++ -Weverything -std=c++14 -c test.mm` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121748/new/ https://reviews.llvm.org/D121748 ___ cfe-commits mailing

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

2022-03-21 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I don't think this patch is sound. I found this problem with this change when the following file is compiled in Objective-C++ mode: template T umax(T a, T b) { return a; } produces this error: test.mm:3:3: error: declaration of 'umax' shadows template

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

2022-03-17 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I see, thanks! Let me think a bit more about this change and test it on our codebase to see if this is a viable Sema change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121748/new/ https://reviews.llvm.org/D121748

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

2022-03-15 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Is there a way this can be tested from Clang? Also, is there a Swift-based test case you have that demonstrates the original problem from Swift's clang importer side? I'm curious to see where it manifests in Swift. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

2022-02-22 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf5153d9e7262: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst… (authored by arphaman). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Changed

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

2022-02-22 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. No, I will land it today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118875/new/ https://reviews.llvm.org/D118875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

2022-02-15 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:686 +return; + if (!StringRef(GlobalRemapEntry).contains('=')) +D.Diag(diag::err_drv_invalid_argument_to_option) Suggestion: It might be good to factor out the code that

[PATCH] D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands

2022-02-14 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D118862#3321343 , @gulfem wrote: > The following two tests started failing in our bots: > > Clang :: Driver/darwin-ld-platform-version-target-version.c > Clang :: Driver/darwin-zippered-target-version.c > >

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

2022-02-14 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 408621. arphaman added a comment. Add checking for -darwin-target-variant support CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118875/new/ https://reviews.llvm.org/D118875 Files: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

2022-02-14 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D118875#3296030 , @bc-lee wrote: > Hi, I built and tested clang using this patch and > https://reviews.llvm.org/D118862. It works great. > The current patch adds the -darwin-target-variant flag to all object files > for

[PATCH] D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands

2022-02-14 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd238acd1131e: [clang][driver] add clang driver support for emitting macho files with two… (authored by arphaman). Changed prior to commit:

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

2022-02-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Revert: To github.com:llvm/llvm-project.git bdf573652138..3f05192c4c40 main -> main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

2022-02-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Yep, I just noticed. Reverting for now and will fix LLDB before recommitting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

2022-02-11 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d9b91524ea4: [Preprocessor] Reduce the memory overhead of `#define` directives (authored by arphaman). Herald added a project: clang. Repository:

[PATCH] D119226: [clang][lex][minimizer] Avoid treating path separators as comments

2022-02-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Cheers, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119226/new/ https://reviews.llvm.org/D119226

[PATCH] D119231: [clang][lex][minimizer] Ensure whitespace between squashed lines

2022-02-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119231/new/ https://reviews.llvm.org/D119231

[PATCH] D115403: [clang][driver] update the darwin driver to point to correct macho_embedded path

2022-02-07 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb58bf76f97f4: [clang][driver] update the darwin driver to point to correct macho_embedded path (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

2022-02-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: ravikandhadai, dexonsmith. Herald added subscribers: ributzka, mgorny, dberris. arphaman requested review of this revision. This patch extends compiler-rt's cmake config to build macOS builtins with both macOS and Mac Catalyst support.

[PATCH] D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands

2022-02-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: ravikandhadai, egorzhdan, dexonsmith, steven_wu. Herald added subscribers: dang, ributzka. arphaman requested review of this revision. Herald added a project: clang. This patch extends clang driver to pass the right flags to the clang

[PATCH] D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token

2022-02-02 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG979d0ee8ab30: [clang] fix out of bounds access in an empty string when lexing a _Pragma with… (authored by arphaman). Repository: rG LLVM Github

[PATCH] D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands

2022-02-02 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG116c1bea65ac: [clang][macho] add clang frontend support for emitting macho files with two… (authored by arphaman). Herald added a project: clang.

[PATCH] D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token

2022-02-01 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 405155. arphaman added a reviewer: egorzhdan. arphaman added a comment. Fix test failure with asserts enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116052/new/ https://reviews.llvm.org/D116052 Files:

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

2022-02-01 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { aaron.ballman wrote: > dexonsmith wrote: > > aaron.ballman wrote:

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

2022-02-01 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 405103. arphaman marked 4 inline comments as done. arphaman added a comment. Update to address review feedback, remove `appendToken` which is not needed as we're can just `setTokens` instead (it's a new macro info) CHANGES SINCE LAST ACTION

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

2022-02-01 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Thanks, that feedback makes sense. I'll update the patch today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

2022-01-14 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: ravikandhadai, egorzhdan, aaron.ballman, rsmith. Herald added subscribers: ributzka, kristof.beyls, mgorny. arphaman requested review of this revision. Recently we observed high memory pressure caused by clang during some parallel builds.

[PATCH] D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability

2022-01-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with one comment. This is great, thanks! Comment at: clang/test/Sema/attr-availability-tvos.c:66 + +#ifdef USE_VERSION_MAP +// iOS 9.3 corresponds to tvOS 9.2, as

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

2022-01-10 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116412/new/ https://reviews.llvm.org/D116412

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

2022-01-05 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG809c6a5a1d2f: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS (authored by egorzhdan, committed by arphaman). Repository:

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

2022-01-05 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116615/new/ https://reviews.llvm.org/D116615

[PATCH] D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS

2022-01-04 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Thanks! I think your tests don't actually test the added code, can you check if you can parse a mapping like `ios_tvos` in the constructed SDK settings? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116615/new/

[PATCH] D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties

2022-01-04 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I think we would still want to diagnose any mismatches between `class` properties that override a `class` property in the superclass. do you think that would be useful? You can adjust the lookup to take that into account. Repository: rG LLVM Github Monorepo

[PATCH] D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token

2021-12-20 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: ravikandhadai, yln, bro4all. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. The lexer can attempt to lex a _Pragma and crash with an out of bounds string access when it's

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-12-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded)

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-12-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded)

[PATCH] D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands

2021-12-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: ravikandhadai, dexonsmith, steven_wu. Herald added subscribers: dang, ributzka, hiraditya. arphaman requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This patch extends clang frontend

[PATCH] D115403: [clang][driver] update the darwin driver to point to correct macho_embedded path

2021-12-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: bro4all, Ericson2314, ravikandhadai. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. Compiler-rt started emitting the macho_embedded libraries in /lib/darwin/macho_embedded

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

2021-12-06 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. This looks good to me! I agree, an `enum class` would be cleaner though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114971/new/

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D114968#3168123 , @dexonsmith wrote: > In D114968#3167519 , @jansvoboda11 > wrote: > >> Assuming the filesystem doesn't change during dependency scanning, this >> change keeps the

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

2021-11-29 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Sorry for delay, this LGTM. Thanks for doing this cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

2021-11-19 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG290cddcd139d: Allow __attribute__((swift_attr)) in attribute push pragmas (authored by beccadax, committed by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

2021-11-19 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I will commit this on behalf of @beccadax as she doesn't have commit access yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112773/new/ https://reviews.llvm.org/D112773 ___

[PATCH] D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

2021-11-05 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa00944ebeab1: [clang] unused-but-set-variable warning should not apply to __block objective… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

2021-10-29 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: ravikandhadai, ahatanak, mbenfield. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. The `__block` Objective-C pointers can be set but not used due to a commonly used lifetime

[PATCH] D109402: Make 'align-mismatch' warning work without an associated function declaration

2021-10-29 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa43d1aa85256: [clang] Make align-mismatch warning work without an associated function… (authored by arphaman). Herald added a project: clang.

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

2021-10-28 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Looks good to me. Can you post the patch with the full context next time so that it's easier to review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

2021-09-20 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded)

[PATCH] D109402: Make 'align-mismatch' warning work without an associated function declaration

2021-09-07 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: tmatheson, ravikandhadai. Herald added a subscriber: ributzka. arphaman requested review of this revision. This change fixes a crash where a NULL fd was used to emit a diagnostic. Instead of crashing, just avoid printing the declaration

[PATCH] D108982: [clang][deps] Use correct DiagnosticOptions for command-line handling

2021-09-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108982/new/ https://reviews.llvm.org/D108982 ___ cfe-commits mailing list

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

2021-09-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D108976#2979867 , @arphaman wrote: > Could you add a test case for this change? Maybe a unit test? Ah I see, you mentioned that the tests are in a follow-up patch. Sorry about that. Repository: rG LLVM Github Monorepo

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

2021-09-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Could you add a test case for this change? Maybe a unit test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108976/new/ https://reviews.llvm.org/D108976 ___ cfe-commits mailing

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

2021-08-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106864/new/ https://reviews.llvm.org/D106864 ___ cfe-commits mailing list

[PATCH] D106316: [clang][darwin] Add support for the -mtargetos= option to the driver

2021-08-02 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf575f371822f: [clang][darwin] Add support for the -mtargetos= option to the driver (authored by arphaman). Herald added a project: clang.

[PATCH] D106862: [clang][modules] Avoid creating partial FullSourceLoc for explicit modules imports

2021-07-29 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. I think this approach makes sense for now. It's unfortunate that the constructor of FullSourceLoc is unable to validate this requirement, do you know how many clients that you describe as

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

2021-07-29 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: clang/test/Modules/cxx20-disable.cpp:2 +// RUN: rm -rf %t && mkdir %t +// RUN: not %clang_cc1 -x objective-c++ -std=c++20 -fno-cxx-modules -I %t %s + jansvoboda11 wrote: > I'm not sure how to best test this. Checking

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I think this should be fixed in 40d2d0c41298f1d8a178216e2534b29e3128cf37 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105960/new/

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. I think this should be fixed if I add `-fuse-ld=` to the invocation. Let me commit that fix to see if it's fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105960/new/ https://reviews.llvm.org/D105960

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D105960#2897245 , @leonardchan wrote: > Hi. I think this patch may have led to the test failure we're seeing on our > clang builders >

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

2021-07-22 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2542c1a5a130: [clang][driver][darwin] Add driver support for Mac Catalyst (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

2021-07-21 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb26ba9da8ae: [clang][darwin] add support for remapping macOS availability to Mac Catalyst… (authored by arphaman). Changed prior to commit:

  1   2   3   4   5   6   7   8   9   10   >