a.makarov added a comment.
Richard, thank you very much! =)
https://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.makarov added a comment.
Friendly ping!
https://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.makarov added a comment.
Ping.
http://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.makarov added a reviewer: rnk.
a.makarov added a comment.
Reid, please, take a look.
http://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.makarov added a comment.
Ping.
http://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.makarov created this revision.
a.makarov added a reviewer: rsmith.
a.makarov added a subscriber: cfe-commits.
It's a patch for PR28050. Seems like overloading resolution wipes out the first
standard conversion sequence (before user-defined conversion) in case of
deprecated string literal
a.makarov updated this revision to Diff 57344.
a.makarov added a comment.
I've updated the patch. Please take a look.
http://reviews.llvm.org/D20171
Files:
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/clang/Driver/CC1Options.td
a.makarov updated this revision to Diff 57071.
a.makarov added a comment.
Renamed option 'DefaultMSCallingConv' into 'DefaultCallingConv' and enum
'DefaultMSCallingConvention' into 'DefaultCallingConvention'.
http://reviews.llvm.org/D20171
Files:
include/clang/Basic/LangOptions.def
a.makarov updated this revision to Diff 57062.
a.makarov added a comment.
Thanks for the review! I've updated the patch, please take a look.
Modifications:
- the dependency from MS compatibility mode is removed;
- the option is renamed into '-fdefault-calling-conv' (since it's not in MS
a.makarov added inline comments.
Comment at: lib/AST/ASTContext.cpp:8616-8619
@@ +8615,6 @@
+ return CC_C;
+case LangOptions::DCC_FastCall:
+ return CC_X86FastCall;
+case LangOptions::DCC_StdCall:
+ return CC_X86StdCall;
+case
a.makarov added inline comments.
Comment at: lib/AST/ASTContext.cpp:8604-8606
@@ -8603,5 +8603,5 @@
bool IsCXXMethod) const {
// Pass through to the C++ ABI object
if (IsCXXMethod)
return
a.makarov created this revision.
a.makarov added a reviewer: rnk.
a.makarov added a subscriber: cfe-commits.
Patch for bug #27711
http://reviews.llvm.org/D20171
Files:
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/clang/Driver/CC1Options.td
a.makarov added a comment.
Richard, Reid, please take a look.
http://reviews.llvm.org/D15373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.makarov added a comment.
Ping
http://reviews.llvm.org/D15373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.makarov updated this revision to Diff 45179.
a.makarov added a comment.
Oops, forgot to drop svn properties. Done. Sorry for noise.
http://reviews.llvm.org/D15373
Files:
lib/Sema/SemaType.cpp
test/CodeGen/pr25786.c
test/Sema/pr25786.c
Index: lib/Sema/SemaType.cpp
a.makarov updated this revision to Diff 45178.
a.makarov added a comment.
I've updated the patch. Now, I've updated the function unwrapping mechanism to
work properly with AttributedType.
Please, re-review the patch.
http://reviews.llvm.org/D15373
Files:
lib/Sema/SemaType.cpp
a.makarov added a comment.
Thanks for review! I've understood your idea, I'm working on updating the patch.
http://reviews.llvm.org/D15373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
a.makarov added a comment.
Ping
http://reviews.llvm.org/D15373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.makarov updated this revision to Diff 43442.
a.makarov added a comment.
Actual updated patch. Sorry for noise.
http://reviews.llvm.org/D15373
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaType.cpp
test/CodeGen/adding_defaulted_cc_attr_to_type.c
a.makarov updated this revision to Diff 43440.
a.makarov added a comment.
I've updated the patch. Please, re-review it again.
About creating attributed type - I think we shouldn't create it if we ignored
specified CC attribute. Ignoring specified CC attribute (and emitting the
warning, of
a.makarov created this revision.
a.makarov added reviewers: aaron.ballman, rsmith.
a.makarov added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
This patch is to avoid attaching the calling convention attribute to the result
type if this attribute was ignored and
21 matches
Mail list logo
