[PATCH] D92244: [OpenCL] Prevent adding vendor extensions for all targets

AlexeySotkin accepted this revision. AlexeySotkin added a comment. This revision is now accepted and ready to land. LGTM, Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92244/new/ https://reviews.llvm.org/D92244 ___ cfe-commits

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin added a comment. Is there any chance to get this commit cherry-picked to 10.x branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 ___

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

This revision was automatically updated to reflect the committed changes. AlexeySotkin marked an inline comment as done. Closed by commit rGf780e15caf1b: [OpenCL] Fix support for cl_khr_mipmap_image_writes (authored by AlexeySotkin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin marked 2 inline comments as done. AlexeySotkin added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin updated this revision to Diff 240510. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Headers/opencl-c.h clang/test/SemaOpenCL/extension-version.cl Index:

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin updated this revision to Diff 234674. AlexeySotkin added a comment. Rename `color` to `depth` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Headers/opencl-c.h

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin added a comment. In D71460#1783390 , @asavonic wrote: > What about `get_image_num_mip_levels` functions defined in the extension > specification? > > Edit: I mean, should the `get_image_num_mip_levels(write_only img)` function > be only

[PATCH] D71272: [OpenCL] Pretty print __private addr space

AlexeySotkin added inline comments. Comment at: clang/test/SemaOpenCL/access-qualifier.cl:28 kernel void k1(img1d_wo img) { - myRead(img); // expected-error {{passing 'img1d_wo' (aka '__write_only image1d_t') to parameter of incompatible type '__read_only image1d_t'}} +

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, svenvh, yaxunl, asavonic. Herald added a project: clang. Herald added a subscriber: cfe-commits. Patch by Ilya Mashkov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71460 Files:

[PATCH] D71272: [OpenCL] Pretty print __private addr space

AlexeySotkin added inline comments. Comment at: clang/test/SemaOpenCL/access-qualifier.cl:28 kernel void k1(img1d_wo img) { - myRead(img); // expected-error {{passing 'img1d_wo' (aka '__write_only image1d_t') to parameter of incompatible type '__read_only image1d_t'}} +

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

AlexeySotkin added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:298-302 +def write_imagef : Builtin<"write_imagef", +[void_t, + image2d_WO_t, + VectorType, +

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

AlexeySotkin added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:298-302 +def write_imagef : Builtin<"write_imagef", +[void_t, + image2d_WO_t, + VectorType, +

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

AlexeySotkin added a comment. LGTM! @joey, any idea when it will be landed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53023/new/ https://reviews.llvm.org/D53023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59985: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

This revision was automatically updated to reflect the committed changes. Closed by commit rL358151: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of… (authored by AlexeySotkin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D59985: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin updated this revision to Diff 194098. AlexeySotkin retitled this revision from "Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function" to "[OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin added a comment. In D59985#1454676 , @Anastasia wrote: > In D59985#1454660 , @AlexeySotkin > wrote: > > > In D59985#1454629 , @Anastasia > > wrote: > > > > >

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin added a comment. In D59985#1454629 , @Anastasia wrote: > In D59985#1453312 , @AlexeySotkin > wrote: > > > Alternative way to fix it is to use `isNullPointerConstant` like we do in > >

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin added a comment. Alternative way to fix it is to use `isNullPointerConstant` like we do in `SemaOpenCLBuiltinEnqueueKernel`. So in case we have a zero literal value we can emit `ConstantPointerNull` directly, without `EmitScalarExpr` . Repository: rC Clang CHANGES SINCE LAST

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + :

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + :

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + :

[PATCH] D53809: Fix invalid address space generation for clk_event_t

AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3614 + ClkEvent = ClkEvent->getType()->isIntegerTy() + ? Builder.CreateBitOrPointerCast(ClkEvent, EventPtrTy) + : Builder.CreatePointerCast(ClkEvent, EventPtrTy);

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, yaxunl. Herald added subscribers: cfe-commits, ebevhan, kristina. Herald added a project: clang. https://reviews.llvm.org/D53809 fixed wrong address space(assert in debug build) generated for `event_ret` argument. But

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

AlexeySotkin added inline comments. Comment at: docs/ReleaseNotes.rst:228 -OpenCL C Language Changes in Clang +OpenCL Language Changes in Clang -- AlexeySotkin wrote: > Why the "C" is removed ? Should we call the section like:

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

AlexeySotkin added inline comments. Comment at: docs/ReleaseNotes.rst:228 -OpenCL C Language Changes in Clang +OpenCL Language Changes in Clang -- Why the "C" is removed ? CHANGES SINCE LAST ACTION

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:131 +static const BlockExpr *getBlockExpr(const Expr *E) { + if (auto Cast = dyn_cast(E)) { +E = Cast->getSubExpr(); Anastasia

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin updated this revision to Diff 187575. AlexeySotkin added a comment. Fix resolving of block invoke function in case of sequence of assignments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58388/new/ https://reviews.llvm.org/D58388 Files: lib/CodeGen/CGBlocks.cpp

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin updated this revision to Diff 187399. AlexeySotkin added a comment. Fix ObjC lit tests failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58388/new/ https://reviews.llvm.org/D58388 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGOpenCLRuntime.cpp

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, yaxunl, svenvh. AlexeySotkin added a project: clang. Emit direct call of block invoke functions when possible, i.e. in case the block is not passed as a function argument. Also doing some refactoring of

[PATCH] D58277: [OpenCL] Change type of block pointer for OpenCL

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, yaxunl, svenvh. Herald added a project: clang. For some reason OpenCL blocks in LLVM IR are represented as function pointers. These pointers do not point to any real function and never get called. Actually they point to

[PATCH] D53809: Fix invalid address space generation for clk_event_t

This revision was automatically updated to reflect the committed changes. Closed by commit rC346838: [OpenCL] Fix invalid address space generation for clk_event_t (authored by AlexeySotkin, committed by ). Repository: rC Clang https://reviews.llvm.org/D53809 Files:

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySotkin added inline comments. Herald added a reviewer: shafik. Comment at: lib/Sema/SemaInit.cpp:8073 + assert((Step->Type->isEventT() || Step->Type->isQueueT() || + Step->Type->isOCLIntelSubgroupAVCType) && "Wrong type for initialization of

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

AlexeySotkin added a comment. In https://reviews.llvm.org/D43783#1215573, @Anastasia wrote: > In https://reviews.llvm.org/D43783#1212485, @yaxunl wrote: > > > In https://reviews.llvm.org/D43783#1204353, @svenvh wrote: > > > > > Sorry for digging up an old commit... > > > > > > Apparently this

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySotkin added a comment. Ping https://reviews.llvm.org/D51484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySotkin added inline comments. Comment at: include/clang/Basic/OpenCLExtensionTypes.def:27 + +INTEL_SGAVC_TYPE(mce_payload_t, McePayload) +INTEL_SGAVC_TYPE(ime_payload_t, ImePayload) Anastasia wrote: > AlexeySachkov wrote: > > Anastasia wrote: > > > From

[PATCH] D51296: [OpenCL] Traverse vector types for ocl extensions support

This revision was automatically updated to reflect the committed changes. Closed by commit rL341309: [OpenCL] Traverse vector types for ocl extensions support (authored by AlexeySotkin, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D49725: [OpenCL] Forbid size dependent types used as kernel arguments

AlexeySotkin added a comment. In https://reviews.llvm.org/D49725#1183316, @aaron.ballman wrote: > FYI: @asavonic, the email address you have associated with your commit id is > `AlexeySotkin@/etc/mailname` which is getting stuck in the moderation queue > as not being signed up to the mailing

[PATCH] D49725: [OpenCL] Forbid size dependent types used as kernel arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL338432: [OpenCL] Forbid size dependent types used as kernel arguments (authored by AlexeySotkin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D49723: [OpenCL] Check for invalid kernel arguments in array types

This revision was automatically updated to reflect the committed changes. Closed by commit rC338427: [OpenCL] Check for invalid kernel arguments in array types (authored by AlexeySotkin, committed by ). Changed prior to commit: https://reviews.llvm.org/D49723?vs=157688=158365#toc Repository:

[PATCH] D46015: [OpenCL] Add separate read_only and write_only pipe IR types

AlexeySotkin added a comment. In https://reviews.llvm.org/D46015#1078317, @stuart wrote: > In https://reviews.llvm.org/D46015#1078260, @AlexeySotkin wrote: > > > In https://reviews.llvm.org/D46015#1078235, @stuart wrote: > > > > > In https://reviews.llvm.org/D46015#1078217, @AlexeySotkin wrote:

[PATCH] D46015: [OpenCL] Add separate read_only and write_only pipe IR types

AlexeySotkin added a comment. In https://reviews.llvm.org/D46015#1078235, @stuart wrote: > In https://reviews.llvm.org/D46015#1078217, @AlexeySotkin wrote: > > > There should not be need for bitcast. Could give an example ? Thanks. > > > If I have a `write_only` pipe as the argument to

[PATCH] D46015: [OpenCL] Add separate read_only and write_only pipe IR types

AlexeySotkin added a comment. There should not be need for bitcast. Could give an example ? Thanks. https://reviews.llvm.org/D46015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46015: [OpenCL] Add separate read_only and write_only pipe IR types

AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.h:65 virtual llvm::Type *getPipeType(const PipeType *T); + virtual llvm::Type *getPipeType(const PipeType *T, StringRef Name, + llvm::Type *); I'm

[PATCH] D46015: [OpenCL] Add separate read_only and write_only pipe IR types

AlexeySotkin added a comment. It is not clear why we need two versions of get_pipe_num_packets and get_pipe_max_packets builtins. There is only one instruction per builtin in the SPIR-V spec. I think splitting the IR type is enough for translation to SPIR-V purposes. Repository: rC Clang

[PATCH] D45808: [OpenCL] Add 'denorms-are-zero' function attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL330404: [OpenCL] Add denorms-are-zero function attribute (authored by AlexeySotkin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45808 Files:

[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

This revision was automatically updated to reflect the committed changes. Closed by commit rC326566: Add possibility to specify output stream for CompilerInstance (authored by AlexeySotkin, committed by ). Changed prior to commit: https://reviews.llvm.org/D43809?vs=136252=136715#toc

[PATCH] D43570: [OpenCL] Add '-cl-uniform-work-group-size' compile option

This revision was automatically updated to reflect the committed changes. Closed by commit rL325771: [OpenCL] Add -cl-uniform-work-group-size compile option (authored by AlexeySotkin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43570

[PATCH] D39936: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short

AlexeySotkin added a comment. https://reviews.llvm.org/D39936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39936: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short

AlexeySotkin updated this revision to Diff 123716. AlexeySotkin added a comment. Replacing #define macros with explicit declarations https://reviews.llvm.org/D39936 Files: include/clang/Basic/OpenCLExtensions.def lib/Headers/opencl-c.h test/SemaOpenCL/extension-version.cl Index:

[PATCH] D39936: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short

AlexeySotkin created this revision. https://reviews.llvm.org/D39936 Files: include/clang/Basic/OpenCLExtensions.def lib/Headers/opencl-c.h test/SemaOpenCL/extension-version.cl Index: test/SemaOpenCL/extension-version.cl ===

[PATCH] D35420: [OpenCL] Fix access qualifiers metadata for kernel arguments with typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rL309155: [OpenCL] Fix access qualifiers metadata for kernel arguments with typedef (authored by AlexeySotkin). Repository: rL LLVM https://reviews.llvm.org/D35420 Files:

[PATCH] D35420: [OpenCL] Fix access qualifiers metadata for kernel arguments with typedef

AlexeySotkin updated this revision to Diff 108334. AlexeySotkin added a comment. Rebasing on tip of trank https://reviews.llvm.org/D35420 Files: lib/CodeGen/CodeGenFunction.cpp test/CodeGenOpenCL/kernel-arg-info.cl Index: test/CodeGenOpenCL/kernel-arg-info.cl

[PATCH] D35420: [OpenCL] Fix access qualifiers metadata for kernel arguments with typedef

AlexeySotkin updated this revision to Diff 107044. AlexeySotkin added a comment. Changing case in the variable name https://reviews.llvm.org/D35420 Files: lib/CodeGen/CodeGenFunction.cpp test/CodeGenOpenCL/kernel-arg-info.cl Index: test/CodeGenOpenCL/kernel-arg-info.cl