[clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-03-13 Thread Amy Huang via cfe-commits
amykhuang wrote: I looked at this a bit and the change that increases the constexpr restrictions is that `ext_defaulted_comparison_constexpr_mismatch` (which was added in https://reviews.llvm.org/D146090) became `err_incorrect_defaulted_comparison_constexpr`?

[clang] Reapply "[Clang][C++23] Implement P2448R2 ..." (#85136) (PR #85145)

2024-03-13 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/85145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-03-13 Thread Amy Huang via cfe-commits
amykhuang wrote: Whoops, not very familiar with git pull requests, I guess. actually reapplying the commit now https://github.com/llvm/llvm-project/pull/77753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Reapply "[Clang][C++23] Implement P2448R2 ..." (#85136) (PR #85145)

2024-03-13 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/85145 This reverts commit 003e292f9895a9cf4e30688269efa668d1fcbb09 because there were dependent changes in the codebase that now fail. >From d8f21288633aefd1528133ccdf46c5dc790e4f1f Mon Sep 17 00:00:00 2001 From:

[clang] Unrevert "[Clang][C++23] Implement P2448R2: Relaxing some constexpr re… (PR #85140)

2024-03-13 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/85140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-03-13 Thread Amy Huang via cfe-commits
amykhuang wrote: Nevermind, unreverted since there appear to be newer tests that use this patch. https://github.com/llvm/llvm-project/pull/77753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Unrevert "[Clang][C++23] Implement P2448R2: Relaxing some constexpr re… (PR #85140)

2024-03-13 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/85140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang][C++23] Implement P2448R2 ..." (PR #85136)

2024-03-13 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/85136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-03-13 Thread Amy Huang via cfe-commits
amykhuang wrote: I'm assuming this behavior is unintended? Sorry for the late revert https://github.com/llvm/llvm-project/pull/77753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang][C++23] Implement P2448R2 ..." (PR #85136)

2024-03-13 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/85136 Revert "[Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (#77753)" This reverts commit 99500e8c08a4d941acb8a7eb00523296fb2acf7a because it causes a behavior change for std=c++20. See

[clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-03-13 Thread Amy Huang via cfe-commits
amykhuang wrote: Hi, this is causing failures for Chrome, building with c++20: ``` $ cat t.cc template class StrongAlias { friend constexpr bool operator==(const StrongAlias &, const StrongAlias &) = default; Type value; }; class Token {}; bool operator==(const Token&, const Token&);

[clang] Fix to msvc::no_unique_address causing assert when used with __declspec(empty_bases) (PR #74776)

2023-12-11 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/74776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix to msvc::no_unique_address causing assert when used with __declspec(empty_bases) (PR #74776)

2023-12-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/74776 no_unique_address makes it possible for a class to be empty and have non-zero virtual size, so just remove this assert. Bug: https://github.com/llvm/llvm-project/issues/74442 >From

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-20 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/70877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-16 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/70877 >From e24ee9cbc51d0f372c30512ce5722b2bc32e20d0 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Tue, 31 Oct 2023 16:45:17 -0700 Subject: [PATCH 1/2] Fix attribute plugins --- clang/lib/Sema/ParsedAttr.cpp | 15

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-16 Thread Amy Huang via cfe-commits
amykhuang wrote: Whoops, sorry about that, I guess I am failing to update my fork properly... https://github.com/llvm/llvm-project/pull/70877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-15 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/70877 >From 8216d6bc5329d4fcb723db14e2c503cb718cb36d Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Tue, 31 Oct 2023 16:45:17 -0700 Subject: [PATCH 1/2] Fix attribute plugins --- clang/lib/Sema/ParsedAttr.cpp | 15

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-15 Thread Amy Huang via cfe-commits
amykhuang wrote: ping for review? https://github.com/llvm/llvm-project/pull/70877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/70877 >From 18369263a3160963b943cd8574edaa212b6d0996 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Tue, 31 Oct 2023 16:45:17 -0700 Subject: [PATCH 1/2] Fix attribute plugins --- clang/lib/Sema/ParsedAttr.cpp | 15

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-07 Thread Amy Huang via cfe-commits
amykhuang wrote: Updated the PR description and the patch. The existing `clang/test/Frontend/plugin-attribute.cpp` seems sufficient for test coverage. (I guess it wasn't being tested on bots though, otherwise we would have seen it?) https://github.com/llvm/llvm-project/pull/70877

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/70877 >From 18369263a3160963b943cd8574edaa212b6d0996 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Tue, 31 Oct 2023 16:45:17 -0700 Subject: [PATCH] Fix attribute plugins --- clang/lib/Sema/ParsedAttr.cpp | 15

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/70877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-11-07 Thread Amy Huang via cfe-commits
amykhuang wrote: Huh, apparently my no-unique-address patch did break existing plugin tests (e.g. clang/test/Frontend/plugin-attribute.cpp), and this patch doesn't fix it https://github.com/llvm/llvm-project/pull/70877 ___ cfe-commits mailing list

[clang] Fix to attribute plugins reaching an unreachable (PR #70877)

2023-10-31 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/70877 [0faee97](https://github.com/llvm/llvm-project/commit/0faee97a924adec76d5c7cd680c289ced51e6b5a) made the attribute plugin code hit an unreachable. Bug:

[clang] [MSVC, ARM64] Add __prefetch intrinsic (PR #67174)

2023-10-13 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-28 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-28 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/67199 >From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 22 Sep 2023 14:40:14 -0700 Subject: [PATCH 1/4] Recommit "Implement [[msvc::no_unique_address]] (#65675)"

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-27 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/67199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-27 Thread Amy Huang via cfe-commits
amykhuang wrote: Added a section for target specific spellings in `GenerateHasAttrSpellingStringSwitch`, and a check for "existsInTarget" in `ParseCXX11AttributeArgs`, and looks like all tests are passing now. https://github.com/llvm/llvm-project/pull/67199

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-27 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/67199 >From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 22 Sep 2023 14:40:14 -0700 Subject: [PATCH 1/3] Recommit "Implement [[msvc::no_unique_address]] (#65675)"

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-27 Thread Amy Huang via cfe-commits
amykhuang wrote: hmm this passes most of the checks in SemaCXX/cxx2a-no-unique-address.cpp, but fails "attribute 'no_unique_address' cannot have an argument list". Also fails Preprocessor/has_attribute.cpp because both attributes are recognized on itanium and windows targets.

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-27 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/67199 >From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 22 Sep 2023 14:40:14 -0700 Subject: [PATCH 1/2] Recommit "Implement [[msvc::no_unique_address]] (#65675)"

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-25 Thread Amy Huang via cfe-commits
@@ -1798,11 +1798,24 @@ def ArmMveStrictPolymorphism : TypeAttr, TargetSpecificAttr { let Documentation = [ArmMveStrictPolymorphismDocs]; } -def NoUniqueAddress : InheritableAttr, TargetSpecificAttr { - let Spellings = [CXX11<"", "no_unique_address", 201803>]; +def

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-22 Thread Amy Huang via cfe-commits
amykhuang wrote: Previous commit attempt caused sphinx errors. Also, because we now have two attributes for the itanium and MSVC versions, there are two separate sections in the documentation, which I didn't realize before. https://github.com/llvm/llvm-project/pull/67199

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/67199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67199 Change the attribute docs so that there is a separate one for the MSVC attribute. This reverts commit 71f9e7695b87298f9855d8890f0e6a3b89381eb5. >From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17

[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Implement [[msvc::no_unique_address]] (#65675)" (PR #67198)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67198 This reverts commit 4a55d426967b9c70f5dea7b3a389e11393a4f4c4. Reverting because this breaks sphinx documentation, and even with it fixed the format of the attribute makes the no_unique_address documentation

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/67195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/67195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix attr docs from previous no-unique-adderss change (PR #67195)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67195 None >From d5347c906ac7db40f9b31ad0c0bcd193df453e4e Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 22 Sep 2023 13:54:28 -0700 Subject: [PATCH] Fix attr docs from previous no-unique-adderss change ---

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSVC, ARM64] Add __prefetch intrinsic (PR #67174)

2023-09-22 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/67174 Implement __prefetch intrinsic. MSVC docs: https://learn.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics?view=msvc-170 Bug: https://github.com/llvm/llvm-project/issues/65405 >From

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-21 Thread Amy Huang via cfe-commits
https://github.com/amykhuang closed https://github.com/llvm/llvm-project/pull/66554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-20 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/66554 >From de9c8618210103074e580105ce894e66dba782a9 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Thu, 7 Sep 2023 11:32:17 -0700 Subject: [PATCH 1/3] [MSVC, ARM64] Add _Copy* and _Count* intrinsics ---

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-20 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/66554 >From de9c8618210103074e580105ce894e66dba782a9 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Thu, 7 Sep 2023 11:32:17 -0700 Subject: [PATCH 1/3] [MSVC, ARM64] Add _Copy* and _Count* intrinsics ---

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-20 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/66554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-20 Thread Amy Huang via cfe-commits
@@ -10779,6 +10779,70 @@ Value *CodeGenFunction::EmitAArch64BuiltinExpr(unsigned BuiltinID, return Load; } + if (BuiltinID == AArch64::BI_CopyDoubleFromInt64 || + BuiltinID == AArch64::BI_CopyFloatFromInt32 || + BuiltinID == AArch64::BI_CopyInt32FromFloat ||

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/66554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
@@ -270,6 +269,20 @@ TARGET_HEADER_BUILTIN(__readx18word, "UsUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES, TARGET_HEADER_BUILTIN(__readx18dword, "UNiUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES, "") TARGET_HEADER_BUILTIN(__readx18qword, "ULLiUNi", "nh", INTRIN_H, ALL_MS_LANGUAGES, "")

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/66554 >From de9c8618210103074e580105ce894e66dba782a9 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Thu, 7 Sep 2023 11:32:17 -0700 Subject: [PATCH 1/3] [MSVC, ARM64] Add _Copy* and _Count* intrinsics ---

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
@@ -10779,6 +10779,70 @@ Value *CodeGenFunction::EmitAArch64BuiltinExpr(unsigned BuiltinID, return Load; } + if (BuiltinID == AArch64::BI_CopyDoubleFromInt64 || + BuiltinID == AArch64::BI_CopyFloatFromInt32 || + BuiltinID == AArch64::BI_CopyInt32FromFloat ||

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-19 Thread Amy Huang via cfe-commits
amykhuang wrote: Are there any other comments here? I think I've addressed all the existing ones. https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/65675 >From 481337fde54dc4d7f68a604952a963c99913675d Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 21 Jul 2023 16:30:30 -0700 Subject: [PATCH 1/6] Implement [[msvc::no_unique_address]] This attribute should

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-19 Thread Amy Huang via cfe-commits
amykhuang wrote: > > We should consider whether we want to support `__msvc_no_unique_address__` > > or similar as an alternative spelling #61196 > > I think `[[__msvc__::__no_unique_address__]]` would be better. This is how > the clang and gnu attributes are handled too. I'm also fine with

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/66554 >From f0375650be09359ac1a87dd7a60a9415a55cf837 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Thu, 7 Sep 2023 11:32:17 -0700 Subject: [PATCH 1/3] [MSVC, ARM64] Add _Copy* and _Count* intrinsics ---

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-19 Thread Amy Huang via cfe-commits
@@ -10752,6 +10752,68 @@ Value *CodeGenFunction::EmitAArch64BuiltinExpr(unsigned BuiltinID, return Load; } + if (BuiltinID == AArch64::BI_CopyDoubleFromInt64 || + BuiltinID == AArch64::BI_CopyFloatFromInt32 || + BuiltinID == AArch64::BI_CopyInt32FromFloat ||

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-18 Thread Amy Huang via cfe-commits
@@ -10752,6 +10752,68 @@ Value *CodeGenFunction::EmitAArch64BuiltinExpr(unsigned BuiltinID, return Load; } + if (BuiltinID == AArch64::BI_CopyDoubleFromInt64 || + BuiltinID == AArch64::BI_CopyFloatFromInt32 || + BuiltinID == AArch64::BI_CopyInt32FromFloat ||

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-15 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/66554 >From 2f18bc9802942e5fa08181026212ea711f9f16a9 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Thu, 7 Sep 2023 11:32:17 -0700 Subject: [PATCH] [MSVC, ARM64] Add _Copy* and _Count* intrinsics ---

[clang] [MSVC, ARM64] Add _Copy* and _Count* intrinsics (PR #66554)

2023-09-15 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/66554 Implement the _Count* and _Copy* Windows ARM intrinsics: ``` double _CopyDoubleFromInt64(__int64) float _CopyFloatFromInt32(__int32) __int32 _CopyInt32FromFloat(float) __int64 _CopyInt64FromDouble(double)

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-13 Thread Amy Huang via cfe-commits
@@ -55,7 +55,7 @@ CXX11(unlikely) // CHECK: likely: 201803L // CHECK: maybe_unused: 201603L // ITANIUM: no_unique_address: 201803L -// WINDOWS: no_unique_address: 0 +// WINDOWS: no_unique_address: 201803L amykhuang wrote: Tried this and the inheritance part

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-13 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/65675: >From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 21 Jul 2023 16:30:30 -0700 Subject: [PATCH 1/3] Implement [[msvc::no_unique_address]] This attribute should

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/65675: >From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 21 Jul 2023 16:30:30 -0700 Subject: [PATCH 1/3] Implement [[msvc::no_unique_address]] This attribute should

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/65675: >From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 21 Jul 2023 16:30:30 -0700 Subject: [PATCH 1/3] Implement [[msvc::no_unique_address]] This attribute should

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
@@ -4505,6 +4505,14 @@ bool FieldDecl::isZeroSize(const ASTContext ) const { if (!CXXRD->isEmpty()) return false; + // MS ABI: nonzero if class type with class type fields amykhuang wrote: As far as I can tell the cases above still apply to MSVC so I

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
@@ -2999,17 +3139,17 @@ void MicrosoftRecordLayoutBuilder::layoutBitField(const FieldDecl *FD) { auto NewSize = Context.toCharUnitsFromBits( llvm::alignDown(FieldBitOffset, Context.toBits(Info.Alignment)) + Context.toBits(Info.Size)); -Size =

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/65675: >From 923a43cd6386f6e57023fd8928eed0dc0ab04d57 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 21 Jul 2023 16:30:30 -0700 Subject: [PATCH 1/2] Implement [[msvc::no_unique_address]] This attribute should

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Amy Huang via cfe-commits
@@ -2937,14 +2964,97 @@ void MicrosoftRecordLayoutBuilder::layoutNonVirtualBase( BaseOffset = CharUnits::Zero(); } else { // Otherwise, lay the base out at the end of the MDC. - BaseOffset = Size = Size.alignTo(Info.Alignment); + BaseOffset = DataSize

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-08 Thread Amy Huang via cfe-commits
@@ -3055,7 +3195,7 @@ void MicrosoftRecordLayoutBuilder::injectVBPtr(const CXXRecordDecl *RD) { // It is possible that there were no fields or bases located after vbptr, // so the size was not adjusted before. if (Size < FieldStart) - Size = FieldStart; +

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-08 Thread Amy Huang via cfe-commits
https://github.com/amykhuang resolved https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang labeled https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/65675: This implements the [[msvc::no_unique_address]] attribute. There is not ABI compatibility in this patch because the attribute is relatively new and there's still some uncertainty in the MSVC version. Bug:

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Amy Huang via cfe-commits
https://github.com/amykhuang labeled https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 27dab4d - Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."t

2023-07-26 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2023-07-26T16:13:36-07:00 New Revision: 27dab4d305acb6e0935e014c061c5317016ae2b3 URL: https://github.com/llvm/llvm-project/commit/27dab4d305acb6e0935e014c061c5317016ae2b3 DIFF: https://github.com/llvm/llvm-project/commit/27dab4d305acb6e0935e014c061c5317016ae2b3.diff

[clang] 8ed7aa5 - Revert "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."

2023-06-22 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2023-06-22T11:42:33-07:00 New Revision: 8ed7aa59f489715d39d32e72a787b8e75cfda151 URL: https://github.com/llvm/llvm-project/commit/8ed7aa59f489715d39d32e72a787b8e75cfda151 DIFF: https://github.com/llvm/llvm-project/commit/8ed7aa59f489715d39d32e72a787b8e75cfda151.diff

[clang] 0150493 - Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

2023-06-20 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2023-06-20T17:30:20-07:00 New Revision: 015049338d7e8e0e81f2ad2f94e5a43e2e3f5220 URL: https://github.com/llvm/llvm-project/commit/015049338d7e8e0e81f2ad2f94e5a43e2e3f5220 DIFF: https://github.com/llvm/llvm-project/commit/015049338d7e8e0e81f2ad2f94e5a43e2e3f5220.diff

[clang] 63aa57d - Small fixes to creduce-clang-crash.py script.

2022-12-22 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2022-12-22T16:33:28Z New Revision: 63aa57dc57e1d47479025f65a89a5a9da974800f URL: https://github.com/llvm/llvm-project/commit/63aa57dc57e1d47479025f65a89a5a9da974800f DIFF: https://github.com/llvm/llvm-project/commit/63aa57dc57e1d47479025f65a89a5a9da974800f.diff LOG:

[clang] 01636fb - Fix documentation error in e8433a2b06d5

2022-10-27 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2022-10-27T22:41:49Z New Revision: 01636fb0aef0ef06f1fa13292ce7682348b41d27 URL: https://github.com/llvm/llvm-project/commit/01636fb0aef0ef06f1fa13292ce7682348b41d27 DIFF: https://github.com/llvm/llvm-project/commit/01636fb0aef0ef06f1fa13292ce7682348b41d27.diff LOG:

[clang] e8433a2 - Update docs for -fuse-ctor-homing

2022-10-27 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2022-10-27T22:24:34Z New Revision: e8433a2b06d554df922d67f953a06701402536a1 URL: https://github.com/llvm/llvm-project/commit/e8433a2b06d554df922d67f953a06701402536a1 DIFF: https://github.com/llvm/llvm-project/commit/e8433a2b06d554df922d67f953a06701402536a1.diff LOG:

[clang] 3283f71 - Add clang flag equivalent to clang-cl /Zl flag

2022-09-22 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2022-09-22T23:08:52Z New Revision: 3283f71069a0d91593c81a610a710979fb655d7f URL: https://github.com/llvm/llvm-project/commit/3283f71069a0d91593c81a610a710979fb655d7f DIFF: https://github.com/llvm/llvm-project/commit/3283f71069a0d91593c81a610a710979fb655d7f.diff LOG:

[clang] 9ada3d5 - Fix error in clang /MT equivalent flag patch.

2022-09-15 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2022-09-15T20:24:51Z New Revision: 9ada3d5a137f5edba7a599ca83e488c76681bbf9 URL: https://github.com/llvm/llvm-project/commit/9ada3d5a137f5edba7a599ca83e488c76681bbf9 DIFF: https://github.com/llvm/llvm-project/commit/9ada3d5a137f5edba7a599ca83e488c76681bbf9.diff LOG:

[clang] fda44be - Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

2022-09-15 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2022-09-15T17:45:41Z New Revision: fda44bedd64dbcde1b54432d99ad2f0fca0ad204 URL: https://github.com/llvm/llvm-project/commit/fda44bedd64dbcde1b54432d99ad2f0fca0ad204 DIFF: https://github.com/llvm/llvm-project/commit/fda44bedd64dbcde1b54432d99ad2f0fca0ad204.diff LOG:

[clang] 28d2977 - [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does

2022-01-07 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2022-01-07T14:42:16-08:00 New Revision: 28d2977ff236dffa2a955714aee86e798ca9acd9 URL: https://github.com/llvm/llvm-project/commit/28d2977ff236dffa2a955714aee86e798ca9acd9 DIFF: https://github.com/llvm/llvm-project/commit/28d2977ff236dffa2a955714aee86e798ca9acd9.diff

[clang] c7104e5 - [Sema] Allow comparisons between different ms ptr size address space types.

2021-10-05 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2021-10-05T10:56:29-07:00 New Revision: c7104e506619b551ee7ab888a040114f260e8cb5 URL: https://github.com/llvm/llvm-project/commit/c7104e506619b551ee7ab888a040114f260e8cb5 DIFF: https://github.com/llvm/llvm-project/commit/c7104e506619b551ee7ab888a040114f260e8cb5.diff

[clang] 0cd9d8a - Revert "[clang-cl] Accept `#pragma warning(disable : N)` for some N"

2021-09-29 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2021-09-29T18:46:55-07:00 New Revision: 0cd9d8a48bdddb17de2c6388f9d775353f9acab9 URL: https://github.com/llvm/llvm-project/commit/0cd9d8a48bdddb17de2c6388f9d775353f9acab9 DIFF: https://github.com/llvm/llvm-project/commit/0cd9d8a48bdddb17de2c6388f9d775353f9acab9.diff

[clang] 1a3bf29 - [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

2021-07-26 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2021-07-26T17:24:42-07:00 New Revision: 1a3bf2953a9209fdc4dbb6e99678e02a7fec019d URL: https://github.com/llvm/llvm-project/commit/1a3bf2953a9209fdc4dbb6e99678e02a7fec019d DIFF: https://github.com/llvm/llvm-project/commit/1a3bf2953a9209fdc4dbb6e99678e02a7fec019d.diff

  1   2   >