This revision was automatically updated to reflect the committed changes.
Closed by commit rL335255: [DebugInfo] Inline for without DebugLocation
(authored by gramanas, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47720
Files:
gramanas added a comment.
ping! should I commit this?
Repository:
rC Clang
https://reviews.llvm.org/D47720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gramanas updated this revision to Diff 150357.
gramanas added a comment.
Make more elaborate comment.
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-preserve-scope.c
gramanas updated this revision to Diff 150135.
gramanas added a comment.
make code more readable
Repository:
rC Clang
https://reviews.llvm.org/D47720
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGen/debug-info-inline-for.c
Index: test/CodeGen/debug-info-inline-for.c
gramanas added a comment.
What about this? Ping!
Repository:
rC Clang
https://reviews.llvm.org/D47097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gramanas added inline comments.
Comment at: test/CodeGen/debug-info-inline-for.c:13
+
+// CHECK: ![[DbgLoc]] = !DILocation(
aprantl wrote:
> Shouldn't you also check *which* location is attached to it?
I wasn't sure if this should be an artificial location or
gramanas updated this revision to Diff 150036.
gramanas marked an inline comment as done.
gramanas added a comment.
Add artificial debug location to the phi instruction
Repository:
rC Clang
https://reviews.llvm.org/D47720
Files:
lib/CodeGen/CGExprScalar.cpp
gramanas updated this revision to Diff 149996.
gramanas added a comment.
Add comment explaining the test
Repository:
rC Clang
https://reviews.llvm.org/D47720
Files:
test/CodeGen/debug-info-inline-for.c
Index: test/CodeGen/debug-info-inline-for.c
gramanas created this revision.
gramanas added a reviewer: vsk.
Herald added subscribers: cfe-commits, JDevlieghere, eraman, aprantl.
This test is a strip down version of a function inside the
amalgamated sqlite source. When converted to IR clang produces
a phi instruction without debug location.
gramanas updated this revision to Diff 148588.
gramanas added a comment.
I added a test that illustrates what @vsk is talking about.
Sorry for not providing the relevant information but I thought this would
be a simple one liner like https://reviews.llvm.org/rL327800. I will update the
gramanas added a comment.
In https://reviews.llvm.org/D47097#149, @probinson wrote:
> Can we step back a second and better explain what the problem is? With
> current Clang the debug info for this function looks okay to me.
> The store that is "missing" a debug location is homing the
gramanas updated this revision to Diff 148414.
gramanas added a comment.
Adress review comments.
Limit changes to the storeInst
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index:
gramanas updated this revision to Diff 148200.
gramanas marked an inline comment as done.
gramanas added a comment.
Remove redundant `this`
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
gramanas updated this revision to Diff 148198.
gramanas added a comment.
Set debug location to the entry block alloca
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
test/CodeGen/debug-info-preserve-scope.c
Index:
gramanas added a comment.
It was a mistake on my part with the arcanist tool. The documentation is fine,
the only problems I encountered were due to my ignorance of how these systems
work.
Repository:
rC Clang
https://reviews.llvm.org/D47161
gramanas updated this revision to Diff 148034.
gramanas added a comment.
Move ApplyDebugLocation before CreateMemTemp
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index:
gramanas abandoned this revision.
gramanas added a comment.
Duplicate of https://reviews.llvm.org/D47097
Repository:
rC Clang
https://reviews.llvm.org/D47161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
gramanas updated this revision to Diff 147876.
gramanas added a comment.
Update diff
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-preserve-scope.c
gramanas created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D47161
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-preserve-scope.c
gramanas updated this revision to Diff 147840.
gramanas marked an inline comment as done.
gramanas added a comment.
Update according to the comments
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index:
gramanas updated this revision to Diff 147838.
gramanas added a comment.
- Apply debug location
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-preserve-scope.c
gramanas created this revision.
gramanas added a reviewer: vsk.
Herald added subscribers: JDevlieghere, aprantl.
In this test there is a store instruction generated by clang
for the function argument `int b` where the debug info is missing.
The goal of this patch is to instruct clang to add an
22 matches
Mail list logo
