[PATCH] D33314: clang-format: Add option to remove semicolon at end of namespace

anatol.pomozov added a comment. Would it be possible to add a Fixer that removes unneeded semicolon after C function? https://reviews.llvm.org/D33314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37312: Add documentation for force_align_arg_pointer function attribute

anatol.pomozov added a comment. Thank you folks for your work. By the way when these changes are going to be released? clang 6.0? Repository: rL LLVM https://reviews.llvm.org/D37312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37312: Add documentation for force_align_arg_pointer function attribute

anatol.pomozov updated this revision to Diff 113458. https://reviews.llvm.org/D37312 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td === ---

[PATCH] D37312: Add documentation for force_align_arg_pointer function attribute

anatol.pomozov updated this revision to Diff 113340. https://reviews.llvm.org/D37312 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td === ---

[PATCH] D37312: Add documentation for force_align_arg_pointer function attribute

anatol.pomozov added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2809 + let Content = [{ +Use this attribute to force stack alignment. + Feel free to reword the documentation (English is not my native language). Let me know if something is not

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. I have no commit permissions (this is my first patch to LLVM project). Ideally if someone of you merge it. If not then I'll ask a friend of mine who works on clang sanitizers to merge it. https://reviews.llvm.org/D36272

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Hi Aaron. Thank you very much for reviewing this patch. I'll be glad to add documentation for 'force_align_arg_pointer' attribute and upload another patch. But before doing it I would like to finish work on the current patch and make its forward progress toward

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. > As I said, as long as BOTH windows versions have the same issue, I think _I_ > am OK with it. The tests fail at windows the same way. The only difference - "attribute is not supported at 64bit" compiler warning is gone with my change. > if we corrected the

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Hi Eric, thank you for your reply. Both these triples are currently broken, with my change and without. The attribute functionality in WinX86_64TargetCodeGenInfo mirrors one in X86_64TargetCodeGenInfo and it should work the same way. It is done intentionally as

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. The function-attributes.c test does not pass at Windows even without my patch. Unfortunately I am not familiar with clang enough to debug this issue. https://reviews.llvm.org/D36272

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov updated this revision to Diff 113166. anatol.pomozov edited the summary of this revision. https://reviews.llvm.org/D36272 Files: include/clang/Basic/Attr.td lib/CodeGen/TargetInfo.cpp test/CodeGen/function-attributes.c Index: test/CodeGen/function-attributes.c

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Another fact: gcc 7.2.0 supports this attribute at x86_64. It would be great if two major compilers were feature compatible and worked in a similar way. https://reviews.llvm.org/D36272 ___ cfe-commits mailing list

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. > Additionally, there is likely value to split the test run-line into 2, one > that specifies 64 bit Windows and one that is 64 bit Linux. The value being > that they validate two different code paths (whereas 32 is the same code > path). I added a RUN for

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Related maillist discussion is http://lists.llvm.org/pipermail/cfe-dev/2017-June/054359.html > Are we SURE the stack alignment for this type is supposed to be 16 bit as > well? I didn't see any discussion about it in the email conversation. > I have very

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Erich, done. I also rerun tests and this time they are green. https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov updated this revision to Diff 112582. https://reviews.llvm.org/D36272 Files: include/clang/Basic/Attr.td lib/CodeGen/TargetInfo.cpp test/CodeGen/function-attributes.c Index: test/CodeGen/function-attributes.c

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Tim, had you chance to look at this patch? Repository: rL LLVM https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits