[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added a comment. @ivanmurashko: Sorry for the delay getting back to you here. Feel free to commandeer, as I don't have plans to get to this soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 352898. andrewjcg added a comment. capitalize param Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 352824. andrewjcg added a comment. fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added inline comments. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:27 +#define FOO +// This include will fail if modules weren't used. The include name itself +// doesn't exist and relies on the header map to remap it to the real header.

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added inline comments. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:27 +#define FOO +// This include will fail if modules weren't used. The include name itself +// doesn't exist and relies on the header map to remap it to the real header.

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 352740. andrewjcg added a comment. fix sed for windows test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 352299. andrewjcg added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added a comment. Hmm, I can't repro the module test failures locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 ___ cfe-commits mailing list

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 351195. andrewjcg added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 350767. andrewjcg added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added inline comments. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:27 +#define FOO +#include "Before/Mapping.h" This include will fail if modules weren't used. The include name itself doesn't exist and relies on the header map to

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added a comment. We were hitting this in our build environment when mixing header maps with clang module maps, where the use of the former would prevent properly associated an included header with it's module via the module map. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg created this revision. Herald added a subscriber: wenlei. andrewjcg updated this revision to Diff 350757. andrewjcg added a comment. andrewjcg edited the summary of this revision. andrewjcg added reviewers: bruno, rsmith. andrewjcg published this revision for review. Herald added a

[PATCH] D83154: clang: Add -fcoverage-prefix-map

andrewjcg added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); keith wrote: > rnk wrote:

[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

andrewjcg updated this revision to Diff 289506. andrewjcg marked 2 inline comments as done. andrewjcg added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86853/new/ https://reviews.llvm.org/D86853 Files:

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg abandoned this revision. andrewjcg added a comment. Ahh, I see, make sense. The motivating issue was due to an apparent bug where realpaths in umbrella dir support for module map files get leaked into dep files for includes starting with `..` (e.g. `#include "../foo.h"`) in

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg updated this revision to Diff 289236. andrewjcg added a comment. simplify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86802/new/ https://reviews.llvm.org/D86802 Files: clang/lib/Frontend/FrontendAction.cpp

[PATCH] D86853: [modules] Repro for pure virtual base class method crash

andrewjcg created this revision. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. andrewjcg requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86853 Files: clang/lib/Serialization/ASTReaderDecl.cpp

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg updated this revision to Diff 288695. andrewjcg added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86802/new/ https://reviews.llvm.org/D86802 Files: clang/lib/Frontend/FrontendAction.cpp

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg added a comment. > How about a malformed module map is not loaded and gives no errors? Heh yeah, was thinking the same :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86802/new/ https://reviews.llvm.org/D86802

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg added a comment. > Can you add a simple testcase to prove the point of the change? Yup, will do! Comment at: clang/lib/Frontend/FrontendAction.cpp:814 +CI.getPreprocessor().getHeaderSearchInfo().loadModuleMapFile( +*File, /*IsSystem*/ false); +

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

andrewjcg created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. andrewjcg requested review of this revision. In some build environments/systems, flags for explicit module map files may be propagated up to dependents which may not choose to enable use of

[PATCH] D85084: [modules] Repro for pure virtual base class method crash

andrewjcg created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. andrewjcg requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85084 Files: clang/test/Modules/Inputs/set-pure-crash/a.h

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

andrewjcg updated this revision to Diff 232190. andrewjcg added a comment. rebase onto monorepo and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70219/new/ https://reviews.llvm.org/D70219 Files:

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

andrewjcg created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When precompiling a header module, `-fmodule-file=name>=` flags can be used to provide an updated path to a module, which allows modules to be moved from the location they were compiled

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

andrewjcg added a comment. Sorry for the delay. Just catching up on the code this covers, so apologies if the questions don't make sense. Comment at: lib/Sema/SemaDeclCXX.cpp:9214-9215 getStdNamespace()->setImplicit(true); +if (getLangOpts().Modules) +

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

andrewjcg added a comment. Herald added a project: clang. Sorry for the delay here, but this should be ready to go. As this is my first accepted diff to LLVM, should I follow https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access to get commit access, or is there some other process

[PATCH] D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules

andrewjcg marked 2 inline comments as done. andrewjcg added a comment. > I don't think we need to change the serialization format for this: a > serialized path beginning with / is already treated as absolute and any other > path is already treated as relative, so we don't need a flag to carry

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

andrewjcg created this revision. Herald added subscribers: cfe-commits, eraman. Undoes `-fvisibility-inlines-hidden`. Test Plan: added test Repository: rC Clang https://reviews.llvm.org/D52956 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp

[PATCH] D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules

andrewjcg updated this revision to Diff 166709. andrewjcg added a comment. Dropping the module directory entirely and fully resolving paths on serialization broke some things during deserialization, specifically when the deserializer wanted to update paths to use an alternate module directory.

[PATCH] D51568: [modules] Add `-fdisable-module-directory` flag for relocatable modules

andrewjcg updated this revision to Diff 163621. andrewjcg added a comment. fix umbrella writing Repository: rC Clang https://reviews.llvm.org/D51568 Files: include/clang/Driver/CC1Options.td include/clang/Lex/HeaderSearchOptions.h lib/Frontend/CompilerInvocation.cpp

[PATCH] D51568: [modules] Add `-fdisable-module-directory` flag for relocatable modules

andrewjcg added a comment. I'm not sure this is the best approach, but I wasn't sure of a better one (to support module files w/o absolute paths). Another approach I tried, was relativizing the other input files (from outside the module directory) using chains of `../` (e.g.

[PATCH] D51568: [modules] Add `-fdisable-module-directory` flag for relocatable modules

andrewjcg created this revision. Herald added a subscriber: cfe-commits. Currently, modules built using module map files embed the path to the directory that houses their inputs (e.g. headers and module map file) into the output module file. This path is embedded as an absolute path and the