aturetsk abandoned this revision.
aturetsk added a comment.
New version in https://reviews.llvm.org/D21374
https://reviews.llvm.org/D21066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: aturetsk
Date: Wed Jun 29 05:57:17 2016
New Revision: 274119
URL: http://llvm.org/viewvc/llvm-project?rev=274119=rev
Log:
Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC.
Differential Revision: http://reviews.llvm.org/D21641
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274119: Use ArgList::hasFlag to check if -miamcu/-mno-iamcu
is passed. NFC. (authored by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D21641?vs=61662=62203#toc
Repository:
rL LLVM
aturetsk added a comment.
Hi Bruno,
As you suggested I changed -miamcu/-mno-iamcu handling code to use hasFlag.
http://reviews.llvm.org/D21641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aturetsk created this revision.
aturetsk added a reviewer: bruno.
aturetsk added a subscriber: cfe-commits.
Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC.
http://reviews.llvm.org/D21641
Files:
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273147: [X86] Add -mno-iamcu option. (authored by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D21469?vs=61088=61245#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21469
Files:
Author: aturetsk
Date: Mon Jun 20 05:31:39 2016
New Revision: 273147
URL: http://llvm.org/viewvc/llvm-project?rev=273147=rev
Log:
[X86] Add -mno-iamcu option.
Add -mno-iamcu option to:
1) Countervail -miamcu option easily
2) Be compatible with GCC which supports this option
Differential
aturetsk created this revision.
aturetsk added reviewers: bruno, echristo.
aturetsk added subscribers: cfe-commits, zinovy.nis.
Herald added a subscriber: mehdi_amini.
Add -mno-iamcu option to:
1) Countervail -miamcu option easily
2) Be compatible with GCC which supports this option
Author: aturetsk
Date: Thu Jun 16 07:26:20 2016
New Revision: 272887
URL: http://llvm.org/viewvc/llvm-project?rev=272887=rev
Log:
Patch "Compilation for Intel MCU (Part 2/3)" caused the clang-x64-ninja-win7
buildbot to fail because of inaccurate CHECK in the test. This is a quick fix
for the test
Author: aturetsk
Date: Thu Jun 16 05:49:27 2016
New Revision: 272885
URL: http://llvm.org/viewvc/llvm-project?rev=272885=rev
Log:
Compilation for Intel MCU (Part 3/3)
This is the last patch required to support compilation for Intel MCU target
(e.g. Intel(R) Quark(TM) micro controller D 2000).
Author: aturetsk
Date: Thu Jun 16 05:36:09 2016
New Revision: 272883
URL: http://llvm.org/viewvc/llvm-project?rev=272883=rev
Log:
Compilation for Intel MCU (Part 2/3)
This is the second patch required to support compilation for Intel MCU target
(e.g. Intel(R) Quark(TM) micro controller D 2000).
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272883: Compilation for Intel MCU (Part 2/3) (authored by
aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D19274?vs=57017=60958#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19274
aturetsk added inline comments.
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
aturetsk wrote:
> bruno wrote:
> > aturetsk
aturetsk created this revision.
aturetsk added reviewers: bruno, echristo, ahatanak, RKSimon.
aturetsk added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
Pass MCSubtargetInfo instead of CPU and Triple to AsmBackend in order to be
able to reach feature bits there (e.g. for
aturetsk added inline comments.
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
bruno wrote:
> aturetsk wrote:
> > bruno
aturetsk created this revision.
aturetsk added reviewers: rsmith, bruno.
aturetsk added subscribers: cfe-commits, zinovy.nis, DavidKreitzer.
Herald added subscribers: srhines, danalbert, tberghammer.
This is the last patch required to support compilation for Intel MCU target
(e.g. Intel(R)
aturetsk added inline comments.
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
bruno wrote:
> Taking a look at this again I
aturetsk added a comment.
Ping.
http://reviews.llvm.org/D19274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aturetsk added a comment.
Hi Bruno,
Thanks for the review.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:157
@@ -156,1 +156,3 @@
+def err_drv_cxx_not_supported : Error<
+ "C++ is not supported for target '%0'">;
Yes. I've found nothing similar.
aturetsk updated this revision to Diff 57017.
aturetsk added a comment.
Fix the remarks.
http://reviews.llvm.org/D19274
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/ToolChain.h
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.cpp
aturetsk added a comment.
Hi,
Thanks for the review.
Committed:
1. Add a test for driver options from m_x86_Features_Group
(http://reviews.llvm.org/rL268487)
2. Add missing -mno-cx16 driver option (http://reviews.llvm.org/rL268488)
3. Add -m[no-]x87 and -m[no-]80387 options to control
Author: aturetsk
Date: Wed May 4 06:19:41 2016
New Revision: 268488
URL: http://llvm.org/viewvc/llvm-project?rev=268488=rev
Log:
Add missing -mno-cx16 driver option.
Differential Revision: http://reviews.llvm.org/D19658
Modified:
cfe/trunk/include/clang/Driver/Options.td
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268487: Add a test for driver options from
m_x86_Features_Group. (authored by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D19658?vs=55579=56125#toc
Repository:
rL LLVM
aturetsk added a comment.
Hi,
Thanks for the review.
All m_x86_Features_Group options are handled in function
handleTargetFeaturesGroup from lib/Driver/Tools.cpp, so there is no additional
code needed.
There was no test for this, so I added a new one trying to cover all options
from
aturetsk updated this revision to Diff 55579.
aturetsk added a comment.
Add a missing option and a test.
http://reviews.llvm.org/D19658
Files:
include/clang/Driver/Options.td
test/Driver/x86-target-features.c
Index: test/Driver/x86-target-features.c
aturetsk created this revision.
aturetsk added reviewers: rsmith, echristo.
aturetsk added subscribers: cfe-commits, zinovy.nis.
Herald added a subscriber: joker.eph.
Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87.
-m[no-]80387 options is added for compatibility with GCC.
Author: aturetsk
Date: Thu Apr 21 05:16:48 2016
New Revision: 266972
URL: http://llvm.org/viewvc/llvm-project?rev=266972=rev
Log:
Compilation for Intel MCU (Part 1/3)
Add -miamcu option which:
* Sets IAMCU triple
* Sets IAMCU ABI
* Enforces static compilation
Differential Revision:
aturetsk created this revision.
aturetsk added reviewers: rsmith, bruno, bkramer.
aturetsk added subscribers: cfe-commits, DavidKreitzer, zinovy.nis.
This is the second patch required to support compilation for Intel MCU target
(e.g. Intel(R) Quark(TM) micro controller D 2000).
When IAMCU
Author: aturetsk
Date: Tue Apr 19 11:25:30 2016
New Revision: 266753
URL: http://llvm.org/viewvc/llvm-project?rev=266753=rev
Log:
Revert r266747 (Compilation for Intel MCU (Part 1/3)) since it breaks a few
buildbots.
Removed:
cfe/trunk/test/Driver/miamcu-opt.c
Modified:
Author: aturetsk
Date: Tue Apr 19 10:50:57 2016
New Revision: 266747
URL: http://llvm.org/viewvc/llvm-project?rev=266747=rev
Log:
Compilation for Intel MCU (Part 1/3)
Add -miamcu option which:
* Sets IAMCU triple
* Sets IAMCU ABI
* Enforces static compilation
Differential Revision:
aturetsk added a comment.
Ping.
http://reviews.llvm.org/D18398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aturetsk added a comment.
Hi Bruno,
Thanks for the review.
Comment at: include/clang/Driver/Options.td:1281
@@ -1280,1 +1280,3 @@
+def miamcu : Flag<["-"], "miamcu">, Group, Flags<[DriverOption,
CoreOption]>,
+ HelpText<"Use Intel MCU ABI">;
def malign_functions_EQ :
aturetsk updated this revision to Diff 52789.
aturetsk added a comment.
Fix remarks,
http://reviews.llvm.org/D18398
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/miamcu-opt.c
Index: test/Driver/miamcu-opt.c
Author: aturetsk
Date: Tue Apr 5 10:04:26 2016
New Revision: 265405
URL: http://llvm.org/viewvc/llvm-project?rev=265405=rev
Log:
[X86] Introduction of -march=lakemont.
Differential Revision: http://reviews.llvm.org/D18651
Modified:
cfe/trunk/lib/Basic/Targets.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265405: [X86] Introduction of -march=lakemont. (authored by
aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D18651?vs=52220=52692#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18651
aturetsk added a comment.
Ping.
http://reviews.llvm.org/D18398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aturetsk added a comment.
I used existing test "test/CodeGen/attr-target-x86.c" to check Lakemont's
target features. However the test is actually run with 64-bit triple
"x86_64-linux-gnu", so "+mmx,+sse,+sse2" are included in target features. The
same thing happens with Pentium and other
aturetsk created this revision.
aturetsk added reviewers: rsmith, echristo.
aturetsk added subscribers: cfe-commits, zinovy.nis.
Add a new CPU - Lakemont.
http://reviews.llvm.org/D18651
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86.c
test/Preprocessor/predefined-arch-macros.c
aturetsk created this revision.
aturetsk added reviewers: rsmith, tra, thakis, ddunbar, bob.wilson, dougk.
aturetsk added subscribers: cfe-commits, zinovy.nis, DavidKreitzer.
Add -miamcu option which:
* Sets IAMCU triple
* Sets IAMCU ABI
* Enforces static compilation
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264149: [X86] Add "x87" in x86 target feature map. (authored
by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D13980?vs=48904=51398#toc
Repository:
rL LLVM
Author: aturetsk
Date: Wed Mar 23 06:15:10 2016
New Revision: 264149
URL: http://llvm.org/viewvc/llvm-project?rev=264149=rev
Log:
[X86] Add "x87" in x86 target feature map.
Differential Revision: http://reviews.llvm.org/D13980
Added:
cfe/trunk/test/CodeGen/attr-target-x87-softfp.c (with
aturetsk abandoned this revision.
aturetsk added a comment.
The patch will be completely reworked and extended to support compilation for
MCU.
http://reviews.llvm.org/D14146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: aturetsk
Date: Mon Mar 14 06:19:43 2016
New Revision: 263422
URL: http://llvm.org/viewvc/llvm-project?rev=263422=rev
Log:
[Driver] Enable --rtlib option for MSVC target
This enables "--rtlib compiler-rt" option under MSVC environment.
Patch by Roman Shirokiy.
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263422: [Driver] Enable --rtlib option for MSVC target
(authored by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D17453?vs=50260=50579#toc
Repository:
rL LLVM
aturetsk added a comment.
Hi,
The related LLVM patch (http://reviews.llvm.org/D13979) was approved. Is this
patch ok for commit?
http://reviews.llvm.org/D13980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: aturetsk
Date: Wed Feb 10 05:58:46 2016
New Revision: 260376
URL: http://llvm.org/viewvc/llvm-project?rev=260376=rev
Log:
[X86] Fix stack alignment for MCU target (Clang part), by Anton Nadolskiy.
This patch fixes stack alignments for MCU (should be aligned to 4 bytes).
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260376: [X86] Fix stack alignment for MCU target (Clang
part), by Anton Nadolskiy. (authored by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D15647?vs=43788=47440#toc
Repository:
rL
Author: aturetsk
Date: Wed Feb 10 06:56:10 2016
New Revision: 260379
URL: http://llvm.org/viewvc/llvm-project?rev=260379=rev
Log:
Reapply the patch of r260376.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
aturetsk updated this revision to Diff 41511.
aturetsk added a comment.
Enable X87 back for all X86 processors.
http://reviews.llvm.org/D13980
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86-mmx.c
test/CodeGen/attr-target-x86.c
Index: test/CodeGen/attr-target-x86.c
aturetsk added inline comments.
Comment at: lib/Basic/Targets.cpp:2551
@@ -2547,3 +2550,3 @@
case CK_i386:
case CK_i486:
case CK_i586:
"x87 instructions probably work" is more like it, and having feature x87
disabled would mean "x87 instructions
aturetsk added inline comments.
Comment at: lib/Basic/Targets.cpp:2548
@@ +2547,3 @@
+ // All X86 processors but i386 have X87.
+ if (Kind != CK_i386)
+setFeatureEnabledImpl(Features, "x87", true);
rsmith wrote:
> What about `CK_Generic`? Also, if `CK_i486`
aturetsk updated this revision to Diff 41309.
aturetsk added a comment.
Extended to take into account recent MCU related changes
http://reviews.llvm.org/D14146
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/miamcu-opt.c
aturetsk updated this revision to Diff 41137.
aturetsk added a comment.
Use getCPUKind once
http://reviews.llvm.org/D13980
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86-mmx.c
test/CodeGen/attr-target-x86.c
Index: test/CodeGen/attr-target-x86.c
aturetsk added a comment.
> Are there any of the intrinsics in the headers that also depend on x87?
Not that I could find.
Comment at: lib/Basic/Targets.cpp:2545-2546
@@ -2544,2 +2544,4 @@
- switch (getCPUKind(CPU)) {
+ CPUKind Kind = getCPUKind(CPU);
+
+ // All X86
aturetsk added a comment.
Hello Richard,
Thank for the review.
Comment at: lib/Basic/Targets.cpp:2538-2539
@@ -2537,1 +2537,4 @@
+ // All X86 processors but i386 have X87.
+ if (getCPUKind(CPU) != CK_i386)
+setFeatureEnabledImpl(Features, "x87", true);
aturetsk created this revision.
aturetsk added a reviewer: rsmith.
aturetsk added subscribers: cfe-commits, mkuper, DavidKreitzer, anadolskiy,
zansari.
Add initial support of -miamcu option which triggers MCU ABI.
http://reviews.llvm.org/D14146
Files:
include/clang/Driver/Options.td
aturetsk created this revision.
aturetsk added a reviewer: rsmith.
aturetsk added a subscriber: cfe-commits.
Add 'x87' in x86 target feature map
http://reviews.llvm.org/D13980
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86-mmx.c
test/CodeGen/attr-target-x86.c
Index:
57 matches
Mail list logo
