[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

futuarmo added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810 + + verifyFormat("#define A LOOONG() LOOONG()\n", + ZeroColumn); owenpan wrote: > Please remove the newline and re-run

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

futuarmo added a comment. @curdeius, all tests pass on fresh build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 ___ cfe-commits mailing list

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

futuarmo added a comment. I will build fresh main branch tomorrow (it tooks 1+ hour) and will comment here about test results I don't have commit rights, so it will be great if someone commit it with user "Armen Khachkinaev" and email "armen...@yandex.ru" Thanks Repository: rG LLVM Github

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

futuarmo added a comment. Yes. Looks like I understood wrong how pre-merge clang-format check works, thanks everyone for help Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

futuarmo updated this revision to Diff 399394. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

futuarmo updated this revision to Diff 398695. futuarmo edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

futuarmo created this revision. futuarmo added reviewers: djasper, MyDeveloperDay. futuarmo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix for #49164 issue. Alse added test for this

[PATCH] D116585: Fix wrong JS import linebreak

futuarmo abandoned this revision. futuarmo added a comment. Issue was fixed by other patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116585/new/ https://reviews.llvm.org/D116585 ___ cfe-commits

[PATCH] D116585: Fix wrong JS import linebreak

futuarmo created this revision. futuarmo added a reviewer: djasper. futuarmo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #52935 Also I could fix it by wrapping 2 if-statements