[PATCH] D135822: [clang-tidy] Add option `IgnoreVoidReturnType` to `modernize-use-trailing-return-type`

2022-10-13 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Hi! I am the original author of this check. I very much welcome your contribution! Thank you for the effort! I am not a clang tools maintainer though, so you will need someone else to review and approve this change set. Comment at: clang-too

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

2022-04-26 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. > Yes, sure, just please specify what `user.name` and `user.email` would you > like to be associated with the commit's author? `user.name`: Bernhard Manfred Gruber `user.email`: bernhardmgru...@gmail.com Thanks a lot! CHANGES SINCE LAST ACTION https://review

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

2022-04-26 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Ping. Can someone merge this please for me? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123065/new/ https://reviews.llvm.org/D123065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

2022-04-08 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 421503. bernhardmgruber added a comment. Added missing '.' in helptext. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123065/new/ https://reviews.llvm.org/D123065 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py clang-tools-e

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

2022-04-08 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 421502. bernhardmgruber added a comment. Rebased on main and applied review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123065/new/ https://reviews.llvm.org/D123065 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

2022-04-04 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. I did not base this revision on my latest main (422d05e792dbd6a97f5afd4cdd5e8aa677e97444 ) since I could not run the python scripts with the changes introduced in 9e1f4f13984186984ba37513372c1

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

2022-04-04 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber created this revision. bernhardmgruber added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, mgehre, xazax.hun. Herald added a project: All. bernhardmgruber requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: c

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

2020-10-03 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked an inline comment as done. bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:72 +TL.getAs().getTypePtr()->getDecl()->getName())) + return false; default:

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

2020-10-03 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:72 +TL.getAs().getTypePtr()->getDecl()->getName())) + return false; default: There is a `break;` missing afte

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

2020-10-02 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Thank you for the quick review! Can you please commit it for me as well? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88700/new/ https://reviews.llvm.org/D88700

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-08-14 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 12 inline comments as done. bernhardmgruber added a comment. Thank you for the time to review this! Could you please also commit it for me? Thank you! Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:430 + AT->getKe

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-08-10 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Btw: what is the general rule for Phabricator reviews here when to tick the `Done` checkbox of a comment? What is the semantic of this checkbox? Is the ticked state the same for everyone? Thank you for the help! Comment at: clang-tools-extra

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-08-06 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-07-21 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:1 -// RUN: %check_clang_tidy -std=c++14,c++17 %s modernize-use-trailing-return-type %t -- -- -fdeclspec -fexceptions +// RUN: %check_clang_tidy -

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-07-21 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 279625. bernhardmgruber marked an inline comment as done. bernhardmgruber edited the summary of this revision. bernhardmgruber added a comment. Removed probably stale FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://re

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-07-21 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Great, I seems I forgot to submit the inline comments. Sorry about that! Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:293 +StringRef File = SM.getBufferData(Loc.first); +const char *TokenBegin = File

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-07-19 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 279088. bernhardmgruber marked 3 inline comments as done. bernhardmgruber added a comment. - Added two more tests with a macro supplied on the command line - Rebased onto master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https:

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-07-08 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Ping. Is there anything I am not seeing here that you still would like me to do? I feel like you are waiting for something obvious from my side :S. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-06-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-06-13 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-06-03 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. In D80514#2071202 , @njames93 wrote: > In D80514#2071056 , @bernhardmgruber > wrote: > > > Reuploaded diff in an attempt to trigger a CI build. > > > It's not working, Still no big

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-06-03 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 268155. bernhardmgruber added a comment. Reuploaded diff in an attempt to trigger a CI build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 Files: clang-tools-extra/clang-tidy/modernize/UseTraili

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-06-03 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Ping. Furthermore: how can I schedule another CI build with the newest version of the diff? When I go to the failed build from Harbormaster and I click restart, it rebuilds an older version of the diff. Thanks for the info! CHANGES SINCE LAST ACTION https://

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 266060. bernhardmgruber added a comment. moved C++20 tests to a new file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 Files: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 2 inline comments as done. bernhardmgruber added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:550 + +#if __cplusplus > 201703L /* C++2a and later */ + njames93 wrote: > bern

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:399 - return true; + return; } Eugene.Zelenko wrote: > Non needed. See readability-redundant-control-flow. Thx! Comme

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 266034. bernhardmgruber marked 2 inline comments as done and 2 inline comments as done. bernhardmgruber added a comment. - split code tables in documentation - removed unnecessary return statement CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber created this revision. bernhardmgruber added reviewers: aaron.ballman, JonasToth, Eugene.Zelenko, lebedev.ri. bernhardmgruber added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. bernhardmgruber updated this revision t

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 265993. bernhardmgruber edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 Files: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 3 inline comments as done. bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:285-302 +SourceLocation End = +expandIfMacroId(ReturnLoc.getSourceRange().getEnd(), SM); +So

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-12-04 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. @Eugene.Zelenko I tried to find what you refer to by PR44206, but I could not find anything :/ Can you please provide me with a link? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-05-09 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 198937. bernhardmgruber marked 3 inline comments as done. bernhardmgruber added a comment. - fixed formatting - fixed function names in tests - added `-fexceptions` to test arguments - fixed type in release notes CHANGES SINCE LAST ACTION https://r

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-05-09 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 2 inline comments as done. bernhardmgruber added a comment. @aaron.ballman I do not have commit privileges and I would be very thankful, if you could commit this patch for me! Thank you! Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:203

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-05-08 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. @aaron.ballman and @JonasToth: Thank you for the patience and all the feedback! It means a great deal to me to have a patch accepted here! Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:95-98 +if (!S->getQualifierLoc() && N

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-05-07 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 198531. bernhardmgruber marked 8 inline comments as done. bernhardmgruber added a comment. Fixed small nits suggested by @aaron.ballman. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files:

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-05-04 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 198143. bernhardmgruber marked 9 inline comments as done. bernhardmgruber added a comment. It took a long while to figure out how to handle certain macro cases. Here is what I came up with: When tokenizing the source code from the beginning of the fu

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-05-04 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:274 + + if (F->getLocation().isInvalid()) +return; aaron.ballman wrote: > bernhardmgruber wrote: > > aaron.ballman wrote: > > > bernhardmgruber wrote: > >

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-03-18 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked an inline comment as not done. bernhardmgruber added a comment. Thank you for the rich feedback @aaron.ballman. I found a solution which seems to work for many of my test cases. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:274 + + if

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-03-18 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 191233. bernhardmgruber marked 7 inline comments as done and 2 inline comments as done. bernhardmgruber added a comment. - extracting specifiers from the return type if it consists of a multitoken built-in type, and preprending it to 'auto'. - extende

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-03-09 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 189993. bernhardmgruber marked 8 inline comments as done. bernhardmgruber added a comment. - added support for __restrict - added two dots at end of comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-03-04 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 189222. bernhardmgruber marked 3 inline comments as done. bernhardmgruber added a comment. Fixed some little nits, thanks @JonasToth! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files: clang-ti

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-02-27 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:335 + StringRef ReturnType = tooling::fixit::getText(ReturnTypeCVRange, Ctx); + StringRef Auto = std::isspace(*ReturnType.end()) // FIXME (dereferencing end) +

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

2019-02-27 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 188621. bernhardmgruber marked 4 inline comments as done. bernhardmgruber retitled this revision from "[clang-tidy] modernize-use-trailing-return check" to "[clang-tidy] modernize-use-trailing-return-type check". bernhardmgruber added a comment. - re

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-02-27 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 2 inline comments as done. bernhardmgruber added a comment. Hi guys! It took me far too long to come up with an update. Honestly, I was quite demotivated as it turned out preventing name collisions of unqualifed names after the rewrite was more difficult than I thought. E

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-02-27 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 188528. bernhardmgruber marked 2 inline comments as done. bernhardmgruber added a comment. Herald added a subscriber: jdoerfert. - rebased onto current master - implemented a basic check for name collisions of unqualified names in the return type with

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-26 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 2 inline comments as done. bernhardmgruber added a comment. Thank you for the feedback! @JonasToth I added tests for `decltype` and i can rewrite all signatures where `decltype` is not the top level expression. The reason is, that the source range of a `clang::DecltypeTyp

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-22 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Thank you again @JonasToth for all your valueable input! I could almost successfully run my check on the llvm/lib subfolder. I created a compilation database from within Visual Studio using an extension called SourceTrail

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-17 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Thank you @JonasToth for providing more feedback! I will add a few more tests with templates. Maybe I should even try to run the check on Boost and see what happens. In the meantime I might need some help: I tried running the check on LLVM last weekend using th

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-17 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 182385. bernhardmgruber marked 19 inline comments as done. bernhardmgruber added a comment. Addressed most of the new review comments (mainly uppercasing start of comments). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://r

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-11 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 181276. bernhardmgruber added a comment. Skipping the check for functions which do not have a valid location. This occurred when I run the check on the LLVM code base. It looked like the matcher matched something like a built in operator. CHANGES S

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-10 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 181051. bernhardmgruber added a comment. Fixed a warning when building with gcc. Added -fdeclspec when running tests to let them compile on Linux as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-10 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 181015. bernhardmgruber added a comment. rebased on current master (there was a conflict in the release notes) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files: clang-tidy/modernize/CMakeLists

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-09 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. I am satisfied with the proposed feature set for now. I will try to run the check on LLVM itself in the next days as a final test. Are there anymore feature requests or changes from your sides? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ h

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-09 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:45 +std::string(Message) + +" (no FixIt provided, function argument list end is inside macro)"); +return {}; Eugene.Zelenko wrote: > MyDeve

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-09 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 180973. bernhardmgruber marked 8 inline comments as done. bernhardmgruber added a comment. - Removed detailed diagnostic messages why FixIts could not be generated - Excluded functions returning member pointers for now - All tests run now CHANGES SIN

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-09 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked an inline comment as done. bernhardmgruber added a comment. I spent some time now to get member pointers as return values working and I am afraid but it seems there is a problem with the clang AST. Given the following code in my check (where `F` is a `FunctionDecl`): co

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-08 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 2 inline comments as done. bernhardmgruber added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:1 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + MyDeveloperDay wrote: > nit

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-07 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. @JonasToth Do you really think I should drop the extra information on why I could not provide a FixIt? If truly yes, than I would like to keep them as comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-07 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:33 + const TypeSourceInfo *TSI = F.getTypeSourceInfo(); + assert(TSI); + const FunctionTypeLoc FTL = JonasToth wrote: > Please add an error-msg to the assertion

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-07 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 180596. bernhardmgruber marked 31 inline comments as done. bernhardmgruber added a comment. Fixed most of the issues pointed out by @JonasToth and added a few more tests. The tests with data member pointers currently fail and I will investiage this.

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-06 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 4 inline comments as done. bernhardmgruber added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:173 +auto l1 = [](int arg) {}; +auto l2 = [](int arg) -> double {}; JonasToth wrote: > you could figure out the

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-06 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 180419. bernhardmgruber added a comment. Big thank you to @JonasToth for providing some macro test cases. I played a bit with macros and settled on the following behavior: - if the closing parenthesis of the function is inside a macro, no FixIt will

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-02 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 179986. bernhardmgruber added a comment. rebased from release_70 onto master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/Modern

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-02 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 2 inline comments as done. bernhardmgruber added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:2 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + +namespace std { aaron.ball

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-02 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 179961. bernhardmgruber added a comment. added more test cases, allowing check to run on out-of-line definitions and updated docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files: clang-tidy

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-02 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 10 inline comments as done. bernhardmgruber added a comment. I fixed most of the stylistic issues. Regarding the missing test cases, I will add those and do the necessary code changes. Thank you very much for pointing them out to me! Comment at: clang-t

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2019-01-02 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 179945. bernhardmgruber marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp c

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2018-12-30 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 179734. bernhardmgruber added a comment. updated diff to one with full context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/Mode

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

2018-12-30 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Hi! This is my first contribution to LLVM and I may not yet know the conventions here. I decided to write this pass, as some work colleagues and me oftenly want to modernize legacy code bases. We like the trailing return type syntax available since C++11 and u

[PATCH] D56160: created clang-tidy pass modernize-use-trailing-return

2018-12-30 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber created this revision. bernhardmgruber added a reviewer: alexfh. bernhardmgruber added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgorny. The new clang-tidy pass modernize-use-trailing-return rewrites function signatures to use a trailing return type. A