[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

2023-04-26 Thread Bogdan Graur via Phabricator via cfe-commits
bgraur added a comment. @aaron.ballman your patch (1395cde24b3641e284bb1daae7d56c189a2635e3 ) fixed all issues we encountered. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

2023-04-25 Thread Bogdan Graur via Phabricator via cfe-commits
bgraur added a comment. We see the same compilation error as the one reported by @sbc100 in several other C libraries. Here's a short reproducer: https://godbolt.org/z/Y8eds47na The tests imply that this should work. Please revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

2023-03-17 Thread Bogdan Graur via Phabricator via cfe-commits
bgraur added a comment. What's the resolution here? Can we revert this and continue the discussions independently? We can always re-land this change if the conclusion is that the approach here is the one that we want. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

2022-08-04 Thread Bogdan Graur via Phabricator via cfe-commits
bgraur added a subscriber: tstellar. bgraur added a comment. @tstellar FYI the clang crash report from @joanahalili and the new compilation errors report from @asmok-g, both introduced by this patch. Is a revert warranted here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

2022-08-04 Thread Bogdan Graur via Phabricator via cfe-commits
bgraur added a comment. @SimplyDanny given the reports from @joanahalili and @asmok-g are you considering a revert for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

2021-11-19 Thread Bogdan Graur via Phabricator via cfe-commits
bgraur added a comment. Early heads up that this revision causes a large regression in compilation time for some of our internal source files: we are seeing seeing an almost 20x increase in compilation times for some files (from 42s to 728s). I'm working on a reproducer which I'm going to

[PATCH] D105890: Add paranthesis around logical expression to silence -Wlogical-op-parentheses warning.

2021-07-13 Thread Bogdan Graur via Phabricator via cfe-commits
bgraur created this revision. Herald added a reviewer: aaron.ballman. bgraur requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105890 Files: clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops"

2020-12-31 Thread Bogdan Graur via Phabricator via cfe-commits
bgraur created this revision. bgraur added a reviewer: SureYeaah. Herald added a subscriber: hiraditya. bgraur requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Test clang/test/Misc:loop-opt-setup.c fails when executed in