[PATCH] D92445: [PowerPC] Enable OpenMP for powerpcle target. [5/5]

This revision was automatically updated to reflect the committed changes. Closed by commit rG2288319733cd: [PowerPC] Enable OpenMP for powerpcle target. [5/5] (authored by Bdragon28). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/

[PATCH] D92445: [PowerPC] Enable OpenMP for powerpcle target. [5/5]

Bdragon28 updated this revision to Diff 314247. Bdragon28 added a comment. Forcing retest again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/test/Driver/ppc-features.cpp

[PATCH] D93919: [PowerPC] Support powerpcle target in Clang [3/5]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cee9d0cf896: [PowerPC] Support powerpcle target in Clang [3/5] (authored by Bdragon28). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D93919: [PowerPC] Support powerpcle target in Clang [3/5]

Bdragon28 updated this revision to Diff 314246. Bdragon28 added a comment. Update altivec changes after fd739804e0591468762eb87488a497a3f7d4afb0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

Bdragon28 updated this revision to Diff 314052. Bdragon28 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Add missing OpenMP TLS test for powerpcle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a reviewer: q66. Bdragon28 added a comment. Add q66 to reviewers list for the targeting bits relevant to Void ppcle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313931. Bdragon28 added a comment. - Fix LLVM object handling unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/lib/Basic/Targets.cpp

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313930. Bdragon28 added a comment. Herald added a subscriber: mgorny. - Fix bug in clang/test/Driver/linux-header-search.cpp -- The powerpc64le test was being done with -m32 accidentally. - Update llvm/unittests/ADT/TripleTest.cpp for powerpcle. - Update

[PATCH] D93919: [PowerPC] Support powerpcle target in Clang [3/5]

Bdragon28 marked 3 inline comments as done. Bdragon28 added inline comments. Comment at: clang/test/Driver/ppc-endian.c:1 -// RUN: %clang -target powerpc64le -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-LE %s -// RUN: %clang -target powerpc64le -mlittle-endian -### -c %s

[PATCH] D93919: [PowerPC] Support powerpcle target in Clang [3/5]

Bdragon28 updated this revision to Diff 314049. Bdragon28 added a comment. - Adjust the GNU LD settings for 32 bit powerpc to more closely match reality. - Add linker emulation test for powerpcle, as well as adding testing for the FreeBSD emulations. Repository: rG LLVM Github Monorepo

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

Bdragon28 updated this revision to Diff 314019. Bdragon28 added a comment. Re-uploading patch for part 5 now that I have the dependency tree fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files:

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

Bdragon28 updated this revision to Diff 314012. Bdragon28 retitled this revision from "[PowerPC] Add powerpcle target." to "[PowerPC] Add powerpcle target. (5/5)". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/

[PATCH] D93919: [PowerPC] powerpcle target 3/5

Bdragon28 created this revision. Herald added subscribers: shchenz, kbarton, nemanjai, emaste. Bdragon28 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Splitting D92445 . Repository: rG LLVM Github

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313655. Bdragon28 added a comment. Fix merge base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/lib/Basic/Targets.cpp

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 marked 2 inline comments as done. Bdragon28 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2152 + "powerpcle-unknown-linux-gnu", +

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313654. Bdragon28 added a comment. - Address review comment from MaskRay. - Incorporate changes from the Void powerpcle patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313651. Bdragon28 added a comment. Trying again.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/lib/Basic/Targets.cpp

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313649. Bdragon28 edited the summary of this revision. Bdragon28 added a comment. Splitting up into multiple commits as per MaskRay's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2428563 , @sfertile wrote: >> On FreeBSD, the main use of this will be on the new powerpc64le arch, where >> we need to build a 32-bit LE bootloader for use with pseries. (it is easier >> to retarget LLVM than make a

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. Regarding things like Altivec and VSX: Altivec should be just fine to run in 32-bit LE. I am undecided as to whether VSX should be banned or not. However that goes, it should be identical in powerpc64 -m32 and powerpc64le -m32. Regarding codegen: CPU capabilities are

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427537 , @Bdragon28 wrote: > In D92445#2427438 , @nemanjai wrote: > >> This seems problematic to me for a few reasons: >> >> 1. There is no 32-bit toolchains or libraries for

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427439 , @MaskRay wrote: > This patch should be split. I suggest that you create 4 patches. > > - llvm: triple change > - llvm: llvm/Object/ELFObjectFile.h llvm-readobj llvm-objdump > - clang > - lld Can do.

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427438 , @nemanjai wrote: > This seems problematic to me for a few reasons: > > 1. There is no 32-bit toolchains or libraries for little endian Linux systems > 2. There is no support in the ELFv2 ABI for 32-bit object

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. On FreeBSD, the main use of this will be on the new powerpc64le arch, where we need to build a 32-bit LE bootloader for use with pseries. (it is easier to retarget LLVM than make a cross-endian bootloader, as it would involve rewriting filesystem code etc.) On

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 created this revision. Bdragon28 added reviewers: MaskRay, PowerPC, jhibbits. Bdragon28 added a project: PowerPC. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven.zhang, shchenz, rupprecht, kbarton, hiraditya, krytarowski, arichardson, nemanjai, emaste. Herald

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279918 , @jrtc27 wrote: > In D79916#2279901 , @Bdragon28 wrote: > >> In D79916#2279884 , @jrtc27 wrote: >> >>> But also you really

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279884 , @jrtc27 wrote: > But also you really should not get warnings for unused static functions in > included headers, only ones defined in the C source file itself. We'd have > countless warnings in the kernel

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279866 , @jrtc27 wrote: > In D79916#2279863 , @Bdragon28 wrote: > >> In D79916#2279816 , @jrtc27 wrote: >> >>> In D79916#2279812

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279863 , @Bdragon28 wrote: > In D79916#2279816 , @jrtc27 wrote: > >> In D79916#2279812 , @Bdragon28 >> wrote: >> >>> In D79916#2279045

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279816 , @jrtc27 wrote: > In D79916#2279812 , @Bdragon28 wrote: > >> In D79916#2279045 , @jrtc27 wrote: >> >>> This has significantly

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279045 , @jrtc27 wrote: > This has significantly regressed FreeBSD's performance with the new version > of Clang. It seems Clang does not inline functions at -O1, unlike GCC, and > since FreeBSD currently compiles

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added a comment. That's fair. Will just use a patch on the FreeBSD side and revisit after 11.0.0 is released. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added a comment. Any chance of a backport to 11? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425 ___ cfe-commits mailing list

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added inline comments. Comment at: clang/lib/Basic/Targets.cpp:361-362 return new LinuxTargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); case llvm::Triple::NetBSD: Bdragon28 wrote:

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added inline comments. Comment at: clang/lib/Basic/Targets.cpp:361-362 return new LinuxTargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); case llvm::Triple::NetBSD: emaste wrote: >

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 updated this revision to Diff 287811. Bdragon28 added a comment. Use correct target for FreeBSD driver test. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425 Files:

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added inline comments. Comment at: clang/test/Driver/freebsd.c:32 +// CHECK-PPC64LE: "--eh-frame-hdr" "-dynamic-linker" "{{.*}}ld-elf{{.*}}" "-o" "a.out" "{{.*}}crt1.o" "{{.*}}crti.o" "{{.*}}crtbegin.o" "-L[[SYSROOT]]/usr/lib" "{{.*}}.o" "-lgcc" "--as-needed"

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 updated this revision to Diff 287795. Bdragon28 added reviewers: MaskRay, dim. Bdragon28 added a comment. Herald added a subscriber: kbarton. Add some tests for the new target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 created this revision. Bdragon28 added a project: PowerPC. Herald added subscribers: cfe-commits, steven.zhang, shchenz, jsji, krytarowski, arichardson, nemanjai, emaste. Herald added a project: clang. As a prerequisite to doing experimental buids of pieces of FreeBSD PowerPC64 as

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

Bdragon28 added a comment. I am definitely in favor of this change, as the defaulting to PIC has been causing headaches in the FreeBSD kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72363/new/ https://reviews.llvm.org/D72363