[PATCH] D61865: [clangd] improve help message for limit-results

umanwizard added a comment. @kadircet what are the next steps? This is my first diff in llvm. I'm not a project member so presumably someone else will have to land it for me. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61865/new/

[PATCH] D61865: [clangd] improve help message for limit-results

umanwizard added a comment. Ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61865/new/ https://reviews.llvm.org/D61865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61865: [clangd] improve help message for limit-results

umanwizard created this revision. umanwizard added a reviewer: clang-tools-extra. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Make it clear that the default is 100. Repository: rCTE Clang Tools Extra

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

umanwizard added a comment. Ignore me. I didn't read the previous discussion before commenting. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61724/new/ https://reviews.llvm.org/D61724 ___ cfe-commits mailing list

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

umanwizard added inline comments. Comment at: clang-tools-extra/trunk/clangd/index/Background.cpp:164 stop(); - for (auto : ThreadPool) -Thread.join(); + ThreadPool.wait(); } This is already called in `~AsyncTaskRunner`. Repository: rL LLVM

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

umanwizard added a comment. By the way, index/Background.{cpp,h} also need to be changed to use the new API. I made that change locally and clangd with full project indexing is now working for me on macOS. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

umanwizard added a comment. Herald added a subscriber: dexonsmith. Herald added a project: clang. Is there any good reason not to land this? Clangd is crashing for me on macOS with stack overflow in the worker threads. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION