Re: [PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

2020-10-05 Thread Breno Guimarães via cfe-commits
Nice! I'm glad to see the patch being revived. Thanks for that :) Em seg, 5 de out de 2020 10:48, fiesh via Phabricator < revi...@reviews.llvm.org> escreveu: > fiesh added a comment. > > Continued in https://reviews.llvm.org/D88833 > > > CHANGES SINCE LAST ACTION >

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

2017-03-21 Thread Breno Guimarães via cfe-commits
est Regards, Breno G. On Tue, Mar 21, 2017 at 11:37 PM, Richard Smith <rich...@metafoo.co.uk> wrote: > On 21 March 2017 at 18:57, Breno Guimarães via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hey guys, >> >> I'm sorry the test did not ma

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

2017-03-21 Thread Breno Guimarães via cfe-commits
Hey guys, I'm sorry the test did not make the decay explicit. It's indeed sort of tricky: https://bugs.llvm.org/show_bug.cgi?id=32239 Basically, assert is expanded into: (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) Well, __func__ and __FILE__ are const char[],