[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Bryan Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1561495cd128: [flang][driver] Mark -L as visible in Flang (authored by erjin, committed by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">;

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">;

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

2023-08-23 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc8e46c7e5ea: [flang][driver] Mark -fuse-ld as visible in Flang (authored by erjin, committed by bryanpkc). Repository: rG LLVM Github Monorepo

[PATCH] D156128: [Clang][AArch64] Fix up immediate range of f64f64 mopa/mops intrinsics

2023-07-25 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc accepted this revision. bryanpkc added a comment. This revision is now accepted and ready to land. Thanks for the catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156128/new/ https://reviews.llvm.org/D156128

[PATCH] D156128: [Clang][AArch64] Fix up immediate range of f64f64 mopa/mops intrinsics

2023-07-24 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/include/clang/Basic/arm_sme.td:254 [IsStreaming, IsSharedZA], - [ImmCheck<0, ImmCheck0_3>]>; + [ImmCheck<0, ImmCheck0_0>]>; }

[PATCH] D156121: [Clang][AArch64] svldr_vnum/svstr_vnum should use cntsb iso vscale for the offset

2023-07-24 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc accepted this revision. bryanpkc added a comment. This revision is now accepted and ready to land. LGTM. Sorry for not catching this earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156121/new/ https://reviews.llvm.org/D156121

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

2023-07-20 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49 +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s -### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV +// SME-SUBFEATURE-CONFLICT-REV:

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

2023-07-20 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c38740ca661: [Clang][AArch64][SME] Generate target features from +(no)sme.* options (authored by bryanpkc). Repository: rG LLVM Github Monorepo

[PATCH] D134681: [Clang][AArch64][SME] Add outer product intrinsics

2023-07-20 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaebde82b29a8: [Clang][AArch64][SME] Add outer product intrinsics (authored by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

2023-07-20 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ae900c06363: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile (authored by bryanpkc). Repository: rG LLVM Github

[PATCH] D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length

2023-07-20 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15d16a79a01f: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length (authored by bryanpkc). Changed prior to commit:

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-07-20 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf225898a7c61: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR) (authored by bryanpkc). Repository: rG LLVM Github Monorepo

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

2023-07-20 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG578b0bd4e621: [Clang][AArch64][SME] Add ZA zeroing intrinsics (authored by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-07-17 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 541132. bryanpkc marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134678/new/ https://reviews.llvm.org/D134678 Files: clang/include/clang/Basic/arm_sme.td

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-07-17 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_str.c:24 +// CHECK-NEXT:[[TMP0:%.*]] = getelementptr i8, ptr [[PTR:%.*]], i64 [[MULVL]] +// CHECK-NEXT:tail call void

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

2023-07-17 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:22 +// +svint8_t test_svread_hor_za8_s8(svint8_t zd, svbool_t pg, uint32_t slice_base) __arm_streaming { +return

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

2023-07-16 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 540842. bryanpkc marked an inline comment as done. bryanpkc added a comment. Removed dependency on SVE and SVE2 as per @sdesmalen's suggestion. Also made `nobf16` imply `nosme` to be consistent with the handling of other feature dependencies. Repository:

[PATCH] D134681: [Clang][AArch64][SME] Add outer product intrinsics

2023-07-16 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 540841. bryanpkc added a comment. Removed the attribute macro from tests, as @sdesmalen suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134681/new/ https://reviews.llvm.org/D134681 Files:

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

2023-07-16 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 540840. bryanpkc added a comment. Removed the attribute macro from tests, as @sdesmalen suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134680/new/ https://reviews.llvm.org/D134680 Files:

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-07-16 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 540839. bryanpkc added a comment. Removed the attribute macro from tests, as @sdesmalen suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134678/new/ https://reviews.llvm.org/D134678 Files:

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

2023-07-16 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 540838. bryanpkc added a comment. Removed the attribute macro as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files: clang/include/clang/Basic/arm_sme.td

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

2023-07-16 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:13 +#else +#define ARM_STREAMING_ATTR __attribute__((arm_streaming)) +#endif sdesmalen wrote: > The spelling has

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

2023-06-28 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. @sdesmalen Could you take a look at the patch stack again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/ https://reviews.llvm.org/D128648 ___ cfe-commits mailing

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

2023-06-17 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 532431. bryanpkc marked 3 inline comments as done. bryanpkc added a comment. Rebased. NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files:

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-06-15 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 531953. bryanpkc added a comment. Also added SME attributes to the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134678/new/ https://reviews.llvm.org/D134678 Files:

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-06-15 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 531949. bryanpkc added a comment. Instead of defining new type flags, `EmitAArch64SMEBuiltinExpr` is updated to switch on `BuiltinID`, as suggested by @sdesmalen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

2023-06-14 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 531330. bryanpkc added a comment. Addressed @sdesmalen's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files: clang/include/clang/Basic/arm_sme.td

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

2023-06-05 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. @sdesmalen Could you review this and the rest of the patch stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/ https://reviews.llvm.org/D128648 ___ cfe-commits

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

2023-06-05 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 528293. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142702/new/ https://reviews.llvm.org/D142702 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp clang/test/Driver/aarch64-implied-sme-features.c

[PATCH] D134681: [Clang][AArch64][SME] Add outer product intrinsics

2023-06-05 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 528291. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134681/new/ https://reviews.llvm.org/D134681 Files: clang/include/clang/Basic/arm_sme.td clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_mopa-za32.c

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

2023-05-30 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 526683. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134680/new/ https://reviews.llvm.org/D134680 Files: clang/include/clang/Basic/arm_sme.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

2023-05-30 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 526621. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134680/new/ https://reviews.llvm.org/D134680 Files: clang/include/clang/Basic/arm_sme.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length

2023-05-28 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 526379. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134679/new/ https://reviews.llvm.org/D134679 Files: clang/include/clang/Basic/arm_sme.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-05-28 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 526361. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134678/new/ https://reviews.llvm.org/D134678 Files: clang/include/clang/Basic/TargetBuiltins.h clang/include/clang/Basic/arm_sme.td

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

2023-05-28 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 526351. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files: clang/include/clang/Basic/TargetBuiltins.h clang/include/clang/Basic/arm_sme.td clang/include/clang/Basic/arm_sve_sme_incl.td

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-05-28 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6250f59105: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics (authored by bryanpkc). Repository: rG LLVM Github Monorepo

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-05-17 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. @sdesmalen How does the latest version look to you? If you approve, I will land this and finish updating the rest of the patch series. One of the pre-merge builds failed for an unrelated reason, but other jobs were successful. Repository: rG LLVM Github Monorepo

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

2023-05-15 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. Rebased on main, and removed dependence on the SME attributes patch as per https://reviews.llvm.org/D127910?vs=522039=522064#inline-1451681. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-05-15 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 522064. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/include/clang/Basic/BuiltinsARM.def

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-05-14 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 522039. bryanpkc edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/BuiltinsNEON.def

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-05-11 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:726 -if (Feature == "+sme") { - HasSME = true; sdesmalen wrote: > Why did you remove this? The `Feature == "+sme"` case is also handled below on line 782. Perhaps we

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

2023-04-24 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. > May I ask you to commit the change? I do not have commit access. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148211/new/ https://reviews.llvm.org/D148211 ___

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

2023-04-24 Thread Bryan Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7b85bfffc486: [clang][tests] Fix Flang driver tests for Windows (authored by kaadam, committed by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

2023-04-21 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc accepted this revision. bryanpkc added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148211/new/ https://reviews.llvm.org/D148211 ___ cfe-commits mailing list

[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

2023-04-17 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. `clang/test/Driver/flang/multiple-inputs-mixed.f90` uses a more general FileCheck pattern: ! CHECK-SYNTAX-ONLY-LABEL: "{{[^"]*}}flang-new{{[^"/]*}}" "-fc1" Perhaps these files should use the same regexp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

2023-03-01 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/include/clang/Basic/arm_sme.td:103 +def NAME # _H : SInst<"svwrite_hor_" # n_suffix # "[_{d}]", "vimiPd", t, MergeOp1, + "aarch64_sme_write" # !cond(!eq(n_suffix, "za128") : "q", true: "") #

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-26 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 500638. bryanpkc edited the summary of this revision. bryanpkc added a comment. Fix some bugs in the range checks of immediate operands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-26 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 500630. bryanpkc added a comment. Moved test case `acle_target_sme.c` into `clang/test/Sema/aarch64-sme-intrinsics/`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

2023-02-26 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. @sdesmalen @rsandifo-arm @aaron.ballman @erichkeane What is the plan for this patch? Is it going to be abandoned in favor of D139028 , or can it be landed in its current form after addressing all outstanding review comments?

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-26 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 500578. bryanpkc added a comment. Removed `EltTypeBool128` as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-21 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8874 case SVETypeFlags::EltTyBool64: + case SVETypeFlags::EltTyBool128: return Builder.getInt1Ty(); kmclaughlin wrote: > Is it

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-19 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked an inline comment as done. bryanpkc added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:332 + # Generate arm_sme.h + clang_generate_header(-gen-arm-sme-header arm_sme.td arm_sme.h) # Generate arm_bf16.h sdesmalen wrote: >

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-19 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 498700. bryanpkc marked 2 inline comments as done and an inline comment as not done. bryanpkc added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-13 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 496976. bryanpkc marked an inline comment as done. bryanpkc added a comment. Fixed minor bugs in the previous upload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-13 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked 5 inline comments as done. bryanpkc added inline comments. Comment at: clang/include/clang/Basic/arm_sme.td:22 +let TargetGuard = "sme" in { + def SVLD1_HOR_ZA8 : MInst<"svld1_hor_za8", "vimiPQ", "c", [IsLoad, IsOverloadNone, IsStreaming, IsSharedZA],

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-13 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 496964. bryanpkc edited the summary of this revision. bryanpkc added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-12 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:332 + # Generate arm_sme.h + clang_generate_header(-gen-arm-sme-header arm_sme.td arm_sme.h) # Generate arm_bf16.h sdesmalen wrote: > The ACLE specification is still in a draft

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-07 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 495592. bryanpkc marked 4 inline comments as done. bryanpkc added a comment. Rebased on trunk and addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-02-07 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked 9 inline comments as done. bryanpkc added inline comments. Comment at: clang/include/clang/Basic/TargetBuiltins.h:312 + /// Flags to identify the types for overloaded SME builtins. + class SMETypeFlags { +uint64_t Flags; david-arm wrote: >

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc created this revision. bryanpkc added reviewers: sdesmalen, rsandifo-arm, david-arm. Herald added a subscriber: kristof.beyls. Herald added a project: All. bryanpkc requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D134681: [Clang][AArch64][SME] Add outer product intrinsics

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492693. bryanpkc retitled this revision from "[Clang][AArch64] Add SME outer product intrinsics" to "[Clang][AArch64][SME] Add outer product intrinsics". bryanpkc edited the summary of this revision. bryanpkc added a comment. Rebased and cleaned up the

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492692. bryanpkc edited the summary of this revision. bryanpkc added a comment. Added `_m` suffix to the intrinsics as required by the amendment in https://github.com/ARM-software/acle/pull/218. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D134680: [Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492682. bryanpkc retitled this revision from "[Clang][AArch64] Add SME svaddha and svaddva intrinsics" to "[Clang][AArch64][SME] Add intrinsics for adding vector elements to ZA tile". bryanpkc edited the summary of this revision. bryanpkc added a comment.

[PATCH] D134679: [Clang][AArch64][SME] Add intrinsics for reading streaming vector length

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492681. bryanpkc retitled this revision from "[Clang][AArch64] Add SME svcntsb/h/w/d C intrinsics" to "[Clang][AArch64][SME] Add intrinsics for reading streaming vector length". bryanpkc edited the summary of this revision. bryanpkc added a comment.

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492680. bryanpkc added a comment. Update patch with more context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files:

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

2023-01-27 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492679. bryanpkc retitled this revision from "[Clang][AArch64] Add SME ldr and str intrinsic" to "[Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)". bryanpkc edited the summary of this revision. bryanpkc added a comment. Rebased and

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-01-26 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492586. bryanpkc added a comment. Minor clean-up. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

2023-01-26 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 492585. bryanpkc retitled this revision from "[Clang][AArch64] Add SME C intrinsics for load and store" to "[Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics". bryanpkc edited the summary of this revision. bryanpkc added a comment. Updated

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-20 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG275ab246ee81: [Clang][test] Avoid FileCheck error when matching `-cc1` (authored by hezuoqiang hezuoqia...@huawei.com, committed by bryanpkc).

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-20 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc accepted this revision. bryanpkc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141886/new/ https://reviews.llvm.org/D141886

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-17 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc requested changes to this revision. bryanpkc added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/modules-ts.cpp:23 // -// CHECK-USE: -cc1 +// CHECK-USE: -cc1{{[^[:xdigit:]]}} // CHECK-USE-SAME: -emit-obj

[PATCH] D141886: [Clang][Test] Avoid matching version numbers

2023-01-16 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. Thanks for the patch. I just have some simple suggestions. Comment at: clang/test/Driver/modules-ts.cpp:23 // -// CHECK-USE: -cc1 +// CHECK-USE: -cc1{{[^[:xdigit:]]}} // CHECK-USE-SAME: -emit-obj An easier-to-understand fix is to

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

2023-01-09 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 487384. bryanpkc retitled this revision from "[Clang][AArch64] Add SME zero intrinsic" to "[Clang][AArch64][SME] Add ZA zeroing intrinsics". bryanpkc edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

2022-12-08 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 481205. bryanpkc added a comment. Removed some more unnecessary lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

2022-12-07 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 481137. bryanpkc added a comment. Removed some diffs that weren't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files:

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

2022-12-07 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked 2 inline comments as done. bryanpkc added a comment. @david-arm, I have moved all the SME definitions into a new file, arm_sme.td. I have moved the common definitions into another file, arm_sve_sme_incl.td, which will be included by both arm_sve.td and arm_sme.td. SveEmitter has

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

2022-12-07 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 481132. bryanpkc marked 5 inline comments as done. bryanpkc edited the summary of this revision. bryanpkc added a comment. Herald added a subscriber: mgrang. Herald added a reviewer: aaron.ballman. Updated the patch according to review comments which suggest

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

2022-11-24 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc commandeered this revision. bryanpkc added a reviewer: sagarkulkarni19. bryanpkc added a comment. In D127910#3885699 , @david-arm wrote: > Hi @sagarkulkarni19, just a gentle ping to see if you are still planning to > do more work on this patch?

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

2021-03-13 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:292 + std::string driverPath = llvm::sys::fs::getMainExecutable(nullptr, nullptr); + driverPath = driverPath.substr(0, driverPath.size() - 9); + return

[PATCH] D97119: [flang][driver] Add options for -std=f2018

2021-03-04 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. I agree with @richard.barton.arm that we could add `-std=` now, even if only for a subset of possible language standards. I expect that standard conformance checks would be quite pervasive, and it would be better to design the infrastructure for such checks earlier

[PATCH] D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++

2020-12-10 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. Herald added a subscriber: dang. @erikjv Are you still working on this? Or is a better alternative being pursued? IIUC, this functionality is still missing in trunk. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63329/new/

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

2020-10-29 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64SchedTSV110.td:9 +// +// This file defines the machine model for ARM Huawei TSV110 to support +// instruction scheduling and other instruction cost heuristics. I suggest deleting the word

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

2019-12-08 Thread Bryan Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG74e6ce2529fa: [Frontend] Allow OpenMP offloading to aarch64 (authored by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

2019-12-06 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 232627. bryanpkc marked 2 inline comments as done. bryanpkc added a comment. Removed unrelated changes from this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

2019-12-06 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked 6 inline comments as done. bryanpkc added inline comments. Comment at: clang/test/OpenMP/openmp_offload_registration.cpp:3-5 +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

2019-12-05 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/test/OpenMP/target_messages.cpp:4 + +// RUN: not %clang_cc1 -fopenmp -std=c++11 -fopenmp-targets=aaa-bbb-ccc-ddd -o - %s 2>&1 | FileCheck %s // CHECK: error: OpenMP target is invalid: 'aaa-bbb-ccc-ddd' ABataev

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

2019-12-05 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. Pinging reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

2019-11-29 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 231582. bryanpkc added a comment. Add tests for -fopenmp-targets=. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804 Files: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

2019-11-28 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. In D70804#1763289 , @ABataev wrote: > Tests are required The tests for this were added in D30644 , but they are currently failing on AArch64 due to D32035 .

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

2019-11-28 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc created this revision. bryanpkc added reviewers: pawosm01, gtbercea. Herald added subscribers: cfe-commits, guansong, kristof.beyls. Herald added a reviewer: jdoerfert. Herald added a project: clang. D30644 added OpenMP offloading to AArch64 targets,

[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

2018-10-25 Thread Bryan Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345344: [AArch64] Implement FP16FML intrinsics (authored by bryanpkc, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

2018-10-24 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added a comment. In https://reviews.llvm.org/D53633#1274621, @t.p.northover wrote: > I think this is reasonable. Thanks Tim. Could you also review https://reviews.llvm.org/D53632, which is the LLVM part of this implementation? Repository: rC Clang https://reviews.llvm.org/D53633

[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

2018-10-23 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc created this revision. bryanpkc added reviewers: SjoerdMeijer, bogden, efriedma, t.p.northover. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Generate the FP16FML intrinsics into arm_neon.h (AArch64 only for now). Add two new type modifiers to NeonEmitter to handle