[PATCH] D28543: Eliminates uninitialized warning for volatile variables.

2017-03-03 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote added a comment. Is there any subgroup that one could suggest for this warning to fall under? https://reviews.llvm.org/D28543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29737: Updates documentation to include command to run clang-tidy tests.

2017-02-08 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote created this revision. Herald added a subscriber: JDevlieghere. Adds the commandline need to run clang-tidy tests. https://reviews.llvm.org/D29737 Files: clang-tools-extra/docs/clang-tidy/index.rst Index: clang-tools-extra/docs/clang-tidy/index.rst

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-02-08 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote added a comment. Any updates on this? https://reviews.llvm.org/D28543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28973: Supresses misc-move-constructor-init warning for const fields.

2017-02-07 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote updated this revision to Diff 87484. lethalantidote marked an inline comment as done. lethalantidote added a comment. - Addresses alexfh's comments. https://reviews.llvm.org/D28973 Files: clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp

[PATCH] D28973: Supresses misc-move-constructor-init warning for const fields.

2017-01-20 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote created this revision. Supresses misc-move-constructor init warning for const fields. https://reviews.llvm.org/D28973 Files: clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp clang-tools-extra/test/clang-tidy/misc-move-constructor-init.cpp Index:

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote updated this revision to Diff 84045. lethalantidote added a comment. Moves check in IsTracked(). https://reviews.llvm.org/D28543 Files: clang/lib/Analysis/UninitializedValues.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp clang/test/Sema/uninit-variables.c Index:

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote added a comment. So I tried the update you suggested (moving it up into IsTracked) and it seems to work and the reasoning makes sense to me. https://reviews.llvm.org/D28543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote updated this revision to Diff 84026. lethalantidote marked an inline comment as done. lethalantidote added a comment. Addresses moving check further up, during analysis. Adds test to check for sometimes branch. Please review. https://reviews.llvm.org/D28543 Files:

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:907 else DiagUninitUse(S, VD, Use, true); } thakis wrote: > Should the check be in DiagUninitUse()? Or is there a reason this one should > happen for

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-10 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote created this revision. lethalantidote added a reviewer: thakis. lethalantidote added a subscriber: cfe-commits. Elliminates uninitialized warning for volitile variables. https://reviews.llvm.org/D28543 Files: clang/lib/Sema/AnalysisBasedWarnings.cpp Index: