carlocab added inline comments.
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2147
+default:
+ // We shouldn't get here, unless the target OS doesn't have an SDK.
+ break;
`llvm_unreachable`? Or `assert`, at least.
Comment
carlocab added inline comments.
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2136
+} else {
+sdk = "macosx";
+}
Since we’re already doing a bunch of triple checks above, it probably doesn’t
hurt to check that we really are targeting macOS
carlocab added a comment.
Herald added a project: All.
Per suggestion on Discord, here’s my git author line:
Carlo Cabrera
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119144/new/
https://reviews.llvm.org/D119144
carlocab added a comment.
Thanks Petr. I don’t have commit access, so I’d appreciate it if you could
commit this for me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119144/new/
https://reviews.llvm.org/D119144
carlocab created this revision.
carlocab added a reviewer: abidh.
carlocab added a project: clang.
Herald added a subscriber: ki.stfu.
carlocab requested review of this revision.
Herald added a subscriber: cfe-commits.
The `baremetal-sysroot` test fails when the toolchain is configured with
