[PATCH] D45109: Remove -cc1 option "-backend-option"

mcrosier accepted this revision. mcrosier added a comment. SGTM! Repository: rC Clang https://reviews.llvm.org/D45109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45092: [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking

This revision was automatically updated to reflect the committed changes. Closed by commit rC329810: [Driver] Dont forward -m[no-]unaligned-access options to GCC when… (authored by mcrosier, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

[PATCH] D45499: [Driver] Handle the default case

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC329754: [Driver] Handle the default case missed in r329748. (authored by mcrosier, committed by ). Changed prior to

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

mcrosier added a comment. In https://reviews.llvm.org/D40476#936700, @mcrosier wrote: > In https://reviews.llvm.org/D40476#936372, @pirama wrote: > > > Thanks for the review. Now let's just hope the windows bots stay happy :) > > > Actually, I just checked and it looks like falkor and saphira

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

mcrosier added a comment. In https://reviews.llvm.org/D40476#936372, @pirama wrote: > Thanks for the review. Now let's just hope the windows bots stay happy :) Actually, I just checked and it looks like falkor and saphira were both added as of a few weeks ago. I'll revert this part of the

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

mcrosier added a comment. Am I correct in assuming this is going to be a problem for Falkor and Saphira as well? If so, can you add solutions for those as well? Cortex-a57 should be good enough for those targets as well. https://reviews.llvm.org/D40476

[PATCH] D38863: Typos in tutorial

mcrosier closed this revision. mcrosier added a comment. Committed in r315652. https://reviews.llvm.org/D38863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

mcrosier added a comment. In https://reviews.llvm.org/D37106#851441, @SjoerdMeijer wrote: > Thanks for fixing this. np! Thanks for the review! Repository: rL LLVM https://reviews.llvm.org/D37106 ___ cfe-commits mailing list

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311660: [Driver][AArch64] Add tests for RDM feature. (authored by mcrosier). Changed prior to commit: https://reviews.llvm.org/D37106?vs=112543=112559#toc Repository: rL LLVM

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

mcrosier created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. Clang side of https://reviews.llvm.org/D37081. Chad https://reviews.llvm.org/D37106 Files: test/Driver/aarch64-rdm.c Index: test/Driver/aarch64-rdm.c

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

mcrosier added a comment. Seems reasonable to me as well.. https://reviews.llvm.org/D36238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35577#818936, @kparzysz wrote: > In https://reviews.llvm.org/D35577#817944, @echristo wrote: > > > "Should this just be part of the tuning for the hexagon backend and not > > options at all" > > > > > I don't think we need separate

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

mcrosier added subscribers: echristo, ddunbar, mcrosier. mcrosier added reviewers: echristo, ddunbar. mcrosier added a comment. Adding @echristo and @ddunbar who have been the primary owners of the driver for the past decade or so. https://reviews.llvm.org/D35577

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added reviewers: echristo, ddunbar. mcrosier added subscribers: echristo, ddunbar. mcrosier added a comment. Adding @echristo and @ddunbar who have been the primary owners of the driver for the past decade or so. https://reviews.llvm.org/D35578

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35578#814817, @sgundapa wrote: > > Wouldn't the fix be to make the backend deal with this, then? Either by > > putting the table with the function text, or or opting out of lookup > > tables? It seems that might be a better experience for

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35578#813629, @Quuxplusone wrote: > If the goal is fine-grained control over the heuristics for compiling switch > statements, perhaps one should enumerate all the possible ways to lower > switch statements --- jump-tables, lookup-tables,

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35578#813548, @sgundapa wrote: > The switch-case statements generate two kinds of tables. > > 1. Jump tables > 2. Lookup tables. > > While the general assumption is that switch-case statements generate jump > tables, the below case

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. What exactly is the difference between -fno-jump-tables, -fno-switch-tables, and -fno-lookup-tables? https://reviews.llvm.org/D35578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35465: [clang] Remove redundant check-prefix=CHECK from tests. NFC.

mcrosier accepted this revision. mcrosier added a comment. LGTM. https://reviews.llvm.org/D35465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291574: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific. (authored by mcrosier). Changed prior to commit: https://reviews.llvm.org/D28400?vs=83367=83817#toc Repository: rL

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

mcrosier added inline comments. Comment at: test/CodeGen/arm_acle.c:247 // ARM-LABEL: test_rbit // AArch32: call i32 @llvm.arm.rbit +// AArch64: call i32 @llvm.bitreverse.i32 RKSimon wrote: > Since you're here is it worth dealing with the AARCH32 case as well?

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

mcrosier created this revision. mcrosier added reviewers: jmolloy, t.p.northover, gberry, RKSimon, rengolin. mcrosier added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Per the title, this patch replaces the target-specific intrinsic with a target-independent equivalent. This

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

mcrosier added inline comments. Comment at: test/CodeGen/fentry.c:11 + +//HAS: attributes #{{[0-9]+}} = { {{.*}}"fentry-call"="true"{{.*}} } +//NOHAS-NOT: attributes #{{[0-9]+}} = { {{.*}}"fentry-call"{{.*}} } mcrosier wrote: > I'd prefer we stick with the

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

mcrosier added inline comments. Comment at: include/clang/Driver/Options.td:1731 def mno_pie_copy_relocations : Flag<["-"], "mno-pie-copy-relocations">, Group; +def mfentry : Flag<["-"], "mfentry">, HelpText<"insert calls to fentry at function entry">, Flags<[CC1Option]>,