[clang] aaf7ffd - Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

2020-10-26 Thread Chandler Carruth via cfe-commits
Author: Chandler Carruth Date: 2020-10-27T01:36:54Z New Revision: aaf7ffd4e1aa81c7f4cc8da4f943982ca2e131f4 URL: https://github.com/llvm/llvm-project/commit/aaf7ffd4e1aa81c7f4cc8da4f943982ca2e131f4 DIFF: https://github.com/llvm/llvm-project/commit/aaf7ffd4e1aa81c7f4cc8da4f943982ca2e131f4.diff

[clang] dc1499b - Improve Clang's getting involved document and make it more inclusive in wording.

2019-10-23 Thread Chandler Carruth via cfe-commits
Author: Chandler Carruth Date: 2019-10-23T16:11:24-07:00 New Revision: dc1499b90dc41838e1ee8c7052bbe9535b3609bb URL: https://github.com/llvm/llvm-project/commit/dc1499b90dc41838e1ee8c7052bbe9535b3609bb DIFF:

Re: r351629 - Emit !callback metadata and introduce the callback attribute

2019-01-22 Thread Chandler Carruth via cfe-commits
On Sat, Jan 19, 2019 at 2:18 AM Johannes Doerfert via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jdoerfert > Date: Fri Jan 18 21:36:54 2019 > New Revision: 351629 > > URL: http://llvm.org/viewvc/llvm-project?rev=351629=rev > Log: > Emit !callback metadata and introduce the

Re: r351629 - Emit !callback metadata and introduce the callback attribute

2019-01-22 Thread Chandler Carruth via cfe-commits
On Sat, Jan 19, 2019 at 2:18 AM Johannes Doerfert via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jdoerfert > Date: Fri Jan 18 21:36:54 2019 > New Revision: 351629 > > URL: http://llvm.org/viewvc/llvm-project?rev=351629=rev > Log: > Emit !callback metadata and introduce the

[libunwind] r351731 - Fix typos throughout the license files that somehow I and my reviewers

2019-01-21 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added the

[clang-tools-extra] r351731 - Fix typos throughout the license files that somehow I and my reviewers

2019-01-21 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added the

[libclc] r351731 - Fix typos throughout the license files that somehow I and my reviewers

2019-01-21 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added the

r351731 - Fix typos throughout the license files that somehow I and my reviewers

2019-01-21 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added the

r351651 - Update the license mentioned in this documentation.

2019-01-19 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Sat Jan 19 03:48:15 2019 New Revision: 351651 URL: http://llvm.org/viewvc/llvm-project?rev=351651=rev Log: Update the license mentioned in this documentation. Modified: cfe/trunk/tools/scan-build-py/README.md Modified: cfe/trunk/tools/scan-build-py/README.md URL:

[libunwind] r351648 - Update more file headers across all of the LLVM projects in the monorepo

2019-01-19 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Sat Jan 19 02:56:40 2019 New Revision: 351648 URL: http://llvm.org/viewvc/llvm-project?rev=351648=rev Log: Update more file headers across all of the LLVM projects in the monorepo to reflect the new license. These used slightly different spellings that defeated my regular

r351640 - Update the license header in this man-page file.

2019-01-19 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Sat Jan 19 01:24:38 2019 New Revision: 351640 URL: http://llvm.org/viewvc/llvm-project?rev=351640=rev Log: Update the license header in this man-page file. It contains an `$Id$` expansion and so can only be updated from a true Subversion client. See the details of this

[libclc] r351636 - Update the file headers across all of the LLVM projects in the monorepo

2019-01-19 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Sat Jan 19 00:50:56 2019 New Revision: 351636 URL: http://llvm.org/viewvc/llvm-project?rev=351636=rev Log: Update the file headers across all of the LLVM projects in the monorepo to reflect the new license. We understand that people may be surprised that we're moving the

r351634 - Convert two more files that were using Windows line endings and remove

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:36:08 2019 New Revision: 351634 URL: http://llvm.org/viewvc/llvm-project?rev=351634=rev Log: Convert two more files that were using Windows line endings and remove a stray single '\r' from one file. These are the last line ending issues I can find in the

[clang-tools-extra] r351634 - Convert two more files that were using Windows line endings and remove

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:36:08 2019 New Revision: 351634 URL: http://llvm.org/viewvc/llvm-project?rev=351634=rev Log: Convert two more files that were using Windows line endings and remove a stray single '\r' from one file. These are the last line ending issues I can find in the

r351633 - Remove random windows line endings that snuck into the middle of this

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:36:00 2019 New Revision: 351633 URL: http://llvm.org/viewvc/llvm-project?rev=351633=rev Log: Remove random windows line endings that snuck into the middle of this code. Modified: cfe/trunk/lib/Lex/PPDirectives.cpp Modified:

[clang-tools-extra] r351632 - Update some code used in our visual studio plugins to use linux file

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:29:07 2019 New Revision: 351632 URL: http://llvm.org/viewvc/llvm-project?rev=351632=rev Log: Update some code used in our visual studio plugins to use linux file endings. We already used them in some cases, and this makes things consistent. This will also

r351632 - Update some code used in our visual studio plugins to use linux file

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:29:07 2019 New Revision: 351632 URL: http://llvm.org/viewvc/llvm-project?rev=351632=rev Log: Update some code used in our visual studio plugins to use linux file endings. We already used them in some cases, and this makes things consistent. This will also

[libclc] r351631 - Install new LLVM license structure and new developer policy.

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects in

r351631 - Install new LLVM license structure and new developer policy.

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects in

[libunwind] r351631 - Install new LLVM license structure and new developer policy.

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects in

[clang-tools-extra] r351631 - Install new LLVM license structure and new developer policy.

2019-01-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects in

r344730 - [TI removal] Test predicate rather than casting to detect a terminator

2018-10-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Oct 18 01:16:20 2018 New Revision: 344730 URL: http://llvm.org/viewvc/llvm-project?rev=344730=rev Log: [TI removal] Test predicate rather than casting to detect a terminator and use the range based successor API. Modified: cfe/trunk/lib/CodeGen/CGLoopInfo.cpp

r344504 - [TI removal] Make `getTerminator()` return a generic `Instruction`.

2018-10-15 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Oct 15 03:42:50 2018 New Revision: 344504 URL: http://llvm.org/viewvc/llvm-project?rev=344504=rev Log: [TI removal] Make `getTerminator()` return a generic `Instruction`. This removes the primary remaining API producing `TerminatorInst` which will reduce the rate at

[clang-tools-extra] r344225 - Fix the qualification of `IntrusiveRefCntPtr` to use `llvm::`.

2018-10-11 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Oct 11 01:05:10 2018 New Revision: 344225 URL: http://llvm.org/viewvc/llvm-project?rev=344225=rev Log: Fix the qualification of `IntrusiveRefCntPtr` to use `llvm::`. Without this, the code only compiled if the header was included after something introduced the alias

r341363 - [x86/SLH] Add a real Clang flag and LLVM IR attribute for Speculative

2018-09-04 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Tue Sep 4 05:38:00 2018 New Revision: 341363 URL: http://llvm.org/viewvc/llvm-project?rev=341363=rev Log: [x86/SLH] Add a real Clang flag and LLVM IR attribute for Speculative Load Hardening. Wires up the existing pass to work with a proper IR attribute rather than just

r340727 - Try to fix this clang driver test case after r340709.

2018-08-27 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Aug 27 01:49:20 2018 New Revision: 340727 URL: http://llvm.org/viewvc/llvm-project?rev=340727=rev Log: Try to fix this clang driver test case after r340709. If any of the bots complain about this, I'll just revert. This test case is essentially trying to test the

Re: r340709 - [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

2018-08-27 Thread Chandler Carruth via cfe-commits
Build bots have been broken all day, so I'm trying a speculative fix in r340727. If this doesn't work, i'll just revert all of this. On Sun, Aug 26, 2018 at 3:51 PM Chandler Carruth wrote: > FYI, test cases also seem to need updating: > >

Re: r340709 - [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

2018-08-26 Thread Chandler Carruth via cfe-commits
FYI, test cases also seem to need updating: http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/19575/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Amips-mti-linux.c On Sun, Aug 26, 2018 at 12:48 PM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray >

Re: r294176 - [AVR] Add support for the full set of inline asm constraints

2018-08-23 Thread Chandler Carruth via cfe-commits
This was due to r340519. I've fixed it in r340596 to clean things up. On Thu, Aug 23, 2018 at 8:20 PM Chandler Carruth wrote: > Trying new address again... > > > On Thu, Aug 23, 2018 at 8:17 PM Chandler Carruth > wrote: > >> Sorry for ancient thread revival, but... >> >> On Mon, Feb 6, 2017 at

r340596 - [AVR] Fix inline asm calls now that the addrspace(0) there is explicit.

2018-08-23 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Aug 23 21:45:04 2018 New Revision: 340596 URL: http://llvm.org/viewvc/llvm-project?rev=340596=rev Log: [AVR] Fix inline asm calls now that the addrspace(0) there is explicit. This updates the test case for r340519 so it should pass again. r340522 only got some of the

Re: r294176 - [AVR] Add support for the full set of inline asm constraints

2018-08-23 Thread Chandler Carruth via cfe-commits
Trying new address again... On Thu, Aug 23, 2018 at 8:17 PM Chandler Carruth wrote: > Sorry for ancient thread revival, but... > > On Mon, Feb 6, 2017 at 2:10 AM Dylan McKay via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: dylanmckay >> Date: Mon Feb 6 03:01:59 2017 >> New

Re: r294176 - [AVR] Add support for the full set of inline asm constraints

2018-08-23 Thread Chandler Carruth via cfe-commits
Sorry for ancient thread revival, but... On Mon, Feb 6, 2017 at 2:10 AM Dylan McKay via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dylanmckay > Date: Mon Feb 6 03:01:59 2017 > New Revision: 294176 > > URL: http://llvm.org/viewvc/llvm-project?rev=294176=rev > Log: > [AVR] Add

r340515 - [x86/retpoline] Split the LLVM concept of retpolines into separate

2018-08-23 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Wed Aug 22 23:06:38 2018 New Revision: 340515 URL: http://llvm.org/viewvc/llvm-project?rev=340515=rev Log: [x86/retpoline] Split the LLVM concept of retpolines into separate subtarget features for indirect calls and indirect branches. This is in preparation for enabling

r338979 - [docs] Don't use the `asm` syntax highlighting (which our docs builder

2018-08-05 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Sun Aug 5 18:28:42 2018 New Revision: 338979 URL: http://llvm.org/viewvc/llvm-project?rev=338979=rev Log: [docs] Don't use the `asm` syntax highlighting (which our docs builder errors on) and clean up the formattting. This isn't actualy assembly anyways, so dropping the

r338209 - Revert r337456: [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-28 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Sat Jul 28 20:05:07 2018 New Revision: 338209 URL: http://llvm.org/viewvc/llvm-project?rev=338209=rev Log: Revert r337456: [CodeGen] Disable aggressive structor optimizations at -O0, take 3 This commit increases the number of sections and overall output size of .o files

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-28 Thread Chandler Carruth via cfe-commits
On Sat, Jul 28, 2018 at 2:26 AM Chandler Carruth wrote: > On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: labath >> Date: Thu Jul 19 07:05:22 2018 >> New Revision: 337456 >> >> URL:

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-28 Thread Chandler Carruth via cfe-commits
On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: labath > Date: Thu Jul 19 07:05:22 2018 > New Revision: 337456 > > URL: http://llvm.org/viewvc/llvm-project?rev=337456=rev > Log: > [CodeGen] Disable aggressive structor optimizations at

r335310 - [x86] Fix a tiny bug in my test case in r335309 by marking that we don't

2018-06-21 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Jun 21 16:52:36 2018 New Revision: 335310 URL: http://llvm.org/viewvc/llvm-project?rev=335310=rev Log: [x86] Fix a tiny bug in my test case in r335309 by marking that we don't expect any diagnostics. Modified: cfe/trunk/test/Sema/builtins-x86.cpp Modified:

r335309 - [x86] Teach the builtin argument range check to allow invalid ranges in

2018-06-21 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Jun 21 16:46:09 2018 New Revision: 335309 URL: http://llvm.org/viewvc/llvm-project?rev=335309=rev Log: [x86] Teach the builtin argument range check to allow invalid ranges in dead code. This is important for C++ templates that essentially compute the valid input in a

r331411 - [gcov] Make the CLang side coverage test work with the new

2018-05-02 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Wed May 2 15:57:20 2018 New Revision: 331411 URL: http://llvm.org/viewvc/llvm-project?rev=331411=rev Log: [gcov] Make the CLang side coverage test work with the new instrumentation codegeneration strategy of using a data structure and a loop. Required some finesse to get

Re: r331244 - Implement P0482R2, support for char8_t type.

2018-05-01 Thread Chandler Carruth via cfe-commits
I adjusted the test case in r331245 - it was failing for me and most of the build bots. Please check that I didn't miss anything. On Mon, Apr 30, 2018 at 10:06 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Apr 30 22:02:45 2018 > New Revision:

r331245 - Fix up r331244 - the emitted definition is weak_odr linkage. Should get

2018-05-01 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Apr 30 23:48:30 2018 New Revision: 331245 URL: http://llvm.org/viewvc/llvm-project?rev=331245=rev Log: Fix up r331244 - the emitted definition is weak_odr linkage. Should get the build bots to healthy again without a full revert. As the functionality added has nothing

Re: r331056 - [docs] add -ffp-cast-overflow-workaround to the release notes

2018-04-27 Thread Chandler Carruth via cfe-commits
On Fri, Apr 27, 2018 at 5:13 PM Richard Smith <rich...@metafoo.co.uk> wrote: > On 27 April 2018 at 17:09, Chandler Carruth via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Fri, Apr 27, 2018 at 4:36 PM Richard Smith via cfe-commits < >> cfe-commits

Re: r331056 - [docs] add -ffp-cast-overflow-workaround to the release notes

2018-04-27 Thread Chandler Carruth via cfe-commits
On Fri, Apr 27, 2018 at 4:36 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 27 April 2018 at 16:07, Sanjay Patel via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Missing dash corrected at r331057. I can improve the doc wording, but >> let's settle on the

r330997 - [x86] Revert r330322 (& r330323): Lowering x86 adds/addus/subs/subus intrinsics

2018-04-26 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Apr 26 14:46:01 2018 New Revision: 330997 URL: http://llvm.org/viewvc/llvm-project?rev=330997=rev Log: [x86] Revert r330322 (& r330323): Lowering x86 adds/addus/subs/subus intrinsics The LLVM commit introduces a crash in LLVM's instruction selection. I filed

Re: [clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Chandler Carruth via cfe-commits
I won't be back at a computer for a while and I really don't know anything about objective-c... But if you don't feel confident submitting fixes with post commit review, you should probably just revert If the fix is trivial and/or you can find ways to test it a similar suggested in my earlier

Re: [clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Chandler Carruth via cfe-commits
See my other email -- you can compile code targeting other platforms regardless of the platform you develop on. Not exactly as good as reproducing it with a bot, but about the best you have. On Sun, Apr 22, 2018 at 6:01 PM Chandler Carruth wrote: > I don't know anything

Re: [clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Chandler Carruth via cfe-commits
I don't know anything about objective-c, or anything about OSX. However, I guarantee these bots aren't using 32-bit OSX. ;] Look at the bot names. They're running Linux in various flavors: ppc64be, ppc64le, armv8, etc. My suspicion is that this is a linux-specific issue. But you can reproduce

Re: [clang-tools-extra] r330559 - update test to use ivar in implementation instead of class extension

2018-04-22 Thread Chandler Carruth via cfe-commits
The commit log here no longer reflects the commit. This is not just updating the test, this is a complete re-application of the original patch in r330492. =[ Also, the bots are still complaining: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/17830

Re: [clang-tools-extra] r330492 - [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-21 Thread Chandler Carruth via cfe-commits
Should be able to reproduce it by patching it in and running the tests yourself? Nothing configuration specific here. Still, no hurry. On Sat, Apr 21, 2018 at 6:02 PM Yan Zhang via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Sorry I was out today. What is the new error? Can u send it to

Re: [clang-tools-extra] r330492 - [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-21 Thread Chandler Carruth via cfe-commits
Ok, this still isn't fixed a day later and over half our build bots are red because of it. =/ I tried just applying the patch, and it doesn't seem to fully fix the test as it results in a different error... I've reverted in r330528 for now so that our bots are green. =] Feel free to re-land once

[clang-tools-extra] r330528 - Revert r330492: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-21 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Sat Apr 21 16:27:34 2018 New Revision: 330528 URL: http://llvm.org/viewvc/llvm-project?rev=330528=rev Log: Revert r330492: [clang-tidy] add new check to find out objc ivars which do not have prefix '_' This commit has been breaking most bots for a day now. There is a fix

Re: [clang-tools-extra] r330492 - [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-21 Thread Chandler Carruth via cfe-commits
I see Alex already got it, but in the future, that kind of trivial test fix for a failing test is fine to just land, and it is more important to get the bots healthy. =] On Fri, Apr 20, 2018, 22:14 Yan Zhang via cfe-commits < cfe-commits@lists.llvm.org> wrote: > https://reviews.llvm.org/D45912

Re: [clang-tools-extra] r330492 - [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

2018-04-20 Thread Chandler Carruth via cfe-commits
This has broken most of the build bots. Are you working on a fix or revert? Might be useful to get on the IRC channel to help coordinate this kind of thing. On Fri, Apr 20, 2018 at 4:45 PM Yan Zhang via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: wizard > Date: Fri Apr 20

r330184 - Add some infuriatingly necessary comments to this test case.

2018-04-17 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Tue Apr 17 04:08:05 2018 New Revision: 330184 URL: http://llvm.org/viewvc/llvm-project?rev=330184=rev Log: Add some infuriatingly necessary comments to this test case. Without these comments, by "luck" the contents of SomeKit's SKWidget.h are precisely the same as

Re: [clang-tools-extra] r329550 - Fix unused variable warning.

2018-04-09 Thread Chandler Carruth via cfe-commits
Chandler. > >assert(Result.Nodes.getNodeAs("call")); > > would also be fine. > > пн, 9 апр. 2018 г. в 10:29, Chandler Carruth via cfe-commits < > cfe-commits@lists.llvm.org>: > >> Author: chandlerc >> Date: Mon Apr 9 00:26:42 2018 >> New

[clang-tools-extra] r329550 - Fix unused variable warning.

2018-04-09 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Apr 9 00:26:42 2018 New Revision: 329550 URL: http://llvm.org/viewvc/llvm-project?rev=329550=rev Log: Fix unused variable warning. Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp Modified:

Re: r329110 - [driver][darwin] Do not infer -simulator environment for non-simulator SDKs

2018-04-03 Thread Chandler Carruth via cfe-commits
On Tue, Apr 3, 2018 at 4:01 PM Alex L via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 3 April 2018 at 14:30, Chandler Carruth wrote: > >> On Tue, Apr 3, 2018 at 1:52 PM Alex Lorenz via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: arphaman >>>

Re: r329110 - [driver][darwin] Do not infer -simulator environment for non-simulator SDKs

2018-04-03 Thread Chandler Carruth via cfe-commits
On Tue, Apr 3, 2018 at 1:52 PM Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Tue Apr 3 13:50:05 2018 > New Revision: 329110 > > URL: http://llvm.org/viewvc/llvm-project?rev=329110=rev > Log: > [driver][darwin] Do not infer -simulator environment for

Re: r329113 - Add REQUIRES: darwin-system to test/Driver/darwin-sdkroot.c

2018-04-03 Thread Chandler Carruth via cfe-commits
See my reply to the original commit, but I think this is the wrong fix. On Tue, Apr 3, 2018 at 2:13 PM Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Tue Apr 3 14:10:26 2018 > New Revision: 329113 > > URL:

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

2018-02-02 Thread Chandler Carruth via cfe-commits
Merged in r324067 (llvm), r324068 (cfe), r324069 (lld) > > > r323288 > > Merged in r324070. > > > r323915 > > Merged in r324071. > > > > > +Reid Kleckner was going to look at doing the (likely more involved) > > backport to the 5 branch > >

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

2018-02-01 Thread Chandler Carruth via cfe-commits
kely more involved) backport to the 5 branch On Mon, Jan 22, 2018 at 2:06 PM Chandler Carruth via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chandlerc > Date: Mon Jan 22 14:05:25 2018 > New Revision: 323155 > > URL: http://llvm.org/viewvc/llvm-pr

r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injec

2018-01-22 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Jan 22 14:05:25 2018 New Revision: 323155 URL: http://llvm.org/viewvc/llvm-project?rev=323155=rev Log: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by

[libunwind] r321469 - There is no portable format string for printing `uintptr_t` values.

2017-12-26 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Tue Dec 26 21:46:53 2017 New Revision: 321469 URL: http://llvm.org/viewvc/llvm-project?rev=321469=rev Log: There is no portable format string for printing `uintptr_t` values. Instead, cast them to `void *` which has a portable format string syntax of `%p`. This fixes a

r321392 - Add an explicit `LLVM_FALLTHROUGH` annotation to an intentional

2017-12-22 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Dec 22 15:29:49 2017 New Revision: 321392 URL: http://llvm.org/viewvc/llvm-project?rev=321392=rev Log: Add an explicit `LLVM_FALLTHROUGH` annotation to an intentional fallthrough. Fixes GCC and Clang warnings about this. Modified: cfe/trunk/lib/Sema/SemaType.cpp

r318137 - [PM] Require a registered x86 target for this test which uses the x86

2017-11-13 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Nov 13 21:20:03 2017 New Revision: 318137 URL: http://llvm.org/viewvc/llvm-project?rev=318137=rev Log: [PM] Require a registered x86 target for this test which uses the x86 triple. Modified: cfe/trunk/test/CodeGen/bounds-checking.c Modified:

r318131 - [PM] Wire up support for the bounds checking sanitizer with the new PM.

2017-11-13 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Nov 13 17:59:18 2017 New Revision: 318131 URL: http://llvm.org/viewvc/llvm-project?rev=318131=rev Log: [PM] Wire up support for the bounds checking sanitizer with the new PM. Not much interesting here. Mostly wiring things together. One thing worth noting is that the

r318130 - [PM] Add a missing header that I had in the next commit but was needed

2017-11-13 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Nov 13 17:47:24 2017 New Revision: 318130 URL: http://llvm.org/viewvc/llvm-project?rev=318130=rev Log: [PM] Add a missing header that I had in the next commit but was needed in r318128. Should fix the build. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp

r318128 - [PM] Port BoundsChecking to the new PM.

2017-11-13 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Nov 13 17:30:04 2017 New Revision: 318128 URL: http://llvm.org/viewvc/llvm-project?rev=318128=rev Log: [PM] Port BoundsChecking to the new PM. Registers it and everything, updates all the references, etc. Next patch will add support to Clang's

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

2017-09-04 Thread Chandler Carruth via cfe-commits
On Sun, Sep 3, 2017 at 10:41 PM Hal Finkel via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > Nevertheless, I think that you've convinced me that this is a least-bad > solution. I'll want a flag preserving the old behavior. Something like > -fwiden-bitfield-accesses (modulo bikeshedding). >

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

2017-08-22 Thread Chandler Carruth via cfe-commits
On Tue, Aug 22, 2017 at 7:18 PM Xinliang David Li via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > On Tue, Aug 22, 2017 at 7:10 PM, Chandler Carruth via llvm-commits < > llvm-comm...@lists.llvm.org> wrote: > >> On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits < >>

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

2017-08-22 Thread Chandler Carruth via cfe-commits
On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator < > revi...@reviews.llvm.org> wrote: > >> chandlerc added a comment. >> >> I'm really not a fan of the degree of complexity

r310994 - Fix a UBSan failure where this boolean was copied when uninitialized.

2017-08-16 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Wed Aug 16 00:22:49 2017 New Revision: 310994 URL: http://llvm.org/viewvc/llvm-project?rev=310994=rev Log: Fix a UBSan failure where this boolean was copied when uninitialized. When r310905 moved the pointer and bool out of a PointerIntPair, it made them end up

r308967 - [PM] Setup TargetLibraryInfo correctly for the new pass manager.

2017-07-25 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Tue Jul 25 03:46:07 2017 New Revision: 308967 URL: http://llvm.org/viewvc/llvm-project?rev=308967=rev Log: [PM] Setup TargetLibraryInfo correctly for the new pass manager. Without this, -fno-builtin and friends doesn't work. Added the obvious RUN lines to the test for

r306786 - Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's

2017-06-29 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Jun 29 22:13:31 2017 New Revision: 306786 URL: http://llvm.org/viewvc/llvm-project?rev=306786=rev Log: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is

r306759 - [clang-format] Switch to case-insensitive header matching and use it to

2017-06-29 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Jun 29 16:20:54 2017 New Revision: 306759 URL: http://llvm.org/viewvc/llvm-project?rev=306759=rev Log: [clang-format] Switch to case-insensitive header matching and use it to improve support for LLVM-style include sorting. This really is a collection of improvements

Re: [PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

2017-06-29 Thread Chandler Carruth via cfe-commits
Sorry, email misfire... On Thu, Jun 29, 2017 at 4:15 PM Chandler Carruth via Phabricator via llvm-commits wrote: > chandlerc added a comment. > > Already said LGTM, please go ahead and submit. If tehre are further > requsets, we can always amke follow-up changes. >

Re: [PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-26 Thread Chandler Carruth via cfe-commits
Maybe Richard would be a better one to explain what on earth is going on here then... On Fri, May 26, 2017 at 1:51 AM David Abdurachmanov < david.abdurachma...@gmail.com> wrote: > Just reminder that this is in C++1z (C++17) mode, which I doubt is being > widely used at this point. > > I was a

Re: [PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

2017-05-26 Thread Chandler Carruth via cfe-commits
I kind of think this may be a GCC bug. It is quite strange that no one else has reported it, and that you're only seeing it in this context. We have many std::string flags and they are used in this way pretty commonly. I'm not seeing this with any other GCC-hosted build bot either, including a

Re: r300650 - [modules] Properly look up the owning module for an instantiation of a merged template.

2017-04-18 Thread Chandler Carruth via cfe-commits
Reverted in r300658. On Tue, Apr 18, 2017 at 8:30 PM Chandler Carruth wrote: > Consider code like the following: > > ``` > #include > > template > class MyAllocator : public std::allocator { > public: > typedef std::allocator Alloc; > typedef typename Alloc::pointer

r300659 - Revert r300653 and r300650. The underlying commit fixes one issue with

2017-04-18 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Wed Apr 19 00:25:13 2017 New Revision: 300659 URL: http://llvm.org/viewvc/llvm-project?rev=300659=rev Log: Revert r300653 and r300650. The underlying commit fixes one issue with modules but exposes much more widespread issues. Example and more information is on the review

Re: r300650 - [modules] Properly look up the owning module for an instantiation of a merged template.

2017-04-18 Thread Chandler Carruth via cfe-commits
Consider code like the following: ``` #include template class MyAllocator : public std::allocator { public: typedef std::allocator Alloc; typedef typename Alloc::pointer pointer; typedef typename Alloc::size_type size_type; MyAllocator() {} template MyAllocator(const

Re: r300650 - [modules] Properly look up the owning module for an instantiation of a merged template.

2017-04-18 Thread Chandler Carruth via cfe-commits
This appears to break a pretty straightforward use of things like libstdc++'s __alloctr_rebind (undefined template with a default argument, specializations, etc): https://github.com/gcc-mirror/gcc/blob/gcc-4_9-branch/libstdc++-v3/include/bits/alloc_traits.h#L58-L73 At least, I'm getting errors

r300035 - Update Clang for an API change to LLVM's switch case iterator (it is now

2017-04-12 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Wed Apr 12 03:12:30 2017 New Revision: 300035 URL: http://llvm.org/viewvc/llvm-project?rev=300035=rev Log: Update Clang for an API change to LLVM's switch case iterator (it is now an actual iterator and so we need to look through it to the case handle). Modified:

r298695 - Revert r298491 and r298494 which changed Clang's handling of 'nonnull'

2017-03-24 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Fri Mar 24 04:11:57 2017 New Revision: 298695 URL: http://llvm.org/viewvc/llvm-project?rev=298695=rev Log: Revert r298491 and r298494 which changed Clang's handling of 'nonnull' attributes. These patches don't work because we can't currently access the parameter

r298494 - Remove an overly aggressive assert in r298491 and leave a comment

2017-03-22 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Wed Mar 22 05:38:07 2017 New Revision: 298494 URL: http://llvm.org/viewvc/llvm-project?rev=298494=rev Log: Remove an overly aggressive assert in r298491 and leave a comment explaining why we have to ignore errors here even though in other parts of codegen we can be more

r298491 - [nonnull] Teach Clang to attach the nonnull LLVM attribute to

2017-03-22 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Wed Mar 22 04:09:13 2017 New Revision: 298491 URL: http://llvm.org/viewvc/llvm-project?rev=298491=rev Log: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes

[clang-tools-extra] r298434 - Don't make unqualified calls to functions that could well be found via

2017-03-21 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Tue Mar 21 15:15:42 2017 New Revision: 298434 URL: http://llvm.org/viewvc/llvm-project?rev=298434=rev Log: Don't make unqualified calls to functions that could well be found via ADL as reasonable extension points. All of this would be cleaner if this code followed the

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

2017-02-09 Thread Chandler Carruth via cfe-commits
On Thu, Feb 9, 2017 at 2:46 PM Tobias von Koch wrote: > On Wed, Feb 8, 2017 at 7:21 PM, Chandler Carruth > wrote: > > > +// The Freescale PPC SDK has the gcc libraries in > +// /usr/lib//x.y.z so have a look there as well. > +"/" +

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

2017-02-08 Thread Chandler Carruth via cfe-commits
It's blast from the past time! On Tue, Sep 18, 2012 at 3:28 PM Hal Finkel wrote: > Author: hfinkel > Date: Tue Sep 18 17:25:07 2012 > New Revision: 164177 > > URL: http://llvm.org/viewvc/llvm-project?rev=164177=rev > Log: > Add C/C++ header locations for the Freescale SDK. > >

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

2017-01-13 Thread Chandler Carruth via cfe-commits
Also need to pull in r291881. Sorry about that. On Thu, Jan 12, 2017 at 3:42 PM Hans Wennborg wrote: > On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth > wrote: > >> This isn't quite right, it should either be left as-is or dropped > >> completely. This

r291881 - Another fix for r291850 because there are apparently targets which add

2017-01-12 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Jan 12 20:47:34 2017 New Revision: 291881 URL: http://llvm.org/viewvc/llvm-project?rev=291881=rev Log: Another fix for r291850 because there are apparently targets which add "-mllvm" flags to the CC1 invocation (notably, Hexagon seems to hit this). Modified:

r291853 - Fix two test cases I missed updating in r291850. Sorry for the noise.

2017-01-12 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Jan 12 16:48:28 2017 New Revision: 291853 URL: http://llvm.org/viewvc/llvm-project?rev=291853=rev Log: Fix two test cases I missed updating in r291850. Sorry for the noise. Modified: cfe/trunk/test/CodeGen/always_inline.c

r291851 - Replace some stray uses of the old spelling of the flag with the new

2017-01-12 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Jan 12 16:43:37 2017 New Revision: 291851 URL: http://llvm.org/viewvc/llvm-project?rev=291851=rev Log: Replace some stray uses of the old spelling of the flag with the new spelling. NFC. Modified: cfe/trunk/test/CodeGen/ms-declspecs.c

r291850 - Address review comments on r290392:

2017-01-12 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Thu Jan 12 16:40:13 2017 New Revision: 291850 URL: http://llvm.org/viewvc/llvm-project?rev=291850=rev Log: Address review comments on r290392: - Don't break using '-mllvm -disable-llvm-optzns' (yet). - Don't add support for '-mllvm -disable-llvm-passes'. This is important

Re: r290450 - [PM] Introduce options to enable the (still experimental) new pass

2017-01-10 Thread Chandler Carruth via cfe-commits
(explicitly adding Richard so he sees this discussion as some of this involves a discussion between myself and him) On Tue, Jan 10, 2017 at 4:36 PM Justin Bogner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Chandler Carruth via cfe-commits <cfe-commits@lists.llvm

r291036 - [gtest] The way EXPECT_TEST now works after upgrading gtest triggers an

2017-01-04 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Wed Jan 4 17:57:25 2017 New Revision: 291036 URL: http://llvm.org/viewvc/llvm-project?rev=291036=rev Log: [gtest] The way EXPECT_TEST now works after upgrading gtest triggers an ODR use. These traits don't have a definition as they're intended to be used strictly at

Re: r290539 - [inline-asm]No error for conflict between inputs\outputs and clobber list

2016-12-29 Thread Chandler Carruth via cfe-commits
On Mon, Dec 26, 2016 at 4:34 AM Marina Yatsina via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: myatsina > Date: Mon Dec 26 06:23:42 2016 > New Revision: 290539 > > URL: http://llvm.org/viewvc/llvm-project?rev=290539=rev > Log: > [inline-asm]No error for conflict between

Re: r290593 - DR1495: A partial specialization is ill-formed if it is not (strictly) more

2016-12-27 Thread Chandler Carruth via cfe-commits
I suspect that this commit is responsible for a regression parsing widely used open source packages like Eigen. See the code in Eigen here:

r290560 - [PM] The new pass manager requires a registered target for these, and

2016-12-26 Thread Chandler Carruth via cfe-commits
Author: chandlerc Date: Mon Dec 26 18:31:34 2016 New Revision: 290560 URL: http://llvm.org/viewvc/llvm-project?rev=290560=rev Log: [PM] The new pass manager requires a registered target for these, and given that they hard code specific triples that seems reasonable so add the REQUIRES. Modified:

  1   2   >