[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

2021-12-02 Thread Chuang-Yu Cheng via Phabricator via cfe-commits
cycheng added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6853 +if (R->isReserveIDT() || R->isClkEventT() || R->isEventT() || +R.getUnqualifiedType().getAsString() == "ndrange_t" || R->isQueueT()) { Se.Diag(NewVD->getLocation(),

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

2021-10-27 Thread Chuang-Yu Cheng via Phabricator via cfe-commits
cycheng updated this revision to Diff 382816. cycheng added a comment. previous update was using wrong file, sorry!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112110/new/ https://reviews.llvm.org/D112110 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaOpenCL/invalid-types.cl

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

2021-10-27 Thread Chuang-Yu Cheng via Phabricator via cfe-commits
cycheng updated this revision to Diff 382813. cycheng marked 2 inline comments as done. cycheng added a comment. - Remove OpenCL 2.0 description - Merge test files into single test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112110/new/ https://reviews.llvm.org/D112110 Files:

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

2021-10-19 Thread Chuang-Yu Cheng via Phabricator via cfe-commits
cycheng created this revision. cycheng added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. cycheng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OpenCL v2.0 s6.5.1 and OpenCL v3.0 s6.11.w both state: Program scope