[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

[Damian Rouson via Phabricator via cfe-commits]

rouson added a comment.

On Mon, May 30, 2022 at 2:39 AM Andrzej Warzynski via Phabricator 
 wrote:

> 1. Lets rename `flang` as `flang-to-external-fc` regardless of what's decided 
> for `flang-new`. That would already be a huge step forward (and  > would 
> reflect accurately what the bash wrapper script actually does).

I support this.  I think the proposed new name is better reflects what the 
current flang script currently does and thereby reduces the likelihood of 
surprise when a user sees an error message from an external compiler.

> 2. As for the NAG test suite, I hope that we can agree not to use it as the 
> condition for renaming `flang-new`. If it's decided that that's a valid > 
> equirement, then I agree with @kiranchandramohan that we should find a way to 
> openly track the progress towards the required pass rate
>
> (and how that's defined).

I agree.

> Perhaps we could discuss more in the call today?

Any news from the call?

Damian


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125788/new/

https://reviews.llvm.org/D125788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

[Damian Rouson via Phabricator via cfe-commits]

rouson added a comment.

+1 @kiranchandramohan

I have access to the NAG Fortran compiler and find it very helpful for checking 
standard conformance.  I was unaware of the NAG test suite and don't see any 
mention of it online. Is it an official product that can be purchased?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125788/new/

https://reviews.llvm.org/D125788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

[Damian Rouson via Phabricator via cfe-commits]

rouson added a comment.

In D125788#3534482 , @sscalpone wrote:

> My belief is that we should wait until f18 hits a reasonable quality bar for 
> executables before making flang-new the default.  My reasoning seems not to 
> have carried the day.

It would hep to have a well-defined quality bar, e.g., a standards-based test 
suite or a collection of application test suites or the progress bar on the 
relevant GitHub project pages.  We could then discuss and vote on which point 
on the quality bar suffices.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125788/new/

https://reviews.llvm.org/D125788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

[Damian Rouson via Phabricator via cfe-commits]

rouson added a comment.

I think this is an exciting step.  I hope it gets approved.  Although it's 
technically true that this could appear to be a regression for current flang 
script users, the ultimate compilation currently happens by invoking an 
external compiler so most current flang script users can eliminate the 
regression by simply calling the external compiler.  The exception would be if 
the current flang script user specifically wants flang's parsing capabilities 
for checking code correctness (do we know if anyone is using the flang script 
that way?) or for testing the parser (which I presume can still happen by other 
means).  It might be nice to simply rename the current script so those who want 
it can simply change the name they use to invoke it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125788/new/

https://reviews.llvm.org/D125788

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122008: [flang][driver] Add support for generating executables

[Damian Rouson via Phabricator via cfe-commits]

rouson added a comment.

@awarzynski I'll echo your comment that "... most people new to LLVM Flang use 
flang rather than flang-new and most (all?) find it very confusing."  I've 
known of flang in various forms (including a flang predated classic flang) and 
yet I'm still finding new information that clears up confusion on my part.  I 
only just realized today that the phrase "LLVM flang" is used to differentiate 
from "classic flang." And although I've known about armflang for several years 
and AOCC (which seemingly should be AOCCF or some such) for a month or so, I 
only just realized today that they are based on classic flang, which finally 
makes sense because I couldn't figure out how they could be based on what is 
currently on the main branch of LLVM flang.  For users and testers, it will be 
really nice if the community coalesces around the main branch of LLVM flang as 
the default meaning when someone says "flang" and if that default flang 
produces executables even if  it's buggy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122008/new/

https://reviews.llvm.org/D122008

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122008: [flang][driver] Add support for generating executables

[Damian Rouson via Phabricator via cfe-commits]

rouson added a comment.

@awarzynski based on @h-vetinari's optimism about adding flags, I still like 
option 2.  If it's not possible to add flags, then I would prefer option 1.  If 
we go with option 3, then I am at least encouraged by reviewing the upstreaming 
project status links that @kiran posted in the Slack flang workspace #general 
channel.  I don't know the time required to complete the remaining tasks, but 
the following issues show 216 of 235 tasks completed with 2 in progress:

Statement Lowering Upstreaming 
: 
12 To Do/1 In Progress/30 Done

FIR Codegen Upstreaming 
: 
2 To Do/0 In Progress/81 Done

Intrinsic Lowering Upstreaming: 
:
0 To Do/0 In Progress/94 Done

FIR passes upstreaming 
:
3 To Do/1 In Progress/11 Done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122008/new/

https://reviews.llvm.org/D122008

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122008: [flang][driver] Add support for generating executables

[Damian Rouson via Phabricator via cfe-commits]

rouson added a comment.

I also very much like the second option.  I think it prevents a naive user from 
stumbling into treacherous territory.  Also, as someone who is funded to write 
tests for flang, making it easier to build executables would expand the options 
for testing. Currently, we're focused on semantics tests primarily because of 
the complications associated with generating executables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122008/new/

https://reviews.llvm.org/D122008

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits