[PATCH] D142637: A slightly more concise AST dump :)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70acb3aab3a1: A slightly more concise AST dump :) (authored by merrymeerkat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142637: A slightly more concise AST dump :)

merrymeerkat marked 3 inline comments as done. merrymeerkat added a comment. thank you @sammccall @gribozavr2 for spotting these issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142637/new/ https://reviews.llvm.org/D142637

[PATCH] D142637: A slightly more concise AST dump :)

merrymeerkat updated this revision to Diff 493557. merrymeerkat added a comment. Addressing review comments (improve tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142637/new/ https://reviews.llvm.org/D142637 Files:

[PATCH] D142637: A more concise AST dump If the modifiedType and the minimally desugared type of an AttributedType are the same, then we do not need to visit both (or show both in an AST dump). Here

merrymeerkat created this revision. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...when it is different from the equivalentType (the minimally desugared type), because the latter is already

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added a comment. Thanks for clarifying! I've gone ahead and landed the change. At least this should reduce the number of false negatives we get (hopefully without introducing too much complexity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd862f66221de: [clang][dataflow] Treat unions as structs. (authored by merrymeerkat). Changed prior to commit:

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added a comment. @ymandel - thank you for pointing all of this out! And no need to apologise at all :) I agree that the changes made here are not ideal. But the alternative is also not ideal. The question becomes: is it better to model unions in a way that is lacking, or to not

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat updated this revision to Diff 485693. merrymeerkat added a comment. Extend documentation comment on storage locations with a FIXME about unions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140696/new/

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added a comment. > another thought: please verify that `createStorageLoction` and `createValue` > can correctly handle union types. Otherwise, you'll likely end up with other > (surprising) crashes in the system. E.g. >

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat updated this revision to Diff 485626. merrymeerkat added a comment. Resolving review comment. Add createValue functionality for unions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140696/new/ https://reviews.llvm.org/D140696 Files:

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat updated this revision to Diff 485485. merrymeerkat added a comment. Add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140696/new/ https://reviews.llvm.org/D140696 Files:

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat updated this revision to Diff 485407. merrymeerkat added a comment. Change TODO to FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140696/new/ https://reviews.llvm.org/D140696 Files:

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a straightfoward way to

[PATCH] D140626: [clang][nullability] Remove old overload for getNullability()

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbee2dd9a4ba: [clang][nullability] Remove old overload for getNullability() (authored by merrymeerkat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140626: [clang][nullability] Remove old overload for getNullability()

merrymeerkat created this revision. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140626 Files: clang/include/clang/AST/Type.h

[PATCH] D140483: Remove empty header file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0fa7c730d01: Remove empty header file. (authored by merrymeerkat). Changed prior to commit: https://reviews.llvm.org/D140483?vs=484578=485075#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D140483: Remove empty header file.

merrymeerkat created this revision. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140483 Files:

[PATCH] D140475: BEGIN_PUBLIC test phabricator

merrymeerkat updated this revision to Diff 484554. merrymeerkat added a comment. ?: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140475/new/ https://reviews.llvm.org/D140475 Files: clang/include/clang/Analysis/AnalysisDiagnostic.h Index:

[PATCH] D140475: BEGIN_PUBLIC test phabricator

merrymeerkat created this revision. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. END_PUBLIC Repository: rG LLVM Github Monorepo

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

merrymeerkat added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9072 auto GetNullability = [](QualType Ty) { +Optional Kind = Ty->getNullability(); barannikov88 wrote: > This now gives a warning > `clang/lib/Sema/SemaExpr.cpp:9072:27:

[PATCH] D140211: [clang][dataflow] Remove unused lambda capture

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

merrymeerkat updated this revision to Diff 483460. merrymeerkat added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140104/new/ https://reviews.llvm.org/D140104 Files:

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

merrymeerkat updated this revision to Diff 483355. merrymeerkat added a comment. Address review comment (add temporary overload) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140104/new/ https://reviews.llvm.org/D140104 Files:

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

merrymeerkat updated this revision to Diff 483345. merrymeerkat added a comment. Resolving review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140104/new/ https://reviews.llvm.org/D140104 Files:

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

merrymeerkat created this revision. Herald added subscribers: martong, kadircet, arphaman, xazax.hun. Herald added a project: All. merrymeerkat requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This change will allow users

[PATCH] D140037: [clang][dataflow] Remove old diagnoser API

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a clean up following the revision D139868

[PATCH] D139868: [clang][dataflow] Change the diagnoser API to receive a correctly typed lattice element

merrymeerkat updated this revision to Diff 482393. merrymeerkat added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139868/new/ https://reviews.llvm.org/D139868 Files:

[PATCH] D139868: [clang][dataflow] Change the diagnoser API to receive a correctly typed lattice element Previously, the diagnoser could only receive the Environment at a given program point. Now, it

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...lattice element. Repository:

[PATCH] D137584: Add const information about AST nodes used to construct CFG elements.

merrymeerkat created this revision. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most constructors and destructors in CFG.h already specify const arguments, but

[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement.

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For example, previously, if the

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

merrymeerkat added a comment. In D137077#3896369 , @aaron.ballman wrote: > Thank you for the patch! However, I think this isn't an improvement to the > diagnostic -- it's a cute phrase, but it doesn't help the programmer to > understand what about

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

merrymeerkat created this revision. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137077 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td