[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

2020-08-03 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. Neon intrinsics vqmovunh_s16, vqmovuns_s32, vqmovund_s64 should have unsigned return types. See

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

2020-07-23 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked an inline comment as done. DavidSpickett added a comment. LGTM, I'll let @chill give the final word. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:476 +// -mfpu=none, -march=armvX+nofp or -mcpu=X+nofp is *very* similar to +//

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

2020-07-22 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:476 +// -mfpu=none, -march=armvX+nofp or -mcpu=X+nofp is *very* similar to +// -mfloat-abi=soft, only that it should not disable MVE-I. Features.insert(Features.end(),

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

2020-07-21 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:476 +// -mfpu=none, -march=armvX+nofp or -mcpu=X+nofp is *very* similar to +// -mfloat-abi=soft, only that it should not disable MVE-I. Features.insert(Features.end(),

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-15 Thread David Spickett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rGfe5912249efa: [clang][Driver] Fix tool path priority test failures (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-13 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +//

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-13 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 277344. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. - Use more standard 'test -f' command before 'mv's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-10 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +//

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-10 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 276952. DavidSpickett added a comment. - mv with stderr redirected instead of using non standard file -E flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-09 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 276671. DavidSpickett added a comment. - Updated rm/mv command lines to account for $DEFAULT_TRIPLE being the same as %target_triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. For the record my logic here is that I could change the tool names to use the same name as --version. However that will break whatever mips toolchain needed this code in the first place. (https://reviews.llvm.org/D13340?id=36227#inline-108606) This default

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 276406. DavidSpickett added a subscriber: stevewan. DavidSpickett added a comment. - Write to cmake and clang's default triple to also fix failure reported by @stevewan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-07-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Right, I see the issue. The code that gets the default triple name (https://reviews.llvm.org/D13340?id=36227#inline-108606) looks up the one you have in cmake, not the actual default which you get in --version. We could "fix" this by doing so when we make the

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-07 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 275950. DavidSpickett added a comment. - Removed \ from regex, not needed for POSIX syntax. - Reflowed text in commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-07-07 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. I saw similar behaviour on Mac OSX and fixed that in the reland. (https://reviews.llvm.org/rGd6efc9811646edbfe13f06c2676fb469f1c155b1) Are you still seeing a failure with that applied? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-02 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 275138. DavidSpickett added a comment. - Added check for alternate gcc names in the first test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 Files:

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-02 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test can fail when the path of the build includes the strings we're checking for. E.g "/gcc" is found in ".../gcc_7.3.0/..." To correct this look for '"' on the end of all matches. So

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

2020-07-02 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:296 +return llvm::any_of( +Split, [](const StringRef ) { return Extension == "nofp"; }); + }; I would check what this does: $ ./bin/clang -target

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-06-25 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett closed this revision. DavidSpickett added a comment. Relanded as d6efc9811646edbfe13f06c2676fb469f1c155b1 . Change was to get the default triple from clang itself, as on MacOS this can be different to the value

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-06-22 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Committed but made a mistake with arc so it landed with the wrong diff number. In any case a failure on MacOS was reported so reverted while I investigate that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-06-17 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 271345. DavidSpickett added a comment. Moved pipe (|) to end of the first lines to make it clearer that there's a continuation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-06-17 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:22 +/// No gccs at all, nothing is found +// RUN: env "PATH=" %t/clang -### -target notreal-none-elf %s 2>&1 \ +// RUN: | FileCheck

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-06-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked 4 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:20 +// No gccs at all, nothing is found +// RUN: env "PATH=" %t/clang -### -target notreal-none-elf %s 2>&1 \ +// RUN: | FileCheck

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-06-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 270716. DavidSpickett added a comment. Address comments from MaskRay. - Use triple slash for actual comments - symlink clang, don't run test on Windows - Merged some commands onto one line e.g. touch/chmod Repository: rG LLVM Github Monorepo

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-22 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Comments on cfe-dev (http://lists.llvm.org/pipermail/cfe-dev/2020-May/065432.html) also in favour of removing the default triple lookup. I tend to agree but think it makes more sense to land this first and address it in a follow up. Repository: rG LLVM Github

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-22 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 265694. DavidSpickett added a comment. - Addressed comments from nickdesaulniers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files:

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:72 +// -gcc has lowest priority +// RUN: default_triple=$(%t/clang --version | grep -oP "(?<=Target:\s).*") +// RUN: touch

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 264201. DavidSpickett added a comment. Added target triple as a substitution so the tests don't have to grep for it. (which I didn't manage to verify on Windows in any case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 264187. DavidSpickett added a comment. Update from arc to hopefully run harbormaster builds again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files:

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-13 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 263696. DavidSpickett added a comment. - Updated test to look for forward or backslash in expected file paths. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/lib/Driver/Driver.cpp

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-13 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 263686. DavidSpickett added a comment. - Fix spelling - Rework explanatory comments to be a bit clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/lib/Driver/Driver.cpp

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-13 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett created this revision. DavidSpickett added reviewers: rogfer01, ddunbar, chandlerc. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at:

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-13 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:72 +// -gcc has lowest priority +// RUN: default_triple=$(%t/clang --version | grep -oP "(?<=Target:\s).*") +// RUN: touch

[PATCH] D78129: Add Marvell ThunderX3T110 support

2020-04-29 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:89 CPU = llvm::sys::getHostCPUName(); - if (CPU == "generic") { Remove stray change. Comment at:

[PATCH] D78129: Add Marvell ThunderX3T110 support

2020-04-29 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:168 + (AArch64::AEK_CRC | AEK_CRYPTO | AEK_FP | AEK_SIMD | AEK_LSE | AEK_RAND)) +AARCH64_CPU_NAME("thunderx3t110", ARMV8_3A, FK_CRYPTO_NEON_FP_ARMV8, false, +

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

2020-04-14 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Or in other words, does amrv8.6-a+sve imply +f32mm *and* +f64mm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77875/new/ https://reviews.llvm.org/D77875 ___ cfe-commits

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

2020-04-14 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. > Note: +f32mm and +f64mm are optional and so have to be enabled by default I think I know what you mean, but "and so are not enabled by default" would be clearer. Also to double check, does f64mm imply f32mm? (not

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

2020-04-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:284 + if (HasMatMul) +Builder.defineMacro("__ARM_FEATURE_MATMUL_INT8", "1"); + I don't see specific tests for this #define Comment at:

[PATCH] D69574: Remove lazy thread-initialisation

2019-11-04 Thread David Spickett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG91167e22eca5: [hwasan] Remove lazy thread-initialisation (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69574/new/

[PATCH] D64243: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand

2019-07-09 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64243/new/ https://reviews.llvm.org/D64243 ___

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

2019-05-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. LGTM but the use of "intrinsic" in the commit message is confusing. Do you mean feature/implied feature, as in "the implied features defined by"? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61668/new/

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

2019-04-12 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60272/new/ https://reviews.llvm.org/D60272 ___

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

2019-04-10 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. What's the motivation for this change, are you working towards common flags for both platforms? The current way to select crypto on AArch64 is '-march=armv8.x-a+crypto/nocrypto'. I can see that would be an issue if Power PC doesn't support that syntax, or doesn't

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

2019-04-10 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Do we need a separate file for that one "__arm_mte_ptrdiff" test? Wouldn't it be easier to wrap the whole function in "__cplusplus" and put it in the same file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485