[PATCH] D26435: Use unique_ptr for cached tokens for default arguments in C++.

dtarditi updated this revision to Diff 78375. dtarditi added a comment. The parameter array needed to be initialized so that assignments involving unique pointers work properly. The memory could be uninitialized according to C++ semantics.. Visual C++ was zeroing the memory and GCC was not.

[PATCH] D26435: Use unique_ptr for cached tokens for default arguments in C++.

dtarditi updated this revision to Diff 77373. dtarditi added a comment. Thanks for the code review feedback - I've addressed it. Yes, we should use reset() instead of release(). I also deleted the unnecessary brackets. I don't have commit access, so if this looks good, could someone commit

[PATCH] D26435: Use unique_ptr for cached tokens for default arguments in C++.

dtarditi created this revision. dtarditi added a subscriber: cfe-commits. This changes pointers to cached tokens for default arguments in C++ from raw pointers to unique_ptrs. There was a fixme in the code where the cached tokens are created about using a smart pointer. The change is

only correct delayed typos for conditional expressions when needed.

r272587 (http://reviews.llvm.org/D20490) fixed an issue where typo correction could cause a crash when compiling C programs.The problem was that a typo expression could be inadvertently processed twice.r272587 fixed this for BinOp expressions. Conditional expressions can hit the same