[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

2020-11-13 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91361/new/ https://reviews.llvm.org/D91361 ___ cfe-commits mailing list

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

2020-11-12 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( Xiangling_L wrote: > daltenty wrote: > > I think that rather that

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

2020-11-12 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( I think that rather that adding CC, we should just pull the if and

[PATCH] D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

2020-10-21 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Thanks! I've verified this fixes the test on AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89904/new/ https://reviews.llvm.org/D89904

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

2020-10-21 Thread David Tenty via Phabricator via cfe-commits
daltenty added a comment. In D89696#2344797 , @jhuber6 wrote: > In D89696#2344753 , @daltenty wrote: > >> In D89696#2344508 , @jhuber6 wrote: >> >>> @daltenty Do you think

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

2020-10-21 Thread David Tenty via Phabricator via cfe-commits
daltenty added a comment. In D89696#2344508 , @jhuber6 wrote: > @daltenty Do you think this will fix the problem on AIX? It's not just AIX that will have this problem I suspect. If you configure any cross-compiling build with a 64-bit host, targeting a

[PATCH] D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts

2020-10-20 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/test/OpenMP/driver-openmp-target.c:2 +// REQUIRES: x86-registered-target +// REQUIRES: clang-64-bits +// RUN: %clang %s -c -E -dM -fopenmp=libomp -fopenmp-version=45 -fopenmp-targets=x86_64-unknown-unknown -o - | FileCheck

[PATCH] D87451: add new option -mignore-xcoff-visibility

2020-10-06 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, other minor nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451

[PATCH] D87451: add new option -mignore-xcoff-visibility

2020-10-06 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file (XCOFF only) + nit: plural. capitalization.

[PATCH] D87451: add new option -mignore-xcoff-visibility

2020-10-06 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:339 + "ignore-xcoff-visibility", + cl::desc("Not emit the visibility attribute for asm in AIX OS or give " + "all symbols 'unspecified' visibility in xcoff object file"),

[PATCH] D87451: add new option ignore-xcoff-visibility

2020-10-02 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file(XCOFF only) + nit: add a space before parens

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

2020-09-30 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGafc277b0ed0d: [AIX][Clang][Driver] Link libm in c++ mode (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D88500?vs=295111=295355#toc Repository: rG LLVM Github Monorepo

[PATCH] D88500: [AIX][Clang][Driver] Link libm in c++ mode

2020-09-29 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 295111. daltenty marked an inline comment as done. daltenty added a comment. - Make dependant on just c++ mode - Add missing colons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

2020-09-29 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 295107. daltenty added a comment. - Add blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D88500: [AIX][Clang][Driver] Link libm when we would libc++

2020-09-29 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 295105. daltenty added a comment. - Remove deps comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88500/new/ https://reviews.llvm.org/D88500 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D88500: [AIX][Clang][Driver] Link libm along with libc++

2020-09-29 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, DiggerLin. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. since libc++ has dependencies on libm. Repository: rG LLVM Github Monorepo

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

2020-09-28 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGee80615b5c1c: [clang][driver][AIX] Set compiler-rt as default rtlib (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

2020-09-28 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 294822. daltenty added a comment. - Remove blankline - Fix path seperators in second test as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https://reviews.llvm.org/D88182 Files:

[PATCH] D87451: add new clang option -mno-xcoff-visibility

2020-09-24 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: llvm/include/llvm/Target/TargetMachine.h:265 + /// corresponding to -mno-xcoff-visibility. + bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; } + DiggerLin wrote: > jasonliu wrote: > > DiggerLin

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

2020-09-24 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 294053. daltenty added a comment. - Fix formating - Fix typos - Replace pattern with windows-friendly directory seperators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

2020-09-23 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. daltenty added reviewers: stevewan, hubert.reinterpretcast, jasonliu, Xiangling_L. Herald added subscribers: cfe-commits, dberris. Herald added a project: clang. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

2020-09-23 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list

[PATCH] D87451: add new clang option -mno-xcoff-visibility

2020-09-22 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: llvm/include/llvm/Target/TargetMachine.h:265 + /// corresponding to -mno-xcoff-visibility. + bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; } + This seems like it needs the corresponding

[PATCH] D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode

2020-09-22 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe8fb4eba4fb6: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode

2020-09-21 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 293262. daltenty added a comment. - Check absence in C cases - Add a note about crti in the nostdlib++ case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87927/new/ https://reviews.llvm.org/D87927 Files:

[PATCH] D87914: [AIX][Clang][Driver] Add handling of shared option

2020-09-21 Thread David Tenty via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8540427419e: [AIX][Clang][Driver] Add handling of shared option (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option

2020-09-21 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG699089f2a970: [AIX][Clang][Driver] Add handling of nostartfiles option (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87904/new/

[PATCH] D87927: [AIX][clang][driver] Make sure ctri.o is linked in C++ mode

2020-09-18 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. since crti is required for functional static initialization. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87927 Files:

[PATCH] D87914: [AIX][Clang][Driver] Add handling of shared option

2020-09-18 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87914 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c

[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option

2020-09-18 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87904 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c

[PATCH] D84880: [AIX] Temporarily disable IncrementalProcessingTest partially

2020-07-29 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84880/new/ https://reviews.llvm.org/D84880

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

2020-07-14 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:15 #include "clang/Tooling/ArgumentsAdjusters.h" +#include "llvm/Option/Option.h" +#include "llvm/Support/Allocator.h" This breaks the powerpc64le bots. Looks like we

[PATCH] D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting

2020-07-09 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG25ec96d91a3a: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D82476?vs=273071=276803#toc Repository: rG

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-07 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver (authored by ShuhongL, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-07 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1a2f4824cb2d: [Clang] Handle AIX Include management in the driver (authored by ShuhongL, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-03 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return if -nostdlibinc is specified as a driver option. + if

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-02 Thread David Tenty via Phabricator via cfe-commits
daltenty requested changes to this revision. daltenty added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver = getDriver(); hubert.reinterpretcast wrote: > Please

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-02 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM other than minor nit Comment at: clang/test/Driver/aix-toolchain-include.cpp:13 + +// Check powerpc-ibm-aix, 64-bit. +// RUN: %clangxx -### -no-canonical-prefixes

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-06-30 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:8 +// RUN: | FileCheck -check-prefix=CHECK-INTERNAL32-INCLUDE %s +// CHECK-INTERNAL32-INCLUDE: {{.*}}clang{{.*}}" "-cc1" +// CHECK-INTERNAL32-INCLUDE: "-resource-dir"

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-06-30 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:1 +// Tests that aix toolchain adds system includes to the search path + nit: aix->AIX nit: period at end of comment. Comment at:

[PATCH] D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting

2020-06-24 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. daltenty added reviewers: stevewan, hubert.reinterpretcast, ShuhongL. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX uses an environment variable called OBJECT_MODE to indicate to utilities in the toolchain whether they should be

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-04-30 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:583 + if (UseSinitAndSterm) +GlobalUniqueModuleId = getUniqueModuleId(()).substr(1); + if `getUniqueModuleId()` returns an empy string, which it does for modules which don't export

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

2020-03-11 Thread David Tenty via Phabricator via cfe-commits
daltenty added a comment. On AIX and PPC LE Linux after this change we are seeing invalid accesses when the backend asserts/fatal_errors. Looks like the driver and CC1 now share some global TimerGroup state that points to Timers which got created by CC1 but didn't get cleanup after the assert.

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

2020-02-18 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG58817a0783ca: [clang][XCOFF] Indicate that XCOFF does not support COMDATs (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

2020-02-18 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 245201. daltenty added a comment. Herald added subscribers: aheejin, dschuff. - Update lang doc to indicate XCOFF doesn't support COMDAT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

2020-02-18 Thread David Tenty via Phabricator via cfe-commits
daltenty added a comment. In D74631#1876995 , @sfertile wrote: > 1. We should probably update the COMDAT section of the lang ref to mention > XCOFF doesn't support COMDATS. I will update the langref as suggested. > 2. Will we report an error somewhere

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

2020-02-14 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/ https://reviews.llvm.org/D74631 Files: clang/test/CodeGen/xcoff-comdat.cpp

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

2020-02-14 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. daltenty added reviewers: stevewan, sfertile, Xiangling_L. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline XCOFF

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

2020-02-11 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/include/clang/Basic/TargetCXXABI.h:116 +/// - static initialization is adjusted to use sinit and sterm functions; +XL_Clang, + Why the underscore in the name? This is a bit inconsistent with both the

[PATCH] D69620: Add AIX assembler support

2019-12-02 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3ebfab709583: Add AIX assembler support (authored by stevewan, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/

[PATCH] D69620: Add AIX assembler support

2019-11-29 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Other than minor nit, LGTM Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input file."); + const

[PATCH] D70675: [AIX] Disable clang python binding tests

2019-11-26 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa38fc6164879: [AIX] Disable clang python binding tests (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70675/new/

[PATCH] D70675: [AIX] Disable clang python binding tests

2019-11-25 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. The Python ctypes FFI interface is broken on AIX, it cannot properly pass structures containing arrays ( https://bugs.python.org/issue38628). So disable the clang python binding tests on

[PATCH] D69620: Add AIX assembler support

2019-11-18 Thread David Tenty via Phabricator via cfe-commits
daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:26 + + bool hasIntegratedCPP() const override { return false; } + stevewan wrote: > Xiangling_L wrote: > > I saw a lot of other target also set `hasIntegratedCPP()` as false, but I >

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

2019-11-06 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6740a88dc18d: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable() (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

2019-11-01 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 227463. daltenty marked an inline comment as done. daltenty added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://reviews.llvm.org/D69638 Files:

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

2019-11-01 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 227461. daltenty added a comment. - Address review comments round 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://reviews.llvm.org/D69638 Files: clang/tools/driver/CMakeLists.txt

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

2019-10-30 Thread David Tenty via Phabricator via cfe-commits
daltenty added a comment. Revised direction in https://reviews.llvm.org/D69638 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.org/D69356 ___ cfe-commits mailing list

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

2019-10-30 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. daltenty edited the summary of this revision. daltenty added reviewers: hubert.reinterpretcast, beanz, lhames. daltenty added a reverted change: D69356: [NFC] Rename

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

2019-10-30 Thread David Tenty via Phabricator via cfe-commits
daltenty added a comment. In D69356#1727581 , @hubert.reinterpretcast wrote: > In D69356#1727484 , @beanz wrote: > > > We should not be adding more variables that are passed around by CMake's > > scope

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

2019-10-30 Thread David Tenty via Phabricator via cfe-commits
daltenty added a comment. > I'm actually opposed to that happening, on two fronts. > (2) we already have `LLVM_ENABLE_PLUGINS` why do we also need > `LLVM_SUPPORT_PLUGINS` seems like duplication and bad design. As I understand it LLVM_ENABLE_PLUGINS is a user-facing option which indicates

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

2019-10-30 Thread David Tenty via Phabricator via cfe-commits
daltenty added a comment. In D69356#1726527 , @hubert.reinterpretcast wrote: > In D69356#1726354 , @beanz wrote: > > > If what you say is correct that "no dead strip" is harmful to plugins on > > some platforms

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

2019-10-25 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG11c2a85db884: [NFC] Rename LLVM_NO_DEAD_STRIP (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

2019-10-24 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 226319. daltenty added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments round 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/

[PATCH] D68340: Add AIX toolchain and basic linker functionality

2019-10-24 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6a27fc257f: Add AIX toolchain and basic linker functionality (authored by stevewan, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX

2019-08-06 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65688/new/ https://reviews.llvm.org/D65688 ___

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

2019-06-07 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362808: Build with _XOPEN_SOURCE defined on AIX (authored by daltenty, committed by ). Changed prior to commit: https://reviews.llvm.org/D62533?vs=202822=203563#toc Repository: rL LLVM CHANGES

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

2019-06-03 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 202822. daltenty added a comment. Fix grammar in comments. Fix up the way we define the macros for Google Test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62533/new/ https://reviews.llvm.org/D62533 Files:

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

2019-05-28 Thread David Tenty via Phabricator via cfe-commits
daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, xingxue, andusy. daltenty added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, jsji, mgorny. It is useful to build with _XOPEN_SOURCE defined on AIX, enabling X/Open and POSIX