[clang] 4a687ef - [clang testing] Unbreak read-only source builds

2022-10-18 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2022-10-18T12:47:12-04:00 New Revision: 4a687efecb825f8c1c3e10ffc7949f4b2cd3c1bd URL: https://github.com/llvm/llvm-project/commit/4a687efecb825f8c1c3e10ffc7949f4b2cd3c1bd DIFF:

[clang] 3eb2be6 - Unbreak no-asserts testing

2021-04-29 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2021-04-29T10:01:37-04:00 New Revision: 3eb2be67b997ea62f47dbe90a62e828ecfb266a8 URL: https://github.com/llvm/llvm-project/commit/3eb2be67b997ea62f47dbe90a62e828ecfb266a8 DIFF:

[clang] 243333e - Revert "[Driver] Drop obsoleted Ubuntu 11.04 gcc detection"

2021-03-20 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2021-03-20T07:29:01-04:00 New Revision: 24ef3ec6c1e3910eb442177c2e2e927e6a87 URL: https://github.com/llvm/llvm-project/commit/24ef3ec6c1e3910eb442177c2e2e927e6a87 DIFF:

Re: [clang] bdf39e6 - [Driver] Drop obsoleted Ubuntu 11.04 gcc detection

2021-03-20 Thread David Zarzycki via cfe-commits
This is failing on my Fedora 33 (x6-64) box. I'm going to revert this. If you need help debugging this, please let me know. Here is the relevant info: FAIL: Clang :: Driver/gcc-toolchain.cpp (6552 of 75252) TEST 'Clang :: Driver/gcc-toolchain.cpp' FAILED

[clang] 87f6de7 - [clang testing] Fix a read-only source build system failure

2020-10-21 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2020-10-21T08:08:03-04:00 New Revision: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 URL: https://github.com/llvm/llvm-project/commit/87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 DIFF:

[clang] dab859d - Reland: [clang driver] Move default module cache from system temporary directory

2020-06-27 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2020-06-27T05:35:15-04:00 New Revision: dab859d1bf250c4d0299ac505e2a6773c56b6503 URL: https://github.com/llvm/llvm-project/commit/dab859d1bf250c4d0299ac505e2a6773c56b6503 DIFF:

[clang] bb26838 - [clang driver] Move default module cache from system temporary directory

2020-06-26 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2020-06-26T07:46:03-04:00 New Revision: bb26838ceffb5feaa18186f55f7525a08084899e URL: https://github.com/llvm/llvm-project/commit/bb26838ceffb5feaa18186f55f7525a08084899e DIFF:

[clang] e717e87 - [libclang] Shared libraries require PIC unless WIN32

2020-04-29 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2020-04-29T11:25:45-04:00 New Revision: e717e8744d374e16603157e5135005727bf17901 URL: https://github.com/llvm/llvm-project/commit/e717e8744d374e16603157e5135005727bf17901 DIFF:

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

2020-04-29 Thread David Zarzycki via cfe-commits
message. > > I'm sorry for the trouble of getting the revert and failed build. I > thought I had everything covered this time... > > Cheers > Cristian. > > > -Original Message- > > From: David Zarzycki > > Sent: Wednesday, 29 April 2020 16:37 > > To:

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

2020-04-29 Thread David Zarzycki via cfe-commits
> > that the check for WIN32 should be added back, but nobody followed through > > on that. What is stopping us from adding Christian's proposed change? > > Specifically: > > > > if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) > > > > Dave >

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

2020-04-29 Thread David Zarzycki via cfe-commits
: if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) Dave On Wed, Apr 29, 2020, at 9:19 AM, Hans Wennborg wrote: > On Sun, Apr 26, 2020 at 1:17 PM David Zarzycki via cfe-commits > wrote: > > > > > > Author: David Zarzycki > > Date: 2020-04-26T0

[clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

2020-04-26 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2020-04-26T07:16:42-04:00 New Revision: 665471907a5c072c6653a38c35f35e5d54cef220 URL: https://github.com/llvm/llvm-project/commit/665471907a5c072c6653a38c35f35e5d54cef220 DIFF:

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

2020-04-05 Thread David Zarzycki via cfe-commits
only visible in C++20 mode where char8_t was introduced. -- Sent from my iPhone > On Apr 5, 2020, at 18:18, Richard Smith wrote: > >  >> On Sun, 5 Apr 2020 at 14:44, David Zarzycki via cfe-commits >> wrote: > >> We have overloaded builtins. Can that not solve __

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

2020-04-05 Thread David Zarzycki via cfe-commits
whereas things like > __builtin_strlen would never work because they take operands of the wrong > types (and we can't cast const char8_t* -> const char* in a constant > expression). > >> On Sun, 5 Apr 2020 at 04:14, David Zarzycki via cfe-commits >> wrote: >>

[clang] 2c88a48 - [clang] Make libcxx test suite pass again after memcmp changes

2020-04-05 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2020-04-05T07:16:47-04:00 New Revision: 2c88a485c71155c19e512f22c54e63ee337282a3 URL: https://github.com/llvm/llvm-project/commit/2c88a485c71155c19e512f22c54e63ee337282a3 DIFF:

Re: [libcxx-dev] [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

2020-04-05 Thread David Zarzycki via cfe-commits
Hi Richard, I'm going to commit a narrow fix to clang to make the libcxx test suite pass again by allowing char8_t again. If you feel that this is the wrong long-term solution, please help the libcxx folks with whatever adjustments they need. Thanks! Dave On Sat, Apr 4, 2020, at 9:55 AM,

Re: [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

2020-04-04 Thread David Zarzycki via cfe-commits
Hi Richard, This breaks libcxx. Can we please revert this or is a quick fix to libcxx possible? FAIL: libc++ :: std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/compare.pass.cpp (58624 of 62672) TEST 'libc++ ::

[clang] 0d61cd2 - Verify that clang's max alignment is <= LLVM's max alignment

2020-01-24 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2020-01-24T12:37:05-05:00 New Revision: 0d61cd25a6927a7700bfb1636faca1ef16c46428 URL: https://github.com/llvm/llvm-project/commit/0d61cd25a6927a7700bfb1636faca1ef16c46428 DIFF:

[clang] 75e500d - Add missing `REQUIRES: hexagon-registered-target`

2019-12-21 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2019-12-21T06:45:30-05:00 New Revision: 75e500dd4713e785f0ca7afc37e7ba206a4391b0 URL: https://github.com/llvm/llvm-project/commit/75e500dd4713e785f0ca7afc37e7ba206a4391b0 DIFF:

[clang] b324902 - Revert "Driver: Don't look for libc++ headers in the install directory on Android."

2019-12-08 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2019-12-08T16:41:46+02:00 New Revision: b32490270b786d2c5ba154e613ee2d5e36ed4197 URL: https://github.com/llvm/llvm-project/commit/b32490270b786d2c5ba154e613ee2d5e36ed4197 DIFF:

[clang] ed33cb5 - [RISCV] Add missing REQUIRES to clang tests

2019-11-23 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2019-11-23T14:47:09+02:00 New Revision: ed33cb5b147402c06a3e0a9082b0f991a9d91a1b URL: https://github.com/llvm/llvm-project/commit/ed33cb5b147402c06a3e0a9082b0f991a9d91a1b DIFF:

[clang] 39af723 - Unbreak the clang test suite when hexagon-link is not available

2019-11-14 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2019-11-15T08:47:02+02:00 New Revision: 39af72378dd0481472e267ed7f15da594de0fee3 URL: https://github.com/llvm/llvm-project/commit/39af72378dd0481472e267ed7f15da594de0fee3 DIFF:

Re: r374133 - [c++20] Implement most of P1152R4.

2019-10-11 Thread David Zarzycki via cfe-commits
Hi Richard, This breaks libcxx and libcxxabi my local stage two build bot (Fedora 31 x86_64). Is this expected? Can we revert this? FAIL: libc++ :: std/utilities/meta/meta.rel/is_invocable.pass.cpp (55505 of 58603) TEST 'libc++ ::

r372949 - [Testing] Workaround libcxx bug when OS is "none"

2019-09-26 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Thu Sep 26 01:19:44 2019 New Revision: 372949 URL: http://llvm.org/viewvc/llvm-project?rev=372949=rev Log: [Testing] Workaround libcxx bug when OS is "none" If clang is configured to use libcxx as the default C++ standard library, then using "none" for the OS in the

r371710 - [WebAssembly] Add REQUIRES to test

2019-09-12 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Wed Sep 11 23:50:33 2019 New Revision: 371710 URL: http://llvm.org/viewvc/llvm-project?rev=371710=rev Log: [WebAssembly] Add REQUIRES to test Modified: cfe/trunk/test/CodeGenCXX/wasm-eh.cpp Modified: cfe/trunk/test/CodeGenCXX/wasm-eh.cpp URL:

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

2019-08-27 Thread David Zarzycki via cfe-commits
Hi Vitaly, Thanks for fixing this! And I’m sorry about accidentally disabling the test entirely by adding “REQUIRES: assertions” instead of “REQUIRES: asserts”. Dave > On Aug 27, 2019, at 1:10 AM, Vitaly Buka wrote: > > fixed with r369992 > > On Mon, Aug 26, 2019 at 1:16 PM Vitaly Buka

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

2019-08-24 Thread David Zarzycki via cfe-commits
Fix: r369843 Please confirm. Thanks! > On Aug 24, 2019, at 8:18 AM, David Zarzycki wrote: > > This seems to have broken building on Red Hat Fedora Linux 30 (x86_64). Was > this expected? > > FAIL: Clang :: CodeGenCXX/lifetime-sanitizer.cpp (7750 of 50751) > TEST 'Clang

r369843 - [Testing] Unbreak r369830

2019-08-24 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Sat Aug 24 01:12:51 2019 New Revision: 369843 URL: http://llvm.org/viewvc/llvm-project?rev=369843=rev Log: [Testing] Unbreak r369830 Modified: cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp Modified: cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp URL:

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

2019-08-24 Thread David Zarzycki via cfe-commits
This seems to have broken building on Red Hat Fedora Linux 30 (x86_64). Was this expected? FAIL: Clang :: CodeGenCXX/lifetime-sanitizer.cpp (7750 of 50751) TEST 'Clang :: CodeGenCXX/lifetime-sanitizer.cpp' FAILED Script: -- : 'RUN: at line 1';

r369496 - [PPC Docs] Remove duplicate info about __builtin_setrnd()

2019-08-21 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Tue Aug 20 23:48:11 2019 New Revision: 369496 URL: http://llvm.org/viewvc/llvm-project?rev=369496=rev Log: [PPC Docs] Remove duplicate info about __builtin_setrnd() This looks like a combination of a copy-and-paste (and paste and paste) error and a commit without

r363916 - [Testing] Dumping the graph requires assertions be enabled

2019-06-20 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Thu Jun 20 02:58:58 2019 New Revision: 363916 URL: http://llvm.org/viewvc/llvm-project?rev=363916=rev Log: [Testing] Dumping the graph requires assertions be enabled Modified: cfe/trunk/test/Analysis/exploded-graph-rewriter/escapes.c Modified:

r352996 - Hot fix two test regressions (%T vs %t)

2019-02-03 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Sun Feb 3 07:49:11 2019 New Revision: 352996 URL: http://llvm.org/viewvc/llvm-project?rev=352996=rev Log: Hot fix two test regressions (%T vs %t) Different Unix "errno" values are returned for the following scenarios: $ echo test >

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

2018-06-04 Thread David Zarzycki via cfe-commits
ico Weber wrote: >> All chromium bots build with asserts on and we definitely don't want shared >> libs :-) Having the people who care about this build config make sure it >> keeps working seems like a good approach to me. >> >> On Mon, Jun 4, 2018 at 8:15 AM, David Zarzyc

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

2018-06-04 Thread David Zarzycki via cfe-commits
What’s stopping the project from automatically setting BUILD_SHARED_LIBS to TRUE if asserts are enabled? That’d automatically “force” active developers to test the scenario on their local machines, but not change the way release builds work. > On Jun 4, 2018, at 8:11 AM, Roman Lebedev via

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

2018-06-04 Thread David Zarzycki via cfe-commits
FYI – This broke `cmake -DBUILD_SHARED_LIBS=TRUE` builds. > On Jun 4, 2018, at 5:04 AM, Eric Liu via cfe-commits > wrote: > > Author: ioeric > Date: Mon Jun 4 02:04:12 2018 > New Revision: 333874 > > URL: http://llvm.org/viewvc/llvm-project?rev=333874=rev > Log: > Reland "Move #include

Re: r332436 - clang-format: Allow optimizer to break template declaration.

2018-05-16 Thread David Zarzycki via cfe-commits
This change broke `test/Index/overriding-ftemplate-comments.cpp` on Red Hat Fedora 28. Was this expected? > On May 16, 2018, at 4:25 AM, Francois Ferrand via cfe-commits > wrote: > > Author: typz > Date: Wed May 16 01:25:03 2018 > New Revision: 332436 > > URL:

r330353 - [UnitTests] NFC/build-perf: Break up nontrivial compile jobs

2018-04-19 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Thu Apr 19 11:19:02 2018 New Revision: 330353 URL: http://llvm.org/viewvc/llvm-project?rev=330353=rev Log: [UnitTests] NFC/build-perf: Break up nontrivial compile jobs RecursiveASTVisitorTest.cpp is one of the longest compile jobs and a build bottleneck on many-core

r326110 - Fix for LLVM r326109

2018-02-27 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Mon Feb 26 10:42:30 2018 New Revision: 326110 URL: http://llvm.org/viewvc/llvm-project?rev=326110=rev Log: Fix for LLVM r326109 Modified: cfe/trunk/lib/Basic/SourceManager.cpp Modified: cfe/trunk/lib/Basic/SourceManager.cpp URL:

[clang-tools-extra] r326118 - Fix for LLVM r326109

2018-02-26 Thread David Zarzycki via cfe-commits
Author: davezarzycki Date: Mon Feb 26 12:21:30 2018 New Revision: 326118 URL: http://llvm.org/viewvc/llvm-project?rev=326118=rev Log: Fix for LLVM r326109 Modified: clang-tools-extra/trunk/clang-query/QueryParser.cpp clang-tools-extra/trunk/clang-query/QueryParser.h Modified: