[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia added inline comments. Comment at: test/clang-tidy/abseil-no-namespace.cpp:10 +#include "absl/external-file.h" +// CHECK: absl/external-file.h:1:11: warning: namespace 'absl' is reserved +// for implementation of the Abseil library and should not be opened in user

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia updated this revision to Diff 162417. deannagarcia added a comment. Rebased the patch https://reviews.llvm.org/D50580 Files: clang-tidy/abseil/AbseilMatcher.h clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoNamespaceCheck.cpp

[PATCH] D51100: [clang-tidy] Add Abseil prefix to documentation

deannagarcia created this revision. deannagarcia added reviewers: aaron.ballman, hokein. deannagarcia added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Adds the Abseil prefix to the list of prefixes in the documentation https://reviews.llvm.org/D51100 Files:

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia updated this revision to Diff 161939. deannagarcia marked 2 inline comments as done. https://reviews.llvm.org/D50580 Files: clang-tidy/abseil/AbseilMatcher.h clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoNamespaceCheck.cpp

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia updated this revision to Diff 161827. deannagarcia marked 11 inline comments as done. https://reviews.llvm.org/D50580 Files: clang-tidy/abseil/AbseilMatcher.h clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoNamespaceCheck.cpp

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia added inline comments. Comment at: clang-tidy/abseil/AbseilMatcher.h:32 + auto Filename = FileEntry->getName(); + llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|" + "synchronization|types|utiliy)");

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia updated this revision to Diff 161720. deannagarcia marked 12 inline comments as done. https://reviews.llvm.org/D50580 Files: clang-tidy/abseil/AbseilMatcher.h clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoNamespaceCheck.cpp

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia added inline comments. Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23 + + Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"), + this); hokein wrote: > JonasToth wrote: > > hugoeg wrote: > > >

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia updated this revision to Diff 161526. deannagarcia edited the summary of this revision. deannagarcia added a comment. This revision includes a matcher so that the warning does not trigger on internal Abseil files. https://reviews.llvm.org/D50580 Files:

[PATCH] D50862: [clang-tidy] Abseil: faster strsplit delimiter check

deannagarcia updated this revision to Diff 161513. https://reviews.llvm.org/D50862 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp clang-tidy/abseil/FasterStrsplitDelimiterCheck.h docs/ReleaseNotes.rst

[PATCH] D50862: [clang-tidy] Abseil: faster strsplit delimiter check

deannagarcia added inline comments. Comment at: clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp:54 + // Now replace the " with '. + auto Pos = Result.find_first_of('"'); + if (Pos == Result.npos) JonasToth wrote: > deannagarcia wrote: > > JonasToth wrote:

[PATCH] D50862: [clang-tidy] Abseil: faster strsplit delimiter check

deannagarcia updated this revision to Diff 161472. deannagarcia marked 11 inline comments as done. https://reviews.llvm.org/D50862 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp

[PATCH] D50862: [clang-tidy] Abseil: faster strsplit delimiter check

deannagarcia added inline comments. Comment at: clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp:49 + // in the character literal. + if (Result == R"("'")") { +return std::string(R"('\'')"); JonasToth wrote: > The comment suggest, that all single quotes

[PATCH] D50862: [clang-tidy] Abseil: faster strsplit delimiter check

deannagarcia updated this revision to Diff 161309. deannagarcia marked 10 inline comments as done. https://reviews.llvm.org/D50862 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp

[PATCH] D50862: [clang-tidy] Abseil: faster strsplit delimiter check

deannagarcia created this revision. deannagarcia added reviewers: hokein, alexfh. deannagarcia added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. This check is an abseil specific check that checks for code using single character string literals as delimiters and

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia added inline comments. Comment at: test/clang-tidy/abseil-duration-division.cpp:58 + // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration objects + // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return + // absl::FDivDuration(t1, t2);}

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia updated this revision to Diff 160582. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia added inline comments. Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23 + + Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"), + this); aaron.ballman wrote: > hokein wrote: > > aaron.ballman wrote: >

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia updated this revision to Diff 160399. deannagarcia marked 7 inline comments as done. https://reviews.llvm.org/D50580 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoNamespaceCheck.cpp clang-tidy/abseil/NoNamespaceCheck.h

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia updated this revision to Diff 160338. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia updated this revision to Diff 160336. deannagarcia marked 6 inline comments as done. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia added inline comments. Comment at: test/clang-tidy/abseil-duration-division.cpp:58 + // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration objects + // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return + // absl::FDivDuration(t1, t2);}

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia created this revision. deannagarcia added reviewers: alexfh, hokein. deannagarcia added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. This check ensures that users of Abseil do not open namespace absl in their code, as that violates our compatibility

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50 + *result.SourceManager, result.Context->getLangOpts()), + ")"); +} JonasToth wrote: > This line looks odd, does it come from clang-format?

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 160109. deannagarcia marked 3 inline comments as done. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 160096. deannagarcia marked 7 inline comments as done. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia marked 9 inline comments as done. deannagarcia added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:32 + hasImplicitDestinationType(qualType(unless(isInteger(, + unless(hasParent(cxxStaticCastExpr(, + this);

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 160013. Herald added a subscriber: mgorny. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159590. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159550. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159537. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/clang-tidy/checks/abseil-duration-division.rst