[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. In D157283#4648242 , @ldionne wrote: > As explained in https://reviews.llvm.org/D89001#4648241, upstream Clang is > the way it should be right now. The intent is that we first look along the > `clang` binary for headers (

[PATCH] D158519: [clangd] Move diagnostics from modules to the main source file

DmitryPolukhin added a comment. Friendly ping, any thoughts about this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158519/new/ https://reviews.llvm.org/D158519 ___ cfe-commits mailing list cfe-co

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. @ldionne could you please upstream 9edb9a711503d540cf3126c0fde11ce9a0d9a7aa (I don't know what it is)? Alternatively I can figure out what to do with this test (it is just copies of the same te

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGf24aa691aa4f: [clang] Match -isysroot behaviour with system compiler on Darwin (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D158519: [clangd] Move diagnostics from modules to main sources file

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: adamcz, sammccall, kadircet. DmitryPolukhin added a project: clang. Herald added subscribers: arphaman, javed.absar. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added subscribers: MaskRay

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. @ldionne, @arphaman and @jroelofs, friendly ping, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin updated this revision to Diff 547825. DmitryPolukhin added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

DmitryPolukhin added a comment. @dexonsmith thank you for quick response. I think we need to update upstream behaviour to match system compiler behaviour otherwise clang-tools that uses path to compiler binary form CDB will not work as expected and extra options won't help much because it is no

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: ldionne, dexonsmith, MaskRay. DmitryPolukhin added a project: clang. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber: cfe-commits. See discussion in https://reviews.llvm.o

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

DmitryPolukhin added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. @ldionne and @dexonsmith, it seems that this diff breaks clang-tools like clang-tidy and clangd if `-isysroot` is specified in the compilation database. Moreover, clang from Xcode 14 and 15 uses path

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d9fcc2ad874: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output (authored by DmitryPolukhin). Repository: rG LLVM Github M

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; + CreateInvocationOptions

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539283. DmitryPolukhin added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539281. DmitryPolukhin added a comment. Use --target=arm-linux-gnueabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang/lib/Driver/ToolChains/Com

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; + CreateInvocationOptions

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539223. DmitryPolukhin added a comment. Added -target arm-linux-gnueabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang/lib/Driver/ToolChains/Co

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added a comment. In D154602#4483600 , @MaskRay wrote: > Thanks for the patch! But I share the concern that the test is added to a > wrong layer > (https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer). >

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539131. DmitryPolukhin added a comment. Moved test to clang/unittests/Driver/ToolChainTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang/l

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1274 if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) -if (StringRef(A->getValue()) == "single") +if (StringRef(A->getValue()) == "single" && Output.isFilename())

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 537774. DmitryPolukhin added a comment. Rebase and uun clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang-tools-extra/clangd/unittests

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: yaxunl, tra, MaskRay. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. DmitryPolukhin published this revision for review. Herald added subscribers

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:90 +if (Tasks) { + std::unique_lock Lock(*Barrier, std::try_to_lock); + Tasks->runAsync("task:" + Path + Version, std::move(Task)); kadircet wrote: > what's

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:694 Result->MainIsIncludeGuarded = CapturedInfo.isMainFileIncludeGuarded(); -return Result; +CapturedCtx.emplace(CapturedInfo.takeLife()); +return std::make_pair(Result, Captu

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. In D148663#4318907 , @kadircet wrote: > I agree with Ilya's concerns here. > > We deliberately don't mess with compile flags pushed over LSP. These are > "overrides" to whatever information we have from other sources, turn

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. In D148663#4305202 , @ilya-biryukov wrote: > In D148663#4301589 , > @DmitryPolukhin wrote: > >> And, if they do so, this diff will just does nothing because there is an >> exact

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. In D148663#4298496 , @ilya-biryukov wrote: > I wanted to chime in and provide a bit of context. > This was a long time ago, so I might misremember, so take this with a grain > of salt. > > Idea behind pushing the CDB over

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. @kadircet @nridge friendly ping, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148663/new/ https://reviews.llvm.org/D148663 ___ cfe-commits m

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: kadircet, nridge, sammccall, ilya-biryukov. DmitryPolukhin added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a sub

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @dyung I cannot reproduce this issue on two different machines in both cases tests work fine. For clang and llvm-jitlink binaries (the only binaries used in the tests) my changes are non-functional and I didn't change anything in compiler-rt or ORC. Are you able

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. In D143436#4203008 , @dyung wrote: > @DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a > bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or > revert if you need time to inves

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

This revision was automatically updated to reflect the committed changes. Closed by commit rGd60d3455eb2b: [clangd] Move standard options adaptor to CommandMangler (authored by DmitryPolukhin). Changed prior to commit: https://reviews.llvm.org/D143436?vs=505030&id=506030#toc Repository: rG L

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

This revision was automatically updated to reflect the committed changes. Closed by commit rGb293c6280d06: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

DmitryPolukhin added a comment. In D146156#4197289 , @shafik wrote: > Is there a way to test this? It was easier to reproduce on small test case than I thought, test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

DmitryPolukhin updated this revision to Diff 505642. DmitryPolukhin added a comment. Test added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146156/new/ https://reviews.llvm.org/D146156 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Preproc

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: bruno, troyj, arphaman, vsapsai, jansvoboda11. DmitryPolukhin added a project: clang. Herald added a subscriber: kadircet. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber:

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet could you please take another look? I had to update diff to make it work when LLVM is configured without X86 targets so they are not valid and thus not injected into the command line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 505030. DmitryPolukhin added a comment. Update test to use any available target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clan

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. Had to revert this diff temporary due to broken ARM builds. It seems that X86 targets are disabled for that bots so tests are not passing. I'll fix upload new version for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

This revision was automatically updated to reflect the committed changes. Closed by commit rG34de7da6246c: [clangd] Move standard options adaptor to CommandMangler (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 504275. DmitryPolukhin added a comment. Fix test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.c

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet thank you for the review! Please take another look. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:199 + // use/change working directory, which ExpandResponseFiles doesn't). + FS = llvm::vfs::getRealFileSystem(); +}

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 504156. DmitryPolukhin marked 4 inline comments as done. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 File

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet it is obvious that there is something in this diff that causes this hesitancy in accepting it. I'm ready to keep iterating on the solution but I need a clue what needs the improvement. Please comment. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet and @nridge friendly ping could you please accept this diff or let me know if you would like to change anything here? I moved `addTargetAndModeForProgramName` after `SystemIncludeExtractor` as was suggested. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D145228: [clangd] Add clangd headers to install targets

DmitryPolukhin added a comment. In D145228#4170792 , @sammccall wrote: >> The install target for clang distributes the clangd static libs > > I don't think this was ever intended, looks like an accidental side-effect of > using LLVM's many cmake macros.

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 502110. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet friendly ping, could you please take a look to this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 ___ cfe-comm

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 500620. DmitryPolukhin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 500449. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 499766. DmitryPolukhin added a comment. Failing tests seems to be just flacky, I was not able to reprocuce any issue with them locally in stress runs and under ASan and TSan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 499433. DmitryPolukhin added a comment. Move call addTargetAndModeForProgramName after SystemIncludeExtractor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 F

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDri

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. @nridge @kadircet please take another look, all tests now pass. As for the location of inserting driver mode please see my previous comment about MSVC CL check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/n

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498878. DmitryPolukhin added a comment. Rebase and retest, cannot reproduce test failure locally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498140. DmitryPolukhin added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp cla

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. @nridge I'm sorry, I pushed version without all tests. Now I added test case for response files, it seems that clangd hasn't had it before this patch. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFi

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498138. DmitryPolukhin added a comment. Add test for expanded response files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498038. DmitryPolukhin added a comment. Move standard adaptors to CommandMangler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/cla

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. In D143436#4122594 , @kadircet wrote: > That's actually because we model compile commands pushed via LSP as a "fixed > compilation database" rather than a json compilation database (you can check > the code in `parseFixed

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. In D143436#4120899 , @nridge wrote: > Note that D138546 is removing the call to > `inferTargetAndDriverMode()` from `GlobalCompilationDatabase.cpp`. It adds > equivalent logic too `Comma

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 495431. DmitryPolukhin added a comment. Fix clang-format sources Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/ClangdLSPSer

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: sammccall, ilya-biryukov. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: s.egerton, kadircet, arphaman, simoncook. Herald added a project: All. DmitryPolukhin requested review of this revision.

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d12b13b0b26: [clang-tidy] Dump effective diagnostics level in YAML output (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin added a comment. In D135367#3842950 , @njames93 wrote: > LGTM, just maybe include a test case where a warning from a clang-tidy check > is promoted to an error as well. Thank you for the review! I've added a test case for clang-tidy check

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin updated this revision to Diff 466767. DmitryPolukhin added a comment. Added testcase for clang-tidy diagnostics as with --warnings-as-errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367/new/ https://reviews.llvm.org/D135367

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin updated this revision to Diff 466037. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367/new/ https://reviews.llvm.org/D135367 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsume

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: njames93, klimek. DmitryPolukhin added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber: cf

[PATCH] D134112: [clang] Update ReleaseNotes about a crash fix (Issue 53628)

This revision was automatically updated to reflect the committed changes. Closed by commit rG41dbee1e6693: [clang] Update ReleaseNotes about a crash fix (Issue 53628) (authored by DmitryPolukhin). Changed prior to commit: https://reviews.llvm.org/D134112?vs=461009&id=461514#toc Repository: r

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

DmitryPolukhin added a comment. In D133948#3793085 , @aaron.ballman wrote: > LGTM! Please add a release note for the fix when you land the changes. Thank you for prompt review! Release notes update in D134112 . Also I

[PATCH] D134112: [clang] Update ReleaseNotes about a crash fix (Issue 53628)

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: aaron.ballman, Tyker. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a project: clang. Update ReleaseNotes about a crash fix (Issue 53628) Test Plan: none Repository: rG LLVM Git

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG133b6d7db90d: [clang][C++20] Fix clang/clangd assert/crash after compilation errors (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

DmitryPolukhin updated this revision to Diff 460437. DmitryPolukhin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133948/new/ https://reviews.llvm.org/D133948 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: Tyker, rsmith, aaron.ballman. DmitryPolukhin added a project: clang. Herald added subscribers: kadircet, arphaman. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added subscribers: cfe-commi

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

DmitryPolukhin added a comment. @ivanmurashko Overall looks good to me but please re-upload patch on top of some stable revision where failed test passes (it seems unrelated to your changes). `struct Include` is a light weight structure so having a copy seems to be the simplest solution. Rep

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8eaa05d06161: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch (authored by ivanmurashko, committed by DmitryPolukhin). Repository: rG LLVM

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

This revision was automatically updated to reflect the committed changes. Closed by commit rGfceaf8621179: [clang] Fix UB when string.front() is used for the empty string (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin updated this revision to Diff 355261. DmitryPolukhin added a comment. Fix clang-tidy style warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105120/new/ https://reviews.llvm.org/D105120 Files: clang/lib/Tooling/ExpandResponseF

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin updated this revision to Diff 355233. DmitryPolukhin added a comment. Replace tab with spaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105120/new/ https://reviews.llvm.org/D105120 Files: clang/lib/Tooling/ExpandResponseFilesC

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: kadircet, lh123, sammccall, hokein, ilya-biryukov. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added a subscriber: usaxena95. DmitryPolukhin requested review of this revision. Compilation database might have

[PATCH] D104021: [clang-tidy] LIT test fix for Remark diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG47d138c93992: [clang-tidy] LIT test fix for Remark diagnostic (authored by ivanmurashko, committed by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D104021: [clang-tidy] LIT test fix for Remark diagnostic

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104021/new/ https://reviews.llvm.org/D104021 _

[PATCH] D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin added a comment. In D90835#2808153 , @lebedev.ri wrote: > This needs to explain why the existing functionality isn't sufficient - if > the header is really not from this project, > then it should be included via `-isystem`, and that will na

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa0d7179bbb3: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText() (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

DmitryPolukhin updated this revision to Diff 350205. DmitryPolukhin added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103722/new/ https://reviews.llvm.org/D103722 Files: clang/unittests/AST/CommentTextTest.cpp

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: teemperor, obruns, bruno. DmitryPolukhin requested review of this revision. Herald added a project: clang. This diff adds testcase for the issue fixed in https://reviews.llvm.org/D77468 but regression test was not added in the d

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added a comment. @bruno and @dexonsmith thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 ___ cfe-commits mailing list cf

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG178ad93e3f1f: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added inline comments. Comment at: clang/lib/Lex/HeaderMap.cpp:265 + } + return ReverseMap.lookup(DestPath); +} bruno wrote: > How about something along the lines of: > > ``` > ... > StringRef Key; > for (unsigned i = 0; i != NumBuckets; ++i) {

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 349199. DmitryPolukhin added a comment. Updated HeaderMapImpl::reverseLookupFilename according to the review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D10

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348965. DmitryPolukhin added a comment. Rebase + try build on Windows again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 Files: clang/include/clang/Lex/He

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added inline comments. Comment at: clang/lib/Lex/HeaderMap.cpp:245 +StringRef HeaderMapImpl::reverseLookupFilename(StringRef DestPath) const { + if (ReverseMap.empty()) { +const HMapHeader &Hdr = getHeader(); bruno wrote: > Please rewrite this

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348900. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Resolved comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 File

[PATCH] D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

This revision was automatically updated to reflect the committed changes. Closed by commit rG37b530a2ea8b: [clang] NFC: split HeaderMapTest to have re-usable header map implementation… (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348264. DmitryPolukhin added a comment. Fix forgotten comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 Files: clang/include/clang/Lex/HeaderMap.h cl

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added a subscriber: bkramer. DmitryPolukhin added a comment. In D103142#2783665 , @dexonsmith wrote: > Naively, this sounds like it could be a non-trivial tax on build times. But > it looks like it's only called in Clang from `Sema::diagn

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348183. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Split changes into NFC https://reviews.llvm.org/D103229 and the rest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: dexonsmith, bruno. DmitryPolukhin added a project: clang. DmitryPolukhin requested review of this revision. NFC changes required for https://reviews.llvm.org/D103142 Test Plan: check-clang Repository: rG LLVM Github Monorep

[PATCH] D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin added a comment. @alexfh, @njames93 and @thakis please take a look! I added all tests cases and put new logic behind a flag to make it as safe as possible. Issue with diagnostics from macro expansion from third-party headers is the one of the biggest problem with deployment that w

[PATCH] D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 347968. DmitryPolukhin added a comment. Herald added a subscriber: dexonsmith. Added test for system like object macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/new/ https://reviews.llvm.org/D9

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 347864. DmitryPolukhin added a comment. Fix linter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 Files: clang/include/clang/Lex/HeaderMap.h clang/lib/Lex

  1   2   3   >