dmpolukhin wrote:
@ChuanqiXu9 thank you for the detailed steps, I uploaded new version. Does it
look like something you had in mind?
https://github.com/llvm/llvm-project/pull/109167
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/109167
>From 72b43bd2f392a009187e1cdd90627691a4017707 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Wed, 18 Sep 2024 09:02:23 -0700
Subject: [PATCH 1/5] [C++20][Modules] Fix crash when function and lambda
in
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/109167
>From 72b43bd2f392a009187e1cdd90627691a4017707 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Wed, 18 Sep 2024 09:02:23 -0700
Subject: [PATCH 1/4] [C++20][Modules] Fix crash when function and lambda
in
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/109167
>From 72b43bd2f392a009187e1cdd90627691a4017707 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Wed, 18 Sep 2024 09:02:23 -0700
Subject: [PATCH 1/3] [C++20][Modules] Fix crash when function and lambda
in
dmpolukhin wrote:
With DeclContext visitor collectLambdas takes 0.03% or smaller, sometime I
don't even see it in sampling profile.
https://github.com/llvm/llvm-project/pull/109167
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/109167
>From 72b43bd2f392a009187e1cdd90627691a4017707 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Wed, 18 Sep 2024 09:02:23 -0700
Subject: [PATCH 1/2] [C++20][Modules] Fix crash when function and lambda
in
dmpolukhin wrote:
> Would you like to explain more why this fail previously in more detail?
Original code in `ASTReader::finishPendingActions` looked like this:
```
for (auto ID : PendingLambdas)
GetDecl(ID);
PendingLambdas.clear();
```
The issue here is that the code uses implicit
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/109167
Summary:
Because AST loading code is lazy and happens in unpredictable order, it is
possible that a function and lambda inside the function can be loaded from
different modules. As a result, the captured Dec
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
dmpolukhin wrote:
> [repro.zip](https://github.com/user-attachments/files/16986643/repro.zip)
>
> edit: got a better reduced repro, see attachment
Thank you for the reprod
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
@@ -1155,6 +1155,16 @@ void ASTDeclReader::VisitFunctionDecl(FunctionDecl *FD) {
for (unsigned I = 0; I != NumParams; ++I)
Params.push_back(readDeclAs
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
dmpolukhin wrote:
> this is causing a crash with precompiled headers. I can try to reduce, but
> hopefully the problem is obvious from this assert/stack trace?
@aeubanks co
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
dmpolukhin wrote:
@ChuanqiXu9 thank you a lot for the review and help with the changes, very
appreciated!
https://github.com/llvm/llvm-project/pull/104512
_
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/104512
___
cfe-commits mailing list
cfe-commits@lis
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
https://github.com/dmpolukhin edited
https://github.com/llvm/llvm-project/pull/104512
___
cfe-commits mailing list
cfe-commits@lis
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
@@ -1155,6 +1155,16 @@ void ASTDeclReader::VisitFunctionDecl(FunctionDecl *FD) {
for (unsigned I = 0; I != NumParams; ++I)
Params.push_back(readDeclAs
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
@@ -1188,6 +1188,11 @@ class ASTReader
/// once recursing loading has been completed.
llvm::SmallVector PendingOdrMergeChecks;
+ /// Lambdas that ne
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
@@ -764,6 +792,15 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) {
Record.push_back(D->param_size());
for (auto *P : D->parameters())
R
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/104512
>From 8772795571c9e36c498cb3dba5496e695dfcb7a2 Mon Sep 17 00:00:00 2001
From: Dmitry P
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
@@ -764,6 +792,15 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) {
Record.push_back(D->param_size());
for (auto *P : D->parameters())
Re
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin
Message-ID:
In-Reply-To:
dmpolukhin wrote:
@ChuanqiXu9 please take a look, I had to load lambdas delayed to avoid bad
cycles when current function was not fully deserialized yet but lambda inside
reference it. Now t
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin
Message-ID:
In-Reply-To:
https://github.com/dmpolukhin ready_for_review
https://github.com/llvm/llvm-project/pull/104512
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
Message-ID:
In-Reply-To:
dmpolukhin wrote:
> Got it. I am pretty interested use case for modules. And from your commit
> history, it looks like you prefer header units than named modules?
Yes, we prefer header units for the time being
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
Message-ID:
In-Reply-To:
dmpolukhin wrote:
> I am curious about your real project, is it open source?
Unfortunately, it is not an open source project but we use bunch of OSS
libraries like Folly, Thrift and many other so I see bugs th
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
Message-ID:
In-Reply-To:
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/104512
>From d54f01fe6c49131a3ff4514520e5270889b9affb Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 15 Aug 2024 14:03
dmpolukhin wrote:
Quick update, all clang/cxx-library tests pass with the change but when I test
it on my real project with modules I see crash or assert in
[ASTDeclMerger::MergeDefinitionData](https://github.com/llvm/llvm-project/blob/main/clang/lib/Serialization/ASTReaderDecl.cpp#L2081)
abou
dmpolukhin wrote:
@ChuanqiXu9 please take another look. I changed approach to remember which
lambdas exist in FunctionDecl and load them for the first decl. I'm still
testing it but interested to know does it look like something that address your
concernes?
https://github.com/llvm/llvm-proje
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/104512
>From 8e11c66e4515bb35671853b89152b43d1ff60ffa Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 15 Aug 2024 14:03:57 -0700
Subject: [PATCH 1/5] [RFC][C++20][Modules] Fix crash when function and lambd
https://github.com/dmpolukhin converted_to_draft
https://github.com/llvm/llvm-project/pull/104512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dmpolukhin wrote:
> And I am still slightly unclear about how we load the wrong lambda first.
Here is stack trace how decl from wrong module becomes canonical.
Full stack trace
```
frame #0: 0x5e651e29
clang`clang::ASTDeclReader::VisitCXXRecordDeclImpl(this=0x7ffe0b70,
D=0x00
https://github.com/dmpolukhin edited
https://github.com/llvm/llvm-project/pull/104512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin ready_for_review
https://github.com/llvm/llvm-project/pull/104512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dmpolukhin wrote:
> Here is another example that merging lambdas are problematic: #102721.
> Although I think we need to solve the problems separately. They are different
> problems.
Thank you for the reference, we need this fix too.
> But the current patch still smells bad. Let's try to find
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/104512
>From 8e11c66e4515bb35671853b89152b43d1ff60ffa Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 15 Aug 2024 14:03:57 -0700
Subject: [PATCH 1/4] [RFC][C++20][Modules] Fix crash when function and lambd
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/104512
>From 8e11c66e4515bb35671853b89152b43d1ff60ffa Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 15 Aug 2024 14:03:57 -0700
Subject: [PATCH 1/4] [RFC][C++20][Modules] Fix crash when function and lambd
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/104512
>From 8e11c66e4515bb35671853b89152b43d1ff60ffa Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 15 Aug 2024 14:03:57 -0700
Subject: [PATCH 1/3] [RFC][C++20][Modules] Fix crash when function and lambd
https://github.com/dmpolukhin converted_to_draft
https://github.com/llvm/llvm-project/pull/104512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dmpolukhin wrote:
> I feel the change is somewhat odd to me. Since the description is about the
> lambda but the change is about VarDecls. I feel there is a mismatch and I
> feel this may not solve the underlying problem fundamentally. I feel it'll be
> better to make it more straight forward.
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/104512
Summary:
Because AST loading code is lazy and happens in unpredictable order it could
happen that function and lambda inside function can be loaded from different
modules. In this case, captured DeclRefExpr
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/100739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/100739
>From edc7f5c84caefeae197a5884c91ec2194fd3148b Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 26 Jul 2024 05:02:52 -0700
Subject: [PATCH 1/4] [C++20][Modules] Allow using stdarg.h with header units
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/100739
>From edc7f5c84caefeae197a5884c91ec2194fd3148b Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 26 Jul 2024 05:02:52 -0700
Subject: [PATCH 1/3] [C++20][Modules] Allow using stdarg.h with header units
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/100739
>From edc7f5c84caefeae197a5884c91ec2194fd3148b Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 26 Jul 2024 05:02:52 -0700
Subject: [PATCH 1/2] [C++20][Modules] Allow using stdarg.h with header units
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/100739
Summary:
Macro like `va_start`/`va_end` marked as builtin functions that makes these
identifiers special and it results in redefinition of the identifiers as
builtins and it hides macro definitions during pr
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/98488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/98488
>From a05c4ca2c2e61653e7bd8d3a2f5faa6b86daa615 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 11 Jul 2024 07:01:49 -0700
Subject: [PATCH 1/4] [clang-tidy] Fix false in unnecessary-value-param inside
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/98488
>From a05c4ca2c2e61653e7bd8d3a2f5faa6b86daa615 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 11 Jul 2024 07:01:49 -0700
Subject: [PATCH 1/3] [clang-tidy] Fix false in unnecessary-value-param inside
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/98488
>From a05c4ca2c2e61653e7bd8d3a2f5faa6b86daa615 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 11 Jul 2024 07:01:49 -0700
Subject: [PATCH 1/2] [clang-tidy] Fix false in unnecessary-value-param inside
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/98488
>From a05c4ca2c2e61653e7bd8d3a2f5faa6b86daa615 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Thu, 11 Jul 2024 07:01:49 -0700
Subject: [PATCH 1/2] [clang-tidy] Fix false in unnecessary-value-param inside
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/98488
Summary:
If callExpr is type dependent, there is no way to analyze individual arguments
until template specialization. Before this diff only calls with dependent
callees were skipped so unnecessary-value-para
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/98309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin edited
https://github.com/llvm/llvm-project/pull/98309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/98309
Summary:
These is no sense to report this cases as an error or add `inline` explicitly
in this cases. If it is not required in normal headers. Similar to #60079.
Test Plan: check-clang
>From 7fd31fea6d4a3003
https://github.com/dmpolukhin approved this pull request.
https://github.com/llvm/llvm-project/pull/92659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin approved this pull request.
https://github.com/llvm/llvm-project/pull/91738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin reopened
https://github.com/llvm/llvm-project/pull/91738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/91738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin approved this pull request.
https://github.com/llvm/llvm-project/pull/84236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -229,7 +229,8 @@ Changes in existing checks
- Improved :doc:`readability-identifier-naming
` check in
`GetConfigPerFile`
- mode by resolving symbolic links to header files.
+ mode by resolving symbolic links to header files. Fixed handling of Hungarian
@@ -229,7 +229,8 @@ Changes in existing checks
- Improved :doc:`readability-identifier-naming
` check in
`GetConfigPerFile`
- mode by resolving symbolic links to header files.
+ mode by resolving symbolic links to header files. Fixed handling of Hungarian
@@ -229,7 +229,8 @@ Changes in existing checks
- Improved :doc:`readability-identifier-naming
` check in
`GetConfigPerFile`
- mode by resolving symbolic links to header files.
+ mode by resolving symbolic links to header files. Fixed handling of Hungarian
dmpolukhin wrote:
I'm not an expert in Hungarian naming but from what I know changes looks good
to me. Just nit in release notes.
https://github.com/llvm/llvm-project/pull/84236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/81985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/81985
>From ddafb4672e1a481d4a9556ebe31ca9a07e1f3569 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 16 Feb 2024 03:51:07 -0800
Subject: [PATCH 1/3] [clang-tidy][readability-identifier-naming] Resolve
sym
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/81985
>From ddafb4672e1a481d4a9556ebe31ca9a07e1f3569 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 16 Feb 2024 03:51:07 -0800
Subject: [PATCH 1/3] [clang-tidy][readability-identifier-naming] Resolve
sym
dmpolukhin wrote:
> This problem seems like it should be handled globally, not in a single
> specific check. IIUC any check that reads options from the .clang-tidy file
> is affected.
Yes, but the majority of checks ignores the problem but
`readability-identifier-naming` handles styles per fi
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/81985
>From ddafb4672e1a481d4a9556ebe31ca9a07e1f3569 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 16 Feb 2024 03:51:07 -0800
Subject: [PATCH 1/2] [clang-tidy][readability-identifier-naming] Resolve
sym
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/81985
Summary:
Some build systems create symlinks in a temporary build directory for headers
in the source tree for isolation purposes. These symlinks prevent
`readability-identifier-naming` detecting issues and ap
dmpolukhin wrote:
> So the intent of the current ordering was to allow creating a toolchain by
> placing the libc++ headers alongside Clang, as is typically done (and
> exceptionally not done on Apple platforms). On Apple platforms, you basically
> always specify a sysroot, either explicitly o
dmpolukhin wrote:
@ldionne if downstream is catching upstream, I would love to discuss rationale
behind ignoring command line option. I asked this question several times and
haven't got answer. Original [diff](https://reviews.llvm.org/D89001) that
introduced this behavior also didn't explain w
dmpolukhin wrote:
@ldionne what about fixing upstream behavior to match actual system compiler
behavior now and when/as soon as we have new behavior in Apple compiler fix it
again in newer clang versions? Moreover as I pointed out Apple compiler
behavior is problematic for clang-tools and clan
dmpolukhin wrote:
@ldionne I also haven't see Apple compiler that matches upstream behavior. In
https://reviews.llvm.org/D157283#4648242, you mentioned that "Xcode 15 RC"
should be such compiler and checked it and couple version after that and none
of them matched upstream so I decided to wait
dmpolukhin wrote:
Pushed as https://github.com/llvm/llvm-project/pull/79466
https://github.com/llvm/llvm-project/pull/70801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/70801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/79466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dmpolukhin wrote:
@AaronBallman @bcardosolopes please take a look.
https://github.com/llvm/llvm-project/pull/79466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/79466
>From 67a266e7bc5682d5f674c0424858ba86f7c9a192 Mon Sep 17 00:00:00 2001
From: Kugan <34810920+kug...@users.noreply.github.com>
Date: Tue, 31 Oct 2023 12:12:10 +
Subject: [PATCH] Apply format only if --forma
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/79466
clang-apply-replacements used to apply format even without --format is
specified. This because, methods like createReplacementsForHeaders only takes
the Spec.Style and would re-order the headers even when it
dmpolukhin wrote:
@kuganv do you have cycles to work on this issue? If not, I can commandeer this
pull requests and update release notes. Please let me know what is your
preference.
https://github.com/llvm/llvm-project/pull/70801
___
cfe-commits mail
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/75753
>From 957951483dab19b0982a5dbe7d5370bd9061d931 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Sun, 17 Dec 2023 14:11:11 -0800
Subject: [PATCH 1/3] [clangd] Expand response files before CDB interpolation
https://github.com/dmpolukhin edited
https://github.com/llvm/llvm-project/pull/75753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dmpolukhin wrote:
@HighCommander4 PTAL
https://github.com/llvm/llvm-project/pull/75753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/75753
>From 957951483dab19b0982a5dbe7d5370bd9061d931 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Sun, 17 Dec 2023 14:11:11 -0800
Subject: [PATCH 1/2] [clangd] Expand response files before CDB interpolation
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/75753
Summary:
After https://reviews.llvm.org/D143436 response files stopped working with CDB
interpolation. It has happened because interpolation removes all unknwn flags
and extra input files. Response file is t
Author: Dmitry Polukhin
Date: 2023-08-23T18:10:18+01:00
New Revision: f24aa691aa4f25291db8f7c61c6e9007288859e7
URL:
https://github.com/llvm/llvm-project/commit/f24aa691aa4f25291db8f7c61c6e9007288859e7
DIFF:
https://github.com/llvm/llvm-project/commit/f24aa691aa4f25291db8f7c61c6e9007288859e7.dif
Author: Dmitry Polukhin
Date: 2023-07-12T00:57:41-07:00
New Revision: 6d9fcc2ad874e4ee9b94eef4b85ffece18e501b1
URL:
https://github.com/llvm/llvm-project/commit/6d9fcc2ad874e4ee9b94eef4b85ffece18e501b1
DIFF:
https://github.com/llvm/llvm-project/commit/6d9fcc2ad874e4ee9b94eef4b85ffece18e501b1.dif
Author: Dmitry Polukhin
Date: 2023-03-17T03:10:36-07:00
New Revision: d60d3455eb2b375d026a4aa74c4ba0c38f5d323c
URL:
https://github.com/llvm/llvm-project/commit/d60d3455eb2b375d026a4aa74c4ba0c38f5d323c
DIFF:
https://github.com/llvm/llvm-project/commit/d60d3455eb2b375d026a4aa74c4ba0c38f5d323c.dif
Author: Dmitry Polukhin
Date: 2023-03-16T02:19:11-07:00
New Revision: b293c6280d06f49c5ca7290855911341ab0bdffa
URL:
https://github.com/llvm/llvm-project/commit/b293c6280d06f49c5ca7290855911341ab0bdffa
DIFF:
https://github.com/llvm/llvm-project/commit/b293c6280d06f49c5ca7290855911341ab0bdffa.dif
Author: Dmitry Polukhin
Date: 2023-03-13T07:00:56-07:00
New Revision: 2a84c53ccdc015a7f53a144aa4f7c0dddf839604
URL:
https://github.com/llvm/llvm-project/commit/2a84c53ccdc015a7f53a144aa4f7c0dddf839604
DIFF:
https://github.com/llvm/llvm-project/commit/2a84c53ccdc015a7f53a144aa4f7c0dddf839604.dif
Author: Dmitry Polukhin
Date: 2023-03-13T06:08:22-07:00
New Revision: 34de7da6246cdfa6ff6f3d3c514583cddc0a10ec
URL:
https://github.com/llvm/llvm-project/commit/34de7da6246cdfa6ff6f3d3c514583cddc0a10ec
DIFF:
https://github.com/llvm/llvm-project/commit/34de7da6246cdfa6ff6f3d3c514583cddc0a10ec.dif
Author: Dmitry Polukhin
Date: 2022-10-12T02:03:56-07:00
New Revision: 5d12b13b0b26bc58b02ee23c369da8b83240cceb
URL:
https://github.com/llvm/llvm-project/commit/5d12b13b0b26bc58b02ee23c369da8b83240cceb
DIFF:
https://github.com/llvm/llvm-project/commit/5d12b13b0b26bc58b02ee23c369da8b83240cceb.dif
Author: Dmitry Polukhin
Date: 2022-09-20T02:05:36-07:00
New Revision: 41dbee1e66937fe7d579b73d30dc790cd79b8738
URL:
https://github.com/llvm/llvm-project/commit/41dbee1e66937fe7d579b73d30dc790cd79b8738
DIFF:
https://github.com/llvm/llvm-project/commit/41dbee1e66937fe7d579b73d30dc790cd79b8738.dif
Author: Dmitry Polukhin
Date: 2022-09-17T07:37:19-07:00
New Revision: 133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d
URL:
https://github.com/llvm/llvm-project/commit/133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d
DIFF:
https://github.com/llvm/llvm-project/commit/133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d.dif
Author: Ivan Murashko
Date: 2021-07-30T12:40:38+03:00
New Revision: 8eaa05d06161db69e68ff2a5f4c8e3545a4e8080
URL:
https://github.com/llvm/llvm-project/commit/8eaa05d06161db69e68ff2a5f4c8e3545a4e8080
DIFF:
https://github.com/llvm/llvm-project/commit/8eaa05d06161db69e68ff2a5f4c8e3545a4e8080.diff
Author: Dmitry Polukhin
Date: 2021-06-30T01:07:47-07:00
New Revision: fceaf8621179aa758c44f3eaee02d789abfd455b
URL:
https://github.com/llvm/llvm-project/commit/fceaf8621179aa758c44f3eaee02d789abfd455b
DIFF:
https://github.com/llvm/llvm-project/commit/fceaf8621179aa758c44f3eaee02d789abfd455b.dif
Author: Ivan Murashko
Date: 2021-06-11T02:02:36-07:00
New Revision: 47d138c93992f779a5dd0810b0e7402e043df61d
URL:
https://github.com/llvm/llvm-project/commit/47d138c93992f779a5dd0810b0e7402e043df61d
DIFF:
https://github.com/llvm/llvm-project/commit/47d138c93992f779a5dd0810b0e7402e043df61d.diff
Author: Dmitry Polukhin
Date: 2021-06-07T03:05:00-07:00
New Revision: aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8
URL:
https://github.com/llvm/llvm-project/commit/aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8
DIFF:
https://github.com/llvm/llvm-project/commit/aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8.dif
Author: Dmitry Polukhin
Date: 2021-06-03T01:37:55-07:00
New Revision: 178ad93e3f1f2381f05baea300873ee5998ac288
URL:
https://github.com/llvm/llvm-project/commit/178ad93e3f1f2381f05baea300873ee5998ac288
DIFF:
https://github.com/llvm/llvm-project/commit/178ad93e3f1f2381f05baea300873ee5998ac288.dif
Author: Dmitry Polukhin
Date: 2021-05-31T01:57:36-07:00
New Revision: 37b530a2ea8bdc28a22a3f8ca701455fb7febdea
URL:
https://github.com/llvm/llvm-project/commit/37b530a2ea8bdc28a22a3f8ca701455fb7febdea
DIFF:
https://github.com/llvm/llvm-project/commit/37b530a2ea8bdc28a22a3f8ca701455fb7febdea.dif
Author: Dmitry Polukhin
Date: 2021-03-24T06:43:13-07:00
New Revision: 338d16275571df4d841609d7e12bcb310b3a95e6
URL:
https://github.com/llvm/llvm-project/commit/338d16275571df4d841609d7e12bcb310b3a95e6
DIFF:
https://github.com/llvm/llvm-project/commit/338d16275571df4d841609d7e12bcb310b3a95e6.dif
Author: Dmitry Polukhin
Date: 2021-03-15T07:32:45-07:00
New Revision: da55af7f1d348c133774d8e8117d60462363fef5
URL:
https://github.com/llvm/llvm-project/commit/da55af7f1d348c133774d8e8117d60462363fef5
DIFF:
https://github.com/llvm/llvm-project/commit/da55af7f1d348c133774d8e8117d60462363fef5.dif
1 - 100 of 260 matches
Mail list logo
